Commit Graph

356 Commits

Author SHA1 Message Date
Jeremy Swinarton
72de1640b1 Bug 1959438: Prevent tab from entering tab group label DOM element on tab insert r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D244931
2025-04-10 02:51:29 +00:00
Cristina Horotan
2d08511dac Backed out changeset 7fed35bbd242 (bug 1938425) for causing bc failures at browser_tab_groups_telemetry.js. CLOSED TREE 2025-04-09 13:06:03 +03:00
DJ
e9f93720b5 Bug 1938425 - add telemetry for reopening saved groups. r=dao,sessionstore-reviewers,tabbrowser-reviewers,urlbar-reviewers,sthompson
Differential Revision: https://phabricator.services.mozilla.com/D243737
2025-04-09 03:07:19 +00:00
Vasish Baungally
94728b2e9c Bug 1958907 - Improve AI tab groups suggest precision. r=rrando,dwalker,tabbrowser-reviewers
Improvements:
1) Preprocess text to remove domain information. This makes similarity check more robust.
2) Optimize for F1, which means increasing threshold and reducing depth parameter

Differential Revision: https://phabricator.services.mozilla.com/D244631
2025-04-08 22:11:32 +00:00
Jeremy Swinarton
6483fac085 Bug 1957723: tabs.create() extensions API correctly adds tabs to groups r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D244613
2025-04-08 15:08:12 +00:00
smolnar
8c01d285cf Backed out changeset 1c700c5b8a89 (bug 1938425) for causing bc failures @ browser_tab_groups_telemetry.js CLOSED TREE 2025-04-07 19:45:55 +03:00
DJ
b8f461ce7f Bug 1938425 - add telemetry for reopening saved groups. r=dao,sessionstore-reviewers,tabbrowser-reviewers,urlbar-reviewers,sthompson
Differential Revision: https://phabricator.services.mozilla.com/D243737
2025-04-07 14:51:17 +00:00
Stephen Thompson
895511dc6f Bug 1938430 - add delete tab group event r=jswinarton,tabbrowser-reviewers,sessionstore-reviewers
Record when users delete an open group from the tab group context menu or delete an open group from a context menu in the all-tabs menu.

This will not record when users close a window or close all of the individual tabs in a tab group, even though those cases have the logical side effect of deleting a tab group.

Differential Revision: https://phabricator.services.mozilla.com/D241884
2025-04-03 14:12:43 +00:00
Vasish Baungally
94d887776e Bug 1953399 - Exclude Firefox View from Smart Tab Suggestions. r=rrando,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D243870
2025-04-02 21:05:26 +00:00
Stephen Thompson
a63b3f8766 Bug 1938697 - fix browser_tab_manager_group issues r=jswinarton,tabbrowser-reviewers
- TabsList has been removing toolbarbuttons (not their parent toolbaritems) and also removing .all-tabs-group-button elements created by GroupsList. Making sure that TabsList only clears group-related toolbaritems in its own menu view
- do some additional waiting/all tabs menu refreshing in the browser_tab_manager_groups tests to make results more consistent

Differential Revision: https://phabricator.services.mozilla.com/D243822
2025-04-02 13:55:59 +00:00
Vasish Baungally
7a6a4ff8f9 Bug 1957097 - Add telemetry for empty suggestion from ML topic model. r=rrando,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D243465
2025-04-01 20:35:12 +00:00
Emily McMinn
31c83f3c1e Bug 1950468 - Add "tabGroupCollapsed" trigger to messaging system and update schema entries r=omc-reviewers,aminomancer,tabbrowser-reviewers,sthompson
Differential Revision: https://phabricator.services.mozilla.com/D241304
2025-04-01 15:44:11 +00:00
Jeremy Swinarton
34d9e59418 Bug 1938426: Record telemetry event when saving a tab group r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D242984
2025-03-27 15:29:19 +00:00
Cosmin Sabou
ced1f3c105 Backed out changeset 68d101b370d8 (bug 1938430) for permafailures on browser_tab_manager_groups.js (Bug 1938697). 2025-03-27 00:21:30 +02:00
Vasish Baungally
2e7c7849b7 Bug 1956073 - Add Opt-in & additional telemetry for Smart Tab Grouping r=rrando,dwalker,tabbrowser-reviewers
- Telemetry for opt-in
     - For each onboarding step
- Telemetry updates for existing
     - Clicking away with ML group name without explicitly clicking "done" or "cancel"
     - When there are no suggestions for "suggest other tabs"
     - Add group id to ml telemetry
     - Move stg telemetry under tab group telemetry
     - Remove num_ from events

Differential Revision: https://phabricator.services.mozilla.com/D242784
2025-03-26 15:41:49 +00:00
Stephen Thompson
78282be03c Bug 1938430 - add delete tab group event r=jswinarton,tabbrowser-reviewers,sessionstore-reviewers
Record when users delete an open group from the tab group context menu or delete an open group from a context menu in the all-tabs menu.

This will not record when users close a window or close all of the individual tabs in a tab group, even though those cases have the logical side effect of deleting a tab group.

Differential Revision: https://phabricator.services.mozilla.com/D241884
2025-03-25 21:16:37 +00:00
Chris Shiohama
a51c127c17 Bug 1953971 - Calls to BrowserTestUtils.addTab in the Tabbed Browser component do not need to be awaited. r=scunnane
Differential Revision: https://phabricator.services.mozilla.com/D241843
2025-03-21 17:00:11 +00:00
Nick Grato
a637f54059 Bug 1951524 - Opt-in UI with Progress bar for Smart Tab groups r=rrando,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson,dwalker,hjones
adding the optin flow and progress bar

Differential Revision: https://phabricator.services.mozilla.com/D241864
2025-03-21 16:03:03 +00:00
Florian Quèze
1c4eb07f93 Bug 1950710 - Migrate histograms to use Glean APIs for FX_TAB_SWITCH_*, r=chutten,tabbrowser-reviewers,mconley.
Differential Revision: https://phabricator.services.mozilla.com/D242167
2025-03-21 15:32:40 +00:00
Dão Gottwald
5b7b89286d Bug 1954865 - Fix closing the last unpinned tab via mouse. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D242292
2025-03-21 12:46:03 +00:00
Butkovits Atila
a1232f30d3 Backed out changeset e2836c2d1f98 (bug 1951524) for causing failures at browser_all_files_referenced.js. 2025-03-21 08:37:42 +02:00
Nick Grato
2a66d14721 Bug 1951524 - Opt-in UI with Progress bar for Smart Tab groups r=rrando,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson,dwalker,hjones
adding the optin flow and progress bar

Differential Revision: https://phabricator.services.mozilla.com/D241864
2025-03-21 03:23:11 +00:00
Stanca Serban
7df2c7072f Backed out 5 changesets (bug 1950710) for causing timeout related failures. CLOSED TREE
Backed out changeset 7a1f8fe65c63 (bug 1950710)
Backed out changeset d2514bee519f (bug 1950710)
Backed out changeset c5f6cd03c1d4 (bug 1950710)
Backed out changeset 9e57a5c12317 (bug 1950710)
Backed out changeset 482b8c741722 (bug 1950710)
2025-03-21 06:29:53 +02:00
Stanca Serban
dfcc675d76 Backed out changeset c0e6b3896ea0 (bug 1954865) for causing mochitests failures in browser_standalonePinnedTab.js. 2025-03-21 06:18:11 +02:00
Florian Quèze
3a92537eb9 Bug 1950710 - Migrate histograms to use Glean APIs for FX_TAB_SWITCH_*, r=chutten,tabbrowser-reviewers,mconley.
Differential Revision: https://phabricator.services.mozilla.com/D242167
2025-03-20 20:14:03 +00:00
Dão Gottwald
ba53c891e3 Bug 1954865 - Fix closing the last unpinned tab via mouse. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D242292
2025-03-20 17:46:50 +00:00
Dão Gottwald
3ba48b6655 Bug 1950904 - Use element index instead of tab index for the drop indicator. r=dwalker,jswinarton,tabbrowser-reviewers,perftest-reviewers,fbilt
Differential Revision: https://phabricator.services.mozilla.com/D239937
2025-03-19 15:07:53 +00:00
Jeremy Swinarton
4bec852b57 Bug 1954500: Fix tab group telemetry to be in line with spec r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D241830
2025-03-18 20:48:15 +00:00
Rolf Rando
ce4fa16558 Bug 1954541 - Remove word duplicates supports singular/plural r=vazish,tabbrowser-reviewers,dwalker
Differential Revision: https://phabricator.services.mozilla.com/D241847
2025-03-18 18:45:16 +00:00
Dão Gottwald
7e0d08a5e4 Bug 1951308 - Don't show a close button for pinned tabs in the tab manager. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D241461
2025-03-13 19:51:59 +00:00
Vasish Baungally
ed268fb313 Bug 1952940 - Prevent Smart Tab Grouping suggestions from including New Tab page. r=rrando,dwalker,tabbrowser-reviewers
Exclude about:home and about:newtab from Smart Tab Grouping suggestions.

Differential Revision: https://phabricator.services.mozilla.com/D240898
2025-03-13 15:06:10 +00:00
Rolf Rando
4d8a5b817c Bug 1952417 - Don't output Smart Tab Group topic for invalid topics r=vazish,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D240922
2025-03-12 20:15:58 +00:00
Jeremy Swinarton
c828d955e5 Bug 1938397: Record active tab group metrics r=dao,tabbrowser-reviewers,sthompson
Differential Revision: https://phabricator.services.mozilla.com/D240196
2025-03-12 17:46:15 +00:00
DJ
b4c31cf534 Bug 1950973 - batch process beforeUnload handlers when removing a tab group. r=dao,tabbrowser-reviewers,sessionstore-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D240273
2025-03-11 18:55:05 +00:00
Greg Stoll
c89735b508 Bug 1946432 - when unloading all tabs, don't switch to Firefox View if it's hidden r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D239778
2025-03-11 12:05:41 +00:00
Vasish Baungally
5fcf6f91a5 Bug 1950486 - Add model revision for smart tab grouping telemetry. r=rrando,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D240061
2025-03-07 18:44:29 +00:00
Goloman Adrian
7f877be10f Backed out changeset edc7847f9776 (bug 1950973) for causing bc failures @browser_prompt_close_groups.js . 2025-03-07 05:08:36 +02:00
DJ
3526f7e308 Bug 1950973 - batch process beforeUnload handlers when removing a tab group. r=dao,tabbrowser-reviewers,sessionstore-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D240273
2025-03-06 20:59:11 +00:00
Goloman Adrian
59941c102c Backed out changeset 29aba9d75f6c (bug 1950486) for causing lint failure @SmartTabGrouping.sys.mjs. CLOSED TREE 2025-03-06 23:48:34 +02:00
Vasish Baungally
c0e8f73d16 Bug 1950486 - Add model revision for smart tab grouping telemetry. r=rrando,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D240061
2025-03-06 20:10:26 +00:00
Vasish Baungally
145851f187 Bug 1952040 - Update Smart Tab Suggest to only use title for similarity comparison. r=rrando,dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D240525
2025-03-06 18:19:41 +00:00
Butkovits Atila
76f1949306 Backed out changeset cd8f12bed08a (bug 1950973) for causing failures at test_restore_manually_with_tab_groups.py. CLOSED TREE 2025-03-06 18:05:15 +02:00
Dão Gottwald
8bce10cd45 Bug 1951939 - Save and close tab group when middle clicking the group label. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D240479
2025-03-06 13:18:26 +00:00
DJ
fb9b1427f2 Bug 1950973 - batch process beforeUnload handlers when removing a tab group. r=dao,tabbrowser-reviewers,sessionstore-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D240273
2025-03-06 11:25:20 +00:00
Jeremy Swinarton
8d67992ca5 Bug 1938423: Add glean metric for tab group create r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D239921
2025-03-04 20:05:19 +00:00
Dão Gottwald
d24f3155d1 Bug 1951080 - Add Tabs to Group should show all Groups for the selection of tabs that also has at least one free tab selected. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D240302
2025-03-04 16:18:50 +00:00
Goloman Adrian
1fdec4b2d1 Backed out changeset dfdd36582a66 (bug 1938423) as requested by Aryx for missing data review. CLOSED TREE 2025-03-04 18:42:28 +02:00
Jeremy Swinarton
290d8c4e22 Bug 1938423: Add glean metric for tab group create r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D239921
2025-03-04 14:29:14 +00:00
Vasish Baungally
6f2179152b Bug 1950466 - Add Clustering Perftests for Suggest Similar Tabs r=rrando
Differential Revision: https://phabricator.services.mozilla.com/D239634
2025-03-02 00:00:51 +00:00
Butkovits Atila
f3560aafd2 Backed out changeset 336b7892e42d (bug 1950466) for causing failures at browser_tab_grouping_telemetry.js. CLOSED TREE 2025-03-01 02:57:54 +02:00