Commit Graph

166 Commits

Author SHA1 Message Date
Robert Strong
7fd5f9815c Bug 1355361 - nsUpdateProcessor::ProcessUpdate should use the directory service instead of nsXREDirProvider (also removes app update gonk support). r=mhowell
Since the ApplyUpdate and SwitchToUpdatedApp functions are almost entirely the same this moves everything into ApplyUpdate.
Removes most of the gonk code from application update.
Makes client code and xpcshell tests use the same code for directory providers in nsUpdateDriver.cpp.
2017-04-12 18:07:07 -07:00
Sylvestre Ledru
61802819c8 Bug 1338086 - Remove useless else blocks in order to reduce complexity in toolkit/mozapps/update/updater/ r=Ehsan
MozReview-Commit-ID: 3X4CIucTfGG
2017-02-09 10:57:33 +01:00
Adam Gashlin
c366e9b2d3 Bug 1321814 - Check for path truncation. r=rstrong 2017-02-06 19:29:48 -05:00
Sylvestre Ledru
79a067af86 Bug 1318004 - Use C++11's override and remove virtual where applicable. r=Ehsan
MozReview-Commit-ID: H9tAe0YN1tx
2016-11-16 17:08:26 +01:00
Sylvestre Ledru
a15f1c5d08 Bug 1318004 - Replace default bodies of special member functions with = default; r=Ehsan
MozReview-Commit-ID: 33AOhtFrXS8
2016-11-16 18:26:14 +01:00
Wes Kocher
b620596e75 Backed out 4 changesets (bug 1318004) for xpcshell failures a=backout CLOSED TREE
Backed out changeset a3fe53641526 (bug 1318004)
Backed out changeset a5d1676b6f88 (bug 1318004)
Backed out changeset b56b37f0f4d7 (bug 1318004)
Backed out changeset fb5254baf1cb (bug 1318004)
2016-11-21 16:15:38 -08:00
Sylvestre Ledru
b48ac2ed6f Bug 1318004 - Use C++11's override and remove virtual where applicable. r=Ehsan
MozReview-Commit-ID: H9tAe0YN1tx
2016-11-16 17:08:26 +01:00
Sylvestre Ledru
eaf1a1bb8c Bug 1318004 - Replace default bodies of special member functions with = default; r=Ehsan
MozReview-Commit-ID: 33AOhtFrXS8
2016-11-16 18:26:14 +01:00
Wes Kocher
13642ca8af Backed out 4 changesets (bug 1318004) for xpcshell failures a=backout
Backed out changeset 6995bd33872b (bug 1318004)
Backed out changeset 9be5c856bc78 (bug 1318004)
Backed out changeset 365b0b7f289a (bug 1318004)
Backed out changeset 2f2ebf176eac (bug 1318004)
2016-11-21 12:23:17 -08:00
Sylvestre Ledru
9fbcdd2d4f Bug 1318004 - Use C++11's override and remove virtual where applicable. r=Ehsan
MozReview-Commit-ID: H9tAe0YN1tx
2016-11-16 17:08:26 +01:00
Sylvestre Ledru
c30faf12df Bug 1318004 - Replace default bodies of special member functions with = default; r=Ehsan
MozReview-Commit-ID: 33AOhtFrXS8
2016-11-16 18:26:14 +01:00
Robert Strong
98fbfc779a bug 1299583 - Don't create backup of files when staging an update. r=mhowell 2016-09-09 11:53:57 -07:00
Matt Howell
0f1045b736 Bug 1246972 - Always require the update working directory to be within the installation path; r=rstrong
This required fixing a few chrome tests which broke on Mac because they were assuming updater-settings.ini would be at the same location as the executables.

Also, this patch removes many dependencies on the current working directory from updater.cpp by changing it to use absolute paths instead. Otherwise this patch would have required adding yet more chdir() calls to avoid invalidating existing assumptions about what the current directory is.

MozReview-Commit-ID: ASxfV4uVpmD
2016-08-25 15:31:13 -07:00
Wes Kocher
85ed172e67 Backed out 2 changesets (bug 1246972) for marSuccessComplete.js failures a=backout
Backed out changeset 4576637003b6 (bug 1246972)
Backed out changeset c079fb045b9d (bug 1246972)
2016-08-25 13:02:17 -07:00
Matt Howell
15447e7a92 Bug 1246972 - Always require the update working directory to be within the installation path; r=rstrong
This required fixing a few chrome tests which broke on Mac because they were assuming updater-settings.ini would be at the same location as the executables.

Also, this patch removes many dependencies on the current working directory from updater.cpp by changing it to use absolute paths instead. Otherwise this patch would have required adding yet more chdir() calls to avoid invalidating existing assumptions about what the current directory is.

MozReview-Commit-ID: ASxfV4uVpmD
2016-08-23 14:11:23 -07:00
Robert Strong
2a38afcb1d Bug 1287176 client code - Status file not written for staging errors. r=mhowell 2016-08-12 22:52:24 -07:00
Robert Strong
5e5c76f9ac Bug 1168743 - client changes - Only use env vars in the test updater and general app update cleanup. r=mhowell 2016-06-11 08:31:10 -07:00
Stephen A Pohl
8387f93469 Bug 394984: Enable any admin user on OSX to update Firefox, front-end and updater changes. r=rstrong 2016-05-24 22:25:11 -04:00
Matt Howell
6dd90bc346 Bug 1237219 - Lock patch files while applying updates; r=rstrong
MozReview-Commit-ID: 8m4SQVhZy4D
2016-04-14 09:33:42 -07:00
Paul Bignier
5591851a30 Bug 1247217 - [CID 749520] Free pointers that should be freed. r=rstrong 2016-04-13 22:58:11 -07:00
Matt Howell
ef65c59d36 Bug 1246944 - Don't continue updating if copying the callback executable fails; r=rstrong 2016-03-23 10:53:48 -07:00
Chris Peterson
99516d2a45 Bug 1236389 - Annotate intentional switch fallthroughs to suppress -Wimplicit-fallthrough warnings in mozapps/update. r=rstrong
toolkit/mozapps/update/updater/updater.cpp:3722:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
toolkit/mozapps/update/updater/updater.cpp:3768:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
2016-01-01 17:04:00 -07:00
Jan Beich
b8f4fb5f3e Bug 1234033 - Unbreak build --with-system-bz2 using Clang. r=dvander 2015-07-24 08:09:04 +00:00
Kathy Brade
1eb030c8f2 Bug 1217985 - Don't depend on Windows crypto DLLs
If not building the Windows Maintenance Service, avoid a dependency
on crypt32.dll and wintrust.dll.

Also, avoid setting sUsingService inside the updater code; this
ensures that all Maintenance Service related codepaths are skipped.
2015-10-27 17:50:32 -07:00
Robert Strong
d1f721c720 Bug 1177861 - remove remaining unused declarations and cleanup update staging. r=spohl 2015-08-11 14:30:35 -07:00
Stephen Pohl
44ac199edd Bug 1158870: Disable mar signing code path in updater for gonk until mar signing is available there. r=bbondy 2015-07-20 15:35:40 -04:00
Robert Strong
000e8cd69c Bug 1171518 - cleanup maintenance service logging. r=bbondy 2015-07-14 12:08:45 -07:00
Robert Strong
b02ffe1f69 Bug 1168720 - Remove use of test env var MOZ_NO_REPLACE_FALLBACK and associated tests that are covered by other tests. r=spohl 2015-06-04 09:20:00 -07:00
Robert Strong
ad77d912c1 Bug 1165061 - Fix Intermittent test_0102_background_restartNotification_staging.xul by not copying app files when staging for tests and enable the tests for Linux and Mac. r=spohl 2015-06-03 11:29:51 -07:00
Robert Strong
a0b7c51e19 Bug 1168009 - heap-use-after-free (ASAN build) in updater.cpp mstrtok. r=spohl 2015-06-01 11:52:08 -07:00
Ryan VanderMeulen
f97a0ba497 Backed out changeset d39ba5b549c5 (bug 1165061) for LSAN leaks. a=me 2015-05-21 11:50:34 -04:00
Robert Strong
7d3835b670 Bug 1165061 - prevent test timeouts by not copying files when staging an update in mochitest-chrome tests. r=spohl 2015-05-20 13:34:29 -07:00
Robert Strong
34aefa862e Bug 1159826 - ensure_copy_recursive() leaks directory streams. r=spohl 2015-04-29 17:27:33 -07:00
Robert Strong
8175749895 Bug 1127481 - Run the updater from the install directory instead of copying it. r=spohl 2015-04-28 22:41:03 -07:00
Kartikaya Gupta
ebe4a3e37e Bug 1039866 - Rip out a bunch of metro-only code. r=jimm,gavin,rstrong 2015-04-23 15:10:30 -04:00
Brian R. Bondy
77b4f213d6 Bug 973933 - New updater-xpcshell binary for updater tests. r=rstrong
This is a rollup of recent work. Changes include:
- Creating an xpcshell only updater binary. This binary has an embedded xpcshell only cert for verifying test only mars.  It is only used by tests and is not signed w/ authenticode certs.
- Modifying tests to use that new binary
- Adding a check-cert option to the maintenance service
- Using that new cert-check option in new tests to test the authenticode path
- No longer doing an authenticode check during service updater tests on the xpcshell binary.
- Enables more tests for other platforms
2015-04-06 12:03:18 -04:00
Stephen Pohl
290ccd1418 Bug 991993: Disable NSS for updater on OSX and enable native APIs. r=smichaud,rstrong 2014-10-22 21:52:54 -04:00
Brian R. Bondy
bc7986adad Bug 903135 - Multi platform MAR verification updater support. r=rstrong 2014-10-22 21:00:26 -04:00
Robert Strong
ae7908e5ce Bug 1083653 - fix intermittent failure for marStageSuccessPartialSvc.js and marStageFailurePartialSvc.js. r=spohl 2015-04-04 05:24:54 -07:00
Robert Strong
9d6e3adefd Bug 1137447 - New app update telemetry for patch type (complete or partial), extended error codes, and general cleanup. r=bbondy 2015-03-28 20:20:53 -07:00
Robert Strong
094f36d2d9 bug 945192 - add x64 support to loaddlls.cpp and general cleanup. r=bbondy 2015-01-29 11:50:33 -08:00
Chris Peterson
f22236a66f Bug 1125690 - Fix -Wtautological-compare warning in toolkit/mozapps/update/updater and mark as FAIL_ON_WARNINGS. r=rstrong 2015-01-25 00:24:34 -08:00
Brian Smith
6b89c1d286 Bug 1119072, Part 11: Do not conflate struct _stat with struct stat in MSVC 2015, r=rstrong 2015-01-12 20:04:46 -08:00
Trevor Saunders
ca22097c3c bug 1077549 - remove useless gcc version checks r=glandium 2015-01-15 21:30:05 -05:00
Kai-Zhen Li
1b1c59ddc3 Bug 1104655 - User syscall to implement ioprio_set for gonk-l. r=rstrong 2015-01-13 10:05:02 +08:00
Nicholas Nethercote
fc9811215d Bug 1080302 (part 2) - Convert all mentions of -foo options to --foo options in comments, help messages and error messages. r=glandium. 2014-10-23 17:35:27 -07:00
Robert Strong
d2ee992f22 Mac v2 signing - Bug 1075169 - Copy staged update when renaming fails and fix crash on staging failure. r=spohl, a=RyanVM over irc 2014-09-30 20:36:45 -07:00
Robert Strong
d3ba089171 Mac v2 signing - Bug 1071465 - old precomplete file is not removed on update. r=spohl 2014-09-29 11:52:48 -07:00
Robert Strong
5a2ed4e398 Mac v2 signing - Bug 1071134 - Fix command line help for updater. r=spohl 2014-09-29 11:52:44 -07:00
Robert Strong
80aff3dcac Mac v2 signing - Bug 1070661 - Error setting access/modification time on application bundle. r=spohl 2014-09-29 11:52:21 -07:00