Commit Graph

30 Commits

Author SHA1 Message Date
Mike de Boer
889e09ada6 Bug 1316459 - play range outline animations after its properties have been set as the result of a scheduled repaint of the modal highlighter. r=Gijs
MozReview-Commit-ID: 4xLHwB0l4ja
2017-01-23 20:13:07 +01:00
Mike de Boer
464ad73586 Bug 1324143 - part 3 - disable CPU intensive tasks when the page is too big to bother. r=jaws
MozReview-Commit-ID: CIEc2bYnxOq
2017-01-06 13:13:28 +01:00
Mike de Boer
4b9abf202e Bug 1324143 - part 1 - remove the deprecated '_getRangeContentArray' utility method and its uses, the unused '_maybeHighlightAll' findbar method and cleanup range outline highlighting code. r=jaws
MozReview-Commit-ID: gLKKEd3CoA
2017-01-06 13:11:26 +01:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Mike de Boer
b9f30ab4f0 Bug 1282752 - use the awesome new Range.getRectsAndTexts() API to fetch the text content for each rect of a range. r=jaws
MozReview-Commit-ID: BKAx4TdBms0
2016-11-11 12:41:00 +01:00
Mike de Boer
80dafbf488 Bug 1304497 - always draw all rectangles, because the showing and hiding of overlapping rectangles during find occurrence navigation is jarring. This essentially backs out bug 1300824. r=jaws
MozReview-Commit-ID: 32HJaR0czyh
2016-11-02 22:18:15 +01:00
Mike de Boer
44f855f3a2 Bug 1305194 - wait a little longer when the finder iterator is requested to find a query of only one or two characters, which improves usability due to less flickering of highlighter results and performance due to avoiding the most costly nsFind operations there are on a page. r=jaws
Single and double character find operations cause a big hit on nsFind, because
it usually yields many more occurrences than other queries. But most importantly,
it needs to keep iterating each text node much longer than other queries, because
there is much less escapes/ loop exits happening.
This also fixes the FinderIterator infinite-depth call-stack due to unresolved
promises that remain active during the lifetime of the FinderIterator. Unwinding
the call-stack properly should save us bytes from the heap.

MozReview-Commit-ID: 4K19X0yngC7
2016-10-12 15:46:44 +02:00
Sebastian Hengst
3764def8a2 Backed out changeset a7882c91ca20 (bug 1305194) for leaking docshells, e.g. in browser_Finder_hidden_textarea.js and browser_findbar.js. r=backout 2016-10-11 21:00:52 +02:00
Mike de Boer
48ab60e886 Bug 1305194 - wait a little longer when the finder iterator is requested to find a query of only one or two characters, which improves usability due to less flickering of highlighter results and performance due to avoiding the most costly nsFind operations there are on a page. r=jaws
Single and double character find operations cause a big hit on nsFind, because
it usually yields many more occurrences than other queries. But most importantly,
it needs to keep iterating each text node much longer than other queries, because
there is much less escapes/ loop exits happening.
This also fixes the FinderIterator infinite-depth call-stack due to unresolved
promises that remain active during the lifetime of the FinderIterator. Unwinding
the call-stack properly should save us bytes from the heap.

MozReview-Commit-ID: 4K19X0yngC7
2016-10-11 18:06:45 +02:00
Mike de Boer
805a22093c Bug 1303874 - clear the dictionary for the current find window only upon restart of the iterator, not each reset. r=jaws
MozReview-Commit-ID: Gp2rnr5z12n
2016-09-26 16:07:53 +02:00
Sebastian Hengst
8951837e34 Backed out changeset 464d8056f9de (bug 1303874) for failing mochitest-chrome-3 test_bug263683.xul on Linux. r=backout 2016-09-23 18:43:19 +02:00
Mike de Boer
c05eb2b506 Bug 1303874 - clear the dictionary for the current find window only upon restart of the iterator, not each reset. r=jaws
MozReview-Commit-ID: Cq9bI5XEp1y
2016-09-22 10:52:22 +02:00
Mike de Boer
716d0144e8 Bug 1302170 - use the newly added setCutoutRectsForElement API for AnonymousContent to optimize rectangle cutouts rendering speed when using findbar dimmed, modal highlighting mode. r=jaws,mstange
MozReview-Commit-ID: Im0yvzDM8nm
2016-09-23 12:39:42 +02:00
Mike de Boer
afc28d0a90 Bug 1301941 - hide the dimmed modal highlight of the find toolbar when the last character is removed from the input field. r=jaws
MozReview-Commit-ID: 5I4ggpJ5xQx
2016-09-16 11:10:51 +02:00
Mike de Boer
fa992fe815 Bug 1302178 - fix ESlint error in browser_FinderHighlighter.js. r=me, a=tomcat
MozReview-Commit-ID: FhNkbzenRAp
2016-09-15 11:34:27 +02:00
Mike de Boer
32c5cc103c Bug 1282752 - support find terms that span multiple lines whilst using modal highlighting in the find toolbar. r=jaws
MozReview-Commit-ID: Jzaqbi945za
2016-09-14 23:31:26 +02:00
Mike de Boer
6bffea2cd5 Bug 1302178 - fix a regression that made the modal highlight not disappear between page navigations. r=jaws
MozReview-Commit-ID: KIrOvR8Pdps
2016-09-13 16:42:12 +02:00
Mike de Boer
df28acbc8c Bug 1300824 - skip cutting out the current found range from the mask so it won't show when you backspace in the findbar input field. r=jaws
MozReview-Commit-ID: 4vcHbHD0z31
2016-09-13 11:32:15 +02:00
Mike de Boer
7d5305d1be Bug 1283042 - add a test for highlighting XML documents; needed to fix up highlightFinished notifications. r=jaws
MozReview-Commit-ID: HKw51diGOBm
2016-09-12 18:46:18 +02:00
Aryeh Gregor
fd7d844ea6 Bug 1299453 - Stop using createEvent("DragEvents"/"KeyEvents") internally; r=smaug
They are non-standard aliases for "DragEvent" and "KeyboardEvent" that
are not supported by any other UA, and we would like to drop support.
So first let's stop using them ourselves, so we can use telemetry to see
if any sites are using them.

MozReview-Commit-ID: ICC33ORa2st
2016-08-31 20:38:50 +03:00
Mike de Boer
6894be27a5 Bug 1279695 - update the position of ranges that are inside fixed, sticky positioned container nodes or frameset or iframe at each repaint or scroll. r=jaws
MozReview-Commit-ID: J8YK1s2kArq
2016-08-25 20:11:46 +02:00
Mike de Boer
c9a9a89a4c Bug 1282070 - repaint the modal highlight mask when the page resizes or changes size due to added/ removed content. r=jaws
MozReview-Commit-ID: 1j0C0BUfT8r
2016-08-19 17:18:41 +02:00
Mike de Boer
1269be4829 Bug 1279684 - make sure that toggling 'Highlight All' also hides the found occurrences from the mask. r=jaws
MozReview-Commit-ID: 2AmSwNgE1if
2016-07-27 16:37:26 +02:00
Mike de Boer
25acabfa98 Bug 1279717 - inverse the mask to use a white background on pages with bright text color. r=jaws
MozReview-Commit-ID: D2UFsOfMJln
2016-06-22 19:22:07 +02:00
Mike de Boer
338074a243 Bug 1279742 - render the highlighter mask using plain HTML and CSS, instead of an SVG document. This improves performance and solves various layouting issues. r=jaws 2016-06-16 10:38:30 +01:00
Mike de Boer
37a166d7dd Bug 384458 - part 5: add unit test coverage for the findbar modal highlight feature. r=jaws 2016-06-09 13:30:51 +02:00
Wes Kocher
6a8a703003 Backed out 6 changesets (bug 384458) for frequent browser_FinderHighlighter.js failures
Backed out changeset ded915ec401f (bug 384458)
Backed out changeset 63ec66da50fa (bug 384458)
Backed out changeset ae71396d3be0 (bug 384458)
Backed out changeset 3b025cbfbe3c (bug 384458)
Backed out changeset 091c5465acf7 (bug 384458)
Backed out changeset 5eabde153def (bug 384458)
2016-06-08 14:53:57 -07:00
Mike de Boer
9d2b4b6431 Bug 384458 - part 5: add unit test coverage for the findbar modal highlight feature. r=jaws 2016-06-08 19:54:12 +02:00