corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
477,034 Commits 1 Branch 0 Tags
c76ce9f99a49d0cb15a2ad724b5db7f2b71142f6
Commit Graph

73 Commits

Author SHA1 Message Date
Mike de Boer
fe79dbffb6 Bug 1339782 - use a WeakMap to keep track of windows with active findbar highlighters and make sure no JS error occurs when a window is closed. r=jaws 
MozReview-Commit-ID: KGdvuWJZzMV
 2017-02-27 16:15:12 +01:00
Florian Quèze
c8cf49999e Bug 1334156 - script-generated patch to replace .ownerDocument.defaultView with .ownerGlobal, r=jaws. 2017-01-27 10:51:03 +01:00
Florian Quèze
0a4ee94a29 Bug 1334199 - script-generated patch to omit getComputedStyle's second argument when it's falsy, r=jaws. 2017-01-27 10:51:02 +01:00
Mike de Boer
f92ef6bfc5 Bug 1316514 - if we attempt to make the 'Highlight All' toggle a global setting, then we need to set the pref when toggled. r=Gijs 
What you see first is the removal of the line `this._highlightAll = aHighlight;`, which is repeated in the `_setHighlightAll` method.
This line was put here initially to make the test_findbar_events.xul test pass but in fact makes it so that the pref is never set in `_setHighlightAll`!
In other words, we never actually persisted the 'Highlight All' state properly.
Reading further: the `_dispatchFindEvent` attaches some findbar state flags to the event details, including the value of `_highlightAll`.
Even though none of our consumers use it currently (haven't checked if TB does, though), you can cancel further execution of highlighting all ranges.
Since the `_setHighlightAll` doesn't do that kind of processing, but merely makes sure the internal state is up to snuff, is persisted properly and the buttons are updated, I moved it up to be invoked before dispatching the event.

MozReview-Commit-ID: 4BBy4FR1r5c
 2017-01-13 17:27:18 +01:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN 
MozReview-Commit-ID: 7E7LPorrEje
 2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout 
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
 2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN 
MozReview-Commit-ID: 8WoGr8i6oCR
 2016-12-29 15:20:47 -05:00
Mark Banner
dc46a8fba3 Bug 1322343 - Enable no-unused-vars in the local scope in toolkit/.eslintrc.js. r=mossop 
MozReview-Commit-ID: CiIsUjQzp4D
 2016-11-09 22:06:32 +00:00
Dave Townsend
e7b1b3284f Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit). r=jaws 
MozReview-Commit-ID: FGFwg6TYkvm
 2016-11-11 15:22:34 -08:00
Mike de Boer
293fa85edc Bug 1303008 - refactor Fennec Finder.jsm integration to always show the correct match count results in the findbar. r=nalexander 
MozReview-Commit-ID: KZIstsbHAyT
 2016-10-10 11:53:25 +02:00
Mike de Boer
94e15875ac Bug 1279707 - when the location changes, we need to be more thorough in clearing the state variables than we are now to make sure we start fresh in new documents. r=jaws 
MozReview-Commit-ID: KkeSKt7XVAc
 2016-09-15 17:11:18 +02:00
Mike de Boer
7d5305d1be Bug 1283042 - add a test for highlighting XML documents; needed to fix up highlightFinished notifications. r=jaws 
MozReview-Commit-ID: HKw51diGOBm
 2016-09-12 18:46:18 +02:00
Mike de Boer
06dc0c6d3b Bug 1290914 - move the matches count and highlight-all request from the findbar binding to the JS module in the content process, so it's closer to the metal. r=jaws 
MozReview-Commit-ID: INYobXmrVj5
 2016-09-08 22:38:55 +02:00
Mike de Boer
a20c2bde64 Bug 1295759 - make sure selected ranges in iframes are cleared when the findbar is hidden as well. Adds a test to guard against regressions. r=jaws 
MozReview-Commit-ID: 5rudNSNK8GK
 2016-08-29 16:22:29 +02:00
Mike de Boer
7e1c629660 Bug 1294392 - consolidate the highlight and counter timers into one iterator timer. r=jaws 
This introduces a new NLP (Natural Language Processing) module with only one
method: 'levenstein'. We're using it to allow the highlighter to keep running
when the it starts the iterator with a word that's one edit distance behind the
value in the findField.

MozReview-Commit-ID: K8oeiXoiLUe
 2016-08-25 20:11:44 +02:00
Mike de Boer
c9a9a89a4c Bug 1282070 - repaint the modal highlight mask when the page resizes or changes size due to added/ removed content. r=jaws 
MozReview-Commit-ID: 1j0C0BUfT8r
 2016-08-19 17:18:41 +02:00
Jared Wein
8860cdf2c1 Bug 1294547 - Enable the comma-spacing rule for eslint. r=felipe 
MozReview-Commit-ID: RCSDEvvk2I
 2016-08-16 15:44:15 -04:00
Wes Kocher
f0be1004da Backed out changeset af4cc6c04573 (bug 1282070) for failures in test_bug263683.xul CLOSED TREE 2016-08-16 11:58:33 -07:00
Mike de Boer
6ce8b34ce5 Bug 1282070 - repaint the modal highlight mask when the page resizes or changes size due to added/ removed content. r=jaws 
MozReview-Commit-ID: JrTOarWMEQQ
 2016-08-16 18:01:19 +02:00
Sebastian Hengst
850eb0c175 Backed out changeset bc160abe215b (bug 1282070) for docshell leakage in browser_visibleFindSelection.js. r=backout 2016-08-16 16:05:45 +02:00
Mike de Boer
831853c0e4 Bug 1282070 - repaint the modal highlight mask when the page resizes or changes size due to added/ removed content. r=jaws 
MozReview-Commit-ID: JKzUehP4pyP
 2016-08-16 12:16:29 +02:00
Mike de Boer
858aad5164 Bug 1294644 - prevent drawing the rectangles all too often when modal highlighting is off and make sure to restore the outline of found links and the highlight color of the currentle highlighted occurrence. r=jaws 
Many thanks to Tooru Fujisawa [:arai] for helping write this patch and testing it.

MozReview-Commit-ID: BxAd3WdqUXU
 2016-08-16 11:25:56 +02:00
Mike de Boer
9e4a7c375b Bug 1280876 - don't take screenshots of pages that have the findbar open. r=jaws,mconley 
MozReview-Commit-ID: Dmz0MaukNVq
 2016-08-10 11:23:47 +02:00
Mike de Boer
4292ac8e62 Bug 1290842 - reduce the amount calls to the highlighter upon the first find action and improve the behavior when modal highlighting is not enabled now that we have a FinderHighlighter class we can use. r=jaws 
MozReview-Commit-ID: K01dpqp8LSf
 2016-08-02 10:40:21 +02:00
Carsten "Tomcat" Book
186ae7c42a Merge mozilla-central to fx-team 2016-07-28 17:44:58 +02:00
Mike de Boer
0145f8eec4 Bug 1281421 - Merge the find counter and highlighter iterators into a FinderIterator singleton. r=jaws 
MozReview-Commit-ID: 9fhOKWIkOXN
 2016-07-28 12:34:13 +02:00
Carsten "Tomcat" Book
334520276b Merge mozilla-central to fx-team 2016-07-27 16:40:43 +02:00
Mike de Boer
1269be4829 Bug 1279684 - make sure that toggling 'Highlight All' also hides the found occurrences from the mask. r=jaws 
MozReview-Commit-ID: 2AmSwNgE1if
 2016-07-27 16:37:26 +02:00
Jared Wein
05f9b81fa7 Bug 1285464 - Keep focus handling in the chrome process so focus will move back to the content out of the typeahead findbar but not change which chrome window has focus. r=mikedeboer 
MozReview-Commit-ID: Ga8QFFgX0ZZ
 2016-07-26 14:53:32 -04:00
Ray Lin
e02d84d80d Bug 1198279 - Clear all highlighted matches when find bar closed. r=mikedeboer 
MozReview-Commit-ID: C4wiWWKAMpa
 2016-07-05 15:59:25 +08:00
Mike de Boer
40aa390f52 Bug 269442 - whole word matching support for nsFind. r=ehsan,dao. ui-r=shorlander 
MozReview-Commit-ID: KIDWHyjOSYL
 2016-06-28 15:13:53 +02:00
Mike de Boer
f9037c003c Bug 384458 - part 4: implement modal highlighting using the AnonymousContent API and SVG masks. r=jaws 2016-06-09 13:30:49 +02:00
Mike de Boer
856fd3cc6a Bug 384458 - part 3: move the highlighting code to its own module. r=jaws 2016-06-09 13:30:48 +02:00
Wes Kocher
6a8a703003 Backed out 6 changesets (bug 384458) for frequent browser_FinderHighlighter.js failures 
Backed out changeset ded915ec401f (bug 384458)
Backed out changeset 63ec66da50fa (bug 384458)
Backed out changeset ae71396d3be0 (bug 384458)
Backed out changeset 3b025cbfbe3c (bug 384458)
Backed out changeset 091c5465acf7 (bug 384458)
Backed out changeset 5eabde153def (bug 384458)
 2016-06-08 14:53:57 -07:00
Mike de Boer
a40c73ccb2 Bug 384458 - part 4: implement modal highlighting using the AnonymousContent API and SVG masks. r=jaws 2016-06-08 19:54:10 +02:00
Mike de Boer
ecd5d54bd4 Bug 384458 - part 3: move the highlighting code to its own module. r=jaws 2016-06-08 19:54:08 +02:00
Mike de Boer
1fab547711 Bug 1056235 - deal with surrogate pairs properly when retrieving the currently selected text for prefill in the findbar. r=masayuki 2016-06-06 12:56:55 +02:00
Dave Townsend
769fc8f245 Bug 1257246: Update toolkit for eslint 2. r=Gijs 
Most of this is fixing functions that in some cases return a value but then
can also run to completion without returning anything. ESLint 2 catches this
where previous versions didn't. Unless there was an obvious other choice I just
made these functions return undefined at the end which is effectively what
already happens.

MozReview-Commit-ID: KHYdAkRvhVr
 2016-04-05 11:33:48 -07:00
Blake Kaplan
044aeb6502 Bug 1174036 - Handle dynamically-removed textareas gracefully. r=mikedeboer r=ehsan 
Also, flush layout when starting a find in order to avoid racing with
textarea-hiding notifications and maintain JS type correctness when objects
are passed over IPC.
 2016-03-28 11:12:31 -07:00
Jared Wein
221e1ba639 Bug 1064580 - Add definitions for onCurrentSelection to the listeners since RemoteFinder.jsm expects them to be present. Also add an error check in Finder.jsm for empty selections. r=evilpie 
MozReview-Commit-ID: E6lgH8OZhaH
 2016-03-07 16:37:34 -05:00
Dave Townsend
a215a4a95a Bug 1245649: Turn on no-extra-semi. r=markh 2016-02-03 17:27:36 -08:00
Paul Rouget
96d8781a2d Bug 1163961 - Browser API: Page search. r=kchen, r=ehsan 2015-06-09 20:04:00 -04:00
Birunthan Mohanathas
fe337d7c5e Bug 1166840 - Remove unused document argument in uses of nsIClipboardHelper.copyString. r=ehsan 2015-05-21 21:49:30 +01:00
Gijs Kruitbosch
9c46e44409 Bug 1133981 - e10s-ify findbar FAYT key handling, r=mconley 2015-03-11 20:22:09 +00:00
Blake Kaplan
72625fcc5b Bug 1055508 - Make the findbar respect the search clipboard as well as prefillwithselection in e10s. r=mikedeboer 2015-01-16 15:11:00 +01:00
Tomasz Kołodziejski
96b4aec9e2 Bug 1070923 - Fix intermittent test_bug451286.xul by waiting for the highlight toggle to finish. r=mikedeboer 2014-09-26 10:49:00 -04:00
Tomasz Kołodziejski
29da2cf4c5 Bug 429732 - Make Finder.jsm iterate over matches asynchronously in small batches so it does not block the UI thread. r=mikedeboer 2014-09-18 10:23:00 +02:00
Mike Conley
9b4a1b2b0b Bug 927424 - Allow findbar binding to cancel content focusing when using RemoteFinder in an e10s window. r=evilpie. 2014-09-04 15:17:47 -04:00
Tomasz Kołodziejski
b928e68e55 Bug 429732 - speed up highlighting by optimizing _getEditableNode. r=ehsan 2014-08-29 11:14:00 +02:00
Adam Dane [:hobophobe]
cd694b2f46 Bug 1008450 - Bail on _findIterator when we lack a body node. r=mikedeboer 2014-05-14 15:16:03 -05:00