Commit Graph

4 Commits

Author SHA1 Message Date
Alastor Wu
a79d7e38d5 Bug 1192818 - part1 : dispatch DOMAudioPlaybackStopped when mute the tab. r=baku
The root cause of the intermittent fail is because "DOMAudioPlaybackStopped" has no directly relationship with browser.mute()/unmute().

In [1], the "DOMAudioPlaybackStopped" is caused by audio stop playing, not by calling the browser.mute(). If the audio stops playing before calling the wait_for_event(), the test would be time-out. I guess the bug 1302280 is also caused by same reason.

So this patch would do two thinngs,
1. dispatch "DOMAudioPlaybackStopped" when we mute tab
2. loop the audio in test file, to make sure the "DOMAudioPlaybackStopped" is
   dispatched when muting the audio, not the file ended.
[1] https://goo.gl/ymUv8P

MozReview-Commit-ID: 5RnyBRE73lQ
2017-02-23 14:15:45 +08:00
Sebastian Hengst
95a9b8273e Backed out changeset 38fa2ec33fa4 (bug 1192818) for frequently failing test_noAudioNotificationOnVolume0Element.html on Android 4.3 debug. r=backout 2017-02-21 19:30:26 +01:00
Alastor Wu
3d07567345 Bug 1192818 - part1 : dispatch DOMAudioPlaybackStopped when mute the tab. r=baku
The root cause of the intermittent fail is because "DOMAudioPlaybackStopped" has no directly relationship with browser.mute()/unmute().

In [1], the "DOMAudioPlaybackStopped" is caused by audio stop playing, not by calling the browser.mute(). If the audio stops playing before calling the wait_for_event(), the test would be time-out. I guess the bug 1302280 is also caused by same reason.

So this patch would do two thinngs,
1. dispatch "DOMAudioPlaybackStopped" when we mute tab
2. loop the audio in test file, to make sure the "DOMAudioPlaybackStopped" is
   dispatched when muting the audio, not the file ended.
[1] https://goo.gl/ymUv8P

MozReview-Commit-ID: 703JHj9dICT
2017-02-21 18:41:09 +08:00
Andrea Marchesini
c8c652d9d4 Bug 1183700 - Don't prevent playback of media elements in a muted tab on desktop, r=ehsan 2015-07-16 19:34:30 +01:00