Ehsan Akhgari
481cbab9fe
Bug 1318768 - Part 1: Make the URL classifier service initialize in the content process; r=gcp
2016-11-22 08:17:20 -05:00
Henry Chang
7f94b8915f
Bug 1315097 - Build the provider dictionary on the main thread to be used everywhere. r=francois,gcp
...
MozReview-Commit-ID: Ft1deSNKuVB
2016-11-04 17:54:05 +08:00
Henry Chang
891cee9c33
Bug 1310142 - Preserve backup databases and raw table updates for diagnostic. r=francois
...
MozReview-Commit-ID: GeJoBrhuTgA
2016-10-14 17:58:18 +08:00
DimiL
8496cac4e0
Bug 1315140 - Add telemetry for the Safe Browsing shutdown code. r=francois
...
MozReview-Commit-ID: F9Hv37Mn73P
2016-11-08 15:11:36 +08:00
Sebastian Hengst
6cf65ed900
Bug 1310297 - Remove test annotations using b2g, mulet or gonk: toolkit. r=RyanVM
...
MozReview-Commit-ID: I5LuDjnM7By
2016-11-05 11:29:22 +01:00
Thomas Nguyen
9a9556049a
Bug 1298257 - Implement url matching for variable-length prefix set. r=dimi,gcp
...
MozReview-Commit-ID: 8Goh7yyAotN
2016-11-04 12:00:33 +08:00
Jared Wein
5edec1c0d9
Bug 1315013 - part 1, remove unnecessary double-slash comments that don't add value and look out of place with the spaced-comment eslint rule. r=mossop
...
MozReview-Commit-ID: HIUTSdkXxbY
2016-11-03 14:42:06 -04:00
dimi
6d436a40ee
Bug 1305581 - Verify that V4 updates were applied correctly by computing a checksum on the final result. r=francois
...
MozReview-Commit-ID: LNtFOVMVw2U
2016-10-27 08:36:26 +08:00
dimi
9c42f796bc
Bug 1301269 - Fix update retry timer is released before firing. r=francois
...
MozReview-Commit-ID: KF1j2EFuxpa
2016-10-21 14:40:11 +08:00
Henry Chang
5e085f2966
Bug 1312323 - Consider the "single encoded value" case and bubble the decoding error up. r=francois.
...
MozReview-Commit-ID: 1GNFkMQ1JoD
2016-10-26 10:03:49 +08:00
dimi
bd858fc5df
Bug 1305780 - P2. Testcase for update fail. r=gcp
...
MozReview-Commit-ID: CopsfRuawdm
2016-10-24 08:43:54 +08:00
DimiL
e841cd1751
Bug 1305780 - P1. Implement the update fail scheme for v4. r=gcp
...
MozReview-Commit-ID: LeVpVIUdmjc
2016-10-19 12:52:05 +08:00
Henry
1a09e5cf41
Bug 1307541 - ProtocolParserProtobuf to init and return update time properly. r=francois.
...
MozReview-Commit-ID: CmVWVKUeunJ
2016-10-18 14:45:21 +08:00
Mark Banner
233309fbe2
Bug 1251003 - Change .eslintrc files to .eslintrc.js to avoid obsolete config file format. r=mossop
...
MozReview-Commit-ID: JrbFxQ5rj6I
2016-10-18 08:38:10 +01:00
Carsten "Tomcat" Book
2f993eaaf3
Merge mozilla-central to autoland
2016-10-14 12:34:25 +02:00
Ehsan Akhgari
cef52e4bd4
Bug 1309924 - Remove the needless arguments to nsUrlClassifierClassifyCallback's constructor; r=francois
2016-10-13 18:42:06 -04:00
Henry Chang
fff35e78ca
Bug 1305484 - Save/load state and checksum to/from disk rather than prefs. r=dimi,francois
...
MozReview-Commit-ID: 4gmmrI9wY4c
2016-10-13 15:22:08 +08:00
Henry
413e8c6a5b
Bug 1305478 - Unify the initial update delay (for both v2 and v4) to 0~1 minute. r=francois
...
MozReview-Commit-ID: 7RbUUfCNQfk
2016-10-11 14:47:57 +08:00
Cykesiopka
c09a7ff473
Bug 1309440 - Remove unused BitBuffer methods from RiceDeltaDecoder.cpp. r=francois
...
MozReview-Commit-ID: GOzgd7eKILm
2016-10-12 10:51:31 +08:00
Dimi Lee
e49ab99ec5
Bug 1308606 - Crash in mozilla::safebrowsing::Classifier::UpdateHashStore. r=francois
...
MozReview-Commit-ID: FIl5cPFzGbl
2016-10-08 20:42:43 +08:00
Henry Chang
ea02e6b8bd
Bug 1285848 - Part 2: Request and parse RICE encoded prefix by default. r=francois
...
MozReview-Commit-ID: Cd0lT5VTM7t
2016-10-05 14:59:53 +08:00
Henry Chang
2e867131fd
Bug 1285848 - Part 1: Implement Rice Delta Decoding. r=francois.
...
MozReview-Commit-ID: 2GR51CRFBDL
2016-10-05 14:59:43 +08:00
Dimi Lee
d316530abf
Bug 1305801 - Part 5: Support SafeBrowsing v4 partial update. r=gcp
...
MozReview-Commit-ID: 7OEWLaZbotS
2016-10-04 09:14:39 +08:00
Dimi Lee
e6d6ca8983
Bug 1305801 - Part 4: Store variable-length prefix to disk. r=francois, r=gcp
...
MozReview-Commit-ID: BMTGtgMuQdg
2016-09-19 11:51:01 +08:00
Dimi Lee
35e3b8769f
Bug 1305801 - Part 3: Testcase for variable length prefixSet. r=francois, r=gcp
...
MozReview-Commit-ID: Gy7LtQ11EkV
2016-09-14 14:49:41 +08:00
Dimi Lee
2c0f37dc9a
Bug 1305801 - Part 2: Add telemetry for variable-length prefix set. r=francois
...
MozReview-Commit-ID: 8SebDJ8ZeKn
2016-09-27 14:26:09 -07:00
Dimi Lee
62bb662f25
Bug 1305801 - Part 1: Implement variable length PrefixSet class for Safe Browsing v4. r=francois, r=gcp
...
MozReview-Commit-ID: FahurMd1KGe
2016-10-04 21:43:08 +08:00
Henry
6fd66a6613
Bug 1305567 - Use base64url encoding and avoid cutting the state. r=francois
2016-09-30 10:36:40 -07:00
Sebastian Hengst
4ad6c96678
Backed out changeset d46155cc719e (bug 1305567) for various failures in browser-chrome, devtools, and xpcshell (e.g. test_streamupdater.js) tests. r=backout on a CLOSED TREE
2016-09-29 20:54:50 +02:00
Henry
285154b77e
Bug 1305567 - Use base64url encoding, avoid cutting the state and dump download error message. r=francois.
...
MozReview-Commit-ID: 1umDhxY5eKl
2016-09-27 11:48:11 -07:00
Henry Chang
13ce085b08
Bug 1302044 - Init tableArray with only enabled tables. r=francois.
...
MozReview-Commit-ID: KMp8oLkBXwb
2016-09-12 17:30:06 +08:00
Francois Marier
42d01a3778
Bug 1297865 - Remove unused URLCLASSIFIER_PS_FAILURE probe. r=bsmedberg,gcp
...
MozReview-Commit-ID: Gl4o8gllqcs
2016-08-25 16:34:07 -07:00
Henry Chang
889e160c68
Bug 1301008 - Pass safebrowsing v4 list state in base64 format to avoid truncation. r=francois
...
MozReview-Commit-ID: 6oVdQvEoMm2
2016-09-07 17:45:15 +08:00
Wes Kocher
acd22e8efa
Merge inbound to m-c a=merge
2016-09-07 17:54:24 -07:00
Carsten "Tomcat" Book
b95ddfd9ff
Merge mozilla-central to autoland
2016-09-07 17:26:11 +02:00
Michael Layzell
419868d357
Bug 1018486 - Part 9: Changes to account for modifications to clang plugin, r=ehsan
...
MozReview-Commit-ID: EPQMbfHYxUK
2016-09-07 10:50:47 -04:00
dimi
b64e697a4d
Bug 1297518 - Increase gethash timeout for testcases. r=gcp
...
MozReview-Commit-ID: BmX6UzGhfhf
2016-09-06 12:21:19 +08:00
Thomas Nguyen
b0c8c47bd2
Bug 999484 - Test FindInReadable calls in safebrowsing code. r=gcp
...
MozReview-Commit-ID: C27J4dh9s6T
2016-09-01 10:48:17 +08:00
Henry Chang
8844a50a30
Bug 1254763 - Part 2: Test cases. r=gcp
...
MozReview-Commit-ID: JDjV3WUfgWW
2016-09-02 12:02:40 +08:00
Henry Chang
176430c017
Bug 1254763 - Part 1: Use per-provider directory for V4 databases. r=dimi,gcp
...
MozReview-Commit-ID: KZGWIcKAQyW
2016-09-02 12:00:00 +08:00
Thomas Nguyen
95d0b2d935
Bug 1299036 - Fix Intermittent toolkit/components/url-classifier/tests/mochitest/test_classifier_worker.html. r=dimi,gcp.
...
MozReview-Commit-ID: 3YgxgjpV7Ay
2016-09-02 15:01:48 +08:00
Nicholas Nethercote
b5810a1eb4
Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm.
...
This change avoids lots of false positives for Coverity's CHECKED_RETURN
warning, caused by NS_WARN_IF's current use in both statement-style and
expression-style.
In the case where the code within the NS_WARN_IF has side-effects, I made the
following change.
> NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
> -->
> Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
In the case where the code within the NS_WARN_IF lacks side-effects, I made the
following change.
> NS_WARN_IF(!condWithoutSideEffects);
> -->
> NS_WARNING_ASSERTION(condWithoutSideEffects, "msg");
This has two improvements.
- The condition is not evaluated in non-debug builds.
- The sense of the condition is inverted to the familiar "this condition should
be true" sense used in assertions.
A common variation on the side-effect-free case is the following.
> nsresult rv = Fn();
> NS_WARN_IF_(NS_FAILED(rv));
> -->
> DebugOnly<nsresult rv> = Fn();
> NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");
2016-09-02 17:12:24 +10:00
Nicholas Nethercote
887efe04d5
Bug 1299727 - Rename NS_WARN_IF_FALSE as NS_WARNING_ASSERTION. r=erahm.
...
The new name makes the sense of the condition much clearer. E.g. compare:
NS_WARN_IF_FALSE(!rv.Failed());
with:
NS_WARNING_ASSERTION(!rv.Failed());
The new name also makes it clearer that it only has effect in debug builds,
because that's standard for assertions.
2016-09-01 15:01:16 +10:00
Nicholas Nethercote
62b6b0fce6
Bug 1297961 (part 1) - Introduce nsURI::GetSpecOrDefault(). r=hurley.
...
This function is an infallible alternative to nsIURI::GetSpec(). It's useful
when it's appropriate to handle a GetSpec() failure with a failure string, e.g.
for log/warning/error messages. It allows code like this:
nsAutoCString spec;
uri->GetSpec(spec);
printf("uri: %s", spec.get());
to be changed to this:
printf("uri: %s", uri->GetSpecOrDefault().get());
This introduces a slight behavioural change. Previously, if GetSpec() failed,
an empty string would be used here. Now, "[nsIURI::GetSpec failed]" will be
produced instead. In most cases this failure string will make for a clearer
log/warning/error message than the empty string.
* * *
Bug 1297961 (part 1b) - More GetSpecOrDefault() additions. r=hurley.
I will fold this into part 1 before landing.
2016-08-26 16:02:31 +10:00
Thomas Nguyen
29f9371e3b
Bug 1201716 - Missing status check in SafeBrowsing::Merge causes SafeBrowsing malfunction. r=francois
...
MozReview-Commit-ID: CtF4Gczkoa1
2016-08-24 17:15:13 +08:00
Thomas Nguyen
7392cef04e
Bug 1296751 - Skip observe browser.safebrowsing.provider.*.(nextupdatetime|lastupdatetime). r=francois
...
MozReview-Commit-ID: 6yNWVJ3LYBE
2016-08-24 17:06:48 +08:00
Henry Chang
156c792bf3
Bug 1296820 - Skip applying TableUpdateV4 to avoid premature update codes being run. r=dimi,francois
...
MozReview-Commit-ID: IqjpAVgISLJ
2016-08-26 14:35:53 +08:00
Wes Kocher
e079662c3f
Merge inbound to central, a=merge
2016-08-26 16:20:50 -07:00
Yoshi Huang
a470396744
Bug 1244340 - Part 1: Use origin attributes as cstor arg for LoadContext r=sicking
2016-08-26 18:59:00 +08:00
Henry Chang
74f5ad2c8b
Bug 1179301 - Restrict the SafeBrowsingHash size and make toUint32/fromUint32 more robust. r=gcp
...
MozReview-Commit-ID: EPQLeuab42W
2016-08-18 14:42:13 +08:00