corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
477,034 Commits 1 Branch 0 Tags
c76ce9f99a49d0cb15a2ad724b5db7f2b71142f6
Commit Graph

65 Commits

Author SHA1 Message Date
Cervantes Yu
6bcb4f30a4 Bug 1024669 - Part 1: Annotate crash reports with thread names. r=gsvelto 
NS_SetCurrentThreadName() is added as an alternative to PR_SetCurrentThreadName()
inside libxul. The thread names are collected in the form of crash annotation to
be processed on socorro.

MozReview-Commit-ID: 4RpAWzTuvPs
 2017-02-07 18:57:23 +08:00
Florian Queze
451928e614 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Sebastian Hengst
f75839c723 Backed out changeset 55f3df15eaa6 (bug 1356569) 2017-04-14 23:39:17 +02:00
Florian Queze
61aabdf237 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
189424cb45 Backed out changeset 7fdcabdbb675 (bug 1024669) for failing mda, GTest and talos jobs. r=backout on a CLOSED TREE 2017-04-10 19:05:44 +02:00
Cervantes Yu
c2014c712d Bug 1024669 - Part 1: Annotate crash reports with thread names. r=gsvelto 
MozReview-Commit-ID: 4RpAWzTuvPs
 2017-02-07 18:57:23 +08:00
Carsten "Tomcat" Book
e6d6caf1f8 Backed out changeset 7a52d887bcea (bug 1024669) for bustage 2017-04-10 11:43:49 +02:00
Cervantes Yu
eb13868db5 Bug 1024669 - Part 1: Annotate crash reports with thread names. r=gsvelto 
MozReview-Commit-ID: 4RpAWzTuvPs
 2017-02-07 18:57:23 +08:00
Joel Maher
d2be399571 Bug 1351067 - add BUG_COMPONENT to toolkit/* files. r=myk,enndeakin,mossop 
MozReview-Commit-ID: 8mv5Oed68JL
 2017-04-09 05:43:43 -04:00
Mark Banner
ec9074e132 Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r=jaws 
MozReview-Commit-ID: LH0CQOPfoe6
 2017-03-20 12:36:37 +01:00
David Major
e77ed51418 No bug - Fix comment to match the code. DONTBUILD 
MozReview-Commit-ID: LXrzCRvEWIa
 2017-01-25 10:06:11 +13:00
Mark Banner
55868dde7c Bug 503613 - Remove old 'tail =' lines from xpcshell.ini files; r=gps 
MozReview-Commit-ID: 62Hp5ISxowJ
 2017-01-18 10:30:39 +00:00
Markus Stange
991ab574ae Bug 1323100 - Register most of the remaining threadfunc threads with the profiler. r=froydnj 
As far as I can tell, this covers all the remaining threads which we start
using PR_CreateThread, except the ones that are created inside NSPR or NSS,
and except for the Shutdown Watchdog thread in nsTerminator.cpp and the
CacheIO thread. The Shutdown Watchdog thread stays alive past leak detection
during shutdown (by design), so we'd report leaks if we profiled it. The
CacheIO thread seems to stay alive past shutdown leak detection sometimes as
well.

This adds a AutoProfilerRegister stack class for easy registering and
unregistering. There are a few places where we still call
profiler_register_thread() and profiler_unregister_thread() manually, either
because registration happens conditionally, or because there is a variable that
gets put on the stack before the AutoProfilerRegister (e.g. a dynamically
generated thread name). AutoProfilerRegister needs to be the first object on
the stack because it uses its own `this` pointer as the stack top address.

MozReview-Commit-ID: 3vwhS55Yzt
 2017-01-05 16:34:26 +01:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN 
MozReview-Commit-ID: FuVu8skcqOe
 2016-12-30 21:47:25 -05:00
Sylvestre Ledru
0f65f2ab6c Bug 1318004 - Converts for(...; ...; ...) loops to use the new range-based loops in C++11. r=Ehsan 
MozReview-Commit-ID: lk5eJXUno9
 2016-11-16 17:12:13 +01:00
Sylvestre Ledru
79a067af86 Bug 1318004 - Use C++11's override and remove virtual where applicable. r=Ehsan 
MozReview-Commit-ID: H9tAe0YN1tx
 2016-11-16 17:08:26 +01:00
Sylvestre Ledru
1672d883a9 Bug 1318004 - Replace string literals containing escaped characters with raw string literals. r=Ehsan 
MozReview-Commit-ID: KOk13e23Py
 2016-11-16 17:07:03 +01:00
Sylvestre Ledru
a15f1c5d08 Bug 1318004 - Replace default bodies of special member functions with = default; r=Ehsan 
MozReview-Commit-ID: 33AOhtFrXS8
 2016-11-16 18:26:14 +01:00
Wes Kocher
b620596e75 Backed out 4 changesets (bug 1318004) for xpcshell failures a=backout CLOSED TREE 
Backed out changeset a3fe53641526 (bug 1318004)
Backed out changeset a5d1676b6f88 (bug 1318004)
Backed out changeset b56b37f0f4d7 (bug 1318004)
Backed out changeset fb5254baf1cb (bug 1318004)
 2016-11-21 16:15:38 -08:00
Sylvestre Ledru
7ccbd595c5 Bug 1318004 - Converts for(...; ...; ...) loops to use the new range-based loops in C++11. r=Ehsan 
MozReview-Commit-ID: lk5eJXUno9
 2016-11-16 17:12:13 +01:00
Sylvestre Ledru
b48ac2ed6f Bug 1318004 - Use C++11's override and remove virtual where applicable. r=Ehsan 
MozReview-Commit-ID: H9tAe0YN1tx
 2016-11-16 17:08:26 +01:00
Sylvestre Ledru
9851572dbc Bug 1318004 - Replace string literals containing escaped characters with raw string literals. r=Ehsan 
MozReview-Commit-ID: KOk13e23Py
 2016-11-16 17:07:03 +01:00
Sylvestre Ledru
eaf1a1bb8c Bug 1318004 - Replace default bodies of special member functions with = default; r=Ehsan 
MozReview-Commit-ID: 33AOhtFrXS8
 2016-11-16 18:26:14 +01:00
Wes Kocher
13642ca8af Backed out 4 changesets (bug 1318004) for xpcshell failures a=backout 
Backed out changeset 6995bd33872b (bug 1318004)
Backed out changeset 9be5c856bc78 (bug 1318004)
Backed out changeset 365b0b7f289a (bug 1318004)
Backed out changeset 2f2ebf176eac (bug 1318004)
 2016-11-21 12:23:17 -08:00
Sylvestre Ledru
ea83e5e8bd Bug 1318004 - Converts for(...; ...; ...) loops to use the new range-based loops in C++11. r=Ehsan 
MozReview-Commit-ID: lk5eJXUno9
 2016-11-16 17:12:13 +01:00
Sylvestre Ledru
9fbcdd2d4f Bug 1318004 - Use C++11's override and remove virtual where applicable. r=Ehsan 
MozReview-Commit-ID: H9tAe0YN1tx
 2016-11-16 17:08:26 +01:00
Sylvestre Ledru
057d135c4c Bug 1318004 - Replace string literals containing escaped characters with raw string literals. r=Ehsan 
MozReview-Commit-ID: KOk13e23Py
 2016-11-16 17:07:03 +01:00
Sylvestre Ledru
c30faf12df Bug 1318004 - Replace default bodies of special member functions with = default; r=Ehsan 
MozReview-Commit-ID: 33AOhtFrXS8
 2016-11-16 18:26:14 +01:00
Sebastian Hengst
6cf65ed900 Bug 1310297 - Remove test annotations using b2g, mulet or gonk: toolkit. r=RyanVM 
MozReview-Commit-ID: I5LuDjnM7By
 2016-11-05 11:29:22 +01:00
Jared Wein
5edec1c0d9 Bug 1315013 - part 1, remove unnecessary double-slash comments that don't add value and look out of place with the spaced-comment eslint rule. r=mossop 
MozReview-Commit-ID: HIUTSdkXxbY
 2016-11-03 14:42:06 -04:00
Jared Wein
0c024fa9ca Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8 
MozReview-Commit-ID: 7Gx90a5y8t6
 2016-10-24 13:14:19 -04:00
Mark Banner
233309fbe2 Bug 1251003 - Change .eslintrc files to .eslintrc.js to avoid obsolete config file format. r=mossop 
MozReview-Commit-ID: JrbFxQ5rj6I
 2016-10-18 08:38:10 +01:00
Nicholas Nethercote
b5810a1eb4 Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm. 
This change avoids lots of false positives for Coverity's CHECKED_RETURN
warning, caused by NS_WARN_IF's current use in both statement-style and
expression-style.

In the case where the code within the NS_WARN_IF has side-effects, I made the
following change.

> NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
> -->
> Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));

In the case where the code within the NS_WARN_IF lacks side-effects, I made the
following change.

> NS_WARN_IF(!condWithoutSideEffects);
> -->
> NS_WARNING_ASSERTION(condWithoutSideEffects, "msg");

This has two improvements.
- The condition is not evaluated in non-debug builds.
- The sense of the condition is inverted to the familiar "this condition should
  be true" sense used in assertions.

A common variation on the side-effect-free case is the following.

> nsresult rv = Fn();
> NS_WARN_IF_(NS_FAILED(rv));
> -->
> DebugOnly<nsresult rv> = Fn();
> NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");
 2016-09-02 17:12:24 +10:00
Kan-Ru Chen
a9b19d0584 Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj 
The patch is generated from following command:

  rgrep -l unused.h|xargs sed -i -e s,mozilla/unused.h,mozilla/Unused.h,

MozReview-Commit-ID: AtLcWApZfES
 2016-08-24 14:47:04 +08:00
Tom Tromey
1b5a2bdb96 Bug 1286877 - do not set c-basic-offset for python-mode; r=gps 
This removes the unnecessary setting of c-basic-offset from all
python-mode files.

This was automatically generated using

    perl -pi -e 's/; *c-basic-offset: *[0-9]+//'

... on the affected files.

The bulk of these files are moz.build files but there a few others as
well.

MozReview-Commit-ID: 2pPf3DEiZqx
 2016-07-14 10:16:42 -06:00
Chris Peterson
c35faf4632 Bug 1277775 - Replace MOZ_CONSTEXPR{_VAR,_TMPL} with constexpr. r=froydnj 2016-07-08 14:39:53 -07:00
Chris Peterson
1e35dbdf75 Bug 1272513 - Part 2: Remove redundant -Wshadow CXXFLAGS from moz.build files. r=glandium 2016-05-14 00:54:55 -07:00
Alessio Placitelli
38c5e57c95 Bug 1242084 - nsTerminator::UpdateTelemetry() leaks 8 byte nsStringBuffer when app.update.channel gets set to Beta. r=gfritzsche 2016-03-14 06:12:00 +01:00
David Rajchenbach-Teller
1cbb83de61 Bug 1252382 - Get rid of PR_Sleep in the terminator;r=froydnj 
The terminator currently makes use of PR_Sleep. As it turns out, late
in shutdown, this can cause infinite recursions and finally exit(-11) . This
patch replaces PR_Sleep with usleep(3) and Sleep().

MozReview-Commit-ID: 3SybinpQUVl
 2016-03-01 09:01:22 +01:00
Dave Townsend
8dc7f59eb3 Bug 1229142: Link browser and toolkit test directory to the shared eslintrc files. r=Standard8 2015-11-30 13:05:00 -08:00
Timur Valeev
9a6e557701 Bug 1232285 - The Terminator's notion of ticks is incorrect. r=Yoric 2015-12-22 10:32:00 +03:00
Dave Townsend
dd9da1fea1 Bug 1229519: Fix miscellaneous parts of toolkit to pass eslint checks. r=MattN 2015-12-03 10:02:45 -08:00
Birunthan Mohanathas
ac37dec517 Bug 1219392 - Capitalize mozilla::unused to avoid conflicts. r=froydnj 2015-11-02 07:53:26 +02:00
Carsten "Tomcat" Book
036e6d2fa3 Backed out 2 changesets (bug 1202902) to recking bug 1202902 to be able to reopen inbound on a CLOSED TREE 
Backed out changeset 647025383676 (bug 1202902)
Backed out changeset d70c7fe532c6 (bug 1202902)
 2015-10-07 14:03:21 +02:00
Carsten "Tomcat" Book
12369728f5 Backed out 1 changesets (bug 1202902) for causing merge conflicts to mozilla-central 
Backed out changeset cfc1820361f5 (bug 1202902)
 2015-10-07 12:13:45 +02:00
Shu-yu Guo
474f49adb7 Bug 1202902 - Scripted fix the world. 2015-10-06 14:00:31 -07:00
Chris Peterson
752223fd52 Bug 1207030 - Enable -Wshadow flag in more directories that have no -Wshadow warnings. r=glandium 2015-09-22 21:39:03 -07:00