corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
477,034 Commits 1 Branch 0 Tags
c76ce9f99a49d0cb15a2ad724b5db7f2b71142f6
Commit Graph

274 Commits

Author SHA1 Message Date
Florian Queze
6cc0b6e992 Bug 1355056 - replace (function(args) { /* do stuff using this */ }).bind(this) with arrow functions, r=jaws. 2017-04-27 00:25:45 +02:00
Florian Queze
5920b597b6 Bug 1359130 - stop using FileUtils.jsm in the search service, r=adw. 2017-04-25 09:21:50 +02:00
Florian Queze
f156577d13 Bug 1359130 - stop using NetUtil.jsm in the search service, r=adw. 2017-04-25 09:21:50 +02:00
Florian Queze
751188972d Bug 1356593 - reimplement the search service's ParamSubstitution function to avoid doing unnecessary work, r=adw. 2017-04-22 02:08:54 +02:00
Zibi Braniecki
8c433fc56a Bug 1346616 - Migrate callsites that are retrieving requested locale from pref, to use LocaleService::GetRequestedLocales. r=jfkthame,Pike 
I'm adding a helper function mozILocaleService::GetRequestedLocale to simplify
most of the callsites that are looking for the first of the requested locales.

In most cases, I'm just matching the behavior of the code with reusing
LocaleService API instead of direct manipulation on the prefs.
That includes how I handle error case scenarios.

In case of sdk/l10n/locale.js I am reusing LocaleService heuristics over
the custom one from the file since the ones in LocaleService are just
more correct and unified accross the whole platform.

In case of FallbackEncoding I have to turn it into a nsIObserver to listen
to intl:requested-locales-changed.

MozReview-Commit-ID: 7rOr2CovLK
 2017-03-11 18:43:11 -08:00
Sebastian Hengst
017c2ee2bf Backed out changeset 60d72c2dd49d (bug 1346616) for eslint failure in DirectoryLinksProvider.jsm. r=backout on a CLOSED TREE 2017-04-18 00:48:16 +02:00
Zibi Braniecki
64bae2dccf Bug 1346616 - Migrate callsites that are retrieving requested locale from pref, to use LocaleService::GetRequestedLocales. r=jfkthame,Pike 
I'm adding a helper function mozILocaleService::GetRequestedLocale to simplify
most of the callsites that are looking for the first of the requested locales.

In most cases, I'm just matching the behavior of the code with reusing
LocaleService API instead of direct manipulation on the prefs.
That includes how I handle error case scenarios.

In case of sdk/l10n/locale.js I am reusing LocaleService heuristics over
the custom one from the file since the ones in LocaleService are just
more correct and unified accross the whole platform.

In case of FallbackEncoding I have to turn it into a nsIObserver to listen
to intl:requested-locales-changed.

MozReview-Commit-ID: 7rOr2CovLK
 2017-03-11 18:43:11 -08:00
Florian Queze
ddf0cda8da Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
4cd95d4a02 Backed out changeset 18d45aa984d6 (bug 1355161) 2017-04-14 23:39:23 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Florian Queze
35cd8ba883 Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Michael Kaply
d49108ac35 Bug 1336560 - Allow distributions to hide search engines. r=florian 
MozReview-Commit-ID: 12lSpSPZTqm
 2017-03-09 11:22:54 -06:00
Sebastian Hengst
1635a93413 Backed out changeset 01b927dcb4af (bug 1336560) for failing eslint in test_sync_disthidden.js (semicolon too many). r=backout 2017-03-16 19:59:04 +01:00
Michael Kaply
c608944901 Bug 1336560 - Allow distributions to hide search engines. r=florian 
MozReview-Commit-ID: 12lSpSPZTqm
 2017-03-09 11:22:54 -06:00
Florian Quèze
f6f1b03368 Bug 1344987 - remove SEARCH_SERVICE_HAS_UPDATES and SEARCH_SERVICE_HAS_ICON_UPDATES Telemetry probes, r=past a=tomcat 2017-03-07 12:52:48 +01:00
Florian Quèze
0b17fc5d60 Bug 1344711 - hand cleanup of cases that were ignored by the script to remove try blocks around get*Pref calls, r=jaws. 2017-03-07 15:29:48 +01:00
Florian Quèze
c7eae86054 Bug 1344711 - script-generated patch to remove try blocks around get*Pref calls, r=jaws. 2017-03-07 15:29:48 +01:00
Zibi Braniecki
b6f0455ba8 Bug 1335983 - Migrate nsCollation::CreateCollection to use LocaleService::GetAppLocale. r=jfkthame 
MozReview-Commit-ID: 5GEnL7Kihpj
 2017-02-07 12:52:03 -08:00
Wes Kocher
49a736e0b6 Backed out 2 changesets (bug 1335983) for build bustage a=backout 
Backed out changeset 5a9559ded976 (bug 1335983)
Backed out changeset de2b0d90e2da (bug 1335983)

MozReview-Commit-ID: 377KQDU1QqJ
 2017-02-07 12:34:30 -08:00
Zibi Braniecki
347f170849 Bug 1335983 - Migrate nsCollation::CreateCollection to use LocaleService::GetAppLocale. r=jfkthame 
MozReview-Commit-ID: bJVrVj2dAS
 2017-02-06 14:57:09 -08:00
Mark Banner
b365ab9867 Bug 1218324 - Correctly report when a search engine could not be installed due to an invalid format. r=florian 
MozReview-Commit-ID: Cqw0uKDWguy
 2016-12-14 14:55:00 +00:00
Tim Huang
e3dbf8ed85 Bug 1312954 - Part 9: Update speculativeConnect to speculativeConnect2 for the search service. r=Gijs 2017-02-02 22:17:00 -05:00
Michael Kaply
a66f7bcdaf Bug 1335810 - Move jarNames to scope where it used. r=florian 2017-02-01 15:44:59 -06:00
Jared Wein
0ec522d5b6 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs 
MozReview-Commit-ID: 6tv0Z06CO4a
 2017-01-17 09:48:17 -06:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN 
MozReview-Commit-ID: FuVu8skcqOe
 2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN 
MozReview-Commit-ID: 7E7LPorrEje
 2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout 
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
 2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN 
MozReview-Commit-ID: 8WoGr8i6oCR
 2016-12-29 15:20:47 -05:00
Dave Townsend
e7b1b3284f Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit). r=jaws 
MozReview-Commit-ID: FGFwg6TYkvm
 2016-11-11 15:22:34 -08:00
Dave Townsend
12596ced47 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws 
MozReview-Commit-ID: HBpjT2uHJaZ
 2016-11-10 14:48:04 -08:00
Mark Banner
1a8c179cd2 Bug 386473 - Change a few QueryInterface functions in nsSearchService.js to use XPCOMUtils.generateQI. Based on a patch originally by Ryan Flint. r=florian 
MozReview-Commit-ID: 2xB9VjjnKW1
 2016-11-02 10:39:53 +00:00
Mark Banner
b5435c3148 Bug 1314373 - Fix general eslint issues in nsSearchService.js. r=mak 
MozReview-Commit-ID: 4f9j6m6EjKA
 2016-11-01 18:42:14 +00:00
Mark Banner
c68266c794 Bug 1314373 - Fix parser issues raised by eslint for nsSearchService.js. r=mak 
MozReview-Commit-ID: FRTCMgRtjTG
 2016-11-01 18:35:46 +00:00
Mark Banner
08233b5a39 Bug 1314373 - Change nsSearchService.js so that it doesn't need to be preprocessed. r=mak 
MozReview-Commit-ID: 8FhZzk4UtPi
 2016-11-01 18:07:34 +00:00
Michael Kaply
b005340d9c Bug 1276739 - Switch search to use a JSON based format. r=florian 
MozReview-Commit-ID: 9xy3UPoRCmW
 2016-05-31 13:37:26 -05:00
Florian Quèze
c0ce1a305d Bug 1289240 - search plugins from an in-use langpack should be treated as default plugins, r=adw. 2016-07-27 19:28:33 +02:00
Ian Moody
d25c9f52b0 Bug 1274545 - Rework the search engine _onLoad code to group update-only code together, and preserve user's metaData on update. r=florian 
Previously on update some engines were losing their user-set keyword, and also
their ordering in the engine list.

MozReview-Commit-ID: 3n464xRQ8bO
 2016-07-07 14:42:07 +01:00
Andrea Marchesini
61e8b39d77 Bug 1281793 - Remove some non-used telemetry IDs - part 5 - Search and other stuff, r=gfritzsche 2016-06-28 19:30:54 +02:00
Carsten "Tomcat" Book
7788eb7a88 Backed out changeset 81120708f321 (bug 1281793) 2016-06-28 17:04:48 +02:00
Andrea Marchesini
0e66e33ceb Bug 1281793 - Remove some non-used telemetry IDs - part 5 - Search and other stuff, r=gfritzsche 2016-06-28 16:44:42 +02:00
Michael Kaply
c6ac48fe52 Bug 1275366 - Allow chrome/resource icon URLs for built-in search engines. r=florian 
DONTBUILD
 2016-06-09 11:30:42 -05:00
Michael Kaply
2d31989a9b Back out changeset f4c18cbc1201 to correct wrong bug (1273719) in commit message. 2016-06-09 11:27:49 -05:00
Michael Kaply
a12c324bda Bug 1273719 - Allow chrome/resource icon URLs for built-in search engines. r=florian 2016-06-09 11:02:05 -05:00
Florian Quèze
a3e244ebc6 Bug 1203168 - ask the user for confirmation when searching with a default search engine of unknown origin, data-review=bsmedberg, r=adw. 2016-05-27 13:41:29 +02:00
Carsten "Tomcat" Book
8905295433 Backed out changeset 08053d1e2cc1 (bug 1203168) for ESlint failure in browser_aboutSearchReset.js 2016-05-27 14:35:31 +02:00
Florian Quèze
01db1a04c5 Bug 1203168 - ask the user for confirmation when searching with a default search engine of unknown origin, data-review=bsmedberg, r=adw. 2016-05-27 13:41:29 +02:00
Florian Quèze
6e9a2738e2 Bug 1273719 - JavaScript strict warnings in nsSearchService.js (reference to undefined property json._readOnly/param.purpose), r=adw. 2016-05-24 13:15:43 +02:00
Florian Quèze
aab370ae50 Bug 1268424 - Collect Telemetry data about the search plugin count, data-review=bsmedberg, r=adw. 2016-05-24 13:14:19 +02:00