corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
477,034 Commits 1 Branch 0 Tags
c76ce9f99a49d0cb15a2ad724b5db7f2b71142f6
Commit Graph

411 Commits

Author SHA1 Message Date
Florian Queze
6cc0b6e992 Bug 1355056 - replace (function(args) { /* do stuff using this */ }).bind(this) with arrow functions, r=jaws. 2017-04-27 00:25:45 +02:00
Florian Queze
5920b597b6 Bug 1359130 - stop using FileUtils.jsm in the search service, r=adw. 2017-04-25 09:21:50 +02:00
Florian Queze
f156577d13 Bug 1359130 - stop using NetUtil.jsm in the search service, r=adw. 2017-04-25 09:21:50 +02:00
Florian Queze
751188972d Bug 1356593 - reimplement the search service's ParamSubstitution function to avoid doing unnecessary work, r=adw. 2017-04-22 02:08:54 +02:00
Zibi Braniecki
8c433fc56a Bug 1346616 - Migrate callsites that are retrieving requested locale from pref, to use LocaleService::GetRequestedLocales. r=jfkthame,Pike 
I'm adding a helper function mozILocaleService::GetRequestedLocale to simplify
most of the callsites that are looking for the first of the requested locales.

In most cases, I'm just matching the behavior of the code with reusing
LocaleService API instead of direct manipulation on the prefs.
That includes how I handle error case scenarios.

In case of sdk/l10n/locale.js I am reusing LocaleService heuristics over
the custom one from the file since the ones in LocaleService are just
more correct and unified accross the whole platform.

In case of FallbackEncoding I have to turn it into a nsIObserver to listen
to intl:requested-locales-changed.

MozReview-Commit-ID: 7rOr2CovLK
 2017-03-11 18:43:11 -08:00
Sebastian Hengst
017c2ee2bf Backed out changeset 60d72c2dd49d (bug 1346616) for eslint failure in DirectoryLinksProvider.jsm. r=backout on a CLOSED TREE 2017-04-18 00:48:16 +02:00
Zibi Braniecki
64bae2dccf Bug 1346616 - Migrate callsites that are retrieving requested locale from pref, to use LocaleService::GetRequestedLocales. r=jfkthame,Pike 
I'm adding a helper function mozILocaleService::GetRequestedLocale to simplify
most of the callsites that are looking for the first of the requested locales.

In most cases, I'm just matching the behavior of the code with reusing
LocaleService API instead of direct manipulation on the prefs.
That includes how I handle error case scenarios.

In case of sdk/l10n/locale.js I am reusing LocaleService heuristics over
the custom one from the file since the ones in LocaleService are just
more correct and unified accross the whole platform.

In case of FallbackEncoding I have to turn it into a nsIObserver to listen
to intl:requested-locales-changed.

MozReview-Commit-ID: 7rOr2CovLK
 2017-03-11 18:43:11 -08:00
Florian Queze
ddf0cda8da Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Florian Queze
451928e614 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
4cd95d4a02 Backed out changeset 18d45aa984d6 (bug 1355161) 2017-04-14 23:39:23 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Sebastian Hengst
f75839c723 Backed out changeset 55f3df15eaa6 (bug 1356569) 2017-04-14 23:39:17 +02:00
Florian Queze
61aabdf237 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Florian Queze
35cd8ba883 Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Jared Wein
5a181760cc Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8 
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx
 2017-03-21 14:29:43 -04:00
Mark Banner
ec9074e132 Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r=jaws 
MozReview-Commit-ID: LH0CQOPfoe6
 2017-03-20 12:36:37 +01:00
Michael Kaply
d49108ac35 Bug 1336560 - Allow distributions to hide search engines. r=florian 
MozReview-Commit-ID: 12lSpSPZTqm
 2017-03-09 11:22:54 -06:00
Sebastian Hengst
1635a93413 Backed out changeset 01b927dcb4af (bug 1336560) for failing eslint in test_sync_disthidden.js (semicolon too many). r=backout 2017-03-16 19:59:04 +01:00
Michael Kaply
c608944901 Bug 1336560 - Allow distributions to hide search engines. r=florian 
MozReview-Commit-ID: 12lSpSPZTqm
 2017-03-09 11:22:54 -06:00
Matthew Noorenberghe
aca0812357 Bug 1344589 - Wait for the httpServer to shutdown in head_search.js to avoid reported leaks. r=adw 
The test slow_timeout in test_searchSuggest.js was keeping a request open for 10s so the server wouldn't stop immediately.

MozReview-Commit-ID: EGFPRKMNa51
 2017-03-09 00:18:35 -05:00
Florian Quèze
f6f1b03368 Bug 1344987 - remove SEARCH_SERVICE_HAS_UPDATES and SEARCH_SERVICE_HAS_ICON_UPDATES Telemetry probes, r=past a=tomcat 2017-03-07 12:52:48 +01:00
Florian Quèze
0b17fc5d60 Bug 1344711 - hand cleanup of cases that were ignored by the script to remove try blocks around get*Pref calls, r=jaws. 2017-03-07 15:29:48 +01:00
Florian Quèze
c7eae86054 Bug 1344711 - script-generated patch to remove try blocks around get*Pref calls, r=jaws. 2017-03-07 15:29:48 +01:00
Zibi Braniecki
b6f0455ba8 Bug 1335983 - Migrate nsCollation::CreateCollection to use LocaleService::GetAppLocale. r=jfkthame 
MozReview-Commit-ID: 5GEnL7Kihpj
 2017-02-07 12:52:03 -08:00
Wes Kocher
49a736e0b6 Backed out 2 changesets (bug 1335983) for build bustage a=backout 
Backed out changeset 5a9559ded976 (bug 1335983)
Backed out changeset de2b0d90e2da (bug 1335983)

MozReview-Commit-ID: 377KQDU1QqJ
 2017-02-07 12:34:30 -08:00
Zibi Braniecki
347f170849 Bug 1335983 - Migrate nsCollation::CreateCollection to use LocaleService::GetAppLocale. r=jfkthame 
MozReview-Commit-ID: bJVrVj2dAS
 2017-02-06 14:57:09 -08:00
Mark Banner
b365ab9867 Bug 1218324 - Correctly report when a search engine could not be installed due to an invalid format. r=florian 
MozReview-Commit-ID: Cqw0uKDWguy
 2016-12-14 14:55:00 +00:00
Tim Huang
e3dbf8ed85 Bug 1312954 - Part 9: Update speculativeConnect to speculativeConnect2 for the search service. r=Gijs 2017-02-02 22:17:00 -05:00
Michael Kaply
a66f7bcdaf Bug 1335810 - Move jarNames to scope where it used. r=florian 2017-02-01 15:44:59 -06:00
Mark Banner
55868dde7c Bug 503613 - Remove old 'tail =' lines from xpcshell.ini files; r=gps 
MozReview-Commit-ID: 62Hp5ISxowJ
 2017-01-18 10:30:39 +00:00
Jared Wein
0ec522d5b6 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs 
MozReview-Commit-ID: 6tv0Z06CO4a
 2017-01-17 09:48:17 -06:00
Hiroyuki Ikezoe
ee3d658e56 Bug 1130284 - Remove updateAppInfo from search xpcshell tests. r=mak 
MozReview-Commit-ID: 46A0ZDLMtnZ
 2017-01-12 06:32:16 +09:00
Florian Quèze
b36a8b8f42 Bug 1330147 - automatic removal of the third boolean parameter in removeObserver calls, r=jaws. 2017-01-11 22:27:42 +01:00
Florian Quèze
13cfe1d3f3 Bug 1329182 - remove trailing newURI null parameters in toolkit/, r=jaws. 2017-01-09 20:27:25 +01:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN 
MozReview-Commit-ID: FuVu8skcqOe
 2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN 
MozReview-Commit-ID: 7E7LPorrEje
 2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout 
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
 2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN 
MozReview-Commit-ID: 8WoGr8i6oCR
 2016-12-29 15:20:47 -05:00
Mark Banner
fb8a196639 Bug 1325623 - Fix most no-undef eslint issues in toolkit/components. r=mossop 
MozReview-Commit-ID: DYJa1uNVagw
 2016-12-23 16:00:46 +00:00
Alessio Placitelli
ef64b5d943 Bug 1315650 - Add a longer timeout for searchbar suggestions in tests. r=mak 
MozReview-Commit-ID: 4dkkibfGFMv
 2016-12-20 06:37:00 +01:00
Dave Townsend
e7b1b3284f Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit). r=jaws 
MozReview-Commit-ID: FGFwg6TYkvm
 2016-11-11 15:22:34 -08:00
Dave Townsend
12596ced47 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws 
MozReview-Commit-ID: HBpjT2uHJaZ
 2016-11-10 14:48:04 -08:00
Mark Banner
8ddd9bb511 Bug 1315951 - Fix no-unused-vars issues in toolkit/components (except places). r=mossop 
MozReview-Commit-ID: 8svkCKZHxsq
 2016-11-08 12:49:32 +00:00
Jared Wein
b6817d7876 Bug 1315781 - Enable no-shadow rule for eslint for xpcshell mochitests. r=mossop 
MozReview-Commit-ID: 1mhCWplknyN
 2016-11-07 22:34:25 -05:00
Iris Hsiao
d24e67dbe4 Backed out changeset f6f28be8d8f2 (bug 1315781) for XPCShell test timed out 2016-11-10 14:53:46 +08:00
Jared Wein
0c41af265f Bug 1315781 - Enable no-shadow rule for eslint for xpcshell mochitests. r=mossop 
MozReview-Commit-ID: DnpVQRrG9Ec
 2016-11-07 22:34:25 -05:00
Sebastian Hengst
6cf65ed900 Bug 1310297 - Remove test annotations using b2g, mulet or gonk: toolkit. r=RyanVM 
MozReview-Commit-ID: I5LuDjnM7By
 2016-11-05 11:29:22 +01:00
Mark Banner
1a8c179cd2 Bug 386473 - Change a few QueryInterface functions in nsSearchService.js to use XPCOMUtils.generateQI. Based on a patch originally by Ryan Flint. r=florian 
MozReview-Commit-ID: 2xB9VjjnKW1
 2016-11-02 10:39:53 +00:00