Commit Graph

64 Commits

Author SHA1 Message Date
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Evan Tseng
9106be5219 Bug 1177360 - Disable reader mode button for amazon.com, r=Gijs
MozReview-Commit-ID: Cg9Gm4HCHbA
2017-03-01 18:22:45 +08:00
Jared Wein
0ec522d5b6 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a
2017-01-17 09:48:17 -06:00
Jim Chen
a55ec92358 Bug 1328683 - Convert ReadingListHelper events to bundle events; r=sebastian 2017-01-10 23:01:27 -05:00
Florian Quèze
13cfe1d3f3 Bug 1329182 - remove trailing newURI null parameters in toolkit/, r=jaws. 2017-01-09 20:27:25 +01:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
fiveNinePlusR
dc7b67c54e Bug 1265304 - Add an estimated time range to reader mode, r=gijs,ui-r=emanuela
Uses an upper and lower bound found from this study: http://iovs.arvojournals.org/article.aspx?articleid=2166061
2016-12-11 21:35:00 +00:00
Dave Townsend
e7b1b3284f Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit). r=jaws
MozReview-Commit-ID: FGFwg6TYkvm
2016-11-11 15:22:34 -08:00
Wes Kocher
1aa5b280a6 Merge inbound to central, a=merge 2016-11-08 13:58:20 -08:00
Sébastien Blin
7190bbc6af Bug 1189491 - Take anchors into account in the reader view, r=gijs
MozReview-Commit-ID: 1udixhxnVao
2016-11-03 05:50:00 +00:00
Evan Tseng
23e8bd1fd1 Bug 1173823 - Always use document.baseURI as the uri parameter of _readerParse method, r=Gijs
MozReview-Commit-ID: RnICyZALNb
2016-11-07 17:31:23 +08:00
Sebastian Hengst
3b219cba1e Backed out changeset 1cb8dac3eb40 (bug 1189491) for failing browser_readerMode.js. r=backout 2016-11-05 13:54:35 +01:00
Sébastien Blin
f3ee406553 Bug 1189491 - Take anchors into account in the reader view, r=gijs
MozReview-Commit-ID: 1udixhxnVao
2016-11-03 05:50:00 +00:00
Wes Kocher
d939df7bcf Backed out changeset 4da7d22ebcd2 (bug 1189491) for multiple eslint failures a=backout CLOSED TREE 2016-11-04 11:55:56 -07:00
Sébastien Blin
f1aba24f22 Bug 1189491 - Take anchors into account in the reader view, r=gijs
MozReview-Commit-ID: 1udixhxnVao
2016-11-03 05:50:00 +00:00
Gijs Kruitbosch
a7e5b8832f No bug, fix eslint errors introduced when enabling more rules in .eslintrc.js, rs=bustage
MozReview-Commit-ID: GADYtKhyd50
2016-11-02 11:33:21 +01:00
Jared Wein
4518d81cb5 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt
2016-08-04 03:28:58 -04:00
Gijs Kruitbosch
252bc6e582 Bug 1281536 - remove reader mode telemetry that's out of date, extend two existing probes, r=margaret,data-r=bsmedberg
MozReview-Commit-ID: 2FSr4v4fPWU
2016-06-24 15:39:23 +01:00
Timothy Guan-tin Chien
0bab46ef0a Bug 1266372 - De-dup code to ReaderMode.leaveReaderMode, r=gijs
Additionally, implements ReaderMode.enterReaderMode.

MozReview-Commit-ID: 8MPvFhX4ws7
2016-04-26 12:52:50 +08:00
Andrzej Hunt
cf169ca80e Bug 1263628 - Ignore fragments when comparing URLs during reader view caching r=gijs
This seems to be a common issue with medium.com articles, but affects any page which was
opened using a fragment in the URL (e.g. foo.com/bar#baz is the same page as foo.com/bar,
however our reader view caching code didn't recognise the former as being equivalent to
the latter).

MozReview-Commit-ID: BtRmHq3sD9z
2016-04-15 11:17:36 -07:00
Andrzej Hunt
eb6f798dbd Bug 1263628 - meta-refresh can use a relative URL, ensure base URI is included r=gijs
E.g. articles on facebook.com provide a meta-refresh containing "0; URL=/foo/bar?....",
and we previously attempted to use just this URL component, instead of constructing it
using the current page URL.

MozReview-Commit-ID: 4vSoz5lc1e
2016-04-15 13:53:19 -07:00
Andrzej Hunt
55e235263f Bug 1234331 - Push article into readercache when bookmarking readerview page r=margaret
MozReview-Commit-ID: D7Yy45xkFd8
2016-03-29 20:08:09 -07:00
Dave Townsend
769fc8f245 Bug 1257246: Update toolkit for eslint 2. r=Gijs
Most of this is fixing functions that in some cases return a value but then
can also run to completion without returning anything. ESLint 2 catches this
where previous versions didn't. Unless there was an obvious other choice I just
made these functions return undefined at the end which is effectively what
already happens.

MozReview-Commit-ID: KHYdAkRvhVr
2016-04-05 11:33:48 -07:00
Gijs Kruitbosch
30046cb032 Bug 1210366 - block youtube and pinterest from reader mode, r=MattN 2016-01-12 18:57:38 +00:00
Gijs Kruitbosch
f6fe0f05ef Bug 1222792 - fix comparing escaped URIs in reader mode when detecting redirects, r=margaret 2015-12-15 15:57:03 +00:00
Dave Townsend
dd9da1fea1 Bug 1229519: Fix miscellaneous parts of toolkit to pass eslint checks. r=MattN 2015-12-03 10:02:45 -08:00
Gijs Kruitbosch
0efa594cc7 Bug 1195976, r=bnicholson 2015-08-27 13:20:47 +01:00
Gijs Kruitbosch
412038a00a Bug 1182778, r=margaret,f=bz 2015-07-17 13:30:42 +01:00
Frederik Braun
fcf3a406cc Bug 1184056 - Non-case sensitive redirects in reader mode. r=margaret 2015-07-15 18:25:10 +02:00
Gijs Kruitbosch
4e6b339476 Bug 1172270 - don't cause extra flushes for reader mode, r=margaret,smaug 2015-06-08 16:56:34 +01:00
Gijs Kruitbosch
df94671464 Bug 1172009 - don't show reader mode button for file:///, r=margaret 2015-06-09 13:48:11 +01:00
Margaret Leibovic
69deac12ea Bug 1166364 - Fix typo in telemetry probe. r=me 2015-05-19 10:33:00 -07:00
Gijs Kruitbosch
c5c10b1105 Bug 1164426 - build reader mode blocklist, r=margaret 2015-05-15 00:31:39 +01:00
Margaret Leibovic
2ba52e29a3 Bug 1129029 - Telemetry probes for reader mode performance. r=Gijs 2015-04-30 14:51:02 -07:00
Gijs Kruitbosch
577fb39dc4 Bug 1160775 - fix reader mode detection to force 1 flush so we don't think the entire page is invisible, r=margaret 2015-05-06 17:40:20 +01:00
Margaret Leibovic
cfe3ed6ec7 Bug 1158228 - Disable visibility check helper function to avoid test bustage. rs=me 2015-05-02 07:29:12 -07:00
Gijs Kruitbosch
57b32622ab Bug 1153384 - improve isProbablyReaderable detection, r=margaret 2015-04-27 15:58:24 +01:00
Gijs Kruitbosch
d49a6a1783 Bug 1157682 - ignore querystring / hash when determining 'home page' for reader mode, r=margaret 2015-04-23 14:38:58 +01:00
Gijs Kruitbosch
af350febdb Bug 1152219 - make reader mode node limit a pref, turn off entirely for desktop because of isProbablyReaderable, r=margaret 2015-04-16 16:24:08 +01:00
Margaret Leibovic
3cf9e323ea Bug 1152121 - Factor out logic to get original URL from reader URL into shared place, and handle malformed URI excpetions. r=Gijs, mcomella 2015-04-06 16:07:03 -07:00
Margaret Leibovic
58c6ccce24 Bug 1152412 - Handle errors downloading and parsing documents for reader view. r=bnicholson 2015-04-10 14:41:14 -07:00
Margaret Leibovic
93d8eb18ff Bug 1150695 - Use isProbablyReaderable function from Readability.js. r=Gijs 2015-04-03 16:25:22 -04:00
Gijs Kruitbosch
c99742b35d Bug 1147487 - don't try to reader-ize non-HTML documents, r=margaret,jaws 2015-04-01 13:40:25 +01:00
Mark Hammond
959491cddf Bug 1149859 - readermode now considers paragraphs with 100 chars acceptable instead of 200. r=margaret 2015-04-02 14:56:19 +11:00
Gijs Kruitbosch
37822347d5 Bug 1146666 - fix reader mode button's dealing with history.pushState, r=margaret 2015-03-25 00:33:16 +00:00
Margaret Leibovic
f2e7417f97 Bug 1143844 - Check document for readerable content to determine whether or not to show reader button. r=Gijs 2015-03-18 13:42:52 -07:00