Florian Queze
6cc0b6e992
Bug 1355056 - replace (function(args) { /* do stuff using this */ }).bind(this) with arrow functions, r=jaws.
2017-04-27 00:25:45 +02:00
Florian Queze
451928e614
Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws.
2017-04-14 21:51:39 +02:00
Florian Queze
d3c36892fa
Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws.
2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0
Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout
2017-04-14 23:39:22 +02:00
Sebastian Hengst
f75839c723
Backed out changeset 55f3df15eaa6 (bug 1356569)
2017-04-14 23:39:17 +02:00
Florian Queze
61aabdf237
Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws.
2017-04-14 21:51:39 +02:00
Florian Queze
9b4f73599f
Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws.
2017-04-14 21:51:38 +02:00
Zibi Braniecki
f4aa49939d
Bug 1347272 - Move ChromeRegistry::IsLocaleRTL to LocaleService::IsAppLocaleRTL. r=jfkthame
...
MozReview-Commit-ID: BDhgIKNSOEL
2017-03-14 12:35:06 -07:00
Iris Hsiao
bc568366eb
Backed out changeset c7174ac72d14 (bug 1347272) for build bustage
2017-03-28 18:16:33 +08:00
Zibi Braniecki
f1060ac666
Bug 1347272 - Move ChromeRegistry::IsLocaleRTL to LocaleService::IsAppLocaleRTL. r=jfkthame
...
MozReview-Commit-ID: BDhgIKNSOEL
2017-03-14 12:35:06 -07:00
Timothy Guan-tin Chien
41bd380984
Bug 1344431 - Tell parent the non-reader-able reader page is not readable, r=Gijs
...
Although regression window testing pin this to bug 1260276, I believe
this is a regression from bug 1126967. Bug 1260276 just make it more
visible because we stop automatically redirect users to the original
page.
This patch fix the bug by checking if the current page is in readerable
state (i.e. not error state), and send the message accordingly.
MozReview-Commit-ID: B5UJcPvVlAc
2017-03-06 16:31:47 +08:00
Xidorn Quan
fa501f6e88
Bug 1342348 part 2 - Remove local link fix in about:reader. r=Gijs
...
MozReview-Commit-ID: GsEuRwj3oXV
2017-02-27 12:06:38 +11:00
Wes Kocher
8a6f2b529c
Backed out 2 changesets (bug 1342348) for xpcshell bustage a=backout
...
Backed out changeset 6e181ffefa61 (bug 1342348)
Backed out changeset 4f0fce98dd3a (bug 1342348)
MozReview-Commit-ID: F7bUbScVyfN
2017-02-27 16:56:04 -08:00
Xidorn Quan
9e587bc9a7
Bug 1342348 part 2 - Remove local link fix in about:reader. r=Gijs
...
MozReview-Commit-ID: GsEuRwj3oXV
2017-02-27 12:06:38 +11:00
Sebastian Hengst
e42ef63c64
Backed out changeset d1578fd6f7e4 (bug 1342348)
2017-02-27 15:25:18 +01:00
Xidorn Quan
f49da41293
Bug 1342348 part 2 - Remove local link fix in about:reader. r=Gijs
...
MozReview-Commit-ID: GsEuRwj3oXV
2017-02-27 12:06:38 +11:00
Jared Wein
0ec522d5b6
Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
...
MozReview-Commit-ID: 6tv0Z06CO4a
2017-01-17 09:48:17 -06:00
Florian Quèze
63de711857
Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws.
2017-01-17 11:50:25 +01:00
Florian Quèze
b36a8b8f42
Bug 1330147 - automatic removal of the third boolean parameter in removeObserver calls, r=jaws.
2017-01-11 22:27:42 +01:00
Florian Quèze
13cfe1d3f3
Bug 1329182 - remove trailing newURI null parameters in toolkit/, r=jaws.
2017-01-09 20:27:25 +01:00
Jared Wein
7c1615ceba
Bug 1329014 - Enable the no-extra-bind rule and use eslint --fix to autofix the errors. r=standard8
...
MozReview-Commit-ID: BwK94W2mHXS
2017-01-05 16:43:29 -05:00
Jared Wein
21fc75d491
Bug 1326479 - Fix 'indent' eslint errors now that eslint scans multiline array and object definitions. r=Gijs
...
MozReview-Commit-ID: 99mWjxu8PPn
2017-01-03 10:07:50 -05:00
Jared Wein
e3149c378f
Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
...
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd
Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
...
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767
Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
...
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
fiveNinePlusR
677bce5a57
Bug 1323415 - Add reader mode time estimate pluralization strings. r=gijs
...
Changes the time estimate string to use the pluralization library
so different localizations will be able to localize correctly.
2016-12-19 11:00:00 +01:00
fiveNinePlusR
dc7b67c54e
Bug 1265304 - Add an estimated time range to reader mode, r=gijs,ui-r=emanuela
...
Uses an upper and lower bound found from this study: http://iovs.arvojournals.org/article.aspx?articleid=2166061
2016-12-11 21:35:00 +00:00
Evan Tseng
a0a3ac8203
Bug 1318605 - Do language detection to get text direction, r=Gijs
...
MozReview-Commit-ID: JxEw7e5y5r1
2016-11-18 18:36:12 +08:00
Sebastian Hengst
f6bbe3cf1a
Backed out changeset cbde1c9e78d5 (bug 1318605) for failing test_reader_view.html and test_session_scroll_position.html on Android. r=backout
2016-11-29 18:25:46 +01:00
Evan Tseng
98f8270ca6
Bug 1318605 - Do language detection to get text direction, r=Gijs
...
MozReview-Commit-ID: JxEw7e5y5r1
2016-11-18 18:36:12 +08:00
Dave Townsend
e7b1b3284f
Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit). r=jaws
...
MozReview-Commit-ID: FGFwg6TYkvm
2016-11-11 15:22:34 -08:00
Dave Townsend
12596ced47
Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws
...
MozReview-Commit-ID: HBpjT2uHJaZ
2016-11-10 14:48:04 -08:00
Sébastien Blin
7190bbc6af
Bug 1189491 - Take anchors into account in the reader view, r=gijs
...
MozReview-Commit-ID: 1udixhxnVao
2016-11-03 05:50:00 +00:00
Sebastian Hengst
3b219cba1e
Backed out changeset 1cb8dac3eb40 (bug 1189491) for failing browser_readerMode.js. r=backout
2016-11-05 13:54:35 +01:00
Sébastien Blin
f3ee406553
Bug 1189491 - Take anchors into account in the reader view, r=gijs
...
MozReview-Commit-ID: 1udixhxnVao
2016-11-03 05:50:00 +00:00
Wes Kocher
d939df7bcf
Backed out changeset 4da7d22ebcd2 (bug 1189491) for multiple eslint failures a=backout CLOSED TREE
2016-11-04 11:55:56 -07:00
Sébastien Blin
f1aba24f22
Bug 1189491 - Take anchors into account in the reader view, r=gijs
...
MozReview-Commit-ID: 1udixhxnVao
2016-11-03 05:50:00 +00:00
Gijs Kruitbosch
a7e5b8832f
No bug, fix eslint errors introduced when enabling more rules in .eslintrc.js, rs=bustage
...
MozReview-Commit-ID: GADYtKhyd50
2016-11-02 11:33:21 +01:00
Jared Wein
0c024fa9ca
Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
...
MozReview-Commit-ID: 7Gx90a5y8t6
2016-10-24 13:14:19 -04:00
Gijs Kruitbosch
8596108aaf
Bug 1280888 - make hash links in about:reader absolute to avoid kicking people out of reader mode unnecessarily, r=jaws
...
MozReview-Commit-ID: IwrPJZZXxEW
2016-08-24 16:49:13 +01:00
Jared Wein
4518d81cb5
Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
...
MozReview-Commit-ID: EMjJ3yWt9Wt
2016-08-04 03:28:58 -04:00
Jared Wein
e8b20b6db5
Bug 1292035 - Enable the space-before-blocks rule for eslint. This patch was generated using 'eslint --fix'. r=markh
...
MozReview-Commit-ID: 2XVoU05YvES
2016-08-04 03:20:25 -04:00
Timothy Guan-tin Chien
0170ec3615
Bug 1260276 - Replace the dead reader page in history when we are being redirected, r=gijs
...
MozReview-Commit-ID: ChSCHuBKT1l
2016-07-13 16:14:34 +08:00
Jared Wein
c8957f6183
Bug 1271742 - Rename currentLineHeight to currentContentWidth in AboutReader.jsm. r=gijs
...
MozReview-Commit-ID: Fn98gl3Tief
2016-05-10 15:01:06 -04:00
danhuang1202
83d0f1d213
Bug 1269521 - Add line height contral in reader mode. r=jaws
...
MozReview-Commit-ID: HLFxqXdBhrD
2016-05-09 19:17:00 +02:00
Timothy Guan-tin Chien
648c7f27c3
Bug 1153393 - Make session restore restores the scroll position of an about:reader page, r=gijs
...
MozReview-Commit-ID: 6smuca3vx5O
2016-05-07 12:31:21 +08:00
danhuang1202
72e5cc0cfb
Bug 1151200 - Add content width control in reader mode. r=shorlander, r=jaws
2016-05-02 04:50:00 +02:00
Timothy Guan-tin Chien
f9af230a34
Bug 1269996 - Remove unload event listener, enabling bfcache for about:reader pages. r=gijs, r=margaret
...
MozReview-Commit-ID: IitxeBIFrGE
2016-05-04 17:53:31 +08:00
Andrzej Hunt
e1ddbca9b4
Bug 1265004 - Try to save in-memory reader view article instead of downloading r=margaret
...
This should guarantee that any reader view page will also be successfully saved offline.
MozReview-Commit-ID: 4J8cY6hYeyU
2016-05-02 15:47:46 -07:00
Eitan Isaacson
7bae627f10
Bug 1257953 - Update narrate to use new animated icon when speaking. r=Gijs
...
MozReview-Commit-ID: 4OnlJBmzu5T
2016-04-20 10:38:20 -07:00