Commit Graph

148 Commits

Author SHA1 Message Date
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Zibi Braniecki
efdaa3952d Bug 1354445 - Migrate Intl.DateTimeFormat to mozIntl.DateTimeFormat in chrome. r=mak
MozReview-Commit-ID: 4z13lcLXN9T
2017-04-08 23:04:32 -07:00
Matthew Noorenberghe
1a7f4ac402 Bug 1355534 - Revert to longer insecure login field contextual warning string. r=johannh
MozReview-Commit-ID: F2hmNQGLvo8
2017-04-11 13:03:29 -04:00
Jared Wein
5a181760cc Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx
2017-03-21 14:29:43 -04:00
Mark Banner
ec9074e132 Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r=jaws
MozReview-Commit-ID: LH0CQOPfoe6
2017-03-20 12:36:37 +01:00
Matthew Noorenberghe
2b8570b31d Bug 1333256 - Bring back the insecure field warning Learn More text in bold. r=johannh
MozReview-Commit-ID: CpPgkdmbb2O
2017-02-14 02:19:20 +08:00
Valentin Gosu
25f2affa4f Bug 1275746 - Fix tests that assume a HTTP url without a hostname is valid r=bz,MattN,jdm,markh
MozReview-Commit-ID: DzRenakrcAG
2016-07-07 16:20:47 +03:00
Matthew Noorenberghe
ca0b5d32c1 Bug 1332165 - Trim values for the purposes of 'skipEmptyFields' in _getPasswordFields. r=Dolske
We will no longer prompt to save passwords consisting solely of whitespace.

MozReview-Commit-ID: FknB39TCHEa
2017-01-23 23:31:34 -08:00
Mark Banner
55868dde7c Bug 503613 - Remove old 'tail =' lines from xpcshell.ini files; r=gps
MozReview-Commit-ID: 62Hp5ISxowJ
2017-01-18 10:30:39 +00:00
Matthew Noorenberghe
a8427e5d49 Bug 1330829 - Login Manager recipe support for ignoring specific password fields. r=johannh
MozReview-Commit-ID: 5Y2pTaPDGb5
2017-01-13 13:34:55 -08:00
Mark Banner
ac52569fff Bug 1329614 - [eslint] Catch more cases of importing globals from 'var foo = Cu.import('...');'. r=jaws
MozReview-Commit-ID: 5NKHHb70YA6
2017-01-09 10:12:26 +00:00
Florian Quèze
13cfe1d3f3 Bug 1329182 - remove trailing newURI null parameters in toolkit/, r=jaws. 2017-01-09 20:27:25 +01:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Gijs Kruitbosch
e5b59d7fbd Bug 1285577 - part 0a: make login manager return the login we're creating with addLogin, r=MattN
This patch also addresses logic issues in LoginHelper.maybeImportLogin, renames
a parameter of maybeImportLogin to be consistent and adds a test.

MozReview-Commit-ID: 12llkOyF7ne
2016-11-30 11:03:21 +00:00
Sebastian Hengst
e906b9416f Backed out changeset 61029bd1995a (bug 1285577) for failing test_autofill_https_upgrade.html at least on Linux. r=backout 2016-12-20 22:56:02 +01:00
Gijs Kruitbosch
c8e3816d11 Bug 1285577 - part 0a: make login manager return the login we're creating with addLogin, r=MattN
This patch also addresses logic issues in LoginHelper.maybeImportLogin, renames
a parameter of maybeImportLogin to be consistent and adds a test.

MozReview-Commit-ID: 12llkOyF7ne
2016-11-30 11:03:21 +00:00
Matthew Noorenberghe
928bc224b9 Bug 1129629 - Update test_user_autocomplete_result.js style checks. r=bustage
MozReview-Commit-ID: 1bBpg4j4hOp
2016-11-23 15:50:57 -08:00
Sebastian Hengst
c134343383 Bug 1318194 - Always lists matching logins regardless of page security. Fix tests. r=bustage-fix 2016-11-18 14:52:47 +01:00
Dave Townsend
e7b1b3284f Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit). r=jaws
MozReview-Commit-ID: FGFwg6TYkvm
2016-11-11 15:22:34 -08:00
Sean Lee
09487b6354 Bug 1289913 - Show autocomplete UI on password fields.; r=MattN
MozReview-Commit-ID: LGKM6igKbQB
2016-11-03 18:07:39 +08:00
Sebastian Hengst
572c945d98 Backed out changeset 53d701cacdea (bug 1289913) for failing xpcshell test_user_autocomplete_result.js on Android and mochitest test_password_field_autocomplete.html on many platforms. r=backout 2016-11-12 14:10:32 +01:00
Sean Lee
3cc8a23f07 Bug 1289913 - Show autocomplete UI on password fields.; r=MattN
MozReview-Commit-ID: LGKM6igKbQB
2016-11-03 18:07:39 +08:00
Sebastian Hengst
6cf65ed900 Bug 1310297 - Remove test annotations using b2g, mulet or gonk: toolkit. r=RyanVM
MozReview-Commit-ID: I5LuDjnM7By
2016-11-05 11:29:22 +01:00
Jared Wein
eb09d153fa Bug 1314474 - Enable no-shadow rule for eslint for browser/ mochitests. r=mossop
MozReview-Commit-ID: 3EQOeDSnmVz
2016-11-04 17:11:52 -04:00
Wes Kocher
5f6cf497a3 Backed out changeset 2a1b034ed3fb (bug 1314474) for xpcshell failures a=backout 2016-11-04 13:57:56 -07:00
Jared Wein
c0329c1f9a Bug 1314474 - Enable no-shadow rule for eslint for browser/ mochitests. r=mossop
MozReview-Commit-ID: 3QTChaVgCRP
2016-11-03 18:29:08 -04:00
Jared Wein
5edec1c0d9 Bug 1315013 - part 1, remove unnecessary double-slash comments that don't add value and look out of place with the spaced-comment eslint rule. r=mossop
MozReview-Commit-ID: HIUTSdkXxbY
2016-11-03 14:42:06 -04:00
Jared Wein
0c024fa9ca Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
MozReview-Commit-ID: 7Gx90a5y8t6
2016-10-24 13:14:19 -04:00
Steve Chung
afc331aad6 Bug 1300988 - Part 2: Move MockDocument to toolkit/modules and refactor unit test in passwordmgr. r=MattN
MozReview-Commit-ID: 16jZ7UzhVDf
2016-10-18 18:45:24 +08:00
Luke Chang
36e6375328 Bug 1309481 - Remove leftover code specific to Logins from JSONFile.jsm and add tests; r=Paolo
MozReview-Commit-ID: DjEPCN2PXA1
2016-10-17 18:26:35 +08:00
Matthew Noorenberghe
3dbe67f6c2 Bug 1310049 - Refactor FormLikeFactory to its own module for use by Form Autofill. r=steveck
This introduces LoginFormFactory which wraps FormLikeFactory for use with login-specific contexts.

MozReview-Commit-ID: 6rPz5JOy3Yp
2016-10-18 13:31:09 -07:00
Mark Banner
233309fbe2 Bug 1251003 - Change .eslintrc files to .eslintrc.js to avoid obsolete config file format. r=mossop
MozReview-Commit-ID: JrbFxQ5rj6I
2016-10-18 08:38:10 +01:00
Matthew Noorenberghe
345002bded Bug 1301287 - Password manager: enable eslint space-infix-ops rule. r=johannh
.js files were fixed automatically with --fix

MozReview-Commit-ID: wzRpQhqEH7
2016-09-07 21:41:15 -07:00
Matthew Noorenberghe
fa2df6f844 Bug 1301287 - Password manager: enable eslint semi rule. r=johannh
.js files were fixed automatically with --fix

MozReview-Commit-ID: Get2mxB8Twx
2016-09-07 21:42:49 -07:00
Matthew Noorenberghe
dfc22c9e92 Bug 1299984 - Enable eslint no-unused-vars for shipping pwmgr code. r=johannh
I also fixed two test cases while I was looking at the results.

MozReview-Commit-ID: LpUj56UNV3r
2016-09-02 14:07:13 -07:00
Saad Quadri
8e73895a95 Bug 1058438 - Add test for disabledHost migration to sqlite v6 in Fennec. r=MattN
MozReview-Commit-ID: DRV3zmXc9yJ
2016-08-09 10:14:56 -07:00
Saad Quadri
94d55fec7d Bug 1058438 - Add additional tests for disabledHost APIs with nonascii characters in URLs. r=MattN
MozReview-Commit-ID: EsN6FNCzbLk
2016-08-09 10:14:53 -07:00
Jared Wein
4518d81cb5 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt
2016-08-04 03:28:58 -04:00
Saad Quadri
4056da1e2b Bug 1278138 - Enforce stricter eslint rules (comma-style) on passwordmgr. r=MattN
MozReview-Commit-ID: A16S8XGZ6Kg
2016-06-07 13:06:13 -07:00
Matthew Noorenberghe
ed7a436c7d Bug 667233 - Follow-up to loosen the restriction on preferredOriginScheme due to tests using data: and chrome:
Also disable the autocomplete/autofill tests on Android.

MozReview-Commit-ID: P4mgzfNzda
2016-05-29 19:09:08 -07:00
Matthew Noorenberghe
d0a256be8c Bug 667233 - Support login scheme upgrades for autocomplete/fill/contextmenu. r=dolske
MozReview-Commit-ID: GG6F81ErAcI
2016-05-29 17:16:01 -07:00
Matthew Noorenberghe
f8dcc2a8ff Bug 667233 - Support scheme upgrades for searching logins. r=dolske
MozReview-Commit-ID: GAw0HIBgOFw
2016-05-29 17:15:52 -07:00
Matthew Noorenberghe
370df6c2aa Bug 667233 - Backout bug 1147561 to only support formSubmit upgrades so we can use the same logic. r=dolske
[mq]: backout_1147561

MozReview-Commit-ID: IKGj6rT1xTX
2016-05-29 17:15:45 -07:00
Ray Lin
687cdd9c4c Bug 925101 - Remove legacy signons.txt files. r=dolske
MozReview-Commit-ID: ICZADhIeKiB
2016-04-19 17:28:01 +08:00
Sebastian Hengst
0abe30125d Bug 1251916 - Use standard JavaScript features in toolkit/components/passwordmgr to pass eslint checks: replace legacy generators with ES6 generators. r=MattN
MozReview-Commit-ID: KxMSovx0mfl
2016-02-28 14:11:17 -08:00