Commit Graph

147 Commits

Author SHA1 Message Date
Florian Queze
451928e614 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Sebastian Hengst
f75839c723 Backed out changeset 55f3df15eaa6 (bug 1356569) 2017-04-14 23:39:17 +02:00
Florian Queze
61aabdf237 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Zibi Braniecki
efdaa3952d Bug 1354445 - Migrate Intl.DateTimeFormat to mozIntl.DateTimeFormat in chrome. r=mak
MozReview-Commit-ID: 4z13lcLXN9T
2017-04-08 23:04:32 -07:00
Jared Wein
5a181760cc Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx
2017-03-21 14:29:43 -04:00
Fischer.json
71a3493ba7 Bug 1338757 - "Remove All Shown" and button in about:preferences should use its own accesskey, r=jaws
MozReview-Commit-ID: 2ucF0GqOCJV
2017-02-13 11:43:37 +08:00
Fischer.json
5b645d203b Bug 1338036 - Switch button label from "Remove All" to "Remove All Shown" when filtering by keyword in about:preferences, r=jaws
MozReview-Commit-ID: 8iK6bg8i0uT
2017-02-09 12:00:12 +08:00
Matthew Noorenberghe
93ae3887e2 Bug 1330844 - Add a pwmgr notPasswordSelector:#cardNumber recipe for buy.gogoinflight.com. r=johannh
MozReview-Commit-ID: GWG3XNmrU9c
2017-01-12 18:22:28 -08:00
Matthew Noorenberghe
cffdf625fd Bug 1330810 - Disable password manager on www.united.com/travel/checkin/changefqtv.aspx. r=johannh
MozReview-Commit-ID: FCRvgYjm8BI
2017-01-12 17:37:46 -08:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Jalen Adams
fbcd128721 Bug 1324171 - Use 'Search' as placeholder text instead of as a label in-front of search fields. r=jaws
MozReview-Commit-ID: 8eZ7Hy9DTuy
2016-12-22 11:32:40 -05:00
Matthew Noorenberghe
9514f9edc3 Bug 1324136 - Add a GetVisibleLogins helper to reduce duplication in passwordManager.js. r=seanlee
MozReview-Commit-ID: BV6iqTvcVw5
2016-12-21 15:48:26 -05:00
Jared Wein
0c024fa9ca Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
MozReview-Commit-ID: 7Gx90a5y8t6
2016-10-24 13:14:19 -04:00
Fischer.json
2916b1a264 Bug 1130447 - Hide the password manager timeLastUsed column by default. r=MattN
MozReview-Commit-ID: LxKnIfBhtQh
2016-09-20 15:45:15 +08:00
Phil Ringnalda
c7ab85e06c Backed out changeset ae0e76aa85b6 (bug 1130447) for failing browser_passwordmgr_fields.js 2016-09-28 21:14:32 -07:00
Fischer.json
82550f7d69 Bug 1130447 - Hide the password manager timeLastUsed column by default. r=MattN
MozReview-Commit-ID: LxKnIfBhtQh
2016-09-20 15:45:15 +08:00
Matthew Noorenberghe
adfd6f5e7c Bug 1286718 - Revert bug 1148026 to remove the initial login fill doorhanger code. r=johannh
MozReview-Commit-ID: 8IiG6gTNeHY
2016-09-09 22:56:52 -07:00
Matthew Noorenberghe
9048f83b33 Bug 1301287 - Password manager: enable eslint no-new-object rule. r=johannh
MozReview-Commit-ID: 608ugBaVxrg
2016-09-07 21:39:48 -07:00
Matthew Noorenberghe
345002bded Bug 1301287 - Password manager: enable eslint space-infix-ops rule. r=johannh
.js files were fixed automatically with --fix

MozReview-Commit-ID: wzRpQhqEH7
2016-09-07 21:41:15 -07:00
Matthew Noorenberghe
fa2df6f844 Bug 1301287 - Password manager: enable eslint semi rule. r=johannh
.js files were fixed automatically with --fix

MozReview-Commit-ID: Get2mxB8Twx
2016-09-07 21:42:49 -07:00
Matthew Noorenberghe
a33e675832 Bug 1301287 - Password manager: enable eslint brace-style rule on shipping code. r=johannh
MozReview-Commit-ID: BDHUOlv83eR
2016-09-07 21:45:20 -07:00
Matthew Noorenberghe
e1b934c26e Bug 1288558 - Enable eslint no-undef for shipping pwmgr code. r=me
MozReview-Commit-ID: 5rbPmxODejr
2016-09-07 18:44:17 -07:00
Steve Chung
50afca3cc0 Bug 1288558 - Part 12: Switch the function naming _filterPasswords and FilterPasswords. r=MattN
MozReview-Commit-ID: 4OWpIZI4IkF
2016-09-07 18:31:56 +08:00
Steve Chung
0b2bd22190 Bug 1288558 - Part 11: Add spaces around operaters for the rest of part. r=MattN
MozReview-Commit-ID: CaVkChviksU
2016-09-07 18:26:03 +08:00
Steve Chung
29f9d2eac0 Bug 1288558 - Part 10: Remove unnecessary signonsTree parameter passing between functions. r=MattN
MozReview-Commit-ID: CYWZqUuzaLq
2016-09-07 18:36:15 -07:00
Steve Chung
00be68f5db Bug 1288558 - Part 9: Create some global variables and Move all the elements to the top. r=MattN
MozReview-Commit-ID: LVJT6ZgaF0M
2016-09-07 18:28:27 -07:00
Steve Chung
8963fc01d4 Bug 1288558 - Part 8: Remove unnecessary and unused parameters for SortTree and move parameters to the top. r=MattN
MozReview-Commit-ID: CiA6e7vPdyb
2016-09-07 18:09:48 -07:00
Steve Chung
9820036347 Bug 1288558 - Part 7: Merge DeleteAllFromTree into DeleteAllSignon and polish the spaces around operators. r=MattN
MozReview-Commit-ID: 6gPZwRycM7r
2016-09-07 15:51:12 +08:00
Steve Chung
3d79e8cab5 Bug 1288558 - Part 6: Merge DeleteSelectedItemFromTree into DeleteSignon and polish the spaces around operators. r=MattN
MozReview-Commit-ID: DTvS1hNT7pB
2016-09-07 15:40:26 +08:00
Steve Chung
d377ccaede Bug 1288558 - Part 5: Merge SignonsStartup/HandleTreeColumnClick into single Startup init function. r=MattN
MozReview-Commit-ID: GmH5csTaCax
2016-09-07 15:15:32 +08:00
Steve Chung
c7fcda9152 Bug 1288558 - Part 4: Replace kObserverService and passwordmanager variables with inline Services. r=MattN
MozReview-Commit-ID: GKcSSCgEkDe
2016-09-07 15:01:11 +08:00
Steve Chung
1726395ac0 Bug 1288558 - Part 3: Replace usage of Components with Cc/Ci/Cu. r=MattN
MozReview-Commit-ID: Goj429Tbk31
2016-09-07 14:51:40 +08:00
Steve Chung
57345541d3 Bug 1288558 - Part 2: Replace var with let. r=MattN
MozReview-Commit-ID: 9zOEOWmk9Hq
2016-09-07 17:50:06 -07:00
Steve Chung
3711bdf445 Bug 1288558 - Part 1: Simply move the functions/variables from passwordManagerCommon to passwordManager. r=MattN
MozReview-Commit-ID: IbBu31XQjCB
2016-09-05 15:47:20 +08:00
Steve Chung
beeb6464b6 Bug 1288557 - Part 1: Replace custom exceptions dialog with usage of permissions. r=MattN
MozReview-Commit-ID: 25fD9IJIVt0
2016-08-30 16:53:03 +08:00
Jared Wein
6de548d828 Bug 1294542 - Enable the block-spacing rule for eslint. r=felipe
MozReview-Commit-ID: GDfvwWRLNm5
2016-08-16 21:27:37 -04:00
Sebastian Hengst
c0e4d28a3a Backed out changeset 7914e9dc6f88 (bug 1294542) for xpcshell failure in test_Log.js. r=backout 2016-08-17 01:24:58 +02:00
Jared Wein
3df021ec2e Bug 1294542 - Enable the block-spacing rule for eslint. r=felipe
MozReview-Commit-ID: AAXqh63QNv3
2016-08-16 15:44:13 -04:00
Jared Wein
e8b20b6db5 Bug 1292035 - Enable the space-before-blocks rule for eslint. This patch was generated using 'eslint --fix'. r=markh
MozReview-Commit-ID: 2XVoU05YvES
2016-08-04 03:20:25 -04:00
Saad Quadri
4056da1e2b Bug 1278138 - Enforce stricter eslint rules (comma-style) on passwordmgr. r=MattN
MozReview-Commit-ID: A16S8XGZ6Kg
2016-06-07 13:06:13 -07:00
Matthew Noorenberghe
dbb09e9341 No bug - passwordManager.js style consistency fixes
MozReview-Commit-ID: 1fZXlESnmMC
2016-04-20 00:44:28 -07:00
Joseph Yeh
687552c8f6 Bug 530999 - Show site favicons in login manager UI; r=MattN
MozReview-Commit-ID: Lh9M3scMTwX
2016-04-19 23:27:14 -07:00
Dave Townsend
769fc8f245 Bug 1257246: Update toolkit for eslint 2. r=Gijs
Most of this is fixing functions that in some cases return a value but then
can also run to completion without returning anything. ESLint 2 catches this
where previous versions didn't. Unless there was an obvious other choice I just
made these functions return undefined at the end which is effectively what
already happens.

MozReview-Commit-ID: KHYdAkRvhVr
2016-04-05 11:33:48 -07:00
Timothy Guan-tin Chien
11d1c72c38 Bug 1243722 - Introduce notUsernameSelector in passwordmgr recipes. r=MattN
Additionally, add a recipe for Facebook.

MozReview-Commit-ID: 2l60v7R0TPP
2016-04-01 14:25:14 +08:00
Sebastian Hengst
9b2fcb3de7 Bug 1251916 - Use standard JavaScript features in toolkit/components/passwordmgr to pass eslint checks: general, simple changes. r=MattN
MozReview-Commit-ID: IdecwypP6on
2016-02-28 14:10:55 -08:00