Commit Graph

53 Commits

Author SHA1 Message Date
Wes Kocher
676e3eb6b3 No bug - Fix up merge bustage from an unsaved change a=me
MozReview-Commit-ID: CdGDhCgrksv
2017-04-25 13:58:03 -07:00
Wes Kocher
1bb3fcd58a Merge inbound to m-c a=merge
MozReview-Commit-ID: A85cs7Yriqj
2017-04-25 13:53:00 -07:00
Chris Peterson
dccd140861 Bug 1358948 - Remove redundant eslint "no-spaced-func" rules and standardize on new "func-call-spacing" name. r=standard8
The "no-spaced-func" name was deprecated in ESLint v3.3.0 and replaced by "func-call-spacing", which is already specified in the mozilla/recommended rules and some other .eslintrc.js files. We need to specify func-call-spacing in accessible/tests/browser/.eslintrc.js because it doesn't inherit the mozilla/recommended rules.

MozReview-Commit-ID: 7L8fuVtTu0X
2017-04-23 19:40:28 -07:00
Hemant Singh Patwal
cc2a3cdcc8 Bug 1354518 - De-duplicate already recommended ESLint rules in toolkit/components/narrate/.eslintrc.js. r=standard8
MozReview-Commit-ID: 2QClhuKkLVU
2017-04-25 19:55:58 +05:30
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Joel Maher
d2be399571 Bug 1351067 - add BUG_COMPONENT to toolkit/* files. r=myk,enndeakin,mossop
MozReview-Commit-ID: 8mv5Oed68JL
2017-04-09 05:43:43 -04:00
Mark Banner
7945b07153 Bug 1342459 - Enable no-undef on browser/base, and clean up unnecessary no-undef references. r=mossop
MozReview-Commit-ID: KVrAnAjMD1E
2017-04-03 11:46:56 +01:00
Mark Banner
c5921108d5 Bug 1347884 - Enable eslint cyclomatic complexity rule at existing levels. r=jaws
Enable the rule with the maximums set to avoid current failures, except for test_form_autocomplete which is very
high (82). The levels are set per major area, with existing warnings being changed to errors.

MozReview-Commit-ID: 37M6Ry0Mr1c
2017-03-16 11:04:39 +00:00
Florian Quèze
c8cf49999e Bug 1334156 - script-generated patch to replace .ownerDocument.defaultView with .ownerGlobal, r=jaws. 2017-01-27 10:51:03 +01:00
Florian Quèze
0a4ee94a29 Bug 1334199 - script-generated patch to omit getComputedStyle's second argument when it's falsy, r=jaws. 2017-01-27 10:51:02 +01:00
Jared Wein
21fc75d491 Bug 1326479 - Fix 'indent' eslint errors now that eslint scans multiline array and object definitions. r=Gijs
MozReview-Commit-ID: 99mWjxu8PPn
2017-01-03 10:07:50 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Eitan Isaacson
3e30859624 Bug 1324868 - invert initial flag in NarrateContols._setupVoices to correct value. r=Gijs
MozReview-Commit-ID: D6Vnh5jTsiv
2016-12-20 11:29:26 -08:00
Eitan Isaacson
d3f4339e21 Bug 1321862 - Use charLength for word highlight in Narrate. r=Gijs
MozReview-Commit-ID: 8mdjtRj2ljw
2016-11-17 11:55:12 -08:00
Evan Tseng
a0a3ac8203 Bug 1318605 - Do language detection to get text direction, r=Gijs
MozReview-Commit-ID: JxEw7e5y5r1
2016-11-18 18:36:12 +08:00
Sebastian Hengst
f6bbe3cf1a Backed out changeset cbde1c9e78d5 (bug 1318605) for failing test_reader_view.html and test_session_scroll_position.html on Android. r=backout 2016-11-29 18:25:46 +01:00
Evan Tseng
98f8270ca6 Bug 1318605 - Do language detection to get text direction, r=Gijs
MozReview-Commit-ID: JxEw7e5y5r1
2016-11-18 18:36:12 +08:00
Timothy Guan-tin Chien
6ed91b7c66 Bug 1316828 - Allow finer control over narration speed, r=eeejay
This patch updates the available speed for user from 8 different speeds to 40.

MozReview-Commit-ID: DZXIhqQERIv
2016-11-11 18:51:04 +08:00
Jared Wein
2dfc7371c2 Bug 1316096 - Change eslint configuration to use string values for rules instead of integers, making it easier for others who are reading the rules to know if a rule is set to off, warn, or error. r=mossop
MozReview-Commit-ID: 2Xuj5nxuQdO
2016-11-08 15:14:19 -05:00
Eitan Isaacson
95fcef0065 Bug 1308030 - Add telemetry probes to narrate. r=bsmedberg,Gijs, data-review=bsmedberg
Added 2 probes:
1. Breakup by language of initilizations and available voice support for that language.
2. Speak time of narrate.

MozReview-Commit-ID: AGD8nON2m7N
2016-10-14 16:49:57 -07:00
Eitan Isaacson
c545c34791 Bug 1310448 - Wait for narrate button to appear before starting tests. r=Gijs
MozReview-Commit-ID: 8MPzdZvAT1
2016-10-17 12:17:39 -07:00
Mark Banner
233309fbe2 Bug 1251003 - Change .eslintrc files to .eslintrc.js to avoid obsolete config file format. r=mossop
MozReview-Commit-ID: JrbFxQ5rj6I
2016-10-18 08:38:10 +01:00
Eitan Isaacson
c4979fc2c4 Bug 1294765 - Filter out voices that don't match the content language. r=Gijs
MozReview-Commit-ID: HkjshGZlfSu
2016-10-11 14:30:03 -07:00
Eitan Isaacson
f650690bd0 Bug 1294765 - Refactor content language detection to happen early and always. r=Gijs
MozReview-Commit-ID: HnKIvznhdfW
2016-10-11 09:54:58 -07:00
Eitan Isaacson
52ac206fca Bug 1307962 - Don't close VoiceList when focusing on toggle button. r=Gijs
MozReview-Commit-ID: E8P8y3oYbtb
2016-10-04 14:41:08 -07:00
Eitan Isaacson
57a2ee420c Bug 1290173 - Introduce Narrate word tracking test. r=mikedeboer
Added a sample article in the Narrate module for testing special cases.

MozReview-Commit-ID: 1oSem9LARB3
2016-09-29 13:28:30 -07:00
Eitan Isaacson
1c389fa300 Bug 1290173 - Introduce word tracking in Narrate. r=mikedeboer
MozReview-Commit-ID: BvcCaGmurh3
2016-07-25 15:13:27 -07:00
Eitan Isaacson
76b1b0bf9b Bug 1299653 - Don't have the page scrolling when the tab is closed. r=jaws
MozReview-Commit-ID: DlmXfQQttRr
2016-09-03 14:14:29 -07:00
Eitan Isaacson
a122e61cf9 Bug 1298436 - Don't get caught in an endless loop when narrating last paragraph. r=jaws
MozReview-Commit-ID: 7SMh0MGusgM
2016-08-27 14:42:51 -07:00
Jared Wein
772e2cebb4 Bug 1291839 - Change the Narrate input[type=range] to use 'change' events instead of 'input' events because we are not interested in intermediate values of the slider. r=eeejay
* * *
[mq]: temp

MozReview-Commit-ID: JpGbdSonDTD
2016-08-16 15:44:15 -04:00
Eitan Isaacson
2070d1f531 Bug 1255261 - Followup - fix eslint error. CLOSED TREE
MozReview-Commit-ID: 7h3yiKPW65R
2016-08-11 10:51:20 -07:00
Eitan Isaacson
f414efb92b Bug 1255261 - Read current paragraph after pressing stop. r=jaws
We always had to make sure we were one paragraph back from where we wanted
to start. That seems broken. I made it so that we start from the current
paragraph.

MozReview-Commit-ID: 4HMTdXcF644
2016-08-11 09:46:55 -07:00
Eitan Isaacson
85995646e3 Bug 1291837 - Wind all the way back when pressing previous in Narrate. r=jaws
MozReview-Commit-ID: 7dbbPPXHPuX
2016-08-03 10:40:58 -07:00
Jared Wein
7c35c99d2d Bug 1292008 - Enable the no-empty rule for eslint. r=markh
MozReview-Commit-ID: EfM3YOUjClW
2016-08-04 00:55:07 -04:00
Tom Tromey
1b5a2bdb96 Bug 1286877 - do not set c-basic-offset for python-mode; r=gps
This removes the unnecessary setting of c-basic-offset from all
python-mode files.

This was automatically generated using

    perl -pi -e 's/; *c-basic-offset: *[0-9]+//'

... on the affected files.

The bulk of these files are moz.build files but there a few others as
well.

MozReview-Commit-ID: 2pPf3DEiZqx
2016-07-14 10:16:42 -06:00
Eitan Isaacson
bcc4416e19 Bug 1270110 - Hide narrate button if no synth voices are present in browser. r=Gijs
MozReview-Commit-ID: iP7mMbeiUo
2016-07-15 12:53:48 -07:00
Eitan Isaacson
7bae627f10 Bug 1257953 - Update narrate to use new animated icon when speaking. r=Gijs
MozReview-Commit-ID: 4OnlJBmzu5T
2016-04-20 10:38:20 -07:00
Wes Kocher
d34e61e3ec Merge m-c to inbound, a=merge
MozReview-Commit-ID: 9YZdlIARozU
2016-04-08 16:47:03 -07:00
Dave Townsend
769fc8f245 Bug 1257246: Update toolkit for eslint 2. r=Gijs
Most of this is fixing functions that in some cases return a value but then
can also run to completion without returning anything. ESLint 2 catches this
where previous versions didn't. Unless there was an obvious other choice I just
made these functions return undefined at the end which is effectively what
already happens.

MozReview-Commit-ID: KHYdAkRvhVr
2016-04-05 11:33:48 -07:00
Eitan Isaacson
39af3e9415 Bug 1262006 - Swap narrate start/stop button tooltip states. r=Gijs
MozReview-Commit-ID: 4cRneVhQclY
2016-04-07 16:15:06 -07:00
Eitan Isaacson
a471c4b77c Bug 1254378 - Update Narrate to work with "voiceschanged" event. r=Margaret
MozReview-Commit-ID: 9gyzWOqHLJd
2016-03-29 10:30:26 -07:00
Ryan VanderMeulen
49cb5a5dc5 Merge fx-team to m-c. a=merge 2016-03-19 11:23:43 -04:00
Eitan Isaacson
d2dd8b5944 Bug 1254234 - Make narrate speed slider range more useful. r=Gijs
MozReview-Commit-ID: KyKxLstRPVD
2016-03-16 11:16:04 -07:00
Gijs Kruitbosch
2b8faefaba Bug 1252855 - make reader mode use AsyncPrefs, r=margaret
MozReview-Commit-ID: U6ZTyQQSHG
2016-03-15 20:40:14 +00:00
Eitan Isaacson
50387587b6 Bug 1254526 - Filter out empty text nodes from narrate queue. r=Gijs
MozReview-Commit-ID: 6g53pWcNtGN
2016-03-09 12:31:25 -08:00
Eitan Isaacson
4c2276e6ce Bug 1254526 - Don't let Narrate get into bad state after encountering a synth error. r=Gijs
MozReview-Commit-ID: GdOgtmM4hGH
2016-03-08 11:32:40 -08:00