Commit Graph

178 Commits

Author SHA1 Message Date
Paolo Amadini
60fca15e25 Bug 1348062 - Test that channels are properly marked for downloads. r=mak
Downloads handled by nsIExternalHelperAppService pass a null request to the final onStateChange notification, thus we need to hold a reference to the request earlier. This also allows unit tests to access the request while the download is running.

MozReview-Commit-ID: 21rapDmMIZw
2017-04-19 10:42:00 +01:00
Florian Queze
451928e614 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Sebastian Hengst
f75839c723 Backed out changeset 55f3df15eaa6 (bug 1356569) 2017-04-14 23:39:17 +02:00
Florian Queze
61aabdf237 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Jared Wein
5a181760cc Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx
2017-03-21 14:29:43 -04:00
Mark Banner
ec9074e132 Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r=jaws
MozReview-Commit-ID: LH0CQOPfoe6
2017-03-20 12:36:37 +01:00
Andrea Marchesini
25207d9b03 Bug 1299500 - Get rid of DeviceStorage API - part 10 - DeviceStorage, r=ehsan, r=billm 2017-03-08 20:15:45 +01:00
Florian Quèze
c7eae86054 Bug 1344711 - script-generated patch to remove try blocks around get*Pref calls, r=jaws. 2017-03-07 15:29:48 +01:00
Greg Mierzwinski
a9323edf9f Bug 1301197 - Add xpcshell code coverage to linux64-jsdcov and the 'coverage' mozinfo flag. r=jmaher
This patch makes it possible to collect code coverage for xpcshell tests using the linux64-jsdcov build. It also enables the use of a 'coverage' flag to disable tests when they are instrumented with the js debugger for code coverage. Lastly, it uses the 'coverage' flag to disable certain tests.

MozReview-Commit-ID: 97VFkJmlwQn
2016-11-08 15:57:21 -05:00
Mark Banner
55868dde7c Bug 503613 - Remove old 'tail =' lines from xpcshell.ini files; r=gps
MozReview-Commit-ID: 62Hp5ISxowJ
2017-01-18 10:30:39 +00:00
Jared Wein
0ec522d5b6 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a
2017-01-17 09:48:17 -06:00
Jared Wein
7c1615ceba Bug 1329014 - Enable the no-extra-bind rule and use eslint --fix to autofix the errors. r=standard8
MozReview-Commit-ID: BwK94W2mHXS
2017-01-05 16:43:29 -05:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Mark Banner
fb8a196639 Bug 1325623 - Fix most no-undef eslint issues in toolkit/components. r=mossop
MozReview-Commit-ID: DYJa1uNVagw
2016-12-23 16:00:46 +00:00
Dave Townsend
e7b1b3284f Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit). r=jaws
MozReview-Commit-ID: FGFwg6TYkvm
2016-11-11 15:22:34 -08:00
Mark Banner
8ddd9bb511 Bug 1315951 - Fix no-unused-vars issues in toolkit/components (except places). r=mossop
MozReview-Commit-ID: 8svkCKZHxsq
2016-11-08 12:49:32 +00:00
Jared Wein
b6817d7876 Bug 1315781 - Enable no-shadow rule for eslint for xpcshell mochitests. r=mossop
MozReview-Commit-ID: 1mhCWplknyN
2016-11-07 22:34:25 -05:00
Iris Hsiao
d24e67dbe4 Backed out changeset f6f28be8d8f2 (bug 1315781) for XPCShell test timed out 2016-11-10 14:53:46 +08:00
Jared Wein
0c41af265f Bug 1315781 - Enable no-shadow rule for eslint for xpcshell mochitests. r=mossop
MozReview-Commit-ID: DnpVQRrG9Ec
2016-11-07 22:34:25 -05:00
Sebastian Hengst
6cf65ed900 Bug 1310297 - Remove test annotations using b2g, mulet or gonk: toolkit. r=RyanVM
MozReview-Commit-ID: I5LuDjnM7By
2016-11-05 11:29:22 +01:00
Jared Wein
5edec1c0d9 Bug 1315013 - part 1, remove unnecessary double-slash comments that don't add value and look out of place with the spaced-comment eslint rule. r=mossop
MozReview-Commit-ID: HIUTSdkXxbY
2016-11-03 14:42:06 -04:00
Jared Wein
0c024fa9ca Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
MozReview-Commit-ID: 7Gx90a5y8t6
2016-10-24 13:14:19 -04:00
Tomislav Jovanovic
fda1335514 bug 915036 - Implement DownloadSource.adjustChannel callback to support POST requests r=Paolo
MozReview-Commit-ID: 1RplqGhjtn6
2016-10-21 15:54:18 +02:00
Mark Banner
233309fbe2 Bug 1251003 - Change .eslintrc files to .eslintrc.js to avoid obsolete config file format. r=mossop
MozReview-Commit-ID: JrbFxQ5rj6I
2016-10-18 08:38:10 +01:00
Jared Wein
8860cdf2c1 Bug 1294547 - Enable the comma-spacing rule for eslint. r=felipe
MozReview-Commit-ID: RCSDEvvk2I
2016-08-16 15:44:15 -04:00
Jared Wein
4518d81cb5 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt
2016-08-04 03:28:58 -04:00
James Andreou
d8171e1f43 Bug 1277590 - Changed setting docShell to private to opening a private window. r=ehsan
MozReview-Commit-ID: 2NSkp2n0mWy
2016-06-07 18:54:26 -07:00
Paolo Amadini
29e7952256 Bug 1261344 - Fix race condition with the state of Download objects when Application Reputation blocking occurs. r=mak
MozReview-Commit-ID: L0SWRBTnKOh
2016-04-18 14:22:05 +01:00
Paolo Amadini
e73184e12b Bug 899013 - Interface for customizing the DownloadIntegration module. r=mak
MozReview-Commit-ID: HWmcxXlLdLx
2016-04-18 14:21:55 +01:00
Paolo Amadini
8a79832341 Bug 1254100 - Part 2 - Downloads blocked by Application Reputation should provide information about the verdict. r=mak
MozReview-Commit-ID: FYH5Tdtbzn
2016-03-16 14:29:23 +00:00
Panos Astithas
f6f9b5b010 Bug 1250581 - Enable the browser_DownloadPDFSaver.js test on e10s. r=me
MozReview-Commit-ID: DMVWdfmaIXr
2016-02-26 12:06:36 +02:00
ISHIKAWA, Chiaki
9ee69e3ce0 Bug 1248252 - Improper outdated octal constant syntax in M-C tree. Use '0o' prefix. r=dao
Be warned. Do not attemp to change the .js "test" source code in ./js
They are meant to check

 - the outdated 0666 octal constant is still parsed correctly,
 - the outdated 0666 octal constant raises syntax error flag
   in strict mode, etc.

So leave them alone.
2016-02-15 08:57:00 +01:00
Paolo Amadini
ed28d1b8f2 Bug 989960 - Unhandled rejections in DOM Promises should cause xpcshell tests to fail. r=Yoric 2016-02-03 12:58:03 +00:00
Wes Kocher
c8dce5079f Backed out changeset e8148cda7d85 (bug 989960) for xpcshell bustage 2016-02-01 08:25:19 -08:00
Paolo Amadini
743e1ad1ea Bug 989960 - Unhandled rejections in DOM Promises should cause xpcshell tests to fail. r=Yoric 2016-01-30 18:53:56 +00:00
Phil Ringnalda
2f2864cc29 Back out 3958782fe187 (bug 989960) for Android crashes in test_watchdog_default.js 2016-01-29 20:12:44 -08:00
Paolo Amadini
4aac6813ea Bug 989960 - Unhandled rejections in DOM Promises should cause xpcshell tests to fail. r=Yoric 2016-01-29 13:19:53 +00:00
Chris Manchester
92989bf2a3 Bug 1243096 - Remove ini manifests containing only support-files and move their contents to TEST_HARNESS_FILES. r=gps 2016-01-27 17:46:34 -08:00
Sebastian Kaspari
a95d19a0ad Bug 1216537 - Check and request storage permission if file download is started. r=nalexander,paolo 2016-01-15 19:38:18 +01:00
Dave Townsend
8dc7f59eb3 Bug 1229142: Link browser and toolkit test directory to the shared eslintrc files. r=Standard8 2015-11-30 13:05:00 -08:00
Mrinal Dhar
b9fcdd077b Bug 1113736 - Remove tail.js and add cleanup function call in head.js. r=paolo 2015-12-28 15:05:13 +00:00
Dave Townsend
1c4c3fc446 Bug 1229519: Fix download managers to pass eslint checks. r=mak 2015-12-03 10:00:18 -08:00
Christoph Kerschbaumer
6d34f2a6f1 Bug 1225641 - Change default security flags within NetUtil.newChannel (r=sicking) 2015-11-17 17:35:30 -08:00
Christoph Kerschbaumer
e2cb9aea77 Bug 1223437 - Use channel.asyncOpen2 in toolkit/components/jsdownloads/test/unit (r=sicking) 2015-11-15 14:48:38 -08:00