corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
477,034 Commits 1 Branch 0 Tags
c76ce9f99a49d0cb15a2ad724b5db7f2b71142f6
Commit Graph

65 Commits

Author SHA1 Message Date
Florian Queze
6cc0b6e992 Bug 1355056 - replace (function(args) { /* do stuff using this */ }).bind(this) with arrow functions, r=jaws. 2017-04-27 00:25:45 +02:00
Alessio Placitelli
fcc1e2b7b8 Bug 1352496 - Enable sending other child processes crash pings from the CrashManager. r=bsmedberg,ted 
MozReview-Commit-ID: bG5iphe9Bc
 2017-04-03 14:43:47 +02:00
Gabriele Svelto
ad6e2212ea Bug 1345153 - When the pingsender fails to send a ping, persist it to disk so that it can be sent later via regular telemetry; r=chutten,ted 
Currently we hand over a crash ping to the pingsender via a pipe; if the
pingsender fails to send the ping we rely on the CrashManager assembling and
sending one instead. Since the crashmanager is not aware of whether the ping
was sent or not this causes duplication on the server side. To solve this
problem we save the ping to disk instead, read it from the pingsender and
delete the file only if the ping was sent. In this scenario the CrashManager
will know that a ping was already sent and will not send a new one.

This patch removes all the code used to deal with pipes between the telemetry,
crashreporter and pingsender code and also tries to cut down the amount of
platform-specific code we have in this machinery.

MozReview-Commit-ID: ASm2jnDagCK
 2017-03-27 12:38:39 +02:00
Gabriele Svelto
30d88a559a Bug 1322611 - After a crash compute the SHA256 hash of a minidump and attach it to the crash ping; r=Ted, nchen 
This patch changes the crashreporter client code as well as the crash service
code to compute a SHA256 hash of a crash' minidump file and add it to the
crash ping. The crash service code computes the hash on the fly before handing
over the crash to the crash manager; the crash manager will then add it to the
crash ping. The crashreporter client on the other hand sends the hash via the
ping it generates but it also adds it to the event file so that the crash
manager can pick it up and send it along with its own crash ping. On Fennec
the crashreporter activity takes care of computing the hash.

SHA256 hash computation uses nsICryptoHash in the crash service, the
java.security.MessageDigest class in Fennec, the bundled NSS library in the
crashreporter when running on Windows and Mac and the system-provided NSS
library under Linux. The latter is required because the crashreporter client
uses the system curl library which is linked to NSS and which would thus clash
with the bundled one if used together.

This patch introduces two new methods for the nsICrashService interface:
|getMinidumpForID()| and |getExtraFileForID()|, these reliably retrieve the
.dmp and .extra files associated with a crash and ensure the files exist
before returning. These new methods are used in the CrashService for
processing and will become the only way to reliably retrieve those files
from a crash ID.

MozReview-Commit-ID: 8BKvqj6URcO
 2017-02-16 07:36:57 +01:00
Chris H-C
80d9deaf2e bug 1338627 - Add crashTime to crash pings data-review=bsmedberg r=gsvelto 
crashDate having only per-day resolution was making client delay analysis
rather inaccurate.

crashTime is an ISO8601 string with per-hour resolution which should smooth
things over on the analysis side.

If per-hour is still too coarse, the use of an ISO string allows us to adapt
later to increasing the resolution, if it passes data review. The underlying
crash timestamp has per-second resolution.

MozReview-Commit-ID: 2hwJHSi8Xje
 2017-02-16 13:13:38 -05:00
Gabriele Svelto
83cc3c6b65 Bug 1310703 - Use the ID generated by the crashreporter client when sending a crash ping so that server-side deduplication works correctly; r=Dexter 
MozReview-Commit-ID: HfyKTru8QgN
 2017-01-16 18:17:02 +01:00
Kevin Gay
a7bd06bf2f Bug 1332644 - Remove 'retentionDays' from sendTelemetryPing call in CrashManager.jsm. r=Dexter 2017-01-23 04:01:54 -08:00
Jared Wein
7c1615ceba Bug 1329014 - Enable the no-extra-bind rule and use eslint --fix to autofix the errors. r=standard8 
MozReview-Commit-ID: BwK94W2mHXS
 2017-01-05 16:43:29 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN 
MozReview-Commit-ID: 7E7LPorrEje
 2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout 
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
 2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN 
MozReview-Commit-ID: 8WoGr8i6oCR
 2016-12-29 15:20:47 -05:00
Gabriele Svelto
921d52f071 Bug 1293656 - Send crash pings for content crashes complete with stack traces r=bsmedberg 
* * *
Bug 1293656 - Fix the test_process_error.xul test
 2016-10-19 12:51:29 +02:00
Gabriele Svelto
7af207f5bf Bug 1293656 - Store all crash annotations in the crash manager's database and filter out privacy-sensitive ones when sending a crash ping r=bsmedberg 2016-10-19 12:48:19 +02:00
Gabriele Svelto
2cb6197414 Bug 1319702 - Fix races in the CrashManager and CrashSubmit objects and in the related tests r=bsmedberg 2016-11-23 11:28:04 +01:00
Dave Townsend
e7b1b3284f Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit). r=jaws 
MozReview-Commit-ID: FGFwg6TYkvm
 2016-11-11 15:22:34 -08:00
Mark Banner
8ddd9bb511 Bug 1315951 - Fix no-unused-vars issues in toolkit/components (except places). r=mossop 
MozReview-Commit-ID: 8svkCKZHxsq
 2016-11-08 12:49:32 +00:00
Gabriele Svelto
1a18e9712e Bug 1280484 - Add stack traces to the crash ping r=bsmedberg 2016-10-17 12:56:45 +02:00
David Anderson
43cff5276f Add GPU process support to the crash reporting service. (bug 1278717, r=ted) 2016-10-14 23:59:29 -07:00
Gabriele Svelto
597c2e9daa Bug 1280477 - Write the stack traces extracted from a crash dump into the crash.main event file r=ted 2016-06-28 15:30:29 +02:00
Jared Wein
4518d81cb5 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh 
MozReview-Commit-ID: EMjJ3yWt9Wt
 2016-08-04 03:28:58 -04:00
Benjamin Smedberg
8bdab4404f Bug 1187270 - Add Telemetry session ID to crash annotations, r=gfritzsche 
MozReview-Commit-ID: GwVI0dfsT4H
 2016-03-14 09:31:19 -04:00
Daniel Holbert
ca38f91a55 backout d85b18faba72 (bug 1187270) for build bustage. 2016-03-15 15:51:56 -07:00
Benjamin Smedberg
b97feb5d63 Bug 1187270 - Add Telemetry session ID to crash annotations, r=gfritzsche 
MozReview-Commit-ID: GwVI0dfsT4H
 2016-03-14 09:31:19 -04:00
Dave Townsend
a2ba043d69 Bug 1245649: Turn on no-trailing-spaces. r=Gijs 2016-02-03 14:22:33 -08:00
Dave Townsend
2e4b5d2078 Bug 1245649: Merge browser and toolkit eslint rule settings. r=felipe 2016-02-03 13:12:18 -08:00
Anup Kumar
7188c329c2 Bug 1003204: Removed CommonUtils.exceptionStr() in toolkit/ r=gfritzsche 2015-12-18 04:05:00 +01:00
Dave Townsend
27d70dc531 Bug 1229519: Fix crash manager to pass eslint checks. r=mak 2015-12-03 10:01:18 -08:00
Shu-yu Guo
37989840cd Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Benjamin Smedberg
553b8282f9 Bug 1199662 - Crash ping environment block is broken when any string field contains a quotation mark. Unescape INI fields properly using the library that already exists for the purpose. r=ted 2015-08-28 12:53:43 -04:00
Benjamin Smedberg
2d706e98b8 Bug 1121013 part C - report a new crash ping type on main-process crashes, and record submission rate/failure information in telemetry. Plugin/content crashes are already recorded via SUBPROCESS_ABNORMAL_ABORT and SUBPROCESS_CRASHES_WITH_DUMP and this patch leaves that unchanged. r=gfritzsche 2015-03-30 17:48:11 -04:00
David Major
0fa8a9d76d Bug 1135543 - Part 4: Define DailyCrashesMeasurement6 containing main-crash-oom; r=bsmedberg 2015-03-14 18:59:21 +13:00
David Major
0bb08704f6 Bug 1135543 - Part 3: Create events file format crash.main.2 which contains metadata; r=bsmedberg 2015-03-14 18:54:36 +13:00
David Major
1ec1349cf9 Bug 1135543 - Part 2 (no part 1): Add a |metadata| parameter to CrashManager.addCrash(); r=bsmedberg 2015-03-14 18:54:06 +13:00
Birunthan Mohanathas
ef70953489 Bug 1024672 - Part 6: Allow storing multiple crash classifications. r=bsmedberg 2014-10-16 16:14:16 +03:00
Shu-yu Guo
6cfc2eb110 Bug 1001090 - Part 4: Fix errors in chrome code. (r=zombie,gavin,fitzgen,dcamp,bgrins,fabrice,gwagner,margaret,mrbkap,mak,njn,vicamo) 2014-09-15 16:30:46 -07:00
Birunthan Mohanathas
070340cba4 Bug 1059390 - Part 5: Add and use CrashManager.generateSubmissionID(). r=gps 2014-09-02 10:02:40 -07:00
Birunthan Mohanathas
00064d37c8 Bug 1024672 - Part 5: Allow classifications to be stored in crash metadata. r=gps 2014-09-02 09:55:16 -07:00
Birunthan Mohanathas
e0284767de Bug 1059940 - Part 1: Expose CrashStore.reset() to clear all data. r=bsmedberg 2014-08-29 13:39:01 -07:00
Birunthan Mohanathas
3a83a080f6 Bug 1059859 - Fix race condition in CrashManager._getStore() resulting in multiple stores being created. r=gps 2014-08-29 13:38:57 -07:00
Birunthan Mohanathas
4967a0296d Bug 1059390 - Part 4: Fix crash submission event file handling and add test. r=bsmedberg 
This also changes things to use a "sub-" prefix for the generated submission ID
in order to distinguish it from a local/remote crash ID.
 2014-08-29 13:38:53 -07:00
Birunthan Mohanathas
1c8eea0008 Bug 1059390 - Part 3: Limit count only for new crash records in CrashStore._ensureCrashRecord. r=bsmedberg 2014-08-29 13:38:49 -07:00
Birunthan Mohanathas
f6f91c7969 Bug 1059390 - Part 1: Allow remote Breakpad ID to be stored in crash metadata. r=gps 2014-08-28 21:03:02 -07:00
Birunthan Mohanathas
4ded33c6dd Bug 1024672 - Part 3: Remove CrashManager.addSubmission in favor of CrashManager.addSubmission{Attempt,Result}. r=gps 2014-08-21 15:43:50 -07:00
Birunthan Mohanathas
69fdcaf3e0 Bug 1024672 - Part 2: Convert submission details stored in separate crash records to crash metadata. r=gps 2014-08-21 15:43:46 -07:00
Birunthan Mohanathas
b0a8bba099 Bug 1024672 - Part 1: Allow submission details to be stored in crash metadata. r=gps 2014-08-21 15:43:42 -07:00
Bill McCloskey
853c5d27a4 Bug 1046964 - Fix some JS warnings (r=ttaubert) 2014-08-19 17:27:58 -07:00
Drew Willcoxon
0276cab04a Bug 1009765 - Add GMP plugin crashes to FHR crash reporting (part 2: FHR, toolkit/components/crashes). r=gps 2014-08-08 15:41:07 -07:00
Birunthan Mohanathas
b47e48cd5d Bug 1049257 - Fix typo in CrashManager.addCrash() in order to update the crash date of existing items. r=gps 2014-08-07 21:52:05 -07:00
Steven MacLeod
24a63a5408 Bug 994707 - Introduce crash submission events and handle them. r=bsmedberg 
This introduces a new crash event type for submissions and handles
them in the Crash Manager. These crash submissions will also be counted
in FHR.
 2014-07-03 14:04:28 -04:00
Wes Kocher
945f586984 Backed out 3 changesets (bug 994707) for Valgrind and XPCShell bustage on a CLOSED TREE 
Backed out changeset 76555f34c210 (bug 994707)
Backed out changeset 3dd92fb7c846 (bug 994707)
Backed out changeset 802779efce2b (bug 994707)
 2014-07-01 11:04:30 -07:00