Commit Graph

58 Commits

Author SHA1 Message Date
Jared Wein
5a181760cc Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx
2017-03-21 14:29:43 -04:00
Mark Banner
ec9074e132 Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r=jaws
MozReview-Commit-ID: LH0CQOPfoe6
2017-03-20 12:36:37 +01:00
Mark Banner
55868dde7c Bug 503613 - Remove old 'tail =' lines from xpcshell.ini files; r=gps
MozReview-Commit-ID: 62Hp5ISxowJ
2017-01-18 10:30:39 +00:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Dave Townsend
e7b1b3284f Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit). r=jaws
MozReview-Commit-ID: FGFwg6TYkvm
2016-11-11 15:22:34 -08:00
Mark Banner
8ddd9bb511 Bug 1315951 - Fix no-unused-vars issues in toolkit/components (except places). r=mossop
MozReview-Commit-ID: 8svkCKZHxsq
2016-11-08 12:49:32 +00:00
Sebastian Hengst
6cf65ed900 Bug 1310297 - Remove test annotations using b2g, mulet or gonk: toolkit. r=RyanVM
MozReview-Commit-ID: I5LuDjnM7By
2016-11-05 11:29:22 +01:00
Mark Banner
233309fbe2 Bug 1251003 - Change .eslintrc files to .eslintrc.js to avoid obsolete config file format. r=mossop
MozReview-Commit-ID: JrbFxQ5rj6I
2016-10-18 08:38:10 +01:00
Marco Bonardo
9f5dc75ac5 Bug 1306639 - Searching in locationbar by typing something and pressing enter is not accounted in telemetry. r=adw
MozReview-Commit-ID: 9r8IyyyxruC
2016-10-06 17:40:13 +02:00
Marco Bonardo
238ca13b58 Bug 1303624 - Remove typeAheadResult support from autocomplete. r=adw
MozReview-Commit-ID: 7XLTON1Rj96
2016-09-21 18:11:45 +02:00
Marco Bonardo
f838352255 Bug 1302472 - keyboard selected value in autocomplete popup cannot be confirmed with <enter> if completedefaultindex is true but completeselectedindex is false. r=adw
MozReview-Commit-ID: FR4pKGZLAl2
2016-09-17 14:03:37 +02:00
Marco Bonardo
b6f51668b8 Bug 1292310 - Enter may wrongly confirm a mouse selected entry in the urlbar. r=adw
MozReview-Commit-ID: 6teMoPr1vb6
2016-09-06 17:55:56 +02:00
Yoshi Huang
d1b4579af0 Bug 1244340 - Part 3: pass userContextId to search suggestions r=mak 2016-08-26 18:59:00 +08:00
Jared Wein
8860cdf2c1 Bug 1294547 - Enable the comma-spacing rule for eslint. r=felipe
MozReview-Commit-ID: RCSDEvvk2I
2016-08-16 15:44:15 -04:00
Jared Wein
ebf1ccbe46 Bug 1291855 - Enable the no-else-return rule for eslint. r=Felipe,kmag,mossop
MozReview-Commit-ID: DYOmE6xwMJh
2016-08-03 18:54:59 -04:00
Dave Townsend
a2ba043d69 Bug 1245649: Turn on no-trailing-spaces. r=Gijs 2016-02-03 14:22:33 -08:00
Marco Bonardo
299ef159d5 Bug 1234186 - Unified autocompletion Visit feature doesn't use https for https-only websites. r=adw 2016-01-19 00:39:57 +01:00
Dave Townsend
8dc7f59eb3 Bug 1229142: Link browser and toolkit test directory to the shared eslintrc files. r=Standard8 2015-11-30 13:05:00 -08:00
Drew Willcoxon
68436cd003 Bug 1182783 - Restore search string and selection when selecting an autofilled urlbar popup result. r=mak 2015-12-15 17:08:41 -08:00
Marco Bonardo
6c190ee363 Bug 720589 - mMatchCounts may be accessed with a nonexisting index. r=neil 2015-11-10 20:18:24 +01:00
Carsten "Tomcat" Book
036e6d2fa3 Backed out 2 changesets (bug 1202902) to recking bug 1202902 to be able to reopen inbound on a CLOSED TREE
Backed out changeset 647025383676 (bug 1202902)
Backed out changeset d70c7fe532c6 (bug 1202902)
2015-10-07 14:03:21 +02:00
Carsten "Tomcat" Book
12369728f5 Backed out 1 changesets (bug 1202902) for causing merge conflicts to mozilla-central
Backed out changeset cfc1820361f5 (bug 1202902)
2015-10-07 12:13:45 +02:00
Shu-yu Guo
474f49adb7 Bug 1202902 - Scripted fix the world. 2015-10-06 14:00:31 -07:00
Shu-yu Guo
37989840cd Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Magnus Melin
6b6bed0e6d Bug 1130858 - Recipient autocomplete suggestion overrides ANY manual address input if quickly entered/pasted and confirmed with Enter/Tab before autocomplete suggestions disappear. r=mak 2015-07-15 16:21:52 +03:00
Marco Bonardo
e661f14530 Bug 1173748 - Part 1: allow inserting result matches at given indices. r=adw 2015-07-03 13:37:37 +02:00
Gijs Kruitbosch
b4e3c116f7 Bug 1043584 - fix mouseover vs. enter issue in the urlbar, r=mak 2014-12-02 15:52:26 -08:00
Andrew Halberstadt
11b824f09b Bug 1066735 - Remove root b2g and android specific xpcshell manifests, r=chmanchester 2014-10-07 18:18:28 -04:00
Jim Blandy
39dc0c6097 Bug 914753: Make Emacs file variable header lines correct, or at least consistent. DONTBUILD r=ehsan
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):

 - Never set the buffer's mode.

   Years ago, Emacs did not have a good JavaScript mode, so it made sense
   to use Java or C++ mode in .js files. However, Emacs has had js-mode for
   years now; it's perfectly serviceable, and is available and enabled by
   default in all major Emacs packagings.

   Selecting a mode in the -*- file variable line -*- is almost always the
   wrong thing to do anyway. It overrides Emacs's default choice, which is
   (now) reasonable; and even worse, it overrides settings the user might
   have made in their '.emacs' file for that file extension. It's only
   useful when there's something specific about that particular file that
   makes a particular mode appropriate.

 - Correctly propagate settings that establish the correct indentation
   level for this file: c-basic-offset and js2-basic-offset should be
   js-indent-level. Whatever value they're given should be preserved;
   different parts of our tree use different indentation styles.

 - We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
   Remove tab-width: settings, at least in files that don't contain tab
   characters.

 - Remove js2-mode settings that belong in the user's .emacs file, like
   js2-skip-preprocessor-directives.
2014-06-24 22:12:07 -07:00
Marco Bonardo
a50da3e1dc Bug 754265 - Add a dedicated API to provide a final complete value different from the matching one, r=Enn sr=gavin 2014-04-18 16:04:19 +02:00
Marco Bonardo
1c5eccb65b Bug 720081 - Part 1: backportable solution for autocomplete controller to provide a different final defaultComplete value for typeAheadResults
r=gavin
2012-06-04 00:42:48 +02:00
Gervase Markham
cb6a072c2a Bug 716478 - update licence to MPL 2. 2012-05-21 12:12:37 +01:00
Masayuki Nakano
1f6df04cb6 Bug 720659 nsAutoCompletController should search with committed composition string at input event handler immediately after compositionend event rather than composition event handler feedback=mak+m_kato, r=gavin 2012-03-13 15:03:03 +09:00
Marco Bonardo
184853699f Bug 720792 - Implement a better solution to start selected searches without a timeout.
r=gavin
2012-03-01 14:37:13 +01:00
Marco Bonardo
78bcfa0fec Bug 720598 - nsAutocompleteController HandleKeyNavigation() and EnterMatch() call GetDefaultCompleteValue() with a bogus aResultIndex.
r=gavin
2012-01-26 00:54:27 +01:00
Marco Bonardo
78d1029b2a Bug 720066 - Tagging broken, cannot type in the tag field.
r=gavin
2012-01-24 20:37:44 +01:00
Michael Ventnor
178570bda1 Bug 660156 - Race condition between sync and async autocomplete searches.
r=mak
2012-01-19 12:31:20 +01:00
Michael Ventnor
6a29d2eb54 Bug 660592 - Allow autocomplete results to hide themselves from the popup.
r=mak sr=gavin
2012-01-19 12:31:19 +01:00
Felix Fung
811a1ae2df Bug 440866 - NO_MATCH in Multiple AutoComplete Searches Cancels Others. r=gavin 2011-11-16 02:36:02 -08:00
Joel Maher
39ca77fbd2 Bug 616999. Xpcshell manifest support; manifest files. r=ted, a=test-only 2011-05-20 11:54:01 -04:00
David Zbarsky
760888f99c Bug 556007 (2/3) - Use values from datalist in autocomplete popups. r=dolske ui-r=limi a2.0=sicking 2010-09-10 07:19:20 +02:00
Marco Bonardo
4b0c422ddd Bug 572800 - Ensure previous autocomplete query has been canceled before starting a new one. r=sdwilsh 2010-06-22 02:01:35 +02:00
Metal Sonic
259a398dae Bug 507387 - fix copyright holder; Mozilla Corporation -> Mozilla Foundation. r=gerv. 2009-12-21 21:50:30 +00:00
Jae-Seong Lee-Russo
d340b148b1 Toolkit tests that fail in js strict mode.
Bug 524781 - xpcshell-tests: turn on strict & werror by default.
r=benjamin.
2009-11-15 12:20:35 +01:00
Daniel Holbert
37cf5be52d Bug 473236 - Remove executable bit from files that don't need it. (Only changes file mode -- no code changes.) r=bsmedberg 2009-01-21 22:55:08 -08:00
Robert Sesek
df6f6c8aa5 Bug 463023 - nsIAutoCompleteController::searchStatus is initialized to 0, which is not a documented constant (nsAutoCompleteController::mSearchStatus); Unit test; r=gavin.sharp 2009-01-03 08:33:20 +01:00
Mark Banner
103516b017 Bug 438861 Autocomplete does not pass back previous results to a second search. r=enndeakin 2008-08-26 08:34:19 +01:00