Commit Graph

5 Commits

Author SHA1 Message Date
Francesco Pischedda
46c0d4af68 Bug 1280573 - Add testing/mozbase to flake8 linter: r=ahal
added testing/mozbase to tools/lint/flake8.lint
fixed a first batch of PEP8 errors/warnings

at first the commad autopep8 -i --max-line-length 99 -r -j 8 .
has been used to fix simpler problems, run from testing/mozbase

some of the issues can not easily fixed :
- undefined 'names' in code for example isLinux - isLinux and isBsd "fixed" with # noqa
- undefined 'message' resolved with return fmt.format(...
- undefined 'structured' resolved replacing those with mozlog
- long comments - some remaining - addressed with # noqa
- package level import everything - addressed with # flake8: noqa

restored testing/mozbase/mozdevice/mozdevice/Zeroconf.py
fixed issues reported on mozreview
fixed ')' in testing/mozbase/mozprocess/mozprocess/qijo.py imports
finally fixed multiline string at testing/mozbase/manifestparser/tests/test_manifestparser.py:114
^^^ and again, but now with ./mach python-test --path-only testing/mozbase/manifestparser/tests/test_manifestparser.py passing
fixed testing/mozbase/manifestparser/tests/test_convert_directory.py assert

fixed this error:
10:15:21     INFO -      return lambda line: stack_fixer_module.fixSymbols(line)
10:15:21     INFO -  TypeError: fixSymbols() takes exactly 2 arguments (1 given)

fixed two spaces lint error even of #  noqa comments
restored assignement to lambda with #  noqa to silence the lint error
global noqa for testing/mozbase/manifestparser/tests/test_filters.py
stupid is/is not error...

MozReview-Commit-ID: 1FpJF54GqIi
2016-09-30 16:08:37 +02:00
Andrew Halberstadt
1a6716a448 Bug 1157302 - [mozbase] Ignore unrecognized version strings when generating changelogs in versioninfo.py, DONTBUILD, r=armenzg 2015-04-22 11:49:34 -04:00
Armen Zambrano Gasparnian
951fbfb4e1 Bug 1048967. Allow versioninfo.py to run from any directory. DONTBUILD 2014-08-08 09:04:57 -04:00
Andrew Halberstadt
95845c1973 Bug 1045700 - Add ability to generate mozbase changelogs to versioninfo.py, r=wlach, DONTBUILD, a=NPOTB 2014-07-30 14:32:14 -04:00
Luv Agarwal
f37f5eaf64 Bug 974184 - Add a versioninfo utility for getting mozbase version info. r=wlach 2014-07-21 11:38:07 +02:00