Commit Graph

2 Commits

Author SHA1 Message Date
Phil Ringnalda
bf34d7ef12 Merge m-i to m-c, a=merge
MozReview-Commit-ID: EDVoIcyWOhi
2016-11-22 20:03:03 -08:00
Nicholas Nethercote
9994803f5a Bug 1315138 - gtestify storage/test/*.cpp. r=mak,erahm.
This change is mostly straightforward, except for the following.

- It removes all the printing from the do_check_* macros because gtest macros
  do appropriate printing.

- test_StatementCache.cpp needs some special gtest magic for the type
  parameterization.

- It merges the four tests in test_unlock_notify.cpp because they rely on being
  executed in order, and so aren't independent.

- storage_test_harness_tail.h is no longer necessary because gtest provides the
  test looping functionality.

- It uses #include and the preprocessor to remove the duplication between
  test_deadlock_detector.cpp and xpcom/tests/DeadlockDetector.cpp.

- It makes the test in test_service_init_background_thread.cpp a death test to
  force it to be the first storage gtest, because it fails otherwise.

- It adds code to undo the SQLite mutex hooking as necessary, so that tests
  don't interfere with each other.

- It de-virtualizes Spinner's destructor (as identified in bug 1318282).
2016-11-11 09:59:23 +11:00