Sylvestre Ledru
fe74f041a1
Bug 1338086 - Remove useless else blocks in order to reduce complexity in netwerk/ r=dragana
...
MozReview-Commit-ID: 2TSxhHWmL2H
2017-02-09 11:21:38 +01:00
Andi-Bogdan Postelnicu
2843f5a91e
Bug 1311669 - Replace integer literals which are cast to bool. r=valentin
...
MozReview-Commit-ID: LdvpF0mFA5V
2016-11-01 14:44:10 +02:00
Nicholas Nethercote
1009bf0056
Bug 1297658 - Avoid unnecessary checking in memory reporters. r=erahm.
...
This patch removes checking of all the callback calls in memory reporter
CollectReport() functions, because it's not useful.
The patch also does some associated clean-up.
- Replaces some uses of nsIMemoryReporterCallback with the preferred
nsIHandleReportCallback typedef.
- Replaces aCallback/aCb/aClosure with aHandleRepor/aData for CollectReports()
parameter names, for consistency.
- Adds MOZ_MUST_USE/[must_use] in a few places in nsIMemoryReporter.idl.
- Uses the MOZ_COLLECT_REPORT macro in all suitable places.
Overall the patch reduces code size by ~300 lines and reduces the size of
libxul by about 37 KiB on my Linux64 builds.
2016-08-24 15:23:45 +10:00
Nicholas Nethercote
00be432ea8
Bug 1247835 (part 1) - Use binary search instead of a hash table in nsEffectiveTLDService. r=jduell.
...
This saves 128 KiB of memory per process. It requires putting the eTLD entries
in sorted order.
2016-02-25 13:31:01 +11:00
Nicholas Nethercote
c7e2861268
Bug 1246013 (part 2) - Change "explicit/xpcom/effective-TLD-service" path to the more sensible "explicit/network/effective-TLD-service". r=jduell.
2016-02-05 11:31:28 +11:00
Nicholas Nethercote
f51c9db2bd
Bug 1246013 (part 1) - Store a copy of the ETLDEntry directly in DomainEntry instead of a pointer to it. r=jduell.
...
This reduces the size of nsEffectiveTLDService from 256 KiB to 128 KiB on
64-bit platforms.
2016-02-05 11:17:35 +11:00
Nicholas Nethercote
62022ea522
Bug 1189156 (part 2) - Don't use enumeration style for nsTHashtable::SizeOf{In,Ex}cludingThis(). r=erahm.
...
After this change, we have ShallowSizeOf{In,Ex}cludingThis(), which don't do
anything to measure children. (They can be combined with iteration to measure
children.)
And we still have the existing single-arg SizeOf{In,Ex}cluding() functions,
which work if the entry type itself defines SizeOfExcludingThis().
2015-07-29 01:50:52 -07:00
Ritu Kothari
9a75c8b3a8
Bug 1167410 - Removing an unused initialization. r=hurley
2015-06-26 15:33:00 +02:00
Emanuel Hoogeveen
b30abdc582
Bug 905127 - Part 1 - Make some functions from nsNetUtil not inline. r=jduell
2015-07-07 04:17:00 +02:00
Nicholas Nethercote
663b82ea3b
Bug 1050009 - Initialize pldhash tables with a length, not a capacity. r=roc.
...
* * *
imported patch rm-dummy-params
2014-08-06 06:31:21 -07:00
Nicholas Nethercote
7b107d5931
Bug 1010064 - Allow memory reports to be anonymized. r=bsmedberg.
2014-05-20 23:06:54 -07:00
Birunthan Mohanathas
eeb9aaaa94
Bug 900908 - Part 3: Change uses of numbered macros in nsIClassInfoImpl.h/nsISupportsImpl.h to the variadic variants. r=froydnj
2014-04-27 03:06:00 -04:00
Nicholas Nethercote
49912eb578
Bug 955942 (part 2) - Remove MemoryUniReporter. r=mccr8.
2013-12-07 22:09:10 -08:00
Birunthan Mohanathas
88a0348924
Bug 713082 - Part 2: Rename Util.h to ArrayUtils.h. r=Waldo
2013-12-08 21:52:54 -05:00
Nicholas Nethercote
0d8c64efcc
Bug 936964 (part 7, attempt 2) - Make lots of classes report their own memory consumption, instead of using a separate reporter class. r=mccr8,sr=bz.
...
* * *
Bug 936964 (part 7b) - Fix a use-after-free found by ASan.
2013-11-07 16:35:30 +11:00
Ehsan Akhgari
65aaebab72
Backed out 9 changesets (bug 943660, bug 936964) because of ASAN use-after-free crashes on browser-chrome and mochitest-other
...
Backed out changeset 85486c4aa3d8 (bug 936964)
Backed out changeset 25312eb71998 (bug 936964)
Backed out changeset 6dbb8333960c (bug 936964)
Backed out changeset da6465ad476f (bug 936964)
Backed out changeset a87ffc992f38 (bug 936964)
Backed out changeset 4ae3a61182db (bug 936964)
Backed out changeset 34e9c3137804 (bug 936964)
Backed out changeset fd1459e71585 (bug 936964)
Backed out changeset 3e8a701d8bdc (bug 943660)
Landed on a CLOSED TREE
2013-11-27 20:05:00 -05:00
Nicholas Nethercote
c363b9d028
Bug 936964 (part 7) - Make lots of classes report their own memory consumption, instead of using a separate reporter class. r=mccr8,sr=bz.
2013-11-07 16:35:30 +11:00
Jason Duell
bb47c440e0
Bug 934805 - Ensure client code passes in sane argument to baseDomain functions. r=hurley
2013-11-15 21:46:39 -05:00
Nicholas Nethercote
c7fbf6a742
Bug 910517 (3rd attempt) - Remove nsIMemoryReporter, and rename nsIMemoryMultiReporter as nsIMemoryReporter. r=mmcr8.
2013-08-27 16:24:51 -07:00
Robert O'Callahan
51222bdd45
Bug 910989. Remove nsTHashtable::Init, fallible allocation, and MT hashtables. r=ehsan,bsmedberg
2013-09-02 20:41:57 +12:00
Phil Ringnalda
6e1be50ee9
Back out 4537337759b7 (bug 910517) because nobody expects the talos inquisition
2013-09-04 22:42:06 -07:00
Nicholas Nethercote
d7fc3db766
Bug 910517 - Remove nsIMemoryReporter, and rename nsIMemoryMultiReporter as nsIMemoryReporter. r=mmcr8.
2013-08-27 16:24:51 -07:00
Nicholas Nethercote
ba1dd3a636
Bug 831193 (part 2) - Don't use NS_MEMORY_REPORTER_IMPLEMENT for the effective-tld-service reporter. r=michal.novotny.
2013-01-15 21:26:44 -08:00
Ehsan Akhgari
1ab9c7bcb4
Bug 895322 - Part 1: Replace the usages of MOZ_STATIC_ASSERT with C++11 static_assert; r=Waldo
...
This patch was mostly generated by running the following scripts on the codebase, with some
manual changes made afterwards:
# static_assert.sh
#!/bin/bash
# Command to convert an NSPR integer type to the equivalent standard integer type
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*/.hg*" \
! -wholename "obj-ff-dbg*" \
! -name nsXPCOMCID.h \
! -name prtypes.h \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.cc" \
-o -iname "*.mm" \) | \
xargs -n 1 `dirname $0`/assert_replacer.py #sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_STATIC_ASSERT static_assert
hg rev --no-backup mfbt/Assertions.h \
media/webrtc/signaling/src/sipcc/core/includes/ccapi.h \
modules/libmar/src/mar_private.h \
modules/libmar/src/mar.h
# assert_replacer.py
#!/usr/bin/python
import sys
import re
pattern = re.compile(r"\bMOZ_STATIC_ASSERT\b")
def replaceInPlace(fname):
print fname
f = open(fname, "rw+")
lines = f.readlines()
for i in range(0, len(lines)):
while True:
index = re.search(pattern, lines[i])
if index != None:
index = index.start()
lines[i] = lines[i][0:index] + "static_assert" + lines[i][index+len("MOZ_STATIC_ASSERT"):]
for j in range(i + 1, len(lines)):
if lines[j].find(" ", index) == index:
lines[j] = lines[j][0:index] + lines[j][index+4:]
else:
break
else:
break
f.seek(0, 0)
f.truncate()
f.write("".join(lines))
f.close()
argc = len(sys.argv)
for i in range(1, argc):
replaceInPlace(sys.argv[i])
2013-07-18 13:59:53 -04:00
Catalin Iacob
f88cdc0744
Bug 798914 (part 5) - Use newly introduced mozilla::MallocSizeOf instead of nsMallocSizeOfFun. r=njn.
2013-06-23 14:03:39 +02:00
Mounir Lamouri
3c456b3fe5
Bug 823175 - Add a method to return the next sub domain of a given host in nsIEffectiveTLDService. r=bz
2013-02-04 17:59:49 +00:00
Nicholas Nethercote
8a28a2740d
Bug 819819 (part 2) - Remove |name| from NS_MEMORY_REPORTER_MALLOC_SIZEOF_FUN. r=jlebar.
2012-12-23 16:59:51 -08:00
Nicholas Nethercote
546a64f11c
Bug 802894 - Add a memory reporter for nsEffectiveTLDService. r=jduell.
2012-10-19 05:07:13 -07:00
Ehsan Akhgari
57ec2ec569
Bug 792502 - Kill the FunctionTimer code; r=vlad
2012-09-19 16:59:38 -04:00
Nathan Froyd
864ece3f81
Bug 704848 - reduce space required by nsEffectiveTLDService with more preprocessing; r=jduell
2012-09-11 07:42:23 -04:00
Randell Jesup
3b4961b603
Bug 773151: Convert nsCAutoString->nsAutoCString CLOSED TREE r=bsmedberg
2012-09-01 22:35:17 -04:00
Ehsan Akhgari
243c878d26
Bug 579517 - Part 1: Automated conversion of NSPR numeric types to stdint types in Gecko; r=bsmedberg
...
This patch was generated by a script. Here's the source of the script for
future reference:
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*/.hg*" \
! -wholename "obj-ff-dbg*" \
! -name nsXPCOMCID.h \
! -name prtypes.h \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert PRInt8 int8_t
convert PRUint8 uint8_t
convert PRInt16 int16_t
convert PRUint16 uint16_t
convert PRInt32 int32_t
convert PRUint32 uint32_t
convert PRInt64 int64_t
convert PRUint64 uint64_t
convert PRIntn int
convert PRUintn unsigned
convert PRSize size_t
convert PROffset32 int32_t
convert PROffset64 int64_t
convert PRPtrdiff ptrdiff_t
convert PRFloat64 double
2012-08-22 11:56:38 -04:00
Aryeh Gregor
8b4a23fc4c
Bug 777292 part 2 - Change all nsnull to nullptr
2012-07-30 17:20:58 +03:00
Gervase Markham
cb6a072c2a
Bug 716478 - update licence to MPL 2.
2012-05-21 12:12:37 +01:00
Benjamin Smedberg
2b55dddfca
Bug 734847 part 2 - treewide changes resulting from the default-infallibility of hashtables; either remove useless result checks, or use the fallible version of APIs, depending on context, r=jlebar
2012-05-18 13:30:49 -04:00
Jeff Walden
7d613942b0
Bug 693469 - Implement mozilla::ArrayLength and mozilla::ArrayEnd, and replace uses of NS_ARRAY_LENGTH whenever possible. (Exceptions: assigning to static initializers, use in static assertions, as template parameters, etc. These will go away when the relevant compilers have C++11 constexpr support.) r=cjones
2011-10-10 22:50:08 -07:00
Jeff Walden
c5e5f873d1
Back out everything since 5435ee09cf7b. Tinderbox compilers hate me. r=epic-fail
2011-10-12 12:21:53 -07:00
Jeff Walden
946f2ae0e3
Bug 639469 - Implement mozilla::ArrayLength and mozilla::ArrayEnd, and replace uses of NS_ARRAY_LENGTH whenever possible. r=cjones
2011-10-10 22:50:08 -07:00
Michael Wu
0fe7772ece
Bug 675553 - Switch from PRBool to bool on a CLOSED TREE , r=bsmedberg,khuey,bz,cjones
2011-09-28 23:19:26 -07:00
Mitchell Field
bc63774d7e
Bug 542222 - Reduce recursion in netwerk makefiles.
2010-06-05 21:18:12 -04:00