Commit Graph

51 Commits

Author SHA1 Message Date
Mats Palmgren
683f0d5571 Bug 1348665 part 2 - Remove the ViewProperty and store the nsView* in a field on the relevant frame classes instead. r=tnikkel
The relevant frame classes are:
SubDocumentFrame
ListControlFrame (only when used for (non-e10s?) comboboxes)
PluginFrame
ViewportFrame
MenuPopupFrame

The view is now created in the frame's Init() method, except for
ViewportFrame which has its view assigned by the frame constructor
via a SetView() call.

MozReview-Commit-ID: 4O7Hm1yqwIp
2017-03-21 01:22:13 +01:00
Neil Deakin
bbadbd2016 Bug 1109868, panels should watch their anchors for position and visibility changes and update accordingly, r=tn 2017-02-16 08:53:59 -05:00
Ting-Yu Lin
88ba0449c7 Bug 1333366 Part 2 - Update legacy NS_SIDE usage and document. r=mats
Delete the "or 0 for no movement in that direction" from the CanAdjustEdges
document in nsMenuPopupFrame.h because the only caller in nsResizerFrame.cpp
never passes 0 to it.

MozReview-Commit-ID: 3A5A8O4MDn1
2017-01-24 18:41:56 +08:00
Neil Deakin
a95143ba64 Bug 1307793, pressing space when menulist is ofocused should perform incremental find select rather than open the menu, r=ksteuber 2016-10-12 09:18:08 -04:00
Neil Deakin
311fe3bbe7 Bug 1210328, compute correct flip state for popups, r=ksteuber 2016-10-11 14:13:36 -04:00
Kirk Steuber
2c1ac87580 Bug 1206133 - Add popuppositioning state and popuppositioned event to improve arrow panel position handling. r=enndeakin
MozReview-Commit-ID: Dh1npORCQ6J
2016-08-16 15:33:05 -07:00
Neil Deakin
24f1b04c80 Bug 52106, open menulist popup with selection over cursor, r=mstange 2016-08-11 10:37:25 -04:00
Neil Deakin
e8399e4841 Bug 1246089, don't rollup a menulist popup when alt is pressed, r=tn 2016-08-11 10:36:20 -04:00
Neil Deakin
4633a9395f Bug 1276976, ensure that popups are visible in the right area, r=tn, r=mrbkap 2016-06-09 11:34:12 -04:00
Carsten "Tomcat" Book
d4c54cdcf7 Backed out changeset e7a3ba795e1a (bug 1276976) for timeouts in browser_tableWidget_mouse_interaction.js on a CLOSED TREE 2016-06-09 15:28:22 +02:00
Neil Deakin
24322506d0 Bug 1276976, ensure that popups are visible in the right area, r=tn, r=mrbkap 2016-06-09 07:59:31 -04:00
Matt Woodrow
61200a9c5c Bug 1243610 - Refactor UpdateOverflow to separate out local overflow from that contributed by descendants. r=dbaron 2016-05-04 12:27:43 +12:00
Kyle Huey
a9cf047227 Bug 1265927: Move nsRunnable to mozilla::Runnable, CancelableRunnable to mozilla::CancelableRunnable. r=froydnj 2016-04-25 17:23:21 -07:00
Jonathan Kew
657b233fdc Bug 890156 - patch 6 - Update window placement code to work with desktop pixels, for per-monitor DPI support on Windows. r=emk 2015-12-03 13:19:50 +00:00
Nicholas Nethercote
4df71be42d Bug 1231256 (part 9) - Remove unused parameter from ShowPopup(). r=roc. 2015-12-08 20:04:37 -08:00
Nicholas Nethercote
c265db3570 Bug 1224482 (part 3) - Replace GetClientOffsetUntyped() with GetClientOffset(). r=kats.
The patch also changes nsMenuPopupFrame::mLastClientOffset to
LayoutDeviceIntPoint.
2015-11-13 01:37:02 -08:00
Nathan Froyd
4e6d8f6705 Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout.  The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.

CLOSED TREE makes big refactorings like this a piece of cake.

 # The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
    xargs perl -p -i -e '
 s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
 s/nsRefPtr ?</RefPtr</g;   # handle declarations and variables
'

 # Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h

 # Handle nsRefPtr.h itself, a couple places that define constructors
 # from nsRefPtr, and code generators specially.  We do this here, rather
 # than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
 # things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
     mfbt/nsRefPtr.h \
     xpcom/glue/nsCOMPtr.h \
     xpcom/base/OwningNonNull.h \
     ipc/ipdl/ipdl/lower.py \
     ipc/ipdl/ipdl/builtin.py \
     dom/bindings/Codegen.py \
     python/lldbutils/lldbutils/utils.py

 # In our indiscriminate substitution above, we renamed
 # nsRefPtrGetterAddRefs, the class behind getter_AddRefs.  Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
    xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'

if [ -d .git ]; then
    git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
    hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi
2015-10-18 01:24:48 -04:00
Botond Ballo
6beb696798 Bug 1205511 - Make nsMenuPopupFrame::MoveTo()'s arguments strongly typed. r=enn 2015-09-28 20:17:34 -04:00
Nick Robson
6fdd25c684 Bug 1075089 - Move popup menu frame offset to LookAndFeel and fix default offset for OS X. r=Enn 2015-08-04 16:41:00 -04:00
Carsten "Tomcat" Book
84ff5e7587 Backed out changeset 7edc58c272f1 (bug 1075089) for causing OS X 10.6 marionette failures in test_single_finger_desktop.py testSingleFingerMouse.test_double_tap on a CLOSED TREE 2015-07-31 14:49:40 +02:00
Nick Robson
d636d52e60 Bug 1075089 - Moved popup menu frame offset to LookAndFeel, fixed default offset for OS X. r=enn 2015-07-30 15:00:00 +02:00
Neil Deakin
9ea8ddc2f9 Bug 1182607, use the right rectangle for a popup anchored at a rectangle when determining if the mouse click was over the anchor, r=tn 2015-07-20 08:59:50 -04:00
Neil Deakin
ad2b72768e Bug 1149745, on Windows, menulist should select the value when the cursor keys are used to navigate items, r=neil 2015-06-26 09:32:25 -07:00
Neil Deakin
2db02a2ef7 Bug 873923, add a method to allow popups to be anchored at a rectangle, r=tn,mark,khuey 2015-05-08 14:49:54 -04:00
Neil Deakin
d876dd5296 Bug 250091, support page up and page down in menulists, r=neil 2015-05-20 13:11:06 -04:00
Andrea Marchesini
f0aa02df0b Bug 1156632 - Remove unused forward class declarations - patch 5 - rdf, parser, layout and something else, r=ehsan 2015-04-22 08:29:22 +02:00
Andrea Marchesini
ad97ae68b8 Bug 1148527 - Indentation fix after bug 1145631, r=ehsan 2015-03-27 18:52:19 +00:00
Ehsan Akhgari
ea41d8de48 Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
This patch was automatically generated using the following script:

function convert() {
echo "Converting $1 to $2..."
find . \
       ! -wholename "*/.git*" \
       ! -wholename "obj-ff-dbg*" \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
Timothy Nikkel
7d36d1c2cf Bug 1130400. Part 2. Use a reflow callback to set the position of xul popups. r=enndeakin
During reflow our frame, or any ancestors, may not yet be placed at their final position. So calculating the screen position of our popup during our reflow could produce incorrect results.

Instead post a reflow callback to do it after reflow is finished.
2015-03-19 23:55:33 -05:00
Masayuki Nakano
6a828735fb Bug 1119609 part.15 Fix new orange of test_menulist_keynav.xul because it's caused by timeout of incremental search in menu r=smaug+enn 2015-02-19 15:50:20 +09:00
David Zbarsky
389ecba2dc Bug 1125040: Use LayoutDeviceIntPoint for GetEventPoint r=botond 2015-02-01 17:27:41 -05:00
Neil Deakin
532cf1125b Bug 1089005, add a third consume option that never consumes even over the anchor. This allows clicks on the location field to adjust the caret position, r=dao 2015-01-09 21:12:10 -05:00
Mats Palmgren
6e2b90ea60 Bug 1116753 - Remove the nsIPresShell* param from remaining frame ctors that still have it. r=roc 2015-01-06 09:27:56 +00:00
Jon Morton
4a98f87acc Bug 979835: Port BoxObject and its subclasses to WebIDL. r=khuey sr=bz 2014-10-14 13:15:21 -07:00
Trevor Saunders
d67df400c1 bug 1047696 - mark a number of classes MOZ_FINAL to get compilers to devirtualize more r=froydnj 2014-08-05 13:33:55 -04:00
Neil Deakin
5413163459 Bug 1026310, set the open state only once the opening transition is finished, rename the internal popup states to be clearer, fix UITour.jsm to check the showing state, r=MattN,neil 2014-07-14 13:39:04 -04:00
Benoit Jacob
e530f599fc Bug 1035394 - Fix dangerous public destructors in layout - r=dbaron 2014-07-08 17:23:18 -04:00
Neil Deakin
879eb67976 Bug 994117, delay popupshown event until after the opening transition has finished, if one exists, which also fixes the issue causing bug 989991, so enable the animation on the main panel, r=neil 2014-06-16 14:43:07 -04:00
Mats Palmgren
6a38f78c53 Bug 1015781 - part 3, Fix whitespace and comments, and move some SetInitialChildList/AppendFrames/InsertFrames/RemoveFrame methods so that they are together in the file. r=roc 2014-05-28 19:36:58 +00:00
Mats Palmgren
a43fc7a0a3 Bug 1015781 - part 1+2, Make the SetInitialChildList/AppendFrames/InsertFrames/RemoveFrame methods return void (scripted change). Remove code handling the return values. r=roc 2014-05-28 19:36:58 +00:00
Mats Palmgren
bebbaf8351 Bug 508665 - part 5, Make nsIFrame::Init require a nsContainerFrame* for the parent frame param. r=roc 2014-05-24 22:20:40 +00:00
Daniel Holbert
4831ca068a Bug 919806 followup: Reindent method declarations affected by NS_IMETHOD-removal. (whitespace-only; no review) DONTBUILD 2014-02-18 00:36:33 -08:00
Arnaud Sourioux
c55abda61c Bug 919806: Get rid of NS_IMETHOD in nsIFrame.h and its implementations r=dholbert 2014-02-17 23:47:48 -08:00
Gijs Kruitbosch
026f28990b Bug 627974 - panels that aren't toplevel shouldn't overlap the taskbar, r=Enn 2014-02-07 17:35:09 +00:00
Neil Deakin
b313311aef Bug 943759, [Australis], support mousethrough on panels to allow mouse events to pass through to the content behind, implemented on Windows, Mac and Linux, use this for the UI tour highlight, r=neil,jmathies,karlt 2014-01-31 08:27:43 -05:00
Neil Deakin
e54318aa98 Bug 941409, add support for an anchor attribute to menus so that the popup can be anchored to a different element than the menu itself, this is used to avoid repositioning the bookmarks toolbar button menu, also changes popups to default to vertical orientation [Australis] r=neil,mconley 2014-01-28 11:28:45 -05:00
Matthew Noorenberghe
6dccb440af Bug 956162 - Implement @flip="none" for popups to allow them to appear off-screen without flipping or resizing. r=Enn
[Australis]
2014-01-22 20:09:03 +00:00
Mats Palmgren
a56486443d Bug 956447 - Make it possible to get frame dumps in non-DEBUG builds. r=roc 2014-01-05 23:31:14 +00:00
Robert O'Callahan
11bf1614c4 Bug 945091. Part 3: Flatten layout/xul/base/* into layout/xul. r=glandium 2013-12-04 14:06:16 +13:00
Carsten "Tomcat" Book
f9c1013575 Backed out changeset b5d2afd37164 (bug 945091) for mochitest-8 bustage on a CLOSED TREE 2013-12-04 09:23:39 +01:00