Commit Graph

1163 Commits

Author SHA1 Message Date
Jonathan Kew
b41d8c794d Bug 1174711 - patch 2 - Convert nsTableFrame to work with logical coordinates. r=dholbert 2015-06-22 10:33:34 +01:00
Jonathan Kew
ac7784827a Bug 1174711 - patch 1 - Rename nsIPercentHeightObserver to nsIPercentBSizeObserver, and update related frame methods to match. r=dholbert 2015-06-22 10:33:34 +01:00
Jonathan Kew
07b2930c0a Bug 1174700 - patch 2 - Convert nsTableFrame::SetColumnDimensions to work with logical-order iteration over the table, so that column coordinates and collapsed borders are correct. r=dholbert 2015-06-20 21:00:33 +01:00
Jonathan Kew
18d7a3a9d7 Bug 1174700 - patch 1 - Convert nsTableRowFrame and nsTableRowGroupFrame to work with logical coordinates. r=dholbert 2015-06-20 21:00:26 +01:00
L. David Baron
7c5f15af6a Back out changesets ed293fc9596c and f18cb4c41578 (bug 1174700) for fatal assertions in all Windows debug reftest runs.
CLOSED TREE

Assertion failure: origKidNormalPosition.B(wm) == 0, at c:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/src/layout/tables/nsTableRowFrame.cpp:861
TEST-UNEXPECTED-FAIL | file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/writing-mode/ua-style-sheet-size-1.html | application terminated with exit code 1
2015-06-20 22:41:07 -07:00
Jonathan Kew
10ed31cdc4 Bug 1174700 - patch 2 - Convert nsTableFrame::SetColumnDimensions to work with logical-order iteration over the table, so that column coordinates and collapsed borders are correct. r=dholbert 2015-06-20 21:00:33 +01:00
Jonathan Kew
7dca7a6c5c Bug 1174700 - patch 1 - Convert nsTableRowFrame and nsTableRowGroupFrame to work with logical coordinates. r=dholbert 2015-06-20 21:00:26 +01:00
Jonathan Kew
a45bc02094 Bug 1174507 - Replace the frame flag CONTAINS_RELATIVE_HEIGHT with CONTAINS_RELATIVE_BSIZE, and adjust callsites appropriately. r=dholbert 2015-06-18 07:33:50 +01:00
Jonathan Kew
bb98c1ac7e Bug 1157569 - part 12 - Convert physical values from BCPropertyData to logical when returning from Get[Included]OuterBCBorder. r=roc 2015-06-17 11:03:25 +01:00
Mats Palmgren
fcb056fcd4 Bug 1174450 part 9 - Remove the nsRenderingContext* param from Intrinsic*SizeOffsets methods since it's unused. r=jfkthame 2015-06-16 11:21:04 +00:00
Xidorn Quan
568d90647a Bug 1171328 - Convert nsTableFrame::GetChildAreaOffset() and its friends to use LogicalMargin. r=dholbert 2015-06-10 13:13:49 +12:00
Daniel Holbert
54f6107ac4 Bug 1169432 part 5: Use range-based 'for' loops when walking frame lists, in nsTableFrame. r=mats 2015-06-05 15:39:35 -07:00
Daniel Holbert
792104a41a Bug 1169432 part 4: Convert NS_ASSERTION(false, ...) to NS_ERROR(...) in nsTableFrame. r=mats 2015-06-05 15:39:27 -07:00
Daniel Holbert
6039aca337 Bug 1169432 part 3: Use nsTArray::Contains instead of nsTArray::IndexOf(), for brevity, in nsTableFrame. r=mats 2015-06-05 15:39:13 -07:00
Daniel Holbert
8e95f07f19 Bug 1169432 part 2: Refactor nsTableFrame::Init. r=mats 2015-06-05 15:39:06 -07:00
Simon Montagu
e6de936024 Bug 1147834: Use abstract coordinates in nsHTMLReflowState, r=jfkthame 2015-06-04 03:43:02 -07:00
Daniel Holbert
a98977f9e3 Bug 1167696 part 2: Remove nsTableReflowState's frame constructor-arg; get it from passed-in reflow state instead. r=mats 2015-05-25 19:43:50 -07:00
Daniel Holbert
df337b594f Bug 1167696 part 1: Remove nsTableReflowState's unused constructor & nsPresContext arg. r=mats 2015-05-25 19:43:10 -07:00
Daniel Holbert
19946c390c Bug 1167765: Misc whitespace cleanup in nsTableFrame.cpp. whitespace/rewrapping-only, no review, DONTBUILD 2015-05-22 14:23:44 -07:00
Xidorn Quan
0a2bdb61ae Bug 1159127 - Always redirect inserting col group frame to first-in-flow table frame. r=mats 2015-05-20 13:29:43 +12:00
Xidorn Quan
a95c207636 Bug 1157569 part 12 - Remove useless m{Start,End}Side from BCMapCellInfo. r=roc 2015-05-04 19:09:25 +12:00
Xidorn Quan
77350f9bef Bug 1157569 part 11 - Rename methods and fields in nsTableCellFrame from physicals to logicals. r=roc 2015-05-04 19:09:25 +12:00
Xidorn Quan
059b18f863 Bug 1157569 part 9 - Rename methods and fields in nsTableRowFrame from physicals to logicals. r=roc 2015-05-04 19:09:25 +12:00
Xidorn Quan
610e73078d Bug 1157569 part 8 - Move some code in BCPaintBorderIterator::SetDamageArea for less computation. r=roc 2015-05-04 19:09:25 +12:00
Xidorn Quan
f1fda36c8e Bug 1157569 part 7 - Rename methods and fields in nsTableColFrame from physicals to logicals. r=roc 2015-05-04 19:09:25 +12:00
Xidorn Quan
795fbd02c8 Bug 1157569 part 6 - Rename methods and fields in BCMapCellInfo from physicals to logicals. r=roc 2015-05-04 19:09:25 +12:00
Xidorn Quan
d42c72a22b Bug 1157569 part 5 - Convert GetColorAndStyle, GetPaintStyleInfo, and CompareBorders in nsTableFrame to accept writing mode and logical side. r=roc
This changes behavior of border collapse on RTL tables, but it seems
that there is no test coverage on those cases, and those cases should
have been broken before, due to the mix of m{Start,End}side and
physical sides in the methods. Hence this change should be fine, as
long as we are going to fix it in later patches.
2015-05-04 19:09:25 +12:00
Xidorn Quan
94e77d04ad Bug 1157569 part 4 - Replace mTableIsLTR with mTableWM in BCMapCellInfo & BCPaintBorderIterator. r=roc 2015-05-04 19:09:25 +12:00
Xidorn Quan
948a00255c Bug 1157569 part 3 - Merge two GetColorAndStyle functions in nsTableFrame. r=roc 2015-05-04 19:09:25 +12:00
Xidorn Quan
63ba89f0cb Bug 1157569 part 2 - Convert output parameters of GetColorAndStyle/GetPaintStyleInfo in nsTableFrame to use pointers. r=roc 2015-05-04 19:09:25 +12:00
Xidorn Quan
42729f13dc bug 1157569 part 1 - Rename BC_BORDER_{TOP,RIGHT,BOTTOM,LEFT}_HALF* to BC_BORDER_{START,END}_HALF*. r=roc 2015-05-04 19:09:25 +12:00
Xidorn Quan
e645ff916c Bug 1159990 - Add TableArea struct and replace nsIntRect with it for table damage area. r=roc 2015-05-01 09:46:59 +12:00
Daniel Holbert
ebd37b4c23 Bug 1155880 part 3: Rename nsTableFrame::GetColumnWidth to use "ISize" instead of "Width". r=jfkthame 2015-04-18 16:01:27 -07:00
Daniel Holbert
678cdc970f Bug 1155880 part 2: Rename nsTableColFrame Get/Set/ResetFinalWidth methods to use "ISize" instead of "Width". r=jfkthame 2015-04-18 16:01:26 -07:00
Daniel Holbert
bf5b274e01 Bug 1155880 part 1: Rename nsITableLayoutStrategy::ComputeColumnWidths and associated comments to use "ISize" instead of "Width". r=jfkthame 2015-04-18 16:01:24 -07:00
Daniel Holbert
709b4256c5 Bug 1155798: Drop end-of-line whitespace from C++ files in layout/tables. (whitespace-only, no review, DONTBUILD) 2015-04-17 11:42:05 -07:00
Mats Palmgren
0280e62037 Bug 1143299 - Make frame insertion methods deal with aPrevFrame being on an overflow list. r=roc a=abillings 2015-04-11 00:21:06 +00:00
Mats Palmgren
cf8f0fef50 Bug 1148833 part 4 - Fix indentation of some Reflow params (white-space changes only). 2015-03-29 22:38:40 +00:00
Mats Palmgren
3f92be8fe8 Bug 1148833 part 3 - Remove nsIFrame::WillReflow and add a non-virtual MarkInReflow method instead that sets NS_FRAME_IN_REFLOW. Call it at the start of Reflow(). r=roc 2015-03-29 22:38:40 +00:00
Ehsan Akhgari
ea41d8de48 Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
This patch was automatically generated using the following script:

function convert() {
echo "Converting $1 to $2..."
find . \
       ! -wholename "*/.git*" \
       ! -wholename "obj-ff-dbg*" \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
Xidorn Quan
ab7b34f1a6 Bug 1145036 part 2 - Rename nsTableFrame::GetCellSpacingX/Y to GetCol/RowSpacing. r=roc 2015-03-20 15:16:00 +11:00
Xidorn Quan
0c0ada3dd4 Bug 1145036 part 1 - Rename mBorderSpacingX/Y to mBorderSpacingCol/Row. r=heycam 2015-03-20 15:16:00 +11:00
Robert O'Callahan
fc5dc44a74 Bug 1082249. Invalidate background-attachment:fixed table-part backgrounds when scrolled. r=mattwoodrow 2015-03-05 00:02:14 +13:00
L. David Baron
7eecc9396d Bug 992077 patch 4 - Stop using OverflowChangedTracker::CHILDREN_AND_PARENT_CHANGED for the overflow area updates dealing with absolutely positioned elements contained by relatively positioned table parts. r=mats
The old code here was also updating overflow areas on more frames than
needed.  (Using CHILDREN_CHANGED on positionedPart itself causes test
failures because positionedPart's overflow area doesn't change in the
overflow updating process, so no overflow change is propagated to the
parent; it's the parent that actually needs the update.)
2015-02-16 16:34:29 +13:00
Seth Fowler
2488118ac6 Bug 1128769 (Part 4) - Record the last draw result when drawing CSS tables and use it to decide whether to sync decode. r=tn 2015-02-05 20:45:56 -08:00
Markus Stange
9d2d6e128b Bug 1130817 - Refactor nsTablePainter a little. r=roc
This patch makes the following changes:
 - Ownership of the col groups' TableBackgroundData has moved into the mColGroups array.
 - nsStyleBorder instances for painting are created on the stack instead of in the allocation
   arena of the pres context, so now we no longer need to call Destroy on them.
 - Not having to call Destroy lets us get rid of a lot of destruction code.
 - TableBackgroundData for the current row group and the current row no longer live in
   member variables of nsTablePainter. They're now on the stack and get passed to the
   methods that need them as usual.
 - All methods now return void instead of nsresult.
 - TableBackgroundData instances are no longer reused.
2015-02-08 01:35:58 -05:00
Seth Fowler
72fb0505de Bug 1128356 - Add template functions for common frame property destructors. r=dbaron 2015-02-04 15:22:27 -08:00
Seth Fowler
38ce6b10a2 Bug 35168 (Part 2) - Allow relative positioning of internal table objects. r=dbaron 2014-08-19 18:24:58 -07:00
Jonathan Kew
cdf9a3916d Bug 1077528 - part 1 - Provide physical and logical accessors for the m{HV}Resize flags in nsHTMLReflowState, and convert all flag users to the accessor methods. r=smontagu 2014-11-28 09:44:02 +00:00
Mats Palmgren
567ed3a34f Bug 907396 - Replace GetParentStyleContextFrame with GetParentStyleContext which can return frame-less display:contents style contexts. r=bzbarsky 2014-11-20 18:24:10 +00:00