L. David Baron
db0eccb0ed
Bug 1209603 patch 6 - Prepare to use a different meaning of mBits when cached style data pointer is null. r=heycam
...
We currently only use the style struct bits in mBits when the style
context has the relevant struct cached. The bit being set indicates
whether or not the context owns the struct.
This patch conditions the necessary tests on a cached struct being
present so that we can use (for reset structs, i.e., those with
non-inherited properties) mBits to mean something different when the
cached storage is null.
2015-10-19 20:42:28 -07:00
L. David Baron
7c87b0f1ff
Bug 1209603 patch 5 - Move inline method nsStyleContext::GetCachedStyleData into header file, and make it public. r=heycam
...
Moving it to the header allows its use by another method in the header
file, in patch 6.
Making it public allows its use in assertions in nsRuleNode in patch 7.
2015-10-19 20:42:28 -07:00
Nathan Froyd
4e6d8f6705
Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat
...
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout. The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.
CLOSED TREE makes big refactorings like this a piece of cake.
# The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
xargs perl -p -i -e '
s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
s/nsRefPtr ?</RefPtr</g; # handle declarations and variables
'
# Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h
# Handle nsRefPtr.h itself, a couple places that define constructors
# from nsRefPtr, and code generators specially. We do this here, rather
# than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
# things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
mfbt/nsRefPtr.h \
xpcom/glue/nsCOMPtr.h \
xpcom/base/OwningNonNull.h \
ipc/ipdl/ipdl/lower.py \
ipc/ipdl/ipdl/builtin.py \
dom/bindings/Codegen.py \
python/lldbutils/lldbutils/utils.py
# In our indiscriminate substitution above, we renamed
# nsRefPtrGetterAddRefs, the class behind getter_AddRefs. Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'
if [ -d .git ]; then
git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi
2015-10-18 01:24:48 -04:00
Cameron McCormack
02af9911ab
Bug 1203766 - Part 3: Add ArenaRefPtr support to nsStyleContext. r=bzbarsky
2015-09-17 12:08:20 +10:00
Cameron McCormack
2092fefbc0
Bug 1203766 - Part 1: Generate nsPresArena::ObjectIDs with a preprocessor-included file. r=bzbarsky
2015-09-17 12:08:19 +10:00
Jonathan Kew
a3c9aff814
Bug 1188061 - Pass the style context to nsStylePosition::CalcDifference so that it can take account of writing-mode where necessary. r=dbaron
2015-09-09 12:22:02 +01:00
Cameron McCormack
b73cb02f51
Bug 1180120 - Part 6: Replace HasSameCachedStyleData call with samePointerStructs bit tests. r=dbaron
2015-08-29 06:13:47 +10:00
Cameron McCormack
1e174425a6
Bug 1180120 - Part 4: Add an outparam to CalcStyleDifference to indicate which struct pointers were identical. r=dbaron
2015-08-29 06:13:47 +10:00
Cameron McCormack
a48f1c4303
Bug 1180120 - Part 2: Move style-if-visited as well in nsStyleContext::Move (and assert that its parent is the same as the non-visited-style parent). r=dbaron
2015-08-29 06:13:47 +10:00
Cameron McCormack
94ce92f8b1
Bug 1180120 - Part 1: Record on style contexts that reset style is explicitly inherited. r=dbaron
2015-08-29 06:13:47 +10:00
Seth Fowler
9e1c1d7b72
Bug 1181907 (Part 3) - Add CSSVariableImageTable and use it to store ImageValues generated by CSS variables. r=heycam
2015-08-26 18:19:38 -07:00
Jonathan Kew
70d4cbfc18
Bug 1196887 - Compare the writing-mode property, not only whether it is horizontal or vertical, when deciding whether to compute display:inline as inline-block. r=dholbert
2015-08-21 09:55:43 +01:00
L. David Baron
602fc5dd3d
Bug 1169440 patch 2 - Rename style struct MaxDifferenceNeverInherited to DifferenceAlwaysHandledForDescendants. r=heycam
...
This was added in bug 897763, but the current name no longer makes sense
in the context of the renaming in 2d8810ba0412 (bug 779968, patch 4).
(I think the old name was also missing a negation -- it meant hints that
were never *non*-inherited.)
2015-06-20 21:54:15 -07:00
Mats Palmgren
29ea64f952
Bug 817406 part 1 - Let ApplyStyleFixups propogate 'direction' to the viewport. r=bz,heycam
2015-05-27 22:18:36 +00:00
Phil Ringnalda
8d133af525
Back out 2 changesets (bug 817406) for b2g reftest-7 bustage
...
CLOSED TREE
Backed out changeset 1499a08f564a (bug 817406)
Backed out changeset d2f3cb3c0233 (bug 817406)
2015-05-27 19:11:54 -07:00
Kang-Hao (Kenny) Lu
785ae1714b
Bug 817406 (part 1) - Let ApplyStyleFixups propogate 'direction' to the viewport. r=bz,heycam
2015-05-27 22:18:36 +00:00
Xidorn Quan
166f3b8ee1
Backout df7c88910f47 (bug 1149009) for new patch.
2015-05-04 09:52:53 +12:00
Cameron McCormack
451d0971f1
Bug 1157097 - Don't share a style context that will have its cached style data cleared. r=dbaron
2015-04-29 14:47:15 +10:00
Xidorn Quan
620ba06ad6
Bug 1157011 - Check line break suppression of BR frame from its parent frame. r=dholbert
2015-04-23 13:32:53 +12:00
Xidorn Quan
081671c691
Bug 1149009 - Fix line break suppression on whitespace not contained but wrapped in ruby boxes. r=dbaron
2015-04-20 15:04:09 +12:00
Cameron McCormack
8831bbdf85
Bug 1154149 - Remove nsPresContext arguments from a bunch of nsStyleSet methods. r=dbaron
2015-04-17 11:09:59 +10:00
Xidorn Quan
f6eafdd98a
Bug 1141931 part 1 - Compute unicode-bidi property to proper values for ruby boxes. r=heycam
2015-04-08 11:22:34 +12:00
Wes Kocher
95d8beba17
Backed out 10 changesets (bug 1141931) for mochitest-5 failures CLOSED TREE
...
Backed out changeset c90940067de6 (bug 1141931)
Backed out changeset 96b48288abab (bug 1141931)
Backed out changeset 87281c7ded34 (bug 1141931)
Backed out changeset 6a914ba0b8ec (bug 1141931)
Backed out changeset 9cfea55b5e95 (bug 1141931)
Backed out changeset f432612b6475 (bug 1141931)
Backed out changeset 48cf9568a4b1 (bug 1141931)
Backed out changeset f1ab848b3fa6 (bug 1141931)
Backed out changeset 8a3c71a3b525 (bug 1141931)
Backed out changeset 119d3c0fd0f6 (bug 1141931)
2015-04-07 14:23:57 -07:00
Xidorn Quan
d7245a0b2a
Bug 1141931 part 1 - Compute unicode-bidi property to proper values for ruby boxes. r=heycam
2015-04-08 08:40:31 +12:00
Jonathan Kew
9425040943
Bug 1134849 - For display:inline elements whose writing mode is orthogonal to their parent's, the computed value should become inline-block. r=dbaron
2015-03-20 08:12:49 +00:00
Kartikaya Gupta
9bac07c5c8
Bug 962594 - Don't build CSS animations for elements that are in a display:none subtree. r=heycam
2015-03-15 20:28:49 -04:00
Xidorn Quan
8a816a119b
Bug 1141919 - Fix incomplete line break suppression in ruby. r=dbaron
2015-03-14 16:29:06 +11:00
Xidorn Quan
63683132d2
Bug 1140264 part 3 - Rename IsInlineDescendantOfRuby to ShouldSuppressLineBreak and exclude rbc/rtc from it. r=dbaron
2015-03-11 10:28:21 +11:00
Mats Palmgren
e74c8d0d9e
Bug 1140198 - display:contents on the root element (but not else-where) should compute to 'block'. r=roc
2015-03-07 14:35:02 +00:00
Cameron McCormack
d94f438bcd
Bug 1139723 - Turn on expensive style struct assertions for 1136010-1.html, and fix pref name typo. r=dbaron
2015-03-05 14:46:18 +11:00
Cameron McCormack
08a3db8571
Bug 1139272 - Allow expensive style context assertions to be enabled with a pref. r=dbaron
2015-03-05 12:48:45 +11:00
Xidorn Quan
aed9d1d538
Bug 1135954 part 2 - Make GetUniqueStyleData private and remove no longer used unique cases. r=heycam
2015-02-26 16:18:15 +11:00
Xidorn Quan
62d217fa6d
Bug 1135954 part 1 - Create empty border/padding style struct for rbc/rtc. r=heycam
2015-02-26 16:18:15 +11:00
Cameron McCormack
3981abdd93
Bug 1127198 - Part 2: Assert if we clear cached structs on a style context still used by a frame. r=dbaron
2015-02-18 09:28:53 +11:00
Cameron McCormack
09fd736766
Bug 1127198 - Part 1: Add a DEBUG-only count of frames that use a style context. r=dbaron
2015-02-18 09:28:53 +11:00
Nicholas Nethercote
0247de46d8
Bug 1127201 (attempt 2, part 1) - Replace most NS_ABORT_IF_FALSE calls with MOZ_ASSERT. r=Waldo.
2015-02-09 14:34:50 -08:00
Xidorn Quan
4aca1a3913
Bug 1122781 part 4 - Add runtime dependency check of style structs. r=dbaron
...
This patch adds a mechanism to check struct computation against a known set of non-cyclic dependencies.
The checks are only done when we get a struct on a context during computation of a struct on the same context.
2015-02-07 13:25:21 +11:00
Xidorn Quan
44edc32f91
Bug 1122781 part 3 - Restyle member initializer list of nsStyleContext. r=dbaron
2015-02-07 13:25:21 +11:00
Xidorn Quan
db22e7d575
Bug 1122781 part 2 - Generate dependencies table of style structs for runtime check. r=dbaron
2015-02-07 13:25:21 +11:00
Andrew McCreight
e048a7df33
Back out Bug 1127201 (part 2) for various problems.
2015-02-06 15:04:32 -08:00
Nicholas Nethercote
40ab0270d5
Bug 1127201 (part 2) - Convert all NS_ABORT_IF_FALSE calls to MOZ_ASSERT. r=Waldo.
2015-02-04 20:05:36 -08:00
Julian Seward
5abddd758d
Bug 1122375 - Fixes to avoid Valgrind false positives with gcc-4.9.x -O2 builds (part 2). r=dbaron.
2015-01-20 10:43:55 +01:00
Cameron McCormack
b6af6d3b71
Bug 649142 - Part 5: Convert logical border properties. r=dbaron
2015-01-17 15:16:02 +11:00
Xidorn Quan
247b44337e
Bug 1055667 part 4 - Compute border/padding to zero for rbc & rtc. r=dbaron
2015-01-15 20:02:11 +11:00
Xidorn Quan
6ed01ce159
Bug 1114792 - Rename nsStyleContext::IsDirectlyInsideRuby to IsInlineDescendantOfRuby. r=dbaron
2014-12-31 16:39:43 +11:00
Phil Ringnalda
d866ff0386
Back out 9 changesets (bug 649142)
...
Backed out changeset 936703c75200 (bug 649142)
Backed out changeset b0252d2620d8 (bug 649142)
Backed out changeset 69ddb2036c50 (bug 649142)
Backed out changeset 67748675e669 (bug 649142)
Backed out changeset 15ed55c61f4e (bug 649142)
Backed out changeset 35c42cd138e1 (bug 649142)
Backed out changeset 1335630cf287 (bug 649142)
Backed out changeset b5725cd39a31 (bug 649142)
Backed out changeset b0eb691d6695 (bug 649142)
2014-12-30 20:04:20 -08:00
Cameron McCormack
73cc5f23f0
Bug 649142 - Part 5: Convert logical border properties. r=dbaron
2014-12-31 12:18:15 +11:00
Mats Palmgren
26063830d9
Bug 1109571 part 4 - Frame construction bits to create the appropriate frame tree for table captions. r=roc
...
Note that this also makes IsPositioned() table captions be abs.pos.
containers, which was broken before.
2014-12-26 07:21:32 +00:00
Xidorn Quan
5e38b50d8b
Bug 1098275 - Inlinize block-level boxes inside ruby. r=heycam
2014-12-11 09:26:18 +11:00
L. David Baron
5f44a2ccdd
Bug 1100773 patch 4 - Fix nonunified build bustage.
2014-11-26 23:39:43 -08:00