Boris Zbarsky
07ac6be52e
Bug 851892 part 12. Convert CSSStyleRule to WebIDL. r=peterv,heycam,mccr8
...
The .style PutForwards bit is coming along for the ride; I did check that Chrome
already implements this, so we're not the only ones.
2017-01-13 10:41:03 -05:00
Boris Zbarsky
fcffc1fbb1
Bug 851892 part 8. Get rid of css::Rule::GetDOMRule. r=heycam
2017-01-13 10:41:03 -05:00
Boris Zbarsky
7f8371f7b5
Bug 851892 part 7. Push the nsIDOMCSSRule implementation up to css::Rule. r=heycam
2017-01-13 10:41:02 -05:00
Boris Zbarsky
fc5565f322
Bug 851892 part 5. Get rid of DOMCSSStyleRule. r=heycam,smaug
2017-01-13 10:41:02 -05:00
Boris Zbarsky
29566dfbe6
Bug 851892 part 4. Make css::Rule wrappercached. r=heycam,peterv,smaug
...
Note that this increases the size of css::Rule by three words, unfortunately.
2017-01-13 10:41:02 -05:00
Boris Zbarsky
b6afec6f99
Bug 851892 part 2. Remove the now-unused GetExistingDOMRule method. r=heycam
2017-01-13 10:41:02 -05:00
Boris Zbarsky
e152128ba1
Bug 851892 part 1. Make all CSS rules cycle-collected. r=heycam,smaug
2016-11-30 18:18:14 -05:00
Sebastian Hengst
f7032ba0ea
Backed out changeset 9a4b96c10b23 (bug 851892) for build bustage. r=backout on a CLOSED TREE
2017-01-20 19:31:31 +01:00
Sebastian Hengst
2520f8d517
Backed out changeset 795ebf4423ba (bug 851892)
2017-01-20 19:30:59 +01:00
Sebastian Hengst
189192c717
Backed out changeset 3be6690b9f0a (bug 851892)
2017-01-20 19:30:50 +01:00
Sebastian Hengst
5e849aeb34
Backed out changeset 2c2afe732553 (bug 851892)
2017-01-20 19:30:46 +01:00
Sebastian Hengst
d61de95f28
Backed out changeset 659550973d4d (bug 851892)
2017-01-20 19:30:37 +01:00
Sebastian Hengst
4249f1e162
Backed out changeset 9ef39356f62c (bug 851892)
2017-01-20 19:30:32 +01:00
Sebastian Hengst
7cab842632
Backed out changeset 31103a03f2c2 (bug 851892)
2017-01-20 19:30:14 +01:00
Boris Zbarsky
f7f00f8c97
Bug 851892 part 12. Convert CSSStyleRule to WebIDL. r=peterv,heycam,mccr8
...
The .style PutForwards bit is coming along for the ride; I did check that Chrome
already implements this, so we're not the only ones.
2017-01-13 10:41:03 -05:00
Boris Zbarsky
4bc1b026f0
Bug 851892 part 8. Get rid of css::Rule::GetDOMRule. r=heycam
2017-01-13 10:41:03 -05:00
Boris Zbarsky
4f6f6ad215
Bug 851892 part 7. Push the nsIDOMCSSRule implementation up to css::Rule. r=heycam
2017-01-13 10:41:02 -05:00
Boris Zbarsky
984aca29bc
Bug 851892 part 5. Get rid of DOMCSSStyleRule. r=heycam,smaug
2017-01-13 10:41:02 -05:00
Boris Zbarsky
a482993f9b
Bug 851892 part 4. Make css::Rule wrappercached. r=heycam,peterv,smaug
...
Note that this increases the size of css::Rule by three words, unfortunately.
2017-01-13 10:41:02 -05:00
Boris Zbarsky
88629f0774
Bug 851892 part 2. Remove the now-unused GetExistingDOMRule method. r=heycam
2017-01-13 10:41:02 -05:00
Boris Zbarsky
7d2cf86b2f
Bug 851892 part 1. Make all CSS rules cycle-collected. r=heycam,smaug
2016-11-30 18:18:14 -05:00
Phil Ringnalda
7646bbe020
Backed out 20 changesets (bug 851892) for load failures in Android crashtest-4
...
Backed out changeset b9c4115cdeac (bug 851892)
Backed out changeset 5f491bf49b85 (bug 851892)
Backed out changeset 9bf5bcb3e8c5 (bug 851892)
Backed out changeset a9cab46e8b45 (bug 851892)
Backed out changeset 73858e15c8c0 (bug 851892)
Backed out changeset a25638588b6b (bug 851892)
Backed out changeset d58e0e5069ef (bug 851892)
Backed out changeset d8da2a3d8f10 (bug 851892)
Backed out changeset a8da3c34983f (bug 851892)
Backed out changeset 29cf8acbd21e (bug 851892)
Backed out changeset c53cd7bdf8b3 (bug 851892)
Backed out changeset e841a2796375 (bug 851892)
Backed out changeset 2eab85b00159 (bug 851892)
Backed out changeset ca4b1fb9cae4 (bug 851892)
Backed out changeset 74c0ba66f108 (bug 851892)
Backed out changeset 719bb9f41e5b (bug 851892)
Backed out changeset d6aa4c6192df (bug 851892)
Backed out changeset dc81a167a75d (bug 851892)
Backed out changeset 65422477b3a5 (bug 851892)
Backed out changeset 3089dd379077 (bug 851892)
2017-01-15 11:50:10 -08:00
Boris Zbarsky
f05d96e7f9
Bug 851892 part 12. Convert CSSStyleRule to WebIDL. r=peterv,heycam,mccr8
...
The .style PutForwards bit is coming along for the ride; I did check that Chrome
already implements this, so we're not the only ones.
2017-01-13 10:41:03 -05:00
Boris Zbarsky
7f8d92e598
Bug 851892 part 8. Get rid of css::Rule::GetDOMRule. r=heycam
2017-01-13 10:41:03 -05:00
Boris Zbarsky
e154eae044
Bug 851892 part 7. Push the nsIDOMCSSRule implementation up to css::Rule. r=heycam
2017-01-13 10:41:02 -05:00
Boris Zbarsky
400aea3a90
Bug 851892 part 5. Get rid of DOMCSSStyleRule. r=heycam
2017-01-13 10:41:02 -05:00
Boris Zbarsky
f99593acd9
Bug 851892 part 4. Make css::Rule wrappercached. r=heycam,peterv
...
Note that this increases the size of css::Rule by three words, unfortunately.
2017-01-13 10:41:02 -05:00
Boris Zbarsky
0ab3477edd
Bug 851892 part 2. Remove the now-unused GetExistingDOMRule method. r=heycam
2017-01-13 10:41:02 -05:00
Boris Zbarsky
83cfd06680
Bug 851892 part 1. Make all CSS rules cycle-collected. r=heycam
2016-11-30 18:18:14 -05:00
Boris Zbarsky
17194e597d
Back out bug 851892 for Windows build bustage on CLOSED TREE
2017-01-13 11:47:22 -05:00
Boris Zbarsky
32646c89a8
Bug 851892 part 12. Convert CSSStyleRule to WebIDL. r=peterv,heycam,mccr8
...
The .style PutForwards bit is coming along for the ride; I did check that Chrome
already implements this, so we're not the only ones.
2017-01-13 10:41:03 -05:00
Boris Zbarsky
f5cfc1f710
Bug 851892 part 8. Get rid of css::Rule::GetDOMRule. r=heycam
2017-01-13 10:41:03 -05:00
Boris Zbarsky
9fda0e1e72
Bug 851892 part 7. Push the nsIDOMCSSRule implementation up to css::Rule. r=heycam
2017-01-13 10:41:02 -05:00
Boris Zbarsky
b109cb4adc
Bug 851892 part 5. Get rid of DOMCSSStyleRule. r=heycam
2017-01-13 10:41:02 -05:00
Boris Zbarsky
71bd55efef
Bug 851892 part 4. Make css::Rule wrappercached. r=heycam,peterv
...
Note that this increases the size of css::Rule by three words, unfortunately.
2017-01-13 10:41:02 -05:00
Boris Zbarsky
1c28981bb9
Bug 851892 part 2. Remove the now-unused GetExistingDOMRule method. r=heycam
2017-01-13 10:41:02 -05:00
Boris Zbarsky
5865c43716
Bug 851892 part 1. Make all CSS rules cycle-collected. r=heycam
2016-11-30 18:18:14 -05:00
Xidorn Quan
2d70bdcd07
Bug 1307357 part 1 - Make css::Rule hold StyleSheet rather than CSSStyleSheet. r=heycam
...
MozReview-Commit-ID: JsJa4YqpCZy
2016-11-23 10:26:20 +11:00
Boris Chiou
37ef670bc3
Bug 1250820 - Part 2: Replace nsCSSPseudoClasses::Type with CSSPseudoClassType. r=heycam
...
MozReview-Commit-ID: 6w4SoaS7gRi
2016-04-22 21:38:46 +08:00
Boris Chiou
3272ec4b93
Bug 1244049 - Part 3: Replace the type of nsCSSSelector::mPseudoType. r=dbaron
2016-02-17 22:04:00 +01:00
Boris Chiou
32cdf253b7
Bug 1244049 - Part 2: Replace nsCSSPseudoElements::Type with CSSPseudoElementType. r=dbaron
...
Also, try to use forward declaraions for CSSPseudoElementType;
2016-02-17 21:37:00 +01:00
Boris Chiou
16edfa82cd
Bug 1244049 - Part 1: Define scoped enum for CSSPseudoElement type. r=dbaron
2016-02-16 23:07:00 +01:00
Boris Zbarsky
5f9c2dc762
Bug 888190. Implement case-insensitive attribute value selectors from Selectors 4. r=dbaron
2016-01-26 14:55:52 -05:00
L. David Baron
6deea63527
Bug 1221436 patch 6 - Remove mechanism for replacing style rules. r=heycam
...
This is no longer used, thanks to patch 5.
2015-11-09 15:57:17 +08:00
L. David Baron
68a4959099
Bug 1221436 patch 5 - Stop generating new style rules in DeclarationChanged (and rename it to SetDeclaration), since we no longer need a new style rule for nsIStyleRule identity rules. r=heycam
...
(I think the change DOMCSSDeclarationImpl::GetCSSDeclaration fixes a
purely theoretical bug that would happen if it were possible to get
ahold of a CSS rule without calling either
CSSStyleSheet::EnsureUniqueInner (which is called by
CSSRuleListImpl::IndexedGetter) or Declaration::SetImmutable (which is
called by rule matching, including that triggered by
inIDomUtils::GetCSSStyleRules). If that were possible, then mutating
such a declaration would mutate the shared Declaration, and then call
WillDirty which would clone the now-mutated Declaration, leading to the
mutation applying to both sheets that shared it rather than just the one
that should have been modified.)
This is the simplification allowed by bug 978833 patch 11 (and part of
what we would otherwise have needed to duplicate in @page and keyframe
rules; we'd also have needed to duplicate the object split between the
internal object and the DOM-exposed object, but for style rules that's
probably worth keeping for the memory savings).
2015-11-09 15:57:17 +08:00
L. David Baron
75a883e95b
Bug 978833 patch 18 - Eliminate StyleRule::RuleMatched and call Declaration::SetImmutable directly for style rules (like for @page and keyframe rules). r=heycam
...
This is just simplification (plus the addition of an assertion).
2015-11-05 16:44:10 +08:00
L. David Baron
803bcb878f
Bug 978833 patch 15 - Make css::Rule no longer inherit from nsIStyleRule. r=heycam
...
This inheritance was previously needed only by a subset of the classes
derived from css::Rule (css::StyleRule, nsCSSKeyframeRule,
nsCSSPageRule). After patch 12, it is now needed by none.
2015-11-05 16:44:10 +08:00
L. David Baron
386ba9023a
Bug 978833 patch 13 - Remove important rule creation from css::StyleRule. r=heycam
...
This is the removal half corresponding to the additions in patch 7; the
removal needs to happen after patch 12.
2015-11-05 16:44:10 +08:00
L. David Baron
a26a645eff
Bug 978833 patch 7 - Fuse allocation of ImportantStyleData with Declaration. r=heycam
...
Note that this adds a new public API to css::Declaration; the equivalent
API is removed from css::StyleRule and nsCSSPageRule in patch 13. But
the removal and addition need to be on opposite sides of patch 12.
This fused allocation is no larger than having a pointer, and it removes
having to worry about cycles.
2015-11-05 16:44:09 +08:00
L. David Baron
1deeca6532
Bug 978833 patch 6 - Move ImportantStyleData from StyleRule.{h,cpp} to Declaration.{h,cpp} r=heycam
...
This is needed for patch 7.
Note that this removes an unused "friend class StyleRule;" declaration.
2015-11-05 16:44:09 +08:00