Commit Graph

18 Commits

Author SHA1 Message Date
Cameron McCormack
7e3de0a555 Bug 1356510 - stylo: Update test expectations. r=manishearth
MozReview-Commit-ID: H9cunzhaNV
2017-04-16 22:11:18 +10:00
Nazım Can Altınova
3fdc79dbd5 Bug 1355003 - stylo: Update test expectations for shape-outside; r=Manishearth
MozReview-Commit-ID: ADUVt5RIBK
2017-04-13 10:34:54 +08:00
Ting-Yu Lin
6cf81bf416 Bug 1326409 Part 5 - Implement shape-outside: polygon(). r=dholbert
The <fill-rule> in the polygon() syntax is not handled because it doesn't
matter to shape-outside at all.

The reftests are numbered from 018 to avoid conflict with the w3c upstream
ones according to this list.
https://test.csswg.org/harness/results/css-shapes-1_dev/grouped/

Reftest 018 to 025 are under various writing-modes, 026 to 029 are testing
empty float area, 030 to 031 are testing polygon containing horizontal
lines.

MozReview-Commit-ID: FPUbMdZsvu6
2017-03-13 12:03:40 +08:00
L. David Baron
0309ac9d81 Rename (renumber) new mozilla-central-reftests shapes1 tests to avoid filename collisions with existing tests. Followup to bug 1311244, bug 1326406, and bug 1326407.
Fixes https://github.com/w3c/csswg-test/issues/1227 .

This patch was written with the script:
#!/bin/bash

cd "$(dirname "$0")/shapes1"

echo "circle 31
ellipse 31
inset 15" | while read BASE INCREMENT
do
   echo shape-outside-$BASE-* | sed 's/ /\n/g;' | sed 's/\([0-9]\{3\}\)/ \1 /' | while read FILESTART OLDNUM FILEEND
   do
       NEWNUM=$(printf "%03d" $(($(echo $OLDNUM | sed 's/^0*//') + $INCREMENT)))
       OLDFILE="$FILESTART$OLDNUM$FILEEND"
       NEWFILE="$FILESTART$NEWNUM$FILEEND"
       hg mv "$OLDFILE" "$NEWFILE"
       sed -i -e "s/$OLDFILE/$NEWFILE/g" *
   done
done
2017-03-03 09:15:54 -08:00
Ting-Yu Lin
787377e136 Bug 1326407 Part 8 - Implement shape-outside: inset(). r=dbaron
The reftests have passed
layout/reftests/w3c-css/submitted/check-for-references.sh.

MozReview-Commit-ID: JZk1fo8SxgV
2017-02-16 10:51:49 +08:00
Cameron McCormack
95e99422cb Bug 1334768 - stylo: Back out 800030115d2e and 404506488cfb for being completely wrong due to bug 1334938.
MozReview-Commit-ID: 8CGTqmtlguT
2017-01-30 16:49:54 +08:00
Cameron McCormack
b9db405c2e Bug 1334768 - stylo: More reftest expectation adjustments for 2017-01-29 merge.
MozReview-Commit-ID: 8TT4JzUIBZl
2017-01-30 10:53:58 +08:00
Ting-Yu Lin
5c6e2823f3 Bug 1326406 Part 4 - Implement shape-outside: ellipse(). r=dbaron
MozReview-Commit-ID: t1gaoKNbNp
2017-01-23 17:18:07 +08:00
Ting-Yu Lin
f4cac5a9ed Bug 1326406 Part 1 - Fix indentation of </body> for the shapes1 reftests. r=dbaron
MozReview-Commit-ID: 20vidQM09Jn
2017-01-23 17:16:31 +08:00
Ting-Yu Lin
353a498900 Bug 1311244 Part 7 - Implement shape-outside: circle(). r=dbaron
circle() allows the user to define an empty flow area, so IsEmpty() needs to
be overridden.

The flow area defined by a shape needs to be clipped to the margin-box per
https://drafts.csswg.org/css-shapes/#relation-to-box-model-and-float-behavior

In the reftests, both clip-path and shape-outside uses the same value so
that it's easier to debug visually.

Add LogicalPoint::LineRelative() because we need to convert a point's I() to
the line-axis in nsFloatManager. LineRelative() differs from I() in all
'rtl' direction per
https://drafts.csswg.org/css-writing-modes-3/#logical-to-physical

MozReview-Commit-ID: FxQaFPrEQ73
2017-01-06 16:36:43 +08:00
Carsten "Tomcat" Book
de8cecb003 Backed out changeset 466053d9302b (bug 1311244) 2017-01-12 14:19:18 +01:00
Ting-Yu Lin
d543342476 Bug 1311244 Part 7 - Implement shape-outside: circle(). r=dbaron
circle() allows the user to define an empty flow area, so IsEmpty() needs to
be overridden.

The flow area defined by a shape needs to be clipped to the margin-box per
https://drafts.csswg.org/css-shapes/#relation-to-box-model-and-float-behavior

In the reftests, both clip-path and shape-outside uses the same value so
that it's easier to debug visually.

Add LogicalPoint::LineRelative() because we need to convert a point's I() to
the line-axis in nsFloatManager. LineRelative() differs from I() in all
'rtl' direction per
https://drafts.csswg.org/css-writing-modes-3/#logical-to-physical

MozReview-Commit-ID: FxQaFPrEQ73
2017-01-06 16:36:43 +08:00
Shing Lyu
ea0c6d953f Bug 1328825 - Update reftest-stylo.list and expectations. r=heycam
MozReview-Commit-ID: AMwdk5wvM0F
2017-01-10 15:50:59 +08:00
Ting-Yu Lin
e7919765e0 Bug 1316549 Part 3 - Fix <shape-box> with border-radius in writing-mode. r=dbaron
The tests cases are designed based on the integer solution to the ellipse
equation (x/a)^2 + (y/b)^2 = 1, where x=36, y=32, a=60, b=40.

MozReview-Commit-ID: De2fXcb6ypP
2016-11-14 18:11:45 +08:00
Ting-Yu Lin
ccd7fe84e2 Bug 1316549 Part 2 - Fix assertion failure: aRadiusY > 0 in FloatInfo::XInterceptAtY(). r=dbaron
We need to consider the case when only one of the four corner radius is
specified. The two reftests are added to test 'border-top-right-radius' and
'border-bottom-right-radius', respectively.

MozReview-Commit-ID: De2fXcb6ypP
2016-11-14 18:11:45 +08:00
Ting-Yu Lin
6c6414f0d8 Bug 1309467 followup - Fix link to versioned css-shapes spec. r=me
Use https://drafts.csswg.org/css-shapes-1/ per bug 1309467 comment 31.

MozReview-Commit-ID: LGErWlbw4qV
2016-11-16 11:57:29 +08:00
Ting-Yu Lin
e43ee61bfb Bug 1309467 Part 5 - Make flow area of <shape-box> values respect border-radius. r=dbaron
In GetFlowArea(), "Shrink our band's height if needed." computation was
moved to the end because we need to pass the unmodified |blockEnd| to
compute LineRight() and LineLeft().

Revamp OutsetBorderRadii() to allow negative margin to reduce the radius,
but not below zero. Also implement the cubic formula required by the spec.
https://drafts.csswg.org/css-shapes/#valdef-shape-box-margin-box

OutsetBorderRadii() is now tailored only for margin-box with border-radius,
so it might no longer be suitable for other scenarios.

MozReview-Commit-ID: HKxW7rp6sIA
2016-10-13 16:28:38 +08:00
Ting-Yu Lin
3885f92712 Bug 1309467 Part 4 - Implement <shape-box> values for shape-outside. r=dbaron
Per spec, float positioning and stacking is not affected by defining a float
area with a shape.
https://drafts.csswg.org/css-shapes/#relation-to-box-model-and-float-behavior

So all the call sites of GetFloatAvailableSpace() related to adding a
float are replaced by GetFloatAvailableSpaceForPlacingFloat().

<shape-box> with border-radius will be implemented in next part.

MozReview-Commit-ID: 1RXEeXDhdWo
2016-10-12 16:06:25 +08:00