Commit Graph

170 Commits

Author SHA1 Message Date
Joel Maher
9c282233ad Bug 1352942 - Intermittent css-grid/grid-whitespace-handling-1b.xhtml. marks as fails. r=hiro
MozReview-Commit-ID: C3CuW2JWcGU
2017-04-19 08:11:51 -04:00
Mats Palmgren
397ae08102 Bug 1350925 part 3 - [css-grid] Reftest.
MozReview-Commit-ID: ITGh6urXXro
2017-04-18 22:35:05 +02:00
Mats Palmgren
751039cd27 Bug 1348857 part 4 - [css-grid] Reftests for grid items that stretch with no Automatic Minimum Size.
MozReview-Commit-ID: 2seF05eqC2W
2017-04-18 22:35:04 +02:00
Mats Palmgren
41caad8d36 Bug 1356820 part 2 - [css-grid] Reftests.
MozReview-Commit-ID: 5Q9hmoJhSxH
2017-04-18 22:35:04 +02:00
Sebastian Hengst
0aa0295b1b Bug 1341802 - stylo: Update reftest expectations for grid-{row,column} and grid-area. r=test-annotations-fix 2017-04-14 23:10:33 +02:00
Nazim Can Altinova
b4fd2f5f45 Bug 1341802 - stylo: Update reftest expectations for grid-{row,column} and grid-area. r=test-annotations-update 2017-04-14 22:38:19 +02:00
Manish Goregaokar
8d1f6ffa12 Bug 1341714 - Part 1: stylo: Add support for text-align match-parent and the <th> -moz-center-or-inherit behavior ; r=heycam
MozReview-Commit-ID: GEDM7JfJB8A
2017-03-26 13:53:34 -07:00
Hiroyuki Ikezoe
a1a3411da2 Bug 1352771 - modify flexbox reftest expectations. r=bholley
MozReview-Commit-ID: 8QCs5TPFKP
2017-04-03 07:26:41 +09:00
Manish Goregaokar
150256fe29 Bug 1352775 - Revert "Bug 1352771 - modify flexbox reftest expectations. r=manishearth"
This reverts commit 13e78ea10b414ac4bd062037d4436ce1689ba865.

MozReview-Commit-ID: CZxOSUfT02b
2017-04-01 19:59:12 -07:00
Hiroyuki Ikezoe
d90156a7a1 Bug 1352771 - modify flexbox reftest expectations. r=bholley
MozReview-Commit-ID: 8QCs5TPFKP
2017-04-02 11:06:23 +09:00
L. David Baron
651fa9086d Bug 1351359 - Make nsGridContainerFrame call ReflowInput::SetBResize(true) because of auto-block-size swapping between measuring reflows and regular reflows. r=mats
This fixes the failure of
layout/reftests/css-grid/grid-min-max-content-sizing-002.html with the
primary patch in bug 1308876 (which causes a child whose parent is dirty
to pick up the dirty bit from the parent only the first reflow of the
child if the parent reflows the child multiple times).  A simplified
testcase for that failure is
https://bugzilla.mozilla.org/attachment.cgi?id=8849771 .

The failure was caused by an error in height calculation of the first
<x> in the test.  The div that is the parent of that x has a definite
height (presumably due to rules in grid), and the x has a specified
height.  The div gets three reflows:  two measuring reflows (from
MinContentContribution and then from MaxContentContribution) and then a
final reflow from nsGridContainerFrame::ReflowInFlowChild.  Prior to the
primary patch in this bug, the div was marked dirty on all three
reflows, but with it it is marked dirty only on the first.  This means
that, without the block-resize flag, the div optimizes away the reflow
of its children, since ShouldReflowAllKids returns false because
IsBResize() is false, even though NS_FRAME_CONTAINS_RELATIVE_BSIZE is
correctly set.

In order to fix this, we need to make sure the BResize flag on the
reflow state in at least some cases (see the comments in the patch for
when, and for how the cases could be optimized in the future).

Note that:

 * when the dirty bit is set on the grid container, the new behavior
   (with the combination of the patches) is strictly more efficient than
   the old, since we will sometimes do non-dirty reflows on the grid
   items (with the b-resize flag)

 * when the dirty bit is *not* set on the grid container, the new
   behavior is less efficient than the old, since we will set the
   b-resize flag when we did not do so before.  However, this slowdown
   fixes existing bugs such as the one in the reftest.

Given that I was able to construct a reftest that triggers the failure
without the changes from bug 1308876, I've moved this to a separate bug.
Without the patch, grid-measuring-reflow-resize-dynamic-001.html fails,
but grid-measuring-reflow-resize-static-001.html passes.  With the patch
both tests pass.  (And without the patch, doing a text zoom on the
dynamic test fixes the layout error.)

MozReview-Commit-ID: JQOdVTQIkU0
2017-03-30 22:56:14 -04:00
Ting-Yu Lin
6b854b6f48 Bug 1322570 Part 2 - Resolve {align,justify}-self using StyleContext from alignment container frame in ReflowInput::InitConstraints(). r=dholbert
Per bug 1322570 comment 46, it's not easy to replace ComputedJustifyItems()
and UsedJustifySelf()'s internal nsStyleContext::GetParent() without
correctness penalty, so we use GetParentAllowServo() for now.

Also, fix the reftest.list added in bug 1334403 which incorrectly wrote test
page as reference page.

MozReview-Commit-ID: 6kAAWSFojd5
2017-03-20 14:12:08 +08:00
Matt Brubeck
0470f360ce Bug 1340683 - stylo: Update stylo test expectations r=KWierso
MozReview-Commit-ID: 54PFVqZfaau
2017-03-16 11:38:33 -07:00
Mats Palmgren
ab35b83a8a Bug 1335806 part 4 - [css-grid] Tweak reftests where 'align/justify-self:normal' now means 'start' for grid items with an intrinsic size / aspect ratio.
MozReview-Commit-ID: AztJxC2cBMR
2017-03-16 15:24:57 +01:00
Mats Palmgren
48c56ea56b Bug 1346699 part 3 - [css-grid] Additional reftests for min/max-sizes affecting flexible track sizing.
MozReview-Commit-ID: 6NORO1Q7xOE
2017-03-16 13:24:50 +01:00
Mats Palmgren
0d84bb2cef Bug 1317149 - Comment out a part of this test that causes to many intermittent failures. r=me 2017-03-15 14:05:00 -04:00
Manish Goregaokar
066385a787 Bug 1296477 - Part 4: stylo: Update test expectations; r=heycam
MozReview-Commit-ID: 9fff2Pme3ey
2017-03-12 21:12:08 -07:00
Phil Ringnalda
a7c67c28a7 Merge m-i to m-c, a=merge 2017-02-26 10:48:26 -08:00
Manish Goregaokar
4b3fabe64e Bug 1342710 - stylo: Disallow keyword values in min/max-size properties; r=xidorn
MozReview-Commit-ID: BTRGHlMXRxg
2017-02-26 00:58:08 -08:00
Phil Ringnalda
330a327598 Merge m-c to m-i 2017-02-25 13:35:20 -08:00
Emilio Cobos Álvarez
c0e5af8f9a Bug 1341083: Implement dynamic restyling for display: contents. r=heycam
MozReview-Commit-ID: KimTU2j4V4p
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-02-25 19:15:38 +01:00
Bobby Holley
19b11d615c No Bug - Twiddle stylo reftest expectations some more. r=me
MozReview-Commit-ID: H1YoN7HpmO1
2017-02-25 17:58:53 -08:00
Emilio Cobos Álvarez
577e47ac51 Bug 1342710, Bug 1324633: Update reftests and crashtests expectations.
MozReview-Commit-ID: LmapjDT6ggu
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-02-25 16:50:44 -08:00
Boris Zbarsky
e0ac9a0993 Reenable some more stylo reftests. No bug. r=bzbarsky
MozReview-Commit-ID: BbRlPC60tvt
2017-02-24 10:49:37 -05:00
Boris Zbarsky
bc644e0dc2 Bug 1341988. Reenable a bunch of stylo reftests that were disabled for reasons that are not relevant anymore. r=bz
MozReview-Commit-ID: CLqLHexhBX3
2017-02-23 02:09:57 -05:00
Ting-Yu Lin
1d4509ad47 Bug 775624 Part 16 - Convert NS_INLINE_IS_BREAK_BEFORE to a method. r=dholbert
MozReview-Commit-ID: 8vxRpqbZNnk
2017-02-14 16:05:24 +08:00
Manish Goregaokar
6eea51c5aa Bug 1342596 - Fix test expectations for min/max-width/height; r=bholley
MozReview-Commit-ID: 7QjxPEVvpqS
2017-02-24 16:53:34 -08:00
Bobby Holley
87972624f7 Bug 1341025 - Disable crashing tests. r=me
MozReview-Commit-ID: UyVh0L0sLe
2017-02-20 11:49:51 -08:00
Manish Goregaokar
3dda7fdbdd Bug 1341013 - Update reftest results; r=Tomcat
MozReview-Commit-ID: La7NFwvaJEh
2017-02-20 03:45:15 -08:00
Manish Goregaokar
8b358ac5ea Bug 1338936 - Part 4: stylo: Update reftest results; r=emilio
MozReview-Commit-ID: 6wg32flypt7
2017-02-19 14:03:48 -08:00
Sebastian Hengst
6b8a70a3be Backed out changeset 2d887234705f (bug 1338936) 2017-02-19 10:37:16 +01:00
Manish Goregaokar
b81d7d2224 Bug 1338936 - Part 4: stylo: Update reftest results; r=emilio
MozReview-Commit-ID: 6wg32flypt7
2017-02-18 21:57:58 -08:00
Cameron McCormack
e1d3a12eca Bug 1334768 - stylo: Adjust a bunch of reftest expectations. r=me on a CLOSED TREE
MozReview-Commit-ID: 1qa08cspl7o
2017-01-31 17:38:24 +01:00
Sebastian Hengst
88a9646493 Backed out changeset e3687105be00 (bug 1334768) 2017-01-31 17:30:16 +01:00
Cameron McCormack
e6568b7407 Bug 1334768 - stylo: Adjust a bunch of reftest expectations. r=me
MozReview-Commit-ID: 1qa08cspl7o
2017-01-31 23:36:46 +08:00
Cameron McCormack
95e99422cb Bug 1334768 - stylo: Back out 800030115d2e and 404506488cfb for being completely wrong due to bug 1334938.
MozReview-Commit-ID: 8CGTqmtlguT
2017-01-30 16:49:54 +08:00
Cameron McCormack
b9db405c2e Bug 1334768 - stylo: More reftest expectation adjustments for 2017-01-29 merge.
MozReview-Commit-ID: 8TT4JzUIBZl
2017-01-30 10:53:58 +08:00
Cameron McCormack
1b17824ce4 Bug 1334768 - stylo: Test expectation adjustments for 2017-01-29 merge.
MozReview-Commit-ID: FFmvs6SHIwW
2017-01-29 15:31:56 +08:00
Shing Lyu
0192dd886a Bug 1331860 - Update reftest-stylo expectations. r=heycam 2017-01-12 10:37:36 +08:00
Florian Quèze
63de711857 Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws. 2017-01-17 11:50:25 +01:00
Cameron McCormack
da02d22e83 Bug 1323892 - stylo: Add the annotations to the right manifest file. r=me
MozReview-Commit-ID: 8Zm7FHDqXtO
2017-01-17 16:03:11 +08:00
Cameron McCormack
f50855d7c7 Bug 1323892 - stylo: Disable and annotate some more crashtests and reftests. r=me
MozReview-Commit-ID: 5Ot9dZR0q8T
2017-01-17 15:06:50 +08:00
Mats Palmgren
cb1b75d5dd Bug 1330380 - Follow-up: remove debug console.log script from a few CSS Grid reftests. r=me 2017-01-15 16:40:20 +01:00
Mats Palmgren
7e3c210cf9 Bug 1330380 part 3 - Add more reftests using percentages in various properties. 2017-01-14 01:05:53 +01:00
Shing Lyu
ea0c6d953f Bug 1328825 - Update reftest-stylo.list and expectations. r=heycam
MozReview-Commit-ID: AMwdk5wvM0F
2017-01-10 15:50:59 +08:00
Mats Palmgren
05b26d81fe Bug 1312379 part 1 - [css-align][css-flexbox][css-grid] Introduce nsIFrame methods for calculating baselines per CSS Alignment and CSS2 'vertical-align'. r=dholbert 2016-12-20 23:56:35 +01:00
Mats Palmgren
a4192e4678 Bug 1313068 - [css-grid] Reftests for synthesize baselines for empty grid containers. 2016-12-20 23:56:34 +01:00
Mats Palmgren
2e8fb1f9f8 Bug 1314664 part 5 - [css-grid] Tweak reftests. 2016-12-20 23:56:34 +01:00
Thomas Wisniewski
bd9e91580b Bug 140562 - Part 3: Fix up reftests to account for the fact that -moz-focus-inner no longer affects button size. r=dbaron 2016-11-30 21:43:32 -05:00
Mats Palmgren
5d82879abd Bug 1319958 - [css-grid] Sprinkle some place-items/self/content shorthands around in the Grid reftests to increase test coverage. 2016-11-28 00:44:22 +01:00