Commit Graph

359 Commits

Author SHA1 Message Date
Daniel Holbert
3910e835e8 Bug 1148078: Replace the word "Logical" with "Flex-Relative" in some vars & functions in flexbox layout. r=mats 2015-03-26 14:37:48 -07:00
Daniel Holbert
008e633cfa Bug 1128354: Don't optimize away a flex item's second reflow, if it has percent-height children. r=mats 2015-03-19 23:00:05 -07:00
Daniel Holbert
c2ffe16121 Bug 1142686: check flex item's content-box size (not border-box size) when deciding whether to skip final reflow. r=mats 2015-03-13 23:08:21 -07:00
Daniel Holbert
9bc40dc935 Backed out changeset 6cd4d71818ee (bug 1142686) because it wasn't quite the final patch version 2015-03-13 23:07:57 -07:00
Daniel Holbert
5ddf64fe0f Bug 1142686: check flex item's content-box size (not border-box size) when deciding whether to skip final reflow. r=mats 2015-03-13 23:00:37 -07:00
Jonathan Kew
3a5f0eb4f4 Bug 1121748 - patch 2 - Use the flex-item frame's final size when computing its logical position within the flex container. r=smontagu 2015-02-02 14:17:00 -08:00
Jonathan Kew
771d3ffcf1 Bug 1127679 - Fix use of incorrect writing mode in flex-item relative positioning. r=smontagu 2015-02-02 18:29:52 +00:00
Daniel Holbert
d2806a679f Bug 1054010: Skip final reflow for flex items that receive an earlier 'measuring reflow' with the right size. r=mats 2015-01-23 14:15:11 -08:00
Daniel Holbert
2992d0df65 Bug 1054054 part 4: Remove stale XXXdholbert comment from ReflowFlexItem. (no review, comment-only) 2015-01-23 10:26:16 -08:00
Daniel Holbert
d6810d6013 Bug 1054054 part 3: De-indent ReflowFlexItem function-body (no review, whitespace-only). 2015-01-23 10:26:00 -08:00
Daniel Holbert
3d22b12f29 Bug 1054054 part 2: Add "a" prefix to args which were formerly local variables, in ReflowFlexItem. r=mats 2015-01-23 10:25:59 -08:00
Daniel Holbert
0462ecf681 Bug 1054054 part 1: Split out code for doing final reflow of each flex item into its own helper-function, "ReflowFlexItem". r=mats 2015-01-23 10:25:58 -08:00
Daniel Holbert
4bb7312fde Bug 1054058 part 3: Use local var to cache flex item's "normal" block offset in container, rather than looking it up. r=mats 2015-01-22 15:12:11 -08:00
Daniel Holbert
ebe81e3273 Bug 1054058 part 2: Resolve flex item ascent (baseline) values lazily. r=mats 2015-01-22 15:12:11 -08:00
Daniel Holbert
99e7e2d9d5 Bug 1054058 part 1: Proactively save flex items' ascent values, whenever they're reflowed, if there's a chance we'll need them later. r=mats 2015-01-22 15:12:10 -08:00
Daniel Holbert
2f7993b31b Bug 1054046: Cache flex items' tentative cross size from reflow state, to avoid creating another reflow state later on just for that piece of information. r=mats 2015-01-21 19:45:37 -08:00
Ehsan Akhgari
a7f747ec15 Bug 1118486 - Part 1: Use = delete instead of MOZ_DELETE directly; r=Waldo
Most of this patch (with the exception of dom/bindings/Codegen.py) was
generated by the following bash script:

#!/bin/bash

function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
       ! -wholename "*security/nss*" \
       ! -wholename "*/.hg*" \
       ! -wholename "*/.git*" \
       ! -wholename "obj-*" \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert MOZ_DELETE '= delete'
2015-01-08 23:19:05 -05:00
Simon Montagu
ef59c33896 Bug 1079154 patch 6: convert ApplyRelativePosition, ReflowChild and FinishReflowChild in nsFlexContainerFrame to the logical versions, r=dholbert 2015-01-06 23:10:07 -08:00
Jonathan Kew
cdf9a3916d Bug 1077528 - part 1 - Provide physical and logical accessors for the m{HV}Resize flags in nsHTMLReflowState, and convert all flag users to the accessor methods. r=smontagu 2014-11-28 09:44:02 +00:00
Daniel Holbert
50490b2d65 Bug 1093316 part 1: Backout changeset aece7f9f944c (i.e. backout bug 1032922 part 2), to reflect CSSWG removing "flex-basis: main-size" from the flexbox spec. 2014-11-25 11:28:15 -08:00
Jonathan Watt
b431664247 Bug 651021 - Make nsRenderingContext a stack class. r=jrmuizel 2014-10-31 20:08:49 +00:00
Anuj Agarwal
0393dda483 Bug 791777 - Replaced NS_finite() with mozilla::IsFinite. r=froydnj 2014-10-01 11:26:00 +02:00
Ehsan Akhgari
8bb87f8a27 Bug 1060985 - Fix more bad implicit constructors in layout; r=roc 2014-08-31 23:36:37 -04:00
Arnaud Sourioux
c2bd526eb9 Bug 1040582 - Change nsLayoutUtils.cpp's MULDIV Macro to inline function in nsCoord.h. r=dholbert 2014-08-29 01:14:00 -04:00
Daniel Holbert
99de337308 Bug 1059138 band-aid: Skip flex item sortedness assertion if the first flex item is part of a shadow DOM. r=bz
Not sure what the right fix is here yet, but this should stop the new 'gaia-header' web component from making this dominate the logcat output.
2014-08-27 17:48:21 -07:00
Daniel Holbert
14a5e3d758 Bug 1032922 part 2: Rename flex-basis's "auto" keyword to "main-size" (but retain "flex:auto" as shorthand for "1 1 main-size"). r=heycam 2014-08-07 22:11:48 -07:00
Jonathan Kew
f6c74bf220 bug 1031241 pt 4 - Rename the {MIN,PREF}_WIDTH constants used to identify the type of intrinsic inline-size. r=smontagu 2014-07-24 18:03:26 +01:00
Jonathan Kew
fe8090d7de bug 1031241 pt 3 - Also rename Intrinsic{Width,Height} to Intrinsic{I,B}Size. r=smontagu 2014-07-24 18:03:26 +01:00
Jonathan Kew
c7e5b8d9dc bug 1031241 pt 1 - Rename Get{Min,Pref}Width to Get{Min,Pref}ISize throughout layout. r=dbaron,smontagu 2014-07-24 18:03:25 +01:00
Simon Montagu
0132cc9646 Bug 789096 patch 9: use logical coordinates in nsHTMLReflowState available size. r=jfkthame 2014-07-24 01:28:46 -07:00
Daniel Holbert
c491e60cd0 Bug 1015474 part 1: Update behavior of "min-width:auto"/"min-height:auto" to match current spec text. r=mats
This updates min-width:auto / min-height:auto to now take several more things
into account, beyond just a flex item's min-content size. Now we'll also
consider its used 'flex-basis', its main max-size property ('max-width' or
'max-height'), and its intrinsic ratio & any constraints in the other
dimension.
2014-07-22 08:24:37 -07:00
Daniel Holbert
90a65b178f Bug 1037177 part 4: Call ResolveAutoFlexBasisAndMinSize at the end of GenerateFlexItemForChild, instead of just after it. r=mats 2014-07-22 08:24:36 -07:00
Daniel Holbert
a7518880cb Bug 1037177 part 3: Split out flexbox's auto-height-measuring code into its own dedicated function. r=mats 2014-07-22 08:24:36 -07:00
Daniel Holbert
606dbe7c7a Bug 1037177 part 2: Rename ResolveFlexItemMaxContentSizing to ResolveAutoFlexBasisAndMinSize. r=mats 2014-07-22 08:24:36 -07:00
Daniel Holbert
3716f2bbc2 Bug 1037177 part 1: Make FlexItem() constructor take a reflow state as a parameter, to reduce arg-count and get faster access to style structs. r=mats 2014-07-22 08:24:36 -07:00
Daniel Holbert
75df66164b Bug 984711 part 5: Add back handling for min-height:auto to nsFlexContainerFrame. r=mats
This conceptually reverts changeset 7a289f49170f from bug 848539, though the code being modified looks a bit different now.
2014-07-22 08:24:35 -07:00
Mats Palmgren
cef69b5425 Bug 1031701 - Remove FlexContainerFrame::MarginComponentForSide(), use nsMargin::Side() instead. r=dholbert 2014-07-01 17:58:14 +00:00
Mats Palmgren
57f71caceb Bug 1028460 - part 3, Change the return type for Get*SkipSides(). r=roc 2014-06-28 10:13:13 +00:00
Phil Ringnalda
650df8d81e Back out 5 changesets (bug 1028460, bug 1031444) for somehow breaking asmjscache/test/test_cachingBasic.html on Android 2.2
Backed out changeset 0b5918ec6521 (bug 1031444)
Backed out changeset 663ff18cd4a1 (bug 1028460)
Backed out changeset ae01b3919c8c (bug 1028460)
Backed out changeset 316c8dfeca9b (bug 1028460)
Backed out changeset e237b2c61ea2 (bug 1028460)
2014-06-28 22:01:28 -07:00
Mats Palmgren
3949ce77fb Bug 1028460 - part 3, Change the return type for Get*SkipSides(). r=roc 2014-06-28 10:13:13 +00:00
Jonathan Watt
ac5ccb0288 Bug 1030843 - Fix crash in nsNativeThemeCocoa::GetMinimumWidgetSize. r=roc 2014-06-27 10:19:00 +01:00
Mats Palmgren
4f9712e3f7 Bug 1025669 - part 0, Add BaseMargin::ApplySkipSides, remove nsIFrame::Apply*SkipSides, and change call sites to use the former. r=roc 2014-06-24 17:52:19 +00:00
Simon Montagu
3324128a4d Bug 789096 patch 8: use logical coordinates in nsBlockReflowState. r=jfkthame 2014-06-20 02:55:35 -07:00
Simon Montagu
614fa9614f Replace GetBaseline with GetLogicalBaseline and use logical coordinates in the line position and baseline getters in nsLayoutUtils. Bug 789096, r=jfkthame 2014-06-17 05:19:38 -07:00
Daniel Holbert
ad9e4a6eed Bug 1024875: Make reflow-related functions in nsFlexContainerFrame return void, now that Reflow returns void. r=mats 2014-06-13 08:37:02 -07:00
Simon Montagu
7182a1b8b9 Replace Get/SetTopAscent with Get/SetBlockStartAscent. Bug 789096, r=jfkthame 2014-06-11 02:45:31 -07:00
Daniel Holbert
fad3cd644c Bug 1018449: Don't opportunistically stretch flex items to container's cross-size if the container is multi-line. r=mats 2014-06-06 15:55:58 -07:00
Daniel Holbert
c1b3d4d17f Bug 1015563: Soften flexbox assertion that can fail from integer overflow. r=mats 2014-06-02 15:15:23 -07:00
Mats Palmgren
a26b4d368e Bug 508665 - part 4, Make nsCSSFrameConstructor use nsContainerFrame* for frames used as parent frames. r=roc 2014-05-24 22:20:40 +00:00
Mats Palmgren
e4c50768a0 Bug 1009272 - [css-grid] Add some sanity checks for the grid container child frame lists. r=dholbert 2014-05-19 23:57:00 +00:00