Commit Graph

610 Commits

Author SHA1 Message Date
Boris Zbarsky
ad0669b8c1 Bug 478219. Put a script blocker around delayed editor init. r+sr=sicking 2009-03-16 07:50:04 -04:00
Boris Zbarsky
66350fb221 Bug 477700. Push a null JSContext around editor init, so it'll work no matter what JS is on the stack. r+sr=smaug 2009-02-16 09:11:41 -05:00
Boris Zbarsky
0676a1312a Bug 335615. Don't do editor init inside frame construction. r=mats, sr=roc 2009-01-29 14:46:17 -05:00
Benjamin Smedberg
0f95227641 Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
7a084ac404 Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal. 2009-01-09 11:35:24 -05:00
Benjamin Smedberg
991a16d8bc Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
Robert O'Callahan
e0b25b33e5 Bug 459613. When we tear down a textcontrol frame, tell its editor that we're blowing away the frame tree so it doesn't try to clear the spellcheck selection, which not only wastes time but does GetPrimaryFrame for during frame destruction which is a no-no. r+sr=mats 2008-12-12 21:34:43 +13:00
Markus Stange
615b3a4ee1 Bug 462793 - Changing listbox selection with keyboard no longer scrolls to make the newly selected item visible, r+sr=roc 2008-11-04 15:38:16 +01:00
Benjamin Smedberg
6690b4d11b Bug 461186 - nsTextControlFrame should not implement nsIPhonetic: there's only one caller, and that caller can use nsITextControlFrame directly. This is one less frame that implements an nsISupports-derived interface. r+sr=roc 2008-10-27 20:27:55 -04:00
Theppitak Karoonboonyanan
1703d4c904 Bug 157546. The 'delete' key should delete an entire cluster. r=peterv,r+sr=roc 2008-10-16 20:44:32 +13:00
Mats Palmgren
817a2167be Ignore the keypress event if DOMEventToNativeKeyEvent() fails. b=456273 r=Olli.Pettay sr=jonas 2008-10-15 12:50:42 +02:00
Taras Glek
f090606a7d bug 455536: s/NS_ERROR_FAILURE/NS_ERROR_OOM/ outparamdelled nsNodeInfoManager::GetNodeInfo r+sr=jsr 2008-09-25 15:46:52 -07:00
Arpad Borsos
40a654b059 Bug 454766 - Add suggested parentheses to layout/; r+sr=roc; (with nits by sgautherie) 2008-09-15 17:40:25 +02:00
Taras Glek
c61f5f5c50 bug 450777:deCOMtaminate nsNodeInfoManager::GetNodeInfo r+sr=jst 2008-09-12 15:32:18 -07:00
Mats Palmgren
e20f76575f Bug 446663. Make sure that if the user is typing in a text input its text input listener will get the events (so that undo/redo work and oninput is fired). 2008-07-31 17:34:11 -07:00
Zack Weinberg
0761467047 Delete nsLayoutUtils::GetAbsoluteCoord(); fold logic into callers and simplify. (Bug 437335) r+sr=dbaron 2008-07-17 16:37:12 -07:00
John Daniels
2aef16c1bf Bug 419532 – deCOMtaminate nsICaret. r+sr=roc 2008-07-16 12:52:01 +02:00
neil@parkwaycc.co.uk
8022b6050d Bug 444466 – Crash [@ nsTextControlFrame::PreDestroy()], r+sr=bz 2008-07-12 11:26:40 +02:00
983863edf4 Landing fix for bug 419716. Make us consistently deal how we're pass param tags to object tags when parsing XHTML. Patch by mrbkap@gmail.com and bent.mozilla@gmail.com, r+sr=jonas@sicking.cc, a=beltzner 2008-04-17 15:30:51 -07:00
c28a527a14 Backout bug 157546 (making the delete key delete by clusters) to fix blockers bug 419217 and bug 419406. Instead of removing the added test, mark now-failing tests as todo. a=damons 2008-04-14 18:04:18 -07:00
81fd20f5b1 Bug 425253. Propagate reflow-depth tracking through XUL box layout. r+sr=dbaron,a=damon 2008-04-09 21:39:41 -07:00
3f195c6cd6 Bug 420499 - "Caret browsing mode wrongly engaged" (Mochitest) [p=chris@pearce.org.nz (Chris Pearce [cpearce]) r+sr=roc a=blocking1.9+] 2008-04-08 11:52:48 -07:00
945f8bd434 Bug 394114 Interfaces missing from various QI implementations. r=jag sr=jag a=dsicore 2008-04-06 05:28:34 -07:00
b7c2dd27e5 Disconnect the frame selection object from the pres shell earlier. b=421083 r+sr=roc a1.9=beltzner 2008-04-02 19:42:20 -07:00
514997b0d3 Bug 424989 Cannot use reconversion of IMEs from system menu at the focus being on textarea r+sr=roc, b1.9=jonas 2008-03-29 12:38:05 -07:00
46f0a1f41c reverting, wrong patch, missing AMBIGUOUS 2008-03-19 14:55:22 -07:00
56b16d9b10 Bug 394114 Interfaces missing from various QI implementations. r=jag sr=jag a=dsicore 2008-03-19 14:19:35 -07:00
0ccdef5621 Bug 418470 Go to line in View Source broken (NS_ERROR_UNEXPECTED at nsISelectionController.scrollSelectionIntoView) (retry) r+sr=roc, a1.9b4=beltzner 2008-02-28 07:28:37 -08:00
4aa69fa997 backing out the previous patch, becaused qm-centos5-01 dep unit test is orange 2008-02-28 05:59:25 -08:00
3538ede317 Bug 418470 Go to line in View Source broken (NS_ERROR_UNEXPECTED at nsISelectionController.scrollSelectionIntoView) r+sr=roc, a1.9b4=beltzner 2008-02-28 03:01:56 -08:00
d53278e296 Bug 157546. 'Delete' key should delete entire cluster. patch by Theppitak Karoonboonyanan, r+sr=roc,a=schrep 2008-02-21 18:24:04 -08:00
439d9b7115 Back out patch from Theppitak Karoonboonyanan in bug 157546 due to test failures. 2008-02-20 03:10:16 -08:00
46fdf03ed0 Bug 157546 - "[CTL-Thai] IM: <delete> key should delete WHOLE Thai "display cell"" [p=thep@linux.thai.net (Theppitak Karoonboonyanan) r+sr=roc a1.9=schrep] 2008-02-20 02:19:31 -08:00
351de4d3bf Back out Theppitak Karoonboonyanan's patch from bug 157546 due to a regression (bug 417745). 2008-02-15 12:20:55 -08:00
ba51f7f475 Bug 157546 - "[CTL-Thai] IM: <delete> key should delete WHOLE Thai "display cell"" [p=thep@linux.thai.net (Theppitak Karoonboonyanan) r+sr=roc a1.9=beltzner] 2008-02-14 21:30:34 -08:00
c383d1b11d Make XUL elements really native anonymous b=410119 r=smaug sr+a=sicking 2008-01-04 03:24:41 -08:00
e3aee240b4 Bug 406407 - "Accelerators for textEdit should not be affected by keyboard group/level" [p=lolkaantimat@gmail.com (Evgeniy Ivanov) r+sr=roc a1.9=stuart] 2007-12-29 12:43:27 -08:00
31eee9eab5 Back out patch from bug 406047, as it is causing orange on Linux and Tp regression on Mac. 2007-12-14 00:55:08 -08:00
e4f3d3937e Bug 406407 - "Accelerators for textEdit should not be affected by keyboard group/level" [p=lolkaantimat@gmail.com (Evgeniy Ivanov) r+sr=roc a1.9=stuart] 2007-12-13 23:20:32 -08:00
750ad2685e Bug 368760, r=mats, sr=roc, a=blocking1.9+ 2007-11-22 12:47:33 -08:00
e67a403ab0 Bug 388558, 'change' event isn't dispatched if user selects input field value from the autocomplete list, r=jst, sr=sicking, a=mconnor 2007-10-02 09:56:07 -07:00
5c621e16b5 extra measure of security for password textfields on Mac OS X. b=394107 r=smorgan sr=roc 2007-09-27 09:01:32 -07:00
24d90daaf9 Only update the select command for focused text inputs. Bug 394792, r=roc, sr=neil, a=roc 2007-09-14 15:33:40 -07:00
99dfbbb6f7 Make maxlength not affect initial values or scripted sets. Bug 345267, r+sr=mats, a=dbaron 2007-08-21 20:22:21 -07:00
4cefb9b2f5 Make auto-height abs-pos textfields with top and bottom offsets both set use their intrinsic height, per spec. Bug 385870, r+sr+a=dbaron 2007-08-21 20:07:25 -07:00
5d24e6562d Account for the padding on our anonymous div when sizing. Bug 388086, r+sr+a=dbaron 2007-08-02 15:06:00 -07:00
52dd7935ae Avoid doing some work when initializing textfields. Bug 221150, patch by
peterv and a little bit me, r=me, sr=roc
2007-07-24 17:11:22 -07:00
ac7ff5b659 Bug 355367, textbox onchange doesn't fire if user tabs out and value changed in onkeydown, r=jst, sr=sicking 2007-07-20 16:19:19 -07:00
f07cedac96 Backing out this change to see if it fixes the test failures. 2007-07-09 16:05:44 -07:00
40901f5dec Attempt to re-enable async reflow and painting in editor. bug 174823, r+sr=roc 2007-07-09 14:55:18 -07:00