corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
477,034 Commits 1 Branch 0 Tags
c76ce9f99a49d0cb15a2ad724b5db7f2b71142f6
Commit Graph

88 Commits

Author SHA1 Message Date
Cameron McCormack
da21cae689 Bug 1322185 - Rename some StyleDisplay enum values for consistency. r=xidorn 
MozReview-Commit-ID: K27LmXKWNdk
 2016-12-05 21:36:28 -10:00
Daniel Holbert
e14eb670ea Bug 1304540 part 2: Use nsCOMPtr/RefPtr (and their forget() API) instead of manual NS_ADDREF macros, in a few files within layout. r=mats 
MozReview-Commit-ID: SrJNtbwc1B
 2016-09-21 15:41:26 -07:00
Daniel Holbert
db2f6f5ff0 Bug 1304540 part 1: minor code-cleanup in the neighborhood of some NS_ADDREF usages. r=mats 
DETAILS ON THE CLEANUP:

* In nsFrameTraversal.cpp:
 - Whitespace fix.
 - Remove a useless nullptr assignment.
 - Use "=" to initialize a nsCOMPtr, per coding style guideline ("initialize variables with nsFoo aFoo = bFoo and not nsFoo aFoo(bFoo)").

* In nsPresShell.cpp:
 - Wrap a longish assignment to 2 lines (since next patch will make the first line longer, which would push the whole thing over 80 characters if it weren't wrapped).
 - Add braces around "if" body.

* In nsTextFrame.cpp:
 - Remove a useless nullptr assignment.
 - Move the "metrics->GetThebesFontGroup()" call slightly earlier, so it happens *before* we've implicitly transferred ownership the object pointed to by "metrics".
 - Add a code-comment.

MozReview-Commit-ID: LG6vgOmM9MK
 2016-09-21 15:39:48 -07:00
Emilio Cobos Álvarez
2efcfaad38 Bug 1299066: Make NS_STYLE_DISPLAY_* an enum class. Prefer indexing instead of linear search in the frame constructor r=heycam,bz 
The main renaming was generated with the following python script:

```

import sys
import re

CAMEL_CASE_REGEX = re.compile(r"(^|_|-)([A-Z])([A-Z]+)")
DISPLAY_REGEX = re.compile(r"\bNS_STYLE_DISPLAY_([^M][A-Z_]+)\b")

def to_camel_case(ident):
  return re.sub(CAMEL_CASE_REGEX,
                lambda m: m.group(2) + m.group(3).lower(), ident)

def constant_to_enum(constant):
  return "StyleDisplay::" + to_camel_case(constant) + ("_" if constant == "NONE" else "")

def process_line(line):
  return re.sub(DISPLAY_REGEX,
                lambda m: constant_to_enum(m.group(1)), line)

lines = []
with open(sys.argv[1], "r") as f:
  for line in f:
    lines.append(process_line(line))

with open(sys.argv[1], "w") as f:
  for line in lines:
    f.write(line)
```

And the following shell commands:

```
find . -name '*.cpp' -exec python display.py {} \;
find . -name '*.h' -exec python display.py {} \;
```

MozReview-Commit-ID: 91xYCbLC2Vf
 2016-09-01 20:41:17 -07:00
Ting-Yu Lin
122e5b9aeb Bug 1227927 Part 2 - Remove nsIFrame::GetFirstPrincipalChild(). r=mats 2016-01-29 22:42:14 +08:00
Neil Deakin
19545a1a28 Bug 1132518, add a flag to nsIFrameTraversal to skip the popup checks, r=mats 2015-07-13 06:07:49 -04:00
Ehsan Akhgari
ea41d8de48 Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj 
This patch was automatically generated using the following script:

function convert() {
echo "Converting $1 to $2..."
find . \
       ! -wholename "*/.git*" \
       ! -wholename "obj-ff-dbg*" \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert MOZ_OVERRIDE override
convert MOZ_FINAL final
 2015-03-21 12:28:04 -04:00
Benoit Jacob
553e5b2a13 Bug 1028588 - Fix dangerous public destructors in layout/ - r=dbaron 2014-06-23 18:40:01 -04:00
Mats Palmgren
a73e99dbc1 Bug 508665 - part 1, Change the signature of SetParent/GetParent from nsIFrame* to nsContainerFrame*. r=roc 2014-05-24 22:20:39 +00:00
Birunthan Mohanathas
eeb9aaaa94 Bug 900908 - Part 3: Change uses of numbered macros in nsIClassInfoImpl.h/nsISupportsImpl.h to the variadic variants. r=froydnj 2014-04-27 03:06:00 -04:00
Arnaud Sourioux
fe6152ac7a Bug 974687 - Part 1: Add about 300 MOZ_OVERRIDE in layout/. r=dholbert 2014-02-24 09:41:56 -05:00
Daniel Holbert
c812fb90d2 Bug 841261: Use init list instead of assignment in nsFrameIterator constructor. r=mats 2013-02-18 08:59:55 -08:00
L. David Baron
ca6c366dc6 Bug 781360 patch 3: Rename {nsIFrame,nsStyleContext,nsComputedDOMStyle}::GetStyle* to Style*, since they can never return null. r=dholbert 
Except for the changes in:
  layout/generic/nsIFrame.h (part)
  layout/style/nsComputedDOMStyle.h (all)
  layout/style/nsRuleNode.cpp (part)
  layout/style/nsStyleContext.cpp (part)
  layout/style/nsStyleContext.h (part)
(see patch 3b in the bug), this patch was written with the sed script:
s/\<GetStyle\(Font\|Color\|List\|Text\|Visibility\|Quotes\|UserInterface\|TableBorder\|SVG\|Background\|Position\|TextReset\|Display\|Content\|UIReset\|Table\|Margin\|Padding\|Border\|Outline\|XUL\|SVGReset\|Column\)\>/Style\1/g
 2013-02-16 13:51:02 -08:00
Ehsan Akhgari
5537d09f04 Bug 579517 follow-up: Remove NSPR types that crept in 2012-10-25 14:44:37 -04:00
Ehsan Akhgari
e91c80d60b Backed out 2 changesets (bug 579517) 
Backed out changeset 5298adc70963
Backed out changeset 86ccf7c918ce (bug 579517)
 2012-10-25 12:32:24 -04:00
Ehsan Akhgari
d766300da5 Code hygiene: don't use PR_TRUE and PR_FALSE, and use stdint types instead of PRInt types (no bug really, but you could say bug 579517) 2012-10-25 11:48:19 -04:00
David Zbarsky
857c4a57f6 Backout bug 779684 for topcrash 2012-10-15 14:35:50 -04:00
David Zbarsky
2d1e72a475 Bug 779684: Create a stack-based nsFrameIterator class out of nsIFrameTraversal and nsIFrameEnumerator r=roc 2012-08-05 23:00:55 -04:00
Aryeh Gregor
8b4a23fc4c Bug 777292 part 2 - Change all nsnull to nullptr 2012-07-30 17:20:58 +03:00
Ehsan Akhgari
2062cd8e93 Bug 758992 - Make the classes which use the XPCOM nsISupports implementation macros final, to avoid the warning about deleting using a pointer to a base class with virtual functions and no virtual dtor (layout parts); r=roc 2012-06-18 23:26:34 -04:00
Gervase Markham
cb6a072c2a Bug 716478 - update licence to MPL 2. 2012-05-21 12:12:37 +01:00
Michael Wu
0fe7772ece Bug 675553 - Switch from PRBool to bool on a CLOSED TREE , r=bsmedberg,khuey,bz,cjones 2011-09-28 23:19:26 -07:00
Mats Palmgren
4e2a044a66 Bug 653649 - New way of getting child lists from frames. (part 4/5) r=roc 
Remove the nsIAtom* child list names and use child list ID enum instead.
 2011-08-24 22:54:30 +02:00
Craig Topper
d1acc42088 Bug 654369 - Part 11: Remove OOM checks from layout/base r=bz 2011-04-28 22:02:40 -07:00
Craig Topper
c898504113 Bug 253889: DeCOMtaminate nsIPresShell r=roc 2010-03-20 17:54:19 -04:00
Boris Zbarsky
8e9c649afe Bug 512336. Make frame lists doubly-linked. r=roc,fantasai 2009-10-02 12:27:37 -04:00
Mats Palmgren
f85d73c25c Bug 233463, patch 5 - Remove nsFrameList(nsIFrame*) ctor. r=bzbarsky 2009-09-18 13:09:36 +02:00
Uri Bernstein
34c8c2994a Bug 466568. Don't traverse into scrollable frames if we're not allowed to traverse out of them. r+sr=roc 2008-12-03 14:24:07 +13:00
Benjamin Smedberg
91a3d948e0 Bug 461212 - deCOM frame traversal (relanding) r=mats.palmgren sr=roc 2008-10-30 10:15:22 -07:00
Benjamin Smedberg
f4133116e4 Backed out changeset affcc1c08bc0 (deCOM frame enumerator) due to regression from it or bug 461410. 2008-10-28 02:47:40 -04:00
Benjamin Smedberg
e6bf9e93fd Bug 461212 - deCOM frame enumerator, r=mats.palmgren sr=roc 2008-10-28 00:47:19 -04:00
57e3d7fd95 Bug 385275, handle tab navigation in popups properly, r+sr=roc 2007-08-15 18:09:58 -07:00
ff550192b3 Bug 387720, fix shift+tab not working, popup reworking uncovered this bug which manifested itself as a regression, r+sr=roc 2007-07-12 06:54:42 -07:00
98de634631 Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros. 2007-07-08 00:08:04 -07:00
7334d31070 Bug 376636 - Building with gcc 4.3 and -pendatic fails due to extra semicolons, patch by Art Haas <ahaas@airmail.net>, rs=me 2007-04-23 07:21:53 -07:00
b6210c4689 bug 378339. nsFrameIterator doesn't initialize mOffEdge. r=uriber, sr=roc 2007-04-22 21:14:25 -07:00
cvshook@sicking.cc
e80f1dba4e Kill remainders of ns(XBL|HTML|XUL|Layout)Atoms. r/sr=jst b=368128 2007-01-30 00:06:41 +00:00
dbaron@dbaron.org
8648581bf7 Change the bulk of ascent (baseline) computation to happen on a virtual method on nsIFrame, and remove the redundant descent member from nsHTMLReflowMetrics, primarily to support having both first-line and last-line baselines. b=367332 r+sr=roc 2007-01-23 04:06:56 +00:00
timeless@mozdev.org
f4ef17d178 Bug 355300 There should be only one nsGkAtoms creature 
r=dbaron
 2006-12-26 17:47:52 +00:00
uriber@gmail.com
3954591075 Allow users of nsFrameTraversal to specify what features they want the iterator to have, and make nsFrame::GetFrameFromDirection() specify "following OOFs". bug=334626 r+sr=roc 2006-08-30 13:38:16 +00:00
uriber@gmail.com
7316f30edc Bug 309286: Caret moves incorrectly in some cases of bidi HTML contained within an inline element in LTR context. r=smontagu sr=roc 2006-03-14 09:16:40 +00:00
uriber@gmail.com
9e6d525d10 Implement the LockInScrollView mechanism for the visual iterator. bug=320874 r=smontagu sr=roc 2006-03-13 20:19:05 +00:00
cbiesinger@web.de
aae44b57d9 bug 183156 remove *UCS2* functions, replacing them with *UTF16* ones 
r+sr=darin
 2006-02-03 14:18:39 +00:00
roc+@cs.cmu.edu
0ae5b0c3c5 Bug 296628. Don't crash when traversal is at the root and we try to go up. r+sr=bzbarsky,a=asa 2005-06-17 02:50:15 +00:00
dougt@meer.net
fad485f388 Focus frame traversal has been broken since a frame reorder (scrollbars are now first followed by the canvas frame). patch by roc, r=bzbarsky, a=shaver 2005-06-01 15:59:59 +00:00
bzbarsky@mit.edu
103741623b Fix crash regression in bug 276954. r+sr+a=dbaron 2005-04-16 06:18:47 +00:00
bzbarsky@mit.edu
d2d558b095 Don't copy/paste code to cast to placeholder frames all over the place; use a 
utility method instead.  Bug 276954, r+sr=roc, a=brendan
 2005-04-14 15:30:35 +00:00
bryner@brianryner.com
6cde4639f0 Change nsIPresContext to nsPresContext globally, follow-up to bug 253470. rs=roc 2004-07-31 23:15:21 +00:00
gerv@gerv.net
a1ec040a65 Bug 236613: change to MPL/LGPL/GPL tri-license. 2004-04-18 14:30:37 +00:00
roc+@cs.cmu.edu
1b8ec3f338 Fix warnings about uninitialized 'result' in nsFrameTraversal. r+sr=brendan 2004-01-09 21:45:24 +00:00