Commit Graph

46 Commits

Author SHA1 Message Date
John Paul Adrian Glaubitz
f174fd2eb9 Bug 972945 - Add autoconf test to enable AltiVec on supported targets only. r=glandium
Currently, the build scripts enable AltiVec unconditionally on all ppc*
targets. However, there some ppc* targets which do not support AltiVec
instruction set extensions, these are often embedded systems like the
PowerPC e500 or similar which have their own type of instruction set
extensions like SPE. Trying to enable Altivec support on these targets
results in a compiler error, hence we need to add an autoconf test for
AltiVec support before trying to enable it on ppc* targets.

Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
2016-08-16 05:17:00 -04:00
Nicholas Nethercote
21c04f7cad Bug 1205533 - Fix and disallow warnings in gfx/qcms/. r=jrmuizel.
This patch fixes various warnings from MSVC.

- Several "truncation from 'double' to 'float'" warnings, easily fixed by
  appending 'f' to literals.

- Some "signed/unsigned mismatch" warnings. In read_tag_lutType(), MSVC is
  apparently promoting the multiplication of a uint8_t and a uint16_t to an
  int32_t, oddly enough. A uint32_t cast fixes the warning.

- |offset| was unused in qcms_data_create_rbg_with_gamma().

- A couple of "overflow in floating-point constant arithmetic" warnings
  involving INFINITY in transform_util.c. There is some type confusion here --
  in C99 HUGE_VAL is a double and INFINITY is a float. So the HUGE_VAL here
  should actualy be HUGE_VALF. But, strangely enough, that isn't enough to
  avoid the warning, I don't know why. However, it turns out that any
  non-positive value for |interval| will have the same effect, so I just
  removed all the INFINITY/HUGE_VAL stuff and used -1 instead.

It also fixes an ARM-only GCC warning.

- "'__force_align_arg_pointer__' attribute directive ignored". This is an
  x86-only attribute. Instead of disabling it on x86-64, instead enable it on
  i386 (which avoids enabling it uselessly on ARM).
2015-09-17 17:11:27 -07:00
David Major
bf9c8a2243 Bug 1168480 - Fix potential leaks in qcms_transform_create. r=seth 2015-05-26 22:18:55 -04:00
Seth Fowler
ceeb57fbba Bug 1163740 - Paper over qcms crashes due to NaN values in qcms_transform::matrix. r=dmajor 2015-05-26 17:34:21 -07:00
Shashank Sabniveesu
e3e8e7e875 Bug 692922 - Fix use of posix_memalign() avoiding typecasts. r=BenWa 2014-05-08 20:43:37 -04:00
guozhu cheng
286803fea7 Bug 907196 - Split CreateCMSOutputProfile profile loading into GetCMSOutputProfileData. r=BenWa, r=jmuizelaar 2013-11-07 18:20:08 +08:00
Ryan VanderMeulen
01522d024c Backed out changeset ef14be22d6f7 (bug 907196) for Windows bustage.
CLOSED TREE
2014-01-13 10:25:52 -05:00
guozhu cheng
aeaa53c39b Bug 907196 - Split CreateCMSOutputProfile profile loading into GetCMSOutputProfileData. r=BenWa, r=jmuizelaar 2013-11-07 18:20:08 +08:00
Joe Drew
ca30eca1e9 Bug 853169 - Make qcms precache reference counts threadsafe/atomic. r=jrmuizel 2013-03-21 23:09:37 -04:00
Joe Drew
cb54855460 Backed out 3 changesets (bug 853628, bug 853169) for crashing mysteriously
Backed out changeset c0befbf2533d (bug 853169)
Backed out changeset 2e318d0a172b (bug 853169)
Backed out changeset 69f965c0fd46 (bug 853628)
2013-03-22 00:27:58 -04:00
Joe Drew
0dc311dd9c Bug 853169 - Make qcms precache reference counts threadsafe/atomic. r=jrmuizel 2013-03-21 23:09:37 -04:00
Phil Ringnalda
b48577984b Back out d77773a8abf9 and eca6b3ea3e8d (bug 853169) for Linux xpcshell crashes
CLOSED TREE
2013-03-20 21:33:03 -07:00
Joe Drew
4ff43d02d4 Bug 853169 - Make qcms precache reference counts threadsafe/atomic. r=jrmuizel 2013-03-20 22:25:43 -04:00
Milan Sreckovic
f5a1bec7cb Bug 722831 - qcms_transform_precacheLUT_float only works with RGB data, so only call it in that case. Grayscale images would fail. r=bgirard 2013-02-08 15:48:09 -05:00
Steve Singer
b47d7f42fb Bug 832711 - Add header for ElfW(auxv_t) missed by bug 817153. r=jmuizelaar 2013-01-23 18:30:48 -05:00
Tobias Netzel
df36c9b7c6 Bug 817153 - AltiVec acceleration for qcms. r=jmuizelaar 2013-01-15 19:44:43 -05:00
Benoit Girard
ac5b1c5038 Bug 679527 - Avoid float operation in qcms transforms. r=jrmuizel 2012-10-19 18:23:07 -04:00
Benoit Girard
7f15ce230b Bug 679527 - Use floorf/ceilf in qcms transform function. r=jrmuizel 2012-10-19 16:35:36 -04:00
Jeff Muizelaar
744ba957f2 Bug 798758. qcms: Fix component order typo. r=Bas
This was caused by bug 791422 (bd16a5d51273)
2012-10-06 08:20:50 -04:00
Jeff Muizelaar
e14722f2c7 Bug 791422. Support more flexibiltiy qcms output format. r=BenWa
This will help support Chrome and should also let us output directly to a cairo
compatible format.
2012-10-03 19:04:25 -04:00
Benoit Girard
b680e82bbb Bug 752254 - qcms - Prefer precache output curves even if a A2B/B2A CLUT is present. r=jmuizelaar 2012-05-22 14:51:29 -04:00
Benoit Girard
0a51e893d5 Bug 701348 - qcms_transform_precacheLUT_float did not properly free dest buffer. r=jmuizelaar 2011-11-10 08:28:58 -05:00
Benoit Girard
128d2d0f0c Bug 674230 - Merge from qcms github branch v4; r=jmuizelaar 2011-07-27 10:11:19 -04:00
Jeff Muizelaar
3d59828bb0 qcms: avoid unnecessary promotion to double. r=ehsan 2011-05-10 12:01:48 -04:00
Jeff Muizelaar
9b5abe777e Bug 605179. qcms: revert build warning fixes. r=ehsan
0ec22e77aefc fixed some build warnings that no longer happen because pedantic is disabled.
2011-05-10 11:55:39 -04:00
Ms2ger
cf1d1ca8ca Bug 605179 - Fix build warnings in gfx/; r=roc a=bsmedberg 2010-12-05 18:38:12 +00:00
Benoit Girard
14e2198562 Bug 575142 - qcms_transform_create should use transform_free. r=jmuizellar 2010-07-24 20:10:15 -04:00
Jeff Muizelaar
c8721bef06 Bug 548612. qcms: Reduce size of output lookup tables. r=bgirard
We currently use a larger output lookup table than we probably need. Switch to
a common define for the table size and lower it. The should also give a small
improvement to startup time because we have fewer lookup table entries to
compute.
2010-06-04 14:48:30 -04:00
Steve Snyder
35338dde52 qcms: Replace second green table release with release of blue table
Cut 'n' paste gone awry: green output table freed instead of blue.

That is, there exists a release for red, 2 releases for green, and none for
blue.
2010-02-18 15:21:11 -05:00
Makoto Kato
9eafe0c2a9 Bug 536725 - Disable SSE1 code on Windows x64 r=jmuizelaar 2010-02-01 17:43:21 +09:00
Ginn Chen
b32413253d Bug 522440 QCMS: Make sse/sse2 code built with Sun Studio 12 on Solaris r=jmuizelaar, ted.mielczarek 2009-11-20 14:15:39 +08:00
Jeff Muizelaar
81cdfac93b Backout 8a790e81279e (bug 528322) because wince doesn't have powf.
The link error was obscured by other errors when I ran this on try...
2009-11-13 11:53:12 -05:00
Jeff Muizelaar
860d17ac9c Bug 528322. qcms: Avoid unneeded precision during table creation. r=joe
Switch from pow() to powf() because it's faster and we don't need the
additional precision.  Also avoid unnecessary conversion to and from doubles by
using float constants instead of doubles.
2009-11-13 10:14:13 -05:00
Steve Snyder
222246b6c4 Bug 512865. qcms: Improve SSE2 performance, add SSE support. r=jrmuizel
This patch greatly improves the performance of QCMS transformations on x86 &
x86_64 systems.  Some notes:

0. On 32-bit x86 systems it does runtime selection between non-SIMD, SSE, and
SSE2 code paths.

1. On x86_64 systems the SSE2 code path is always taken.  The non-SIMD and SSE
code paths are left intact, but contemporary versions of the GCC and MSVC
compilers will see that they cannot be reached and optimize them away.

2. The execution of the SSE2 code path is reduced by 67%, relative to the
original Intel/Microsoft formatted ASM code.  The relative performance is seen
on a Pentium4 (Northwood) 2.4GHz CPU with DDR1 RAM.

3. The SSE code path provides a 80% reduction in execution time, relative to
the non-SIMD code path.  The relative performance is seen on a Pentium3
(Coppermine) 1.26GHz CPU with SDRAM.

4. The code has been split out into separate files so that it can be built
with different cflags (-msse, and -msse2) when using gcc.

5. Try to land again, this time with __attribute__((__force_align_arg_pointer__))
to avoid crashes on linux.
2009-10-01 14:19:41 -04:00
Jeff Muizelaar
25f9fdb935 Backed out changeset cb4f078cc8cb (bug 512865)
Was causing crashes on the leak test box.
2009-09-24 23:35:53 -04:00
Steve Snyder
e24422b587 Bug 512865. qcms: Improve SSE2 performance, add SSE support. r=jrmuizel
This patch greatly improves the performance of QCMS transformations on x86 &
x86_64 systems.  Some notes:

0. On 32-bit x86 systems it does runtime selection between non-SIMD, SSE, and
SSE2 code paths.

1. On x86_64 systems the SSE2 code path is always taken.  The non-SIMD and SSE
code paths are left intact, but contemporary versions of the GCC and MSVC
compilers will see that they cannot be reached and optimize them away.

2. The execution of the SSE2 code path is reduced by 67%, relative to the
original Intel/Microsoft formatted ASM code.  The relative performance is seen
on a Pentium4 (Northwood) 2.4GHz CPU with DDR1 RAM.

3. The SSE code path provides a 80% reduction in execution time, relative to
the non-SIMD code path.  The relative performance is seen on a Pentium3
(Coppermine) 1.26GHz CPU with SDRAM.

4. The code has been split out into separate files so that it can be built
with different cflags (-msse, and -msse2) when using gcc.
2009-09-24 11:58:24 -04:00
d05bfffeab Bug 491195 fix warnings in qcms
mostly comparisons between unsigned and signed
also an incomplete initializer
and a warning about using C++ style variables
r=jrmuizel
2009-07-22 17:31:03 -05:00
Jeff Muizelaar
d8f332176a Bug 497363. qcms: Add reference to the rationale for not correcting alpha. r=joedrew 2009-06-12 14:38:32 -04:00
Jeff Muizelaar
9582e09cfe Bug 497363. qcms: Use a minimum of 256 entries when calling invert_lut. r=joedrew
Makes the number of output entries produced by invert_lut() a parameter and
changes all callers to use a minimum of 256 entries when computing the inverse.
2009-06-12 14:38:30 -04:00
Jeff Muizelaar
6747316398 Bug 488955 - Fix linear gamma input tables, used in iCCP PNG testsuite images. r=joe 2009-04-22 13:49:09 -04:00
Jeff Muizelaar
4d69af1c09 Bug 489133 - Handle bad cHRM chunks in PNGs. r=joe 2009-04-21 22:21:48 -04:00
Jeff Muizelaar
20fc6d3d83 Bug 489133 - Fix handling of bad whitepoints in PNGs. r=joe 2009-04-21 22:21:13 -04:00
Makoto Kato
5fa34b3485 Bug 487900 - Enable SSE2 code for x86_64 in qcms. r=jmuizelaar 2009-04-15 22:14:03 +09:00
Jeff Muizelaar
c77c0f248d Bug 481926 - Rewrite color management component sr=vlad, r=ted, r=joedrew (\o/)
Replaces lcms with qcms
2009-04-07 12:02:11 -04:00
Joe Drew
64dcaf7b09 Backed out changeset 6f3c2171bbb2:
Bug 481926 - Rewrite color management component. r=joe,ted sr=vlad
2009-04-03 16:27:27 -04:00
Jeff Muizelaar
e30918d02d Bug 481926 - Rewrite color management component. r=joe,ted sr=vlad 2009-04-03 15:09:56 -04:00