Commit Graph

10 Commits

Author SHA1 Message Date
Zibi Braniecki
e1617486a8 Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.

This allows us to remove a lot of calls for the app locale.

The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.

MozReview-Commit-ID: DzmFEUvMq3N
2017-03-14 16:09:54 -07:00
Sebastian Hengst
1f6ea2382a Backed out changeset cc308a73ad05 (bug 1347314) for eslint failure in test_device.html. r=backout 2017-03-22 18:20:26 +01:00
Zibi Braniecki
a56e4c7360 Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.

This allows us to remove a lot of calls for the app locale.

The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.

MozReview-Commit-ID: DzmFEUvMq3N
2017-03-14 16:09:54 -07:00
Tom Tromey
a67980a817 Bug 1321839 - make devtools/shared eslint-clean; r=jryans
MozReview-Commit-ID: AGSdhrT4Z3D
2016-12-02 10:32:04 -07:00
Tom Tromey
bd2b8192f3 Bug 1266839 - replace uses of nsIXULAppInfo in devtools; r=gregtatum
MozReview-Commit-ID: KIsffqE99hA
2016-07-15 14:04:02 -06:00
Tom Tromey
c8e6faf303 Bug 1273941 - replace uses of promise.defer in devtools/shared; r=jryans
MozReview-Commit-ID: 2n3uJ5QKsKL
2016-06-09 09:03:47 -06:00
Tom Tromey
86974842a1 Bug 1265869 - Add task.js and use in devtools. r=jryans
MozReview-Commit-ID: G5UuAh2RiZZ
2016-05-17 13:07:55 -06:00
J. Ryan Stinnett
530b903fcf Bug 1271084 - Apply ESLint autofixes to ignored /devtools files. r=tromey
For simple rules like function spacing, we can auto-fix these across the code
base so they are followed in a consistent way.

To generate this patch, I ran:

./mach eslint devtools --no-ignore --fix

After this, I reverted any changes to third party files that we really do want
to ignore.

MozReview-Commit-ID: 6Q8BApkAW20
2016-05-18 12:49:23 -05:00
Wellington Cordeiro
8523d6ccf6 Bug 933170 - Make it clear that we show gecko's resolution, not device's resolution. r=jryans 2016-05-06 12:04:00 -04:00
J. Ryan Stinnett
80b83da4ac Bug 1196047 - Move system.js to devtools/shared. r=jsantell 2015-10-09 18:26:04 -05:00