In bug 1313933, we removed the session store black magic that RDM used to do in
order to hide the container tab.
Unfortunately, that fix appears to have been imperfect. Session store has a
fallback path that can still record the current URL, causing the container URL
to be recorded anyway, even though we asked nicely to please not do that.
In this change, we try a fresh approach of wedging the session history listener
for the container tab so it can't record anything. This avoids the racy
approach that was used before bug 1313933 while still appearing to block the
container URL from being recorded.
MozReview-Commit-ID: JZTYzMAvaEM
The action creator for removing custom devices calls the one for remove device
association directly, which skips the step of also messaging the manager.
I've made the simplest change to fix just this issue, which moves the message
sending into the action creator for this one case. Bug 1332754 will apply the
same approach to other messages (they aren't causing issues yet since they are
not called from other action creators in the same way).
MozReview-Commit-ID: AICcT2vG1wl
If a device is active, remove it on resize. If not, leave device properties
alone, so that things like touch simulation stay enabled when resizing without
a device.
MozReview-Commit-ID: Hvo6AdTJRBJ
Use "change" instead of "update" terminology with viewport properties.
Remove redundant "viewport" word from viewport changes.
MozReview-Commit-ID: HSFLiZyTVYy
- Added `addDeviceForTest` that removes automatically the device added at the
end of the test.
- Improved `switchDevice` with more assertions.
MozReview-Commit-ID: D1BJozD65uj
This is done by making the RDM APIs used by the style editor and its test for
this feature the same across old and new RDM, so that the test will work with
either version.
MozReview-Commit-ID: CdM6qeZQqni
The primary browser navigational UI should now behave as if it's connected to
the page content in the viewport, including things like:
* Content page's URL is displayed in location bar
* Content page's title is displayed on the tab
* Back / forward navigates the viewport
* Entering a location navigates the viewport
* Page loading progress is displayed in the status bar as usual
MozReview-Commit-ID: FzxWEwj13sJ
- removed responsive.html/events.js
- added `isActiveForWindow` method to `ResponsiveUIManager`
- simplified how the check for RDM menu is done
- re-enabled tests for OS X debug in e10s
- refactored tests using `BrowserTestUtils`
MozReview-Commit-ID: 1TADh1dRVcU
Watch for the tab's `beforeunload` and destroy RDM when it happens. This
resolves issues with session restore getting confused about the state of content
managed by RDM.
MozReview-Commit-ID: DXs87Xm11JR
This change brings the following improvements to RDM:
* Page state is preserved when toggling in and out of RDM
* Session history is no longer manipulated, so the tool UI won't end up in the
tab's back-forward page list.
Known issues to be fixed later:
* The browser UI is not hooked up to the viewport browser
* Restarting the browser with the tool open shows a confused, empty RDM
MozReview-Commit-ID: Fb6QRv6LYow
ESLint 2 now flags anonymous generator functions according to
generator-star-spacing. Most of the changes here are correcting that.
MozReview-Commit-ID: 9xg2Gmlaz94
