This version addresses some popup sizing bugs, and also a few other issues I
ran into when debugging Blake's problems:
* The standalone popup needs a max width of 800px for Chrome compatibility,
which is wider than our default max width.
* I added a flex attribute to our browser so that it fills the entire space
of the slide-in panel. This is only necessary for browsers with content
that is shorter than the height of the panel when it gets its desired
width, but becomes longer when it doesn't, so it didn't show up in my
initial tests.
* I also added an extra pixel to the width calculations, since I noticed that
a lot of single lines of text were unexpectedly wrapping without it. I'll
look into this more in a follow-up bug.
I also added some comments, and renamed a couple of variables, where things
seemed unclear.
The test changes are mostly just updates to older browser action tests to use
newer helpers, rather than ad-hoc events, to open/close/click the widgets. A
few tests also needed updates to explicitly close the panel when they were
done with it.
This version addresses some popup sizing bugs, and also a few other issues I
ran into when debugging Blake's problems:
* The standalone popup needs a max width of 800px for Chrome compatibility,
which is wider than our default max width.
* I added a flex attribute to our browser so that it fills the entire space
of the slide-in panel. This is only necessary for browsers with content
that is shorter than the height of the panel when it gets its desired
width, but becomes longer when it doesn't, so it didn't show up in my
initial tests.
* I also added an extra pixel to the width calculations, since I noticed that
a lot of single lines of text were unexpectedly wrapping without it. I'll
look into this more in a follow-up bug.
I also added some comments, and renamed a couple of variables, where things
seemed unclear.
The test changes are mostly just updates to older browser action tests to use
newer helpers, rather than ad-hoc events, to open/close/click the widgets. A
few tests also needed updates to explicitly close the panel when they were
done with it.
part 1: reorganize file locations, r=Gijs
part 2: remove built-in pocket code, r=Gijs
part 3: l10n support, r=glandium
part 4: move code/functionality from part 2 into the addon, r=Gijs
part 5: remove dead code, r=Gijs
part 6: create a simple api for addons to add to reader mode, r=Gijs
part 7: various test fixes related to cui behaviour and pocket, r=me
This patch leverages broadcasters to keep the various sync UI elements sane.
Rather than adding yet another button ID to browser-syncui, we now just update
the broadcaster and let all the elements automagically get the attributes.
