Commit Graph

53 Commits

Author SHA1 Message Date
Zibi Braniecki
8c433fc56a Bug 1346616 - Migrate callsites that are retrieving requested locale from pref, to use LocaleService::GetRequestedLocales. r=jfkthame,Pike
I'm adding a helper function mozILocaleService::GetRequestedLocale to simplify
most of the callsites that are looking for the first of the requested locales.

In most cases, I'm just matching the behavior of the code with reusing
LocaleService API instead of direct manipulation on the prefs.
That includes how I handle error case scenarios.

In case of sdk/l10n/locale.js I am reusing LocaleService heuristics over
the custom one from the file since the ones in LocaleService are just
more correct and unified accross the whole platform.

In case of FallbackEncoding I have to turn it into a nsIObserver to listen
to intl:requested-locales-changed.

MozReview-Commit-ID: 7rOr2CovLK
2017-03-11 18:43:11 -08:00
Sebastian Hengst
017c2ee2bf Backed out changeset 60d72c2dd49d (bug 1346616) for eslint failure in DirectoryLinksProvider.jsm. r=backout on a CLOSED TREE 2017-04-18 00:48:16 +02:00
Zibi Braniecki
64bae2dccf Bug 1346616 - Migrate callsites that are retrieving requested locale from pref, to use LocaleService::GetRequestedLocales. r=jfkthame,Pike
I'm adding a helper function mozILocaleService::GetRequestedLocale to simplify
most of the callsites that are looking for the first of the requested locales.

In most cases, I'm just matching the behavior of the code with reusing
LocaleService API instead of direct manipulation on the prefs.
That includes how I handle error case scenarios.

In case of sdk/l10n/locale.js I am reusing LocaleService heuristics over
the custom one from the file since the ones in LocaleService are just
more correct and unified accross the whole platform.

In case of FallbackEncoding I have to turn it into a nsIObserver to listen
to intl:requested-locales-changed.

MozReview-Commit-ID: 7rOr2CovLK
2017-03-11 18:43:11 -08:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Fischer.json
28360e42ce Bug 1309123 - Show persistent-storage permission request notification, r=florian
MozReview-Commit-ID: H3YAalEyWME
2017-04-11 12:07:29 +08:00
Prathiksha
5a945dceda Bug 1224137 - List the 'allow pages from <example.com> to take you to their tab' permission (for alerts/prompts) in the site identity / permission panel. r=johannh
MozReview-Commit-ID: LIsJ8VG0stN
2017-04-09 11:45:01 +05:30
Johann Hofmann
8a0dbf708e Bug 1349990 - Update host matching for webrtc prompts. r=Paolo
MozReview-Commit-ID: IIuHvVTy2G7
2017-03-24 13:13:18 +01:00
Jared Wein
5a181760cc Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx
2017-03-21 14:29:43 -04:00
Mark Banner
ec9074e132 Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r=jaws
MozReview-Commit-ID: LH0CQOPfoe6
2017-03-20 12:36:37 +01:00
Florian Quèze
c1bca211b8 Bug 1345294 - add an eslint rule to reject usage of {get,set}ComplexValue for nsISupportsString and suggest {get,set}StringPref instead, and make it pass, r=Mossop. 2017-03-16 19:26:02 +01:00
Florian Quèze
49d8db6821 Bug 1345294 - script generated patch (+ some hand cleanup) to replace {get,set}ComplexValue for nsISupportsString by {get,set}StringPref, r=Mossop. 2017-03-16 19:26:01 +01:00
Mark Banner
8aae1860ea Bug 1086549 - Converting browser tests from removePage to History.remove. Patch by Yoric, updated by Standard8. r=mak
MozReview-Commit-ID: BdRCP6DOHZS
2017-03-08 20:39:05 +00:00
Mark Banner
320eaf1633 Bug 1343521 - Move the mochitests in browser/modules/test/ to their own subdirectory. r=jaws
MozReview-Commit-ID: AV3QzLofo2w
2017-03-01 17:10:16 +00:00
Mark Banner
55868dde7c Bug 503613 - Remove old 'tail =' lines from xpcshell.ini files; r=gps
MozReview-Commit-ID: 62Hp5ISxowJ
2017-01-18 10:30:39 +00:00
Florian Quèze
45647c4570 Bug 1329182 - remove trailing newURI null parameters in browser/, r=jaws. 2017-01-09 20:27:25 +01:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Dave Townsend
4e295aa48d Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz
2016-11-11 08:10:51 -08:00
Dave Townsend
b0f59ac265 Bug 1316882: Turn on func-call-spacing eslint rule. r=bgrins
MozReview-Commit-ID: GIkQnRX9woD
2016-11-10 15:05:32 -08:00
Dave Townsend
12596ced47 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws
MozReview-Commit-ID: HBpjT2uHJaZ
2016-11-10 14:48:04 -08:00
Jared Wein
b6817d7876 Bug 1315781 - Enable no-shadow rule for eslint for xpcshell mochitests. r=mossop
MozReview-Commit-ID: 1mhCWplknyN
2016-11-07 22:34:25 -05:00
Iris Hsiao
d24e67dbe4 Backed out changeset f6f28be8d8f2 (bug 1315781) for XPCShell test timed out 2016-11-10 14:53:46 +08:00
Jared Wein
0c41af265f Bug 1315781 - Enable no-shadow rule for eslint for xpcshell mochitests. r=mossop
MozReview-Commit-ID: DnpVQRrG9Ec
2016-11-07 22:34:25 -05:00
Sebastian Hengst
d1c538318e Bug 1310297 - Remove test annotations using b2g, mulet or gonk: browser. r=RyanVM
MozReview-Commit-ID: LDNr97hKpc8
2016-11-05 11:29:13 +01:00
Mark Banner
233309fbe2 Bug 1251003 - Change .eslintrc files to .eslintrc.js to avoid obsolete config file format. r=mossop
MozReview-Commit-ID: JrbFxQ5rj6I
2016-10-18 08:38:10 +01:00
Shane Caraveo
242f1d454e Bug 1289549 P3 socialapi move toolkit component to browser, r=florian
MozReview-Commit-ID: 2rMDwrZTTpG
2016-08-23 15:24:07 -07:00
Tooru Fujisawa
412ae0e2a1 Bug 1256088 - Merge mock app-info implementation into AppInfo.jsm. r=gps 2016-03-16 16:58:29 +09:00
Dave Townsend
8dc7f59eb3 Bug 1229142: Link browser and toolkit test directory to the shared eslintrc files. r=Standard8 2015-11-30 13:05:00 -08:00
Carsten "Tomcat" Book
036e6d2fa3 Backed out 2 changesets (bug 1202902) to recking bug 1202902 to be able to reopen inbound on a CLOSED TREE
Backed out changeset 647025383676 (bug 1202902)
Backed out changeset d70c7fe532c6 (bug 1202902)
2015-10-07 14:03:21 +02:00
Carsten "Tomcat" Book
12369728f5 Backed out 1 changesets (bug 1202902) for causing merge conflicts to mozilla-central
Backed out changeset cfc1820361f5 (bug 1202902)
2015-10-07 12:13:45 +02:00
Shu-yu Guo
474f49adb7 Bug 1202902 - Scripted fix the world. 2015-10-06 14:00:31 -07:00
Shu-yu Guo
37989840cd Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Andrew Halberstadt
11b824f09b Bug 1066735 - Remove root b2g and android specific xpcshell manifests, r=chmanchester 2014-10-07 18:18:28 -04:00
Birunthan Mohanathas
d439a5124b Bug 1044446 - Collapse test-only moz.build files under browser/ into ancestor moz.build files. r=gps 2014-07-28 18:02:44 -07:00
Nathan Froyd
388930da96 Bug 1043554 - remove redundant social/ {Makefile,moz.build}; r=mshal
XPCSHELL_RESOURCES seems to be leftover from pre-manifest days, and the
manifest already has everything we need.
2014-07-24 15:04:26 -04:00
Shane Caraveo
44d24f6077 Bug 1032432 remove builtin manifest support, r=felipe 2014-07-18 10:27:52 -07:00
Bill McCloskey
299fa136b5 Bug 1005696 - Make sure test blocklist.xml isn't overwritten before use (r=Unfocused) 2014-06-20 17:46:02 -07:00
Shane Caraveo
aaebc260ff bug 894806 [Australis] refactor and remove social.provider, r=markh 2014-03-11 19:25:45 -07:00
Florian Quèze
b5a6179e98 Bug 930641 - Remove the social.allowMultipleWorkers preference, r=mixedpuppy. 2013-12-18 16:50:05 +01:00
Gregory Szorc
189afd1a65 Bug 901990 - Part 2: Upgrade xpcshell manifests; r=ted 2013-09-24 11:50:08 -07:00
Shane Caraveo
af3542d2c2 bug 914926 fix workers on startup when social disabled, r=markh 2013-09-19 10:25:08 -07:00
Phil Ringnalda
743b11ad64 Backed out changeset acce93fb65a1 (bug 914926)
CLOSED TREE
2013-09-16 17:55:08 -07:00
Shane Caraveo
193735459a Bug 914926 - Fix workers on startup when social disabled. r=markh
CLOSED TREE
2013-09-14 10:16:47 -07:00
Ryan VanderMeulen
7995bfbdd6 Speculatively backout changeset bc8d1b9545c5 (bug 914926) on suspicion of causing intermittent Windows XP debug mochitest-bc crashes.
CLOSED TREE
2013-09-16 16:53:54 -04:00
Shane Caraveo
28ec2e5b6b bug 914926 fix workers on startup when social disabled, r=markh 2013-09-14 10:16:47 -07:00
Matt Brubeck
8966877b33 Bug 840287 - Move NewTabUtils.jsm into toolkit [r=ttaubert] 2013-02-16 20:16:16 -08:00