Commit Graph

6 Commits

Author SHA1 Message Date
Mythmon
f42d4b51b4 Bug 1336501 - Sync shield-recipe-client from GitHub (ad0f45e) r=Gijs
MozReview-Commit-ID: KiDjjs2qpk5
2017-02-08 09:51:55 -08:00
Mark Banner
ba10e01046 Bug 1336070 - Enable eslint no-undef for browser/, apart from components/ and base/content/. r=mossop
MozReview-Commit-ID: CJtpm8zlLxa
2017-02-02 09:08:42 +00:00
Gijs Kruitbosch
e7055beaab Bug 1330954 - fix leakiness of SHIELD system add-on and re-enable test, r=kmag,mythmon
There are 3 issues this tackles:
- we were keeping a reference to the notification we added (this.notice),
  which kept windows alive.
- we had the CleanupManager keep a reference to our close method, which kept
  a reference to us, which kept a reference to the window.
- the fact that we use timeouts to call this.close() in 2 places meant
  this.close would get called multiple times, which meant we errored out on
  later occasions, because various things had been nulled out. This tidies up
  the timeouts when cleanup is called to avoid re-entrancy/errors/leaks.

MozReview-Commit-ID: EYvK7bQEh3X
2017-01-13 13:42:47 +00:00
Mythmon
0a8023ce47 Bug 1308656 - Add shield-recipe-client as system add-on r=Gijs,rhelmer
MozReview-Commit-ID: KNTGKOFXDlH
2016-10-10 16:14:56 -07:00
Sebastian Hengst
1d4dfdf50e Backed out changeset a53f5aa00347 (bug 1308656) for syntax error in browser_dbg_searchbox-parse.js (line cut off). r=backout 2016-12-21 09:44:17 +01:00
Mythmon
8c64984947 Bug 1308656 - Add shield-recipe-client as system add-on r=Gijs,rhelmer
MozReview-Commit-ID: KNTGKOFXDlH
2016-10-10 16:14:56 -07:00