Commit Graph

29 Commits

Author SHA1 Message Date
Jared Wein
5a181760cc Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx
2017-03-21 14:29:43 -04:00
Zibi Braniecki
e1617486a8 Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.

This allows us to remove a lot of calls for the app locale.

The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.

MozReview-Commit-ID: DzmFEUvMq3N
2017-03-14 16:09:54 -07:00
Sebastian Hengst
1f6ea2382a Backed out changeset cc308a73ad05 (bug 1347314) for eslint failure in test_device.html. r=backout 2017-03-22 18:20:26 +01:00
Zibi Braniecki
a56e4c7360 Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.

This allows us to remove a lot of calls for the app locale.

The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.

MozReview-Commit-ID: DzmFEUvMq3N
2017-03-14 16:09:54 -07:00
Mark Banner
358fce1e31 Bug 1343519 - Change the ESLint rule 'import-browserjs-globals' to be an environment (mozilla/browser-window) to better describe the purpose of it. r=mossop
MozReview-Commit-ID: FTDV8BcMGeF
2017-03-01 21:29:52 +00:00
Mark Banner
ba10e01046 Bug 1336070 - Enable eslint no-undef for browser/, apart from components/ and base/content/. r=mossop
MozReview-Commit-ID: CJtpm8zlLxa
2017-02-02 09:08:42 +00:00
Florian Quèze
c32c931bc9 Bug 1334831 - script-generated patch to use .remove() instead of .parentNode.removeChild, r=jaws. 2017-01-30 08:10:22 +01:00
Jared Wein
0ec522d5b6 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a
2017-01-17 09:48:17 -06:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Gijs Kruitbosch
41dd46ed97 Bug 1320039, r=kmag,wladimir
MozReview-Commit-ID: Fsj4bG5e2gT
2016-11-24 11:21:05 +00:00
Jared Wein
ef8b1e86ca Bug 1316870 - Enable no-shadow eslint rule for browser/. r=mossop 2016-11-15 22:58:30 -05:00
Dave Townsend
12596ced47 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws
MozReview-Commit-ID: HBpjT2uHJaZ
2016-11-10 14:48:04 -08:00
Mark Banner
f1870b61b8 Bug 1315615 - Fix no-unused-vars issues in the Pocket extension. r=jaws
MozReview-Commit-ID: 4L8XCRo1PWe
2016-11-07 08:57:40 +00:00
Shane Caraveo
b2aa7c2779 Bug 1304151 add finished locales and a couple minor bug fixes, r=flod,Gijs
MozReview-Commit-ID: eyeDj5nxXE
2016-09-28 23:29:52 -07:00
Shane Caraveo
48d05d6f98 Bug 1304142 pocket a/b test updates, r=Gijs
MozReview-Commit-ID: ChBRc81QQ7Y
2016-09-20 16:06:37 -07:00
Jared Wein
4518d81cb5 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt
2016-08-04 03:28:58 -04:00
Michael Kaply
b72a94415a Bug 1287476 - Clear panel handlers to avoid double page. r=Gijs 2016-07-18 12:12:01 -05:00
Michael Kaply
b086b3340a Bug 1276054 - Uplift pocket changes from partner. r=gijs 2016-07-05 09:34:30 -05:00
Ryan VanderMeulen
cfd8d773ca Backed out changeset 0b20196061d7 (bug 1276054) for browser_UITour_pocket.js failures. 2016-06-24 15:41:09 -04:00
Michael Kaply
2502648f23 Bug 1276054 - Uplift pocket changes from partner. r=gijs 2016-06-23 10:48:39 -05:00
Dave Townsend
aebdf4481b Bug 1245649: Turn on no-irregular-whitespace and no-mixed-spaces-and-tabs. r=jaws 2016-02-03 18:09:49 -08:00
Dave Townsend
a215a4a95a Bug 1245649: Turn on no-extra-semi. r=markh 2016-02-03 17:27:36 -08:00
Shane Caraveo
73d9d8fb9d Bug 1235873 fix pocket panel size when in menu panel, r=Gijs 2016-01-22 17:39:59 -08:00
Shane Caraveo
ee64a8946a Bug 1236755 use about urls for panel iframes, r=Gijs 2016-01-12 09:27:33 -08:00
Dave Townsend
a37b82025e Bug 1237340: Fix browser and toolkit eslint failures. r=Felipe 2016-01-06 10:10:35 -08:00
Shane Caraveo
3d87f487dc Bug 1215694 move pocket to a system addon, r=Gijs, r=glandium
part 1: reorganize file locations, r=Gijs
  part 2: remove built-in pocket code, r=Gijs
  part 3: l10n support, r=glandium
  part 4: move code/functionality from part 2 into the addon, r=Gijs
  part 5: remove dead code, r=Gijs
  part 6: create a simple api for addons to add to reader mode, r=Gijs
  part 7: various test fixes related to cui behaviour and pocket, r=me
2015-12-29 15:40:52 -08:00