Commit Graph

129 Commits

Author SHA1 Message Date
Florian Queze
6cc0b6e992 Bug 1355056 - replace (function(args) { /* do stuff using this */ }).bind(this) with arrow functions, r=jaws. 2017-04-27 00:25:45 +02:00
Joel Maher
12505893fc Bug 1355088 - add BUG_COMPONENT to browser/* files. r=mossop
MozReview-Commit-ID: 88mDTdI0oN7
2017-04-19 08:11:47 -04:00
Eugen Sawin
1f617c1192 Bug 1355542 - [2.0] Remove unused web progress callbacks and add missing progress filters. r=felipe 2017-04-13 23:20:17 +02:00
Zack Herrick
50c0d3d538 Bug 1335907 - Reorganize the preferences based on feedback from user research. r=mconley
The FX_PREFERENCES_CATEGORY_OPENED probe must be extended to version 59 to support the fallback "forked" preference implementation (in-content-old).

The switchToAdvancedSubPane within utilityOverlay's openPreferences must also remain until the fallback has been removed (bug 1349689).

Patch co-authored by Zack Herrick <herrickz@msu.edu> and Ziyan Long <lzylong@gmail.com>.

MozReview-Commit-ID: 1sx0Wj15yM7
2017-03-29 11:52:08 -04:00
Jared Wein
5a181760cc Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx
2017-03-21 14:29:43 -04:00
Zibi Braniecki
e1617486a8 Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.

This allows us to remove a lot of calls for the app locale.

The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.

MozReview-Commit-ID: DzmFEUvMq3N
2017-03-14 16:09:54 -07:00
Sebastian Hengst
1f6ea2382a Backed out changeset cc308a73ad05 (bug 1347314) for eslint failure in test_device.html. r=backout 2017-03-22 18:20:26 +01:00
Zibi Braniecki
a56e4c7360 Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.

This allows us to remove a lot of calls for the app locale.

The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.

MozReview-Commit-ID: DzmFEUvMq3N
2017-03-14 16:09:54 -07:00
Mark Banner
ec9074e132 Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r=jaws
MozReview-Commit-ID: LH0CQOPfoe6
2017-03-20 12:36:37 +01:00
Mark Banner
7d691acb44 Bug 1344027 - Fix most of the remaining ESLint no-undef issues in browser/components. r=jaws
MozReview-Commit-ID: DUnxVITvZgh
2017-03-03 09:29:14 +00:00
Florian Quèze
91f7a2ef3a Bug 1331599 - script-generated patch to replace removeEventListener calls with the once option when possible, r=jaws. 2017-01-25 07:01:52 +01:00
Mark Banner
55868dde7c Bug 503613 - Remove old 'tail =' lines from xpcshell.ini files; r=gps
MozReview-Commit-ID: 62Hp5ISxowJ
2017-01-18 10:30:39 +00:00
Jared Wein
601c1e5636 Bug 1331661 - Manually fix the remaining 'quotes' errors for eslint. r=Gijs
MozReview-Commit-ID: 7iXjQtp9ftV
2017-01-17 10:38:58 -06:00
Jared Wein
0ec522d5b6 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a
2017-01-17 09:48:17 -06:00
Mark Banner
ac52569fff Bug 1329614 - [eslint] Catch more cases of importing globals from 'var foo = Cu.import('...');'. r=jaws
MozReview-Commit-ID: 5NKHHb70YA6
2017-01-09 10:12:26 +00:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Jared Wein
ef8b1e86ca Bug 1316870 - Enable no-shadow eslint rule for browser/. r=mossop 2016-11-15 22:58:30 -05:00
Dave Townsend
4e295aa48d Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz
2016-11-11 08:10:51 -08:00
Sebastian Hengst
d1c538318e Bug 1310297 - Remove test annotations using b2g, mulet or gonk: browser. r=RyanVM
MozReview-Commit-ID: LDNr97hKpc8
2016-11-05 11:29:13 +01:00
Mark Banner
0dc78b7964 Bug 1314918 - Fix most of the remaining no-unused-vars issues for local scope in browser/. r=mossop
MozReview-Commit-ID: LdoXLniNeT7
2016-11-03 11:51:48 +00:00
Jared Wein
0c024fa9ca Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
MozReview-Commit-ID: 7Gx90a5y8t6
2016-10-24 13:14:19 -04:00
jordan9769
701059464d Bug 1311349 - Enable eslint of browser/components/translation/; r=florian,standard8
MozReview-Commit-ID: 4hIAnfs3qL0
2016-10-27 01:41:58 +05:30
Mark Banner
233309fbe2 Bug 1251003 - Change .eslintrc files to .eslintrc.js to avoid obsolete config file format. r=mossop
MozReview-Commit-ID: JrbFxQ5rj6I
2016-10-18 08:38:10 +01:00
Eitan Isaacson
e059073278 Bug 1308021 - Replace "iw" with "he" in cld2 detectLanguage results. r=florian
I have a pull request for these changes upstream:
https://github.com/CLD2Owners/cld2/pull/50

MozReview-Commit-ID: LUqrA4Genv0
2016-10-07 14:35:45 -07:00
Ryan VanderMeulen
89924435a4 No bug - Enable some e10s that pass and add some more annotations to ones that don't. 2016-05-09 17:01:16 -04:00
Mike de Boer
a5c8a12fbb Bug 1241930: Part 2 - convert all assertion methods used inside content tasks to the Assert.* family in browser tests. r=mconley 2016-03-04 14:32:24 +01:00
Kris Maglione
9b2ea3b213 Bug 1248501 - Allow fuller use of the CLD2 API from LanguageDetector.detectLanguage. r=florian r=azakai
MozReview-Commit-ID: 9UGcu0lssGa
2016-02-18 13:59:59 -08:00
Mike Conley
fe02bc0e8e Bug 1233497 - Run translation tests within ContentTasks to avoid CPOW usage. r=mikedeboer 2016-01-04 17:33:19 -05:00
Shu-yu Guo
90b93e6d5b Bug 1220564 - Update chrome code uses of genexprs and legacy comprehensions. (r=billm) 2016-01-06 16:02:16 -08:00
Dave Townsend
8dc7f59eb3 Bug 1229142: Link browser and toolkit test directory to the shared eslintrc files. r=Standard8 2015-11-30 13:05:00 -08:00
Chirath R
6e37d10e35 Bug 1216941 - Remove outset class from custom notification bar bindings. r=dao 2015-10-23 12:23:05 +02:00
Tooru Fujisawa
a2d438cd88 Bug 1207491 - Part 20: Remove use of expression closure from browser/components/translation/. r=Gijs 2015-09-23 18:36:24 +09:00
Georg Fritzsche
cc141d1325 Bug 1205968 - Remove TranslationProvider category registration and manifest. r=felipe 2015-09-21 00:02:04 -07:00
Shu-yu Guo
37989840cd Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Iaroslav Sheptykin
d3f1c02874 Bug 1121006 - Migrate translation component from FHR to telemetry histograms. r=gfritzsche 2015-08-21 22:55:30 +02:00
Brian Birtles
b8e1747a1e Bug 1189630 - Make browser_translation_exceptions.js wait for infobar to finish animating; r=florian 2015-08-07 09:01:09 +09:00
Iaroslav (yarik) Sheptykin
f8cbf6904e Bug 1191306 - Replacing .includes with indexOf to avoid test failures on Aurora. r=felipe 2015-08-05 16:47:22 +02:00
Iaroslav Sheptykin
34d74cad80 Bug 1174468 - Show Yandex.Translate attribution when Yandex engine is selected. r=felipc 2015-07-20 06:54:00 -04:00
Michael Layzell
d6aa873ac4 Bug 1173523 - Part 6: Update translation to use new API for nsIPermission, r=florian 2015-07-16 14:49:31 -04:00
Wes Kocher
c06754ff70 Backed out 24 changesets (bug 1173523, bug 1172080, bug 817007, bug 1165263) for android reftest bustage CLOSED TREE
Backed out changeset 84fe04b2e7d1 (bug 1172080)
Backed out changeset 0ff004760a1f (bug 1172080)
Backed out changeset af147585ad55 (bug 1165263)
Backed out changeset c3af8ebb6db0 (bug 1165263)
Backed out changeset cd3f33a888fe (bug 1165263)
Backed out changeset e5db39044a1e (bug 1165263)
Backed out changeset c01c9ed77061 (bug 1165263)
Backed out changeset fb723aaa4267 (bug 1165263)
Backed out changeset f754e52e74dc (bug 1165263)
Backed out changeset c6bda3a0afd6 (bug 817007)
Backed out changeset bfa100253349 (bug 817007)
Backed out changeset b787b3f9aadc (bug 1173523)
Backed out changeset 4a0676b73f77 (bug 1173523)
Backed out changeset 82034a4560c5 (bug 1173523)
Backed out changeset 4bdb91114c7a (bug 1173523)
Backed out changeset 72406261eccc (bug 1173523)
Backed out changeset 541b6faf7196 (bug 1173523)
Backed out changeset 1caac4569616 (bug 1173523)
Backed out changeset 0d4f9f9e1b4e (bug 1173523)
Backed out changeset 2d5661eb966c (bug 1173523)
Backed out changeset 89833c0bb0cd (bug 1173523)
Backed out changeset ea64d70eacfe (bug 1173523)
Backed out changeset a8e4f1c0c445 (bug 1173523)
Backed out changeset cf498d466b85 (bug 1173523)
2015-07-14 14:00:32 -07:00
Michael Layzell
e9d8f23792 Bug 1173523 - Part 6: Update translation to use new API for nsIPermission, r=florian 2015-07-14 15:06:21 -04:00
Michael Layzell
20f33b6cf4 Bug 1170200 - Part 2: Update JavaScript consumers of nsIPermissionManager::Remove; r=ehsan 2015-07-03 17:12:27 -04:00
Ehsan Akhgari
7015e19689 Backout bug 1170200 because of test failures on a CLOSED TREE 2015-07-03 16:43:47 -04:00
Michael Layzell
b70b5a5766 Bug 1170200 - Part 2: Update JavaScript consumers of nsIPermissionManager::Remove; r=ehsan 2015-07-03 14:18:23 -04:00
Iaroslav Sheptykin
ade2c58f2c Bug 1129056 - Implement Yandex translation engine. r=felipe
Some parts of the patch by Felipe, with f=florian
2015-06-04 17:49:55 -03:00
ziyunfei
649e7033e4 Bug 1102219 - Part 4: Replace String.prototype.contains with String.prototype.includes in chrome code. r=till 2015-04-30 00:32:05 +09:00
Iaroslav Sheptykin
0112909f0b Bug 1012532 - Replace translation engine usage of RESTRequest with Http.jsm. r=felipe 2015-03-24 15:32:16 -03:00