corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
477,034 Commits 1 Branch 0 Tags
c76ce9f99a49d0cb15a2ad724b5db7f2b71142f6
Commit Graph

307 Commits

Author SHA1 Message Date
Florian Queze
6cc0b6e992 Bug 1355056 - replace (function(args) { /* do stuff using this */ }).bind(this) with arrow functions, r=jaws. 2017-04-27 00:25:45 +02:00
Zibi Braniecki
efdaa3952d Bug 1354445 - Migrate Intl.DateTimeFormat to mozIntl.DateTimeFormat in chrome. r=mak 
MozReview-Commit-ID: 4z13lcLXN9T
 2017-04-08 23:04:32 -07:00
Zibi Braniecki
e1617486a8 Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike 
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.

This allows us to remove a lot of calls for the app locale.

The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.

MozReview-Commit-ID: DzmFEUvMq3N
 2017-03-14 16:09:54 -07:00
Sebastian Hengst
1f6ea2382a Backed out changeset cc308a73ad05 (bug 1347314) for eslint failure in test_device.html. r=backout 2017-03-22 18:20:26 +01:00
Zibi Braniecki
a56e4c7360 Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike 
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.

This allows us to remove a lot of calls for the app locale.

The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.

MozReview-Commit-ID: DzmFEUvMq3N
 2017-03-14 16:09:54 -07:00
Florian Quèze
b15de4893d Bug 1345253 - Use element.firstChild.remove() instead of element.removeChild(element.firstChild), r=jaws. 2017-03-08 10:17:52 +01:00
Mark Banner
770421d220 Bug 909102 - Fix middle-clicking on a folder in the left panel of the Library (to open all items within the folder). r=mak 
MozReview-Commit-ID: 75Z8wOynfQh
 2017-03-02 11:34:43 +00:00
Mark Banner
7d691acb44 Bug 1344027 - Fix most of the remaining ESLint no-undef issues in browser/components. r=jaws 
MozReview-Commit-ID: DUnxVITvZgh
 2017-03-03 09:29:14 +00:00
Wes Kocher
fdeb9cafb4 Backed out changeset 55d9a513c90e (bug 909102) for browser_library_openFlatContainer.js failures a=backout 
MozReview-Commit-ID: 5Tj19H0K6bf
 2017-03-03 10:58:11 -08:00
Mark Banner
8885b0f26a Bug 909102 - Fix middle-clicking on a folder in the left panel of the Library (to open all items within the folder). r=mak 
MozReview-Commit-ID: 75Z8wOynfQh
 2017-03-02 11:34:43 +00:00
Jared Wein
0ec522d5b6 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs 
MozReview-Commit-ID: 6tv0Z06CO4a
 2017-01-17 09:48:17 -06:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN 
MozReview-Commit-ID: FuVu8skcqOe
 2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN 
MozReview-Commit-ID: 7E7LPorrEje
 2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout 
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
 2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN 
MozReview-Commit-ID: 8WoGr8i6oCR
 2016-12-29 15:20:47 -05:00
Jared Wein
ef8b1e86ca Bug 1316870 - Enable no-shadow eslint rule for browser/. r=mossop 2016-11-15 22:58:30 -05:00
Dave Townsend
12596ced47 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws 
MozReview-Commit-ID: HBpjT2uHJaZ
 2016-11-10 14:48:04 -08:00
Mark Banner
7fc1c9a3bf Bug 1315617 - Fix remaining no-unused-vars for local scope in browser/ and enable the rule for all of browser/ r=mossop 
MozReview-Commit-ID: FO1p5G5K3zg
 2016-11-03 11:56:28 +00:00
Phil Ringnalda
acb30e2175 Merge m-c to autoland 2016-11-04 19:05:33 -07:00
Dave Townsend
dc3810c548 Bug 1314343: Turn on no-unreachable in eslint. r=standard8 
Unreachable code can be a sign of a mistake so we should turn this rule on.

MozReview-Commit-ID: LQphsNL7HBX
 2016-11-01 10:58:35 -07:00
Mark Banner
0dc78b7964 Bug 1314918 - Fix most of the remaining no-unused-vars issues for local scope in browser/. r=mossop 
MozReview-Commit-ID: LdoXLniNeT7
 2016-11-03 11:51:48 +00:00
Jared Wein
0c024fa9ca Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8 
MozReview-Commit-ID: 7Gx90a5y8t6
 2016-10-24 13:14:19 -04:00
Jonathan Kew
21b427cfa4 Bug 1301655 - pt 3 - Replace use of nsIScriptableDateFormat with Intl API methods in browser/components/places code. r=gandalf 2016-10-28 12:04:07 +01:00
Jared Wein
8860cdf2c1 Bug 1294547 - Enable the comma-spacing rule for eslint. r=felipe 
MozReview-Commit-ID: RCSDEvvk2I
 2016-08-16 15:44:15 -04:00
Jared Wein
4518d81cb5 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh 
MozReview-Commit-ID: EMjJ3yWt9Wt
 2016-08-04 03:28:58 -04:00
Jared Wein
ebf1ccbe46 Bug 1291855 - Enable the no-else-return rule for eslint. r=Felipe,kmag,mossop 
MozReview-Commit-ID: DYOmE6xwMJh
 2016-08-03 18:54:59 -04:00
Prakhar Gupta
9a9529b9e9 Bug 485265 - "JSON backup should force .json extension". r=mak77 2016-06-30 13:21:00 +02:00
Dave Townsend
a2ba043d69 Bug 1245649: Turn on no-trailing-spaces. r=Gijs 2016-02-03 14:22:33 -08:00
Marco Bonardo
2456bebdca Bug 1230471 - Basic eslint fixes in places. r=mconley 2015-12-10 06:46:49 -05:00
Matt Coles
cd61049874 Bug 558566 - Restoring bookmarks from a backup should case-insensitively check the file extension. r=mak 2015-07-10 00:01:02 +01:00
simplyblue
eebafcf9e3 Bug 1228976 - Remove array comprehensions from Places .r=mak 2015-12-03 16:26:58 +05:30
Gijs Kruitbosch
55079ed3a7 Bug 731025 - Add telemetry for migrator usage and errors, r=MattN,p=bsmedberg 2015-10-07 13:34:46 +01:00
Hassen ben tanfous
aa7b48bf89 Bug 1074804 - Replace arrays .indexOf with .includes in Places. r=mak 2015-10-11 20:24:32 +02:00
Tooru Fujisawa
735dfed4e6 Bug 1207491 - Part 10: Remove use of expression closure from browser/components/places/content/. r=Gijs 2015-09-23 18:36:21 +09:00
Shu-yu Guo
37989840cd Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Muhsin Ali Steiman
4712994b1d Bug 1188787 - Use AppConstants.jsm instead of preprocessing in browser/components/places. r=mak 2015-08-28 07:37:00 -04:00
Tim Taubert
f784e03d75 Bug 1145063 - Remove the keywords column from the Library r=mak 2015-05-04 14:22:32 +02:00
Asaf Romano
d911d456eb Bug 951651 - Make bookmarkProperties, Star UI and Library info pane work with PlacesTransactions. r=mak 2015-04-23 16:34:55 +03:00
Carsten "Tomcat" Book
a4d1b4af8a Backed out changeset 7f9114a84892 (bug 951651) for bc2 test bustage on a CLOSED TREE 2015-04-23 08:52:56 +02:00
Asaf Romano
823f1fa468 Bug 951651 - Make bookmarkProperties, Star UI and Library info pane work with PlacesTransactions. r=mak. 2015-04-23 08:15:21 +03:00
Asaf Romano
2400f9a445 Bug 1070690 - Remove _setDetailsFieldsDisabledState and paneElementsBroadcaster. r=mak 2014-09-23 09:01:04 +03:00
Bernardo P. Rittmeyer
cd6d04122c Bug 1058951 - Added telemetry probes to measure possible performance impacts of future changes at the places database. r=mak 2014-09-04 14:15:00 +02:00
Jim Blandy
39dc0c6097 Bug 914753: Make Emacs file variable header lines correct, or at least consistent. DONTBUILD r=ehsan 
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):

 - Never set the buffer's mode.

   Years ago, Emacs did not have a good JavaScript mode, so it made sense
   to use Java or C++ mode in .js files. However, Emacs has had js-mode for
   years now; it's perfectly serviceable, and is available and enabled by
   default in all major Emacs packagings.

   Selecting a mode in the -*- file variable line -*- is almost always the
   wrong thing to do anyway. It overrides Emacs's default choice, which is
   (now) reasonable; and even worse, it overrides settings the user might
   have made in their '.emacs' file for that file extension. It's only
   useful when there's something specific about that particular file that
   makes a particular mode appropriate.

 - Correctly propagate settings that establish the correct indentation
   level for this file: c-basic-offset and js2-basic-offset should be
   js-indent-level. Whatever value they're given should be preserved;
   different parts of our tree use different indentation styles.

 - We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
   Remove tab-width: settings, at least in files that don't contain tab
   characters.

 - Remove js2-mode settings that belong in the user's .emacs file, like
   js2-skip-preprocessor-directives.
 2014-06-24 22:12:07 -07:00
Althaf Hameez
205e15b076 Bug 818587 - Adding a compression option for bookmark backups. r=mak 2014-05-24 19:48:00 +02:00
Marco Bonardo
3caa30fe56 Bug 981592 - Ensure the Library selected left pane container is open before selecting one of its descendants. r=mano 2014-03-12 16:24:28 +01:00
Marco Bonardo
c6d972df6e Bug 967192 - Bookmarks restore and import should use OS.File. r=mano 2014-03-07 08:41:47 +01:00
Marco Bonardo
fdf569a8fe Bug 435851 - dragging a folder shortcut drags the concrete folder instead. r=mano 2014-03-04 21:44:21 +01:00
Marco Bonardo
b315dd7b44 Bug 968177 - Apply the shared backups code to bookmarks.html export. r=mano 2014-03-03 17:51:42 +01:00
Marco Bonardo
72baee977f Bug 824433 - Bookmarks backup takes a long time to write out on shutdown. r=mano 2014-02-04 14:43:20 +01:00
cptanu
97ee864317 Bug 649002 - Use XPCOMUtils.defineLazyModuleGetter in places.js. r=dao 2013-11-11 09:04:08 -05:00