corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
477,034 Commits 1 Branch 0 Tags
c76ce9f99a49d0cb15a2ad724b5db7f2b71142f6
Commit Graph

132 Commits

Author SHA1 Message Date
Florian Queze
451928e614 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Sebastian Hengst
f75839c723 Backed out changeset 55f3df15eaa6 (bug 1356569) 2017-04-14 23:39:17 +02:00
Florian Queze
61aabdf237 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Kirk Steuber
a5f3668356 Bug 1349823 - Populate bookmark panel before showing it r=enndeakin+6102,mak 
When panel behavior became asynchronous, |StarUI._doShowEditBookmarkPanel| needed to be changed to wait for the panel to finish opening before initializing it. Although the content of the panel can be changed successfully before the panel opens, the element focus at the end of initialization fails. This prevents the capturing of certain events, such as an Esc keypress (which should close the panel).

However, this introduced the problem where there is a short delay between when the bookmark panel opens and when the correct content is displayed in it. To fix this, the initialization function |gEditItemOverlay.initPanel| will now be called before the panel opens, but the element focus code will wait for the panel's popupshown event.

MozReview-Commit-ID: 6SrcCz963qW
 2017-04-05 15:38:37 -07:00
Jared Wein
5a181760cc Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8 
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx
 2017-03-21 14:29:43 -04:00
Mark Banner
e2dabf7035 Bug 1344017 - Fix an issue where the folder picker in the edit bookmark overlay is not always be updated correctly. r=mak 
MozReview-Commit-ID: 7AuIyuFWlGF
 2017-03-07 22:11:38 +00:00
Mark Banner
7d691acb44 Bug 1344027 - Fix most of the remaining ESLint no-undef issues in browser/components. r=jaws 
MozReview-Commit-ID: DUnxVITvZgh
 2017-03-03 09:29:14 +00:00
Florian Quèze
63de711857 Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws. 2017-01-17 11:50:25 +01:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN 
MozReview-Commit-ID: FuVu8skcqOe
 2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN 
MozReview-Commit-ID: 7E7LPorrEje
 2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout 
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
 2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN 
MozReview-Commit-ID: 8WoGr8i6oCR
 2016-12-29 15:20:47 -05:00
Marco Bonardo
0261f8f54a Bug 1314013 - Allow the bookmarking ui to add a new keyword when the provided postData differs from the existing one. r=adw 
MozReview-Commit-ID: FRqwTxNpej
 2016-11-16 15:31:46 +01:00
Jared Wein
ef8b1e86ca Bug 1316870 - Enable no-shadow eslint rule for browser/. r=mossop 2016-11-15 22:58:30 -05:00
Mark Banner
0dc78b7964 Bug 1314918 - Fix most of the remaining no-unused-vars issues for local scope in browser/. r=mossop 
MozReview-Commit-ID: LdoXLniNeT7
 2016-11-03 11:51:48 +00:00
Kirk Steuber
2c1ac87580 Bug 1206133 - Add popuppositioning state and popuppositioned event to improve arrow panel position handling. r=enndeakin 
MozReview-Commit-ID: Dh1npORCQ6J
 2016-08-16 15:33:05 -07:00
Marco Bonardo
3c8be8a7e0 Bug 1150678 - Changing url of a bookmark with a keyword breaks the keyword forever. r=adw 
MozReview-Commit-ID: 89Od4PKpQse
 2016-08-30 11:04:22 +02:00
Jared Wein
99638e1465 Bug 1294621 - Enable the no-lonely-if rule for eslint. r=gijs 
MozReview-Commit-ID: 8izEqc8IyCu
 2016-08-12 11:50:35 -04:00
Jared Wein
4518d81cb5 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh 
MozReview-Commit-ID: EMjJ3yWt9Wt
 2016-08-04 03:28:58 -04:00
Dão Gottwald
afd98e3cc6 Bug 1219788 - Show bookmarks toolbar when adding a bookmark to the bookmarks toolbar folder. r=mak 2016-05-24 14:31:33 +02:00
Sebastian Hengst
e2b9fd07a5 Backed out changeset 54ebf85e8731 (bug 1219788) for leaks in many mochitests on Linux. r=backout 2016-05-21 09:35:06 +02:00
Dão Gottwald
f294e5ef5b Bug 1219788 - Show bookmarks toolbar when adding a bookmark to the bookmarks toolbar folder. r=mak 2016-05-20 14:41:49 +02:00
Marco Bonardo
2456bebdca Bug 1230471 - Basic eslint fixes in places. r=mconley 2015-12-10 06:46:49 -05:00
Hassen ben tanfous
aa7b48bf89 Bug 1074804 - Replace arrays .indexOf with .includes in Places. r=mak 2015-10-11 20:24:32 +02:00
Marco Bonardo
f4ec8ceb6b Bug 1208063 - The name input field on the new bookmark dialog doesn't get focus. r=adw 2015-10-07 15:40:13 +02:00
Tooru Fujisawa
735dfed4e6 Bug 1207491 - Part 10: Remove use of expression closure from browser/components/places/content/. r=Gijs 2015-09-23 18:36:21 +09:00
Shu-yu Guo
37989840cd Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Marco Bonardo
28bac68066 Bug 1193621 - Can't change tag name in library. r=ttaubert 2015-09-02 16:41:01 +02:00
Marco Bonardo
0a1df808e2 Bug 1167915 - "Add a Keyword for this Search" does not work anymore on POST forms. r=ttaubert 2015-06-03 21:12:48 +02:00
Tom Schuster
5d2068da71 Bug 1150855 - Remove uses of the curly syntax. r=jaws 2015-05-22 21:23:57 +02:00
Marco Bonardo
fa43c2730f Bug 1163341 - Cannot edit location of a bookmark. r=ttaubert 2015-05-11 20:26:25 +02:00
Marco Bonardo
1e9a160779 Bug 1160864 - The description field is not shown when editing a read-only container child in the Library. r=mano 2015-05-08 12:43:29 +02:00
Marco Bonardo
72be7839f8 Bug 1161882 - "Add a Keyword for this search..." dialog accept button is disabled. r=ttaubert 2015-05-08 12:43:24 +02:00
Marco Bonardo
afc00068bd Bug 1160708 - Bookmark Properties dialog not longer allows empty bookmark names. r=ttaubert 2015-05-04 13:05:10 +02:00
Marco Bonardo
120c7fd5fa Bug 1159812 - Bookmark All Tabs is broken. r=ttaubert 2015-05-04 13:05:07 +02:00
Marco Bonardo
d6f35e59ae Bug 1160131 - editBookmarkOverlay.js throws an error when adding a tag to a bookmark. r=ttaubert 2015-05-04 13:05:03 +02:00
Marco Bonardo
e8f163b328 Bug 1159462 - unreachable code in editBookmarkOverlay.js. r=mano 2015-04-30 10:40:10 +02:00
Asaf Romano
6b6a1ee58c Bug 1158900 - Editing bookmark's Location and Description in the Properties window doesn't work; bookmark title missing. r=mak 2015-04-28 11:05:42 +03:00
Asaf Romano
d9340281e6 Bug 1158553 - Star button / Edit Bookmark panel doesn't move the bookmark to the chosen folder. r=mak 2015-04-28 11:04:44 +03:00
Asaf Romano
d911d456eb Bug 951651 - Make bookmarkProperties, Star UI and Library info pane work with PlacesTransactions. r=mak 2015-04-23 16:34:55 +03:00
Carsten "Tomcat" Book
a4d1b4af8a Backed out changeset 7f9114a84892 (bug 951651) for bc2 test bustage on a CLOSED TREE 2015-04-23 08:52:56 +02:00
Asaf Romano
823f1fa468 Bug 951651 - Make bookmarkProperties, Star UI and Library info pane work with PlacesTransactions. r=mak. 2015-04-23 08:15:21 +03:00
Michael Lopez
90e7b2a3b7 Bug 658179 - Set the selected tag listitem to the listitem of the tag being added or removed to prevent scrolling to a previously selected tag; r=mak 2015-01-02 12:54:00 +01:00
Gijs Kruitbosch
f0b6bf38fc Bug 1033463 - don't null out gEditBookmarkOverlay, r=mak 2014-07-10 15:57:31 +01:00
Marco Bonardo
fd265057ac Bug 969318 - Mute "A promise chain failed to handle a rejection" error from the livemarks service. r=mano 2014-03-12 16:24:23 +01:00
Marco Bonardo
fdf569a8fe Bug 435851 - dragging a folder shortcut drags the concrete folder instead. r=mano 2014-03-04 21:44:21 +01:00
Asaf Romano
5aef20d6e8 Bug 912855 - Can't remove check-mark on "Load this bookmark in the sidebar". r=mak 2013-10-09 16:33:58 +02:00