Commit Graph

104 Commits

Author SHA1 Message Date
Alexandre Poirot
208511b0d3 Bug 1356231 - Use toolkit EventEmitter.jsm instead of devtools module. r=mossop
MozReview-Commit-ID: 49JI7NtLwKK
2017-04-27 17:58:09 +02:00
Joel Maher
12505893fc Bug 1355088 - add BUG_COMPONENT to browser/* files. r=mossop
MozReview-Commit-ID: 88mDTdI0oN7
2017-04-19 08:11:47 -04:00
Marco Bonardo
9b56138641 Bug 1356567 - root icons should still create a page association if the domain differs. r=adw,kitcambridge
Root domain icons are no more associated with their pages, BUT if the page uses
a root domain icon from another domain, it should still get an association with it
or we couldn't relate the two.

This also fixes an overlooked problem in PlacesTestUtils where Date objects
cross a boundary and fail instanceof checks. This causes failures in the same
test that this patch is modifying.
To protect from future similar issues some protection has been added to updatedPlaces
so that it will crash in debug builds.

MozReview-Commit-ID: 3MTKhGj3ehj
2017-04-14 20:34:27 +02:00
Carsten "Tomcat" Book
b64dbe3b57 Backed out changeset eb94759f0fcf (bug 1356567) for test failures in own test 2017-04-18 12:58:09 +02:00
Marco Bonardo
f10bff9f87 Bug 1356567 - root icons should still create a page association if the domain differs. r=adw,kitcambridge
Root domain icons are no more associated with their pages, BUT if the page uses
a root domain icon from another domain, it should still get an association with it
or we couldn't relate the two.

This also fixes an overlooked problem in PlacesTestUtils where Date objects
cross a boundary and fail instanceof checks. This causes failures in the same
test that this patch is modifying.
To protect from future similar issues some protection has been added to updatedPlaces
so that it will crash in debug builds.

MozReview-Commit-ID: 3MTKhGj3ehj
2017-04-14 20:34:27 +02:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Ganesh Chaitanya Kale
6edcf609d0 Bug 1343182 - Add updatePlaces' ignoreErrors, ignoreResults and aGroupNotifications to insertMany API in History.jsm. r=mak
MozReview-Commit-ID: 45VbtBu25cP
2017-04-01 13:10:04 +05:30
Zack Herrick
50c0d3d538 Bug 1335907 - Reorganize the preferences based on feedback from user research. r=mconley
The FX_PREFERENCES_CATEGORY_OPENED probe must be extended to version 59 to support the fallback "forked" preference implementation (in-content-old).

The switchToAdvancedSubPane within utilityOverlay's openPreferences must also remain until the fallback has been removed (bug 1349689).

Patch co-authored by Zack Herrick <herrickz@msu.edu> and Ziyan Long <lzylong@gmail.com>.

MozReview-Commit-ID: 1sx0Wj15yM7
2017-03-29 11:52:08 -04:00
Mark Banner
ec9074e132 Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r=jaws
MozReview-Commit-ID: LH0CQOPfoe6
2017-03-20 12:36:37 +01:00
Mark Banner
7d691acb44 Bug 1344027 - Fix most of the remaining ESLint no-undef issues in browser/components. r=jaws
MozReview-Commit-ID: DUnxVITvZgh
2017-03-03 09:29:14 +00:00
Ursula Sarracini
36dac5da7b Bug 1340181 - Hide Activity Stream URL in URLbar r=fkiefer,mconley
MozReview-Commit-ID: F0P5tn2wyG
2017-02-22 13:18:09 -05:00
Gijs Kruitbosch
aa113a28a7 Bug 1343850 - fix PlacesProvider.jsm undefined variable (aLastKnownTitle vs. aTitle), r=mak
MozReview-Commit-ID: D86SQTcMLvM
2017-03-02 13:51:05 +00:00
Gijs Kruitbosch
b381e8453b Bug 1341097 - part 3: don't dispatch oodles of titlechanged notifications for new history entries, r=mak
MozReview-Commit-ID: 7jHOcCQ5ZBb
2017-02-27 18:26:21 +00:00
Marco Bonardo
401af443d2 Bug 1336291 - Lots of 'TypeError: this._browsers is null' browser_remotenewtab_pageloads.js. r=Felipe
MozReview-Commit-ID: HrQm0Rh9vCN
2017-02-06 18:54:54 +01:00
Marco Bonardo
2ea06bb808 Bug 1320481 - thumbnails cache not cleared with clear history on shutdown. r=Felipe
The "places-shutdown" notification is not a good time to remove observers, since
history notifications (and in particular onClearHistory) may happen at the same
time (The sanitizer runs at "profile-change-teardown" that is basically the same
as "places-shutdown").
We can't ensure proper order of these calls, the safest/simplest thing is just
to keep a weak reference and continue observing.

MozReview-Commit-ID: 9zHkDqozXup
2017-01-26 17:54:32 +01:00
Florian Quèze
91f7a2ef3a Bug 1331599 - script-generated patch to replace removeEventListener calls with the once option when possible, r=jaws. 2017-01-25 07:01:52 +01:00
Mark Banner
55868dde7c Bug 503613 - Remove old 'tail =' lines from xpcshell.ini files; r=gps
MozReview-Commit-ID: 62Hp5ISxowJ
2017-01-18 10:30:39 +00:00
Florian Quèze
f412bc04ab Bug 1330464 - script-generated removal of additional parameters that don't exist in the interface, r=jaws. 2017-01-13 20:21:53 +01:00
Florian Quèze
b36a8b8f42 Bug 1330147 - automatic removal of the third boolean parameter in removeObserver calls, r=jaws. 2017-01-11 22:27:42 +01:00
Wes Kocher
704a2ad591 Merge m-c to autoland, a=merge
MozReview-Commit-ID: 6wWFiDQ0QJ8
2017-01-10 18:35:54 -08:00
Gijs Kruitbosch
96aa5c60dc Bug 1329457, r=bz,dao
MozReview-Commit-ID: 9WNuDkQnyM0
2017-01-09 16:07:57 +00:00
Mark Banner
ac52569fff Bug 1329614 - [eslint] Catch more cases of importing globals from 'var foo = Cu.import('...');'. r=jaws
MozReview-Commit-ID: 5NKHHb70YA6
2017-01-09 10:12:26 +00:00
Florian Quèze
45647c4570 Bug 1329182 - remove trailing newURI null parameters in browser/, r=jaws. 2017-01-09 20:27:25 +01:00
Jared Wein
7c1615ceba Bug 1329014 - Enable the no-extra-bind rule and use eslint --fix to autofix the errors. r=standard8
MozReview-Commit-ID: BwK94W2mHXS
2017-01-05 16:43:29 -05:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
868234de76 Bug 1325464 - Manually fix the remaining ES6 method syntax eslint errors. r=MattN
MozReview-Commit-ID: 6NqMryvKH9S
2016-12-28 12:22:09 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
90112e00c1 Bug 1325464 - Manually fix the remaining ES6 method syntax eslint errors. r=MattN
MozReview-Commit-ID: 6NqMryvKH9S
2016-12-28 12:22:09 -05:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Dave Townsend
4e295aa48d Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz
2016-11-11 08:10:51 -08:00
Dave Townsend
12596ced47 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws
MozReview-Commit-ID: HBpjT2uHJaZ
2016-11-10 14:48:04 -08:00
Sebastian Hengst
d1c538318e Bug 1310297 - Remove test annotations using b2g, mulet or gonk: browser. r=RyanVM
MozReview-Commit-ID: LDNr97hKpc8
2016-11-05 11:29:13 +01:00
Jared Wein
0c024fa9ca Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
MozReview-Commit-ID: 7Gx90a5y8t6
2016-10-24 13:14:19 -04:00
Mark Banner
d4b538c2b7 Bug 1240165 - Expand the eslint rule 'mark-test-function-used' to cover xpcshell tests as well as gecko tests and apply to the whole tree. r=miker
MozReview-Commit-ID: FlbJ8yzWXlw
2016-10-26 09:46:40 +01:00
Mark Banner
233309fbe2 Bug 1251003 - Change .eslintrc files to .eslintrc.js to avoid obsolete config file format. r=mossop
MozReview-Commit-ID: JrbFxQ5rj6I
2016-10-18 08:38:10 +01:00
Blake Kaplan
9fb223a5f9 Bug 1304531 - Remove CPOW usage from browser_newtabwebchannel.js. r=Felipe
This one also probably wouldn't cause problems, but getting rid of the CPOW
was so easy, I did so anyway.

MozReview-Commit-ID: IWNwpKF52gI
2016-09-20 18:59:42 -07:00
Jared Wein
8860cdf2c1 Bug 1294547 - Enable the comma-spacing rule for eslint. r=felipe
MozReview-Commit-ID: RCSDEvvk2I
2016-08-16 15:44:15 -04:00
Tom Tromey
1b5a2bdb96 Bug 1286877 - do not set c-basic-offset for python-mode; r=gps
This removes the unnecessary setting of c-basic-offset from all
python-mode files.

This was automatically generated using

    perl -pi -e 's/; *c-basic-offset: *[0-9]+//'

... on the affected files.

The bulk of these files are moz.build files but there a few others as
well.

MozReview-Commit-ID: 2pPf3DEiZqx
2016-07-14 10:16:42 -06:00
Pushpankar
77a14e357c Bug 1286854 - Replace ownerDocument.defaultView with ownerGlobal in browser/. r=dao 2016-07-16 10:20:04 +02:00
Thom Chiovoloni
1d7a0871f8 Bug 1238128 - Ensure that the details passed to WebChannelMessageToChrome is a string, with a whitelist for messages from existing users r=Margaret,markh,MattN
MozReview-Commit-ID: DpdJ5bUcBdQ
2016-07-12 19:34:41 -04:00
Ursula Sarracini
40f85f68ba Bug 1277668 - NewTabSearchProvider observing unknown topic showing up on console when adding search engines and in test r=oyiptong
MozReview-Commit-ID: 5pgiGy5HGqT
2016-06-29 10:22:55 -04:00
Ryan VanderMeulen
85d011532a Bug 1271177, bug 1262719 - Skip browser_newtabmessages.js for frequent failures.
CLOSED TREE
2016-05-17 23:32:57 -04:00
Ursula Sarracini
b2cd1465d5 Bug 1210410 Implement search messages for the Remote New Tab r=oyiptong
MozReview-Commit-ID: 8trDqRegP3G
2016-05-10 10:32:31 -04:00
Olivier Yiptong
7eddad3c33 Bug 1262662 - clear history on startup for newtab messages tests r=marcosc
MozReview-Commit-ID: C10RS4fH5FW
2016-04-14 07:57:22 -07:00
Olivier Yiptong
3b677457c8 Bug 1239116 - Places messages enabled for remote newtab r=rrosario
MozReview-Commit-ID: FUXUcVckh7A
2016-03-10 16:39:04 -05:00
Sebastian Hengst
d919ec054f Bug 1239119 - NewTab webchannel messages for thumbnails. Follow-up: Move semicolon from end of if block to end of function assigned to document.onreadystatechange (discovered by eslint). r=eslint-fix 2016-04-01 20:17:23 +02:00
Olivier Yiptong
84038c9668 Bug 1239119 - NewTab webchannel messages for thumbnails r=ursula
MozReview-Commit-ID: JyW9kmxY9OE
2016-03-08 14:21:07 -05:00