Commit Graph

476 Commits

Author SHA1 Message Date
Jason Prickett
e0cf13dab7 Bug 1928465 - Add asrouter trigger listener for button click r=mviar,omc-reviewers
This patch adds an `elementClick` trigger listener that can be used like so:

```
trigger: {
        id: "elementClicked",
        params: ["element-id"],
}
```

Differential Revision: https://phabricator.services.mozilla.com/D228399
2024-11-20 02:58:51 +00:00
Beth Rennie
83f3481e28 Bug 1929116 - Update NimbusEnrollment.schema.json and store new Firefox Labs fields in saved enrolments r=chumphreys,omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D228723
2024-11-19 22:18:43 +00:00
Emilio Cobos Álvarez
ebe0ec0cbc Bug 1388910 - Remove -moz-user-modify property. r=dshin
We successfully unshipped it in bug 1920118.

Differential Revision: https://phabricator.services.mozilla.com/D229530
2024-11-19 19:35:35 +00:00
Emily McMinn
4d805df532 Bug 1931420 - Update Staff Picks callout targeting r=omc-reviewers,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D229060
2024-11-15 19:31:09 +00:00
Emily McMinn
4165938b55 Bug 1904945 - Add Staff Picks callout to moz-central r=omc-reviewers,hanna_a
Differential Revision: https://phabricator.services.mozilla.com/D226345
2024-11-13 15:46:37 +00:00
Emily McMinn
d2925a7795 Bug 1927385 - Update Onboarding Flow section of Firefox source docs r=omc-reviewers,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D227886
2024-11-12 22:56:27 +00:00
negin
8700809cf7 Bug 1927515 - [FxMS Docs] Updates Spotlight UI template documentation in source doc r=omc-reviewers,mviar
Differential Revision: https://phabricator.services.mozilla.com/D227745
2024-11-11 16:17:00 +00:00
Punam Dahiya
771a61c29f Bug 1927387 - Move Simple CFR Template doc under CFR UI Template in source doc r=omc-reviewers,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D227302
2024-11-08 20:36:07 +00:00
Butkovits Atila
6f8ee9a560 Backed out changeset 41e4ca00b589 (bug 1904945) for causing failures at test_persist_closed_tabs_restore_manually.py. 2024-11-08 21:19:37 +02:00
Emily McMinn
96b0584aa9 Bug 1904945 - Add Staff Picks callout to moz-central r=omc-reviewers,hanna_a
Differential Revision: https://phabricator.services.mozilla.com/D226345
2024-11-08 16:24:08 +00:00
Shane Hughes
c794534286 Bug 1927502 - Add multi-message doc for firefox-source-docs. r=omc-reviewers,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D227122
2024-11-06 19:42:34 +00:00
Sandor Molnar
847fd3bab7 Bug 1775852 - Disable browser_asrouter_group_userprefs.js on linux1804-64-qr asan & debug & opt configuration. r=intermittent-reviewers,jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D228117
2024-11-06 01:24:02 +00:00
Dave Townsend
4ea798a326 Bug 1894239: Enable MOZ_SELECTABLE_PROFILES by default. r=jhirsch,omc-reviewers,niklas,emcminn,mconley
This also removes some tests of `MOZ_SELECTABLE_PROFILES` from `browser/components/profiles` files
where the test is pointless because that test is excluded from the build if `MOZ_SELECTABLE_PROFILES`
is unset.

Differential Revision: https://phabricator.services.mozilla.com/D227372
2024-11-05 12:59:04 +00:00
Stanca Serban
7bfaea64ba Backed out changeset 101063793364 (bug 1894239) for causing mochitests failures in browser_sentence_case_strings.js. CLOSED TREE 2024-11-04 20:39:11 +02:00
Dave Townsend
09c0a011d8 Bug 1894239: Enable MOZ_SELECTABLE_PROFILES by default. r=jhirsch,omc-reviewers,niklas,emcminn,mconley
This also removes some tests of `MOZ_SELECTABLE_PROFILES` from `browser/components/profiles` files
where the test is pointless because that test is excluded from the build if `MOZ_SELECTABLE_PROFILES`
is unset.

Differential Revision: https://phabricator.services.mozilla.com/D227372
2024-11-04 16:20:41 +00:00
Goloman Adrian
43172c6f10 Backed out changeset 4aeabb1fca7f (bug 1894239) for causing bc failures @browser_parsable_css.js. CLOSED TREE 2024-11-04 17:11:24 +02:00
Dave Townsend
658587a8e9 Bug 1894239: Enable MOZ_SELECTABLE_PROFILES by default. r=jhirsch,omc-reviewers,niklas,emcminn,mconley
This also removes some tests of `MOZ_SELECTABLE_PROFILES` from `browser/components/profiles` files
where the test is pointless because that test is excluded from the build if `MOZ_SELECTABLE_PROFILES`
is unset.

Differential Revision: https://phabricator.services.mozilla.com/D227372
2024-11-04 13:19:59 +00:00
Goloman Adrian
a536e48199 Backed out changeset 07b4dffd9109 (bug 1894239) for causing bc failures @browser_all_files_referenced.js. CLOSED TREE 2024-11-04 14:50:12 +02:00
Dave Townsend
d23817862a Bug 1894239: Enable MOZ_SELECTABLE_PROFILES by default. r=jhirsch,omc-reviewers,niklas,emcminn,mconley
This also removes some tests of `MOZ_SELECTABLE_PROFILES` from `browser/components/profiles` files
where the test is pointless because that test is excluded from the build if `MOZ_SELECTABLE_PROFILES`
is unset.

Differential Revision: https://phabricator.services.mozilla.com/D227372
2024-11-04 11:15:32 +00:00
Mike Conley
c396598259 Bug 1928661 - Make sure showing-fxa-menu-message attribute is set before ViewShowing fires for AppMenu or FxA avatar menu panels. r=pdahiya,omc-reviewers
The async constructFxAMessage message was often not resolving before the ViewShowing
event fired, meaning that the attribute wasn't set in time.

Differential Revision: https://phabricator.services.mozilla.com/D227668
2024-11-01 20:32:03 +00:00
Goloman Adrian
8d0a2fbb16 Backed out changeset 6539a7d0d9ca (bug 1894239) for causing xpcshell failures at test_selectable_profile_launch.js. CLOSED TREE 2024-11-01 20:43:36 +02:00
Dave Townsend
0085ce80d2 Bug 1894239: Enable MOZ_SELECTABLE_PROFILES by default. r=jhirsch,omc-reviewers,niklas,emcminn,mconley
This also removes some tests of `MOZ_SELECTABLE_PROFILES` from `browser/components/profiles` files
where the test is pointless because that test is excluded from the build if `MOZ_SELECTABLE_PROFILES`
is unset.

Differential Revision: https://phabricator.services.mozilla.com/D227372
2024-11-01 17:08:27 +00:00
Cristian Tuns
8f3ca1449e Backed out changeset 7df0f0dd73a1 (bug 1894239) for causing bc failures in /browser_appmenu.js CLOSED TREE 2024-11-01 12:48:39 -04:00
Dave Townsend
52f716131a Bug 1894239: Enable MOZ_SELECTABLE_PROFILES by default. r=jhirsch,omc-reviewers,niklas,emcminn,mconley
This also removes some tests of `MOZ_SELECTABLE_PROFILES` from `browser/components/profiles` files
where the test is pointless because that test is excluded from the build if `MOZ_SELECTABLE_PROFILES`
is unset.

Differential Revision: https://phabricator.services.mozilla.com/D227372
2024-11-01 14:38:45 +00:00
Emily McMinn
803813abef Bug 1903708 - Enable about:messagepreview to preview private browsing messages r=omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D220289
2024-10-30 22:10:37 +00:00
hanna alemu
6d1493ff8d Bug 1899747 - Add option to extend feature callout page_event_listener to all windows r=omc-reviewers,mviar,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D213239
2024-10-30 20:56:29 +00:00
Punam Dahiya
8d7c4d95e6 Bug 1927878 - Make Attribution parameters in devtools editable r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D227263
2024-10-29 23:26:31 +00:00
Mike Conley
398b96c057 Bug 1926585 - Append the right menu identifier to the utm_content param for FxAMenuMessage. r=pdahiya,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D226650
2024-10-24 16:06:45 +00:00
hanna alemu
c8150a4dc2 Bug 1911877 - [Docs] Feature callout doc incorrectly says randomize is a property of tiles rather than MultiSelectItem r=omc-reviewers,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D226400
2024-10-22 15:22:48 +00:00
negin
a5e13562b4 Bug 1917928 - make logging FxMS telemetry more discoverable r=omc-reviewers,hanna_a
Updates https://firefox-source-docs.mozilla.org/browser/components/asrouter/docs/telemetry.html to include a section on local debugging/telemetry testing with telemetry logs and glean.

Differential Revision: https://phabricator.services.mozilla.com/D223000
2024-10-21 19:01:02 +00:00
Rebecca King
d7e1907648 Bug 1916815 - Replace --in-content-accent-color variable with the --color-accent-primary token r=desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D224509
2024-10-21 14:50:46 +00:00
Mike Conley
50825d3ded Bug 1922594 - Add image assets for FxA menu messages. r=pdahiya,omc-reviewers
This also tweaks some styles for the fxa-menu-message so that we're
more aligned with the Figma specification.

Differential Revision: https://phabricator.services.mozilla.com/D225894
2024-10-19 20:45:50 +00:00
Mike Conley
a52a1d1d9f Bug 1922594 - Add strings for FxA menu messages and the ability to experiment with the sign-in CTA on both panels. r=fluent-reviewers,omc-reviewers,skhamis,desktop-theme-reviewers,bolsson,pdahiya,hjones
The CTAs for the AppMenu have a collapsed state (since the AppMenu has a Sign In
button to the right of the CTA taking up space), whereas the CTAs for
the FxA avatar panel do not.

Differential Revision: https://phabricator.services.mozilla.com/D224948
2024-10-19 20:45:50 +00:00
Norisz Fay
295237067d Backed out 2 changesets (bug 1922594) for causing bc failures on browser_sync.js CLOSED TREE
Backed out changeset 32bbfcc1607a (bug 1922594)
Backed out changeset 9372edf868fe (bug 1922594)
2024-10-19 03:25:51 +03:00
Mike Conley
51c773a1f0 Bug 1922594 - Add image assets for FxA menu messages. r=pdahiya,omc-reviewers
This also tweaks some styles for the fxa-menu-message so that we're
more aligned with the Figma specification.

Differential Revision: https://phabricator.services.mozilla.com/D225894
2024-10-18 20:43:30 +00:00
Mike Conley
53a3f31513 Bug 1922594 - Add strings for FxA menu messages and the ability to experiment with the sign-in CTA on both panels. r=fluent-reviewers,omc-reviewers,skhamis,desktop-theme-reviewers,bolsson,pdahiya,hjones
The CTAs for the AppMenu have a collapsed state (since the AppMenu has a Sign In
button to the right of the CTA taking up space), whereas the CTAs for
the FxA avatar panel do not.

Differential Revision: https://phabricator.services.mozilla.com/D224948
2024-10-18 20:43:29 +00:00
Emily McMinn
f3bbb3366b Bug 1918536 - CREATE_NEW_SELECTABLE_PROFILE Special Message Action && test message r=jhirsch,omc-reviewers,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D222980
2024-10-17 18:18:59 +00:00
hanna alemu
c1335b0cb7 Bug 1892548 - Remove faulty test r=omc-reviewers,mviar
Removes the react_to_trigger test that causes intermittent failures on different platforms. The method that renders the infobar message (showInfoBarMessage) and the defaultBrowserCheck trigger are covered by other tests separately.

Differential Revision: https://phabricator.services.mozilla.com/D225532
2024-10-15 19:52:11 +00:00
Hanna Jones
99fc51fda2 Bug 1921088 - Upgrade Stylelint and related libraries to the latest version r=Standard8,devtools-reviewers,omc-reviewers,home-newtab-reviewers,nchevobbe,thecount,desktop-theme-reviewers,dao,aminomancer
In addition to upgrding our Stylelint packages, this patch also introduces the @stylistic/stylelint-plugin to preserve a number of rules that were completely removed in v16. It also migrates the code for the custom plugin introduced in bug 1838298 to ES Modules.

Differential Revision: https://phabricator.services.mozilla.com/D224250
2024-10-15 19:39:46 +00:00
Mike Conley
8f93af2686 Bug 1920799 - Add tests for the new menu messaging surface for the FxA CTA message. r=pdahiya,omc-reviewers,home-newtab-reviewers,nbarrett
To manually test the message, make sure to set
`browser.newtabpage.activity-stream.asrouter.devtoolsEnabled` to `true`,
and then visit about:asrouter. Scroll down to the message with ID
FXA_ACCOUNTS_APPMENU_PROTECT_BROWSING_DATA, and click "Show".

This will default to opening the AppMenu with the message. You can open
it for the PXI menu by changing `testingTriggerContext` in the test
message definition from "app_menu" to "pxi_menu".

Differential Revision: https://phabricator.services.mozilla.com/D224790
2024-10-15 16:15:09 +00:00
Mike Conley
dd4373aecb Bug 1920799 - Add a new messaging surface to the AppMenu and PXI menus for describing the value of signing into an FxA. r=pdahiya,Gijs,desktop-theme-reviewers,omc-reviewers,home-newtab-reviewers,fluent-reviewers,hjones,skhamis,nbarrett
Developing tests in a later patch in this series.

Differential Revision: https://phabricator.services.mozilla.com/D223409
2024-10-15 16:15:09 +00:00
Chris H-C
724b00c304 Bug 1920562 - Remove JS uses of Services.telemetry.setEventRecordingEnabled r=florian,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,sessionstore-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,urlbar-reviewers,sfoster,nchevobbe,valentin,Gijs,dimi,lina,mconley,pdahiya,willdurand
Differential Revision: https://phabricator.services.mozilla.com/D223833
2024-10-08 20:14:42 +00:00
jabram
32769d20ee Bug 1865371 - Replace --in-content-box-background with --background-color-box r=cmkm,desktop-theme-reviewers,credential-management-reviewers,omc-reviewers,aminomancer,dao,issammani
Differential Revision: https://phabricator.services.mozilla.com/D222674
2024-10-07 20:15:01 +00:00
Sandor Molnar
92076e16a7 Backed out 5 changesets (bug 1920562) for causing xpc assertion failures. CLOSED TREE
Backed out changeset 8f085ab589a8 (bug 1920562)
Backed out changeset 4405387ae770 (bug 1920562)
Backed out changeset a68fd13a33ae (bug 1920562)
Backed out changeset cd3672fc08ed (bug 1920562)
Backed out changeset 62ab18879eea (bug 1920562)
2024-10-08 00:16:13 +03:00
hanna alemu
ad40840097 Bug 1910641 - Update the FxMS Bookmarks Bar button for the onboarding setup checklist experiment r=mviar,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D224537
2024-10-07 17:56:24 +00:00
Chris H-C
e944bfe7a2 Bug 1920562 - Remove JS uses of Services.telemetry.setEventRecordingEnabled r=florian,settings-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,sessionstore-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,urlbar-reviewers,sfoster,nchevobbe,valentin,Gijs,dimi,lina,mconley,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D223833
2024-10-07 17:29:57 +00:00
Shane Hughes
e919464011 Bug 1922147 - Use only textareas for ASRouterAdmin targeting editors. r=omc-reviewers,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D224270
2024-10-03 17:16:22 +00:00
Florian Quèze
93b33a0974 Bug 1922217 - Migrate telemetry events to use Glean APIs for messaging_experiments, r=chutten,omc-reviewers,pdahiya.
Differential Revision: https://phabricator.services.mozilla.com/D223291
2024-10-03 11:45:27 +00:00
Jason Prickett
2817fb56a2 Bug 1901617 - Create onboarding checklist r=mviar,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D221538
2024-09-26 17:54:01 +00:00
Eric Chen
7ccb2cc84f Bug 1896804 - adding support for architecture based experiment targeting r=nalexander,omc-reviewers,mviar
Differential Revision: https://phabricator.services.mozilla.com/D223424
2024-09-25 18:32:21 +00:00