Commit Graph

66 Commits

Author SHA1 Message Date
Valentin Gosu
c7039bca17 Bug 1733356 - Fix non-unified build errors in netwerk/protocol/http/ r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D127407
2021-10-13 19:39:08 +00:00
Cristian Tuns
b97fa80548 Backed out 10 changesets (bug 1733922, bug 1733356) for causing hybrid build bustages on nsAboutProtocolHandler.cpp. CLOSED TREE
Backed out changeset 293ff1a22c98 (bug 1733922)
Backed out changeset b640749ee844 (bug 1733356)
Backed out changeset d2e3dc1b492a (bug 1733356)
Backed out changeset cd6c19829601 (bug 1733356)
Backed out changeset ef8145f88447 (bug 1733356)
Backed out changeset 366e2d375980 (bug 1733356)
Backed out changeset 14563275a25b (bug 1733356)
Backed out changeset 7700cd82bdf2 (bug 1733356)
Backed out changeset 4e198c3d5ef3 (bug 1733356)
Backed out changeset c26481d0f689 (bug 1733356)
2021-10-11 10:02:20 -04:00
Valentin Gosu
640a20152b Bug 1733356 - Fix non-unified build errors in netwerk/protocol/http/ r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D127407
2021-10-11 10:40:08 +00:00
Valentin Gosu
c877be3ca4 Bug 1714307 - Run modernize-use-default-member-init --fix check on netwerk/protocol/http/ r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D117503
2021-06-16 08:10:12 +00:00
Csoregi Natalia
e88581b300 Backed out changeset 6e00f8bd2acc (bug 1714307) for causing hazard bustage. CLOSED TREE 2021-06-09 21:50:03 +03:00
Valentin Gosu
c01e585de7 Bug 1714307 - Run modernize-use-default-member-init --fix check on netwerk r=necko-reviewers,kershaw
This changeset is the result of adding modernize-use-default-member-init to
tools/clang-tidy/config.yaml then proceeding to run
`./mach static-analysis check netwerk/ --fix`
I then went through the resulting fix and manually updated all of the member
variables which were missed due to them having a non-trivial constructor.

Note that the tool was only run on Linux, so code that only runs on some
platforms may have been missed.

The member variables that are still initialized in the contructor definition
are:
  - bitfields (not all currently supported compilers allow default-member-init
  - variables that are initialized via a parameter
  - variables that use code not visible in the header file

There are a few advantages to landing this change:
- fewer lines of code - now declaration is in the same place as initialization
  this also makes it easier to see when looking at the header.
- it makes it harder to miss initializing a member when adding a new contructor
- variables that depend on an include guard look much nicer now

Additionally I removed some unnecessary reinitialization of NetAddr members
(it has a constructor that does that now), and changed nsWifiScannerDBus to
use the thread-safe strtok_r instead of strtok.

Differential Revision: https://phabricator.services.mozilla.com/D116980
2021-06-09 10:20:04 +00:00
Valentin Gosu
56cd5036af Bug 1714307 - Autofix static-analysis warnings in netwerk/ r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D116701
2021-06-04 12:35:16 +00:00
Butkovits Atila
1f3e4dc865 Backed out changeset c4b44c4ef15b (bug 1714307) for causing build bustages on nsHTTPCompressConv.h. CLOSED TREE 2021-06-04 13:53:37 +03:00
Valentin Gosu
5b4ead87fd Bug 1714307 - Autofix static-analysis warnings in netwerk/ r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D116701
2021-06-04 10:00:55 +00:00
Valentin Gosu
30f1adb35b Bug 1710045 - Static analysis auto fixes r=necko-reviewers,kershaw
Depends on D114718

Differential Revision: https://phabricator.services.mozilla.com/D115987
2021-06-01 07:24:02 +00:00
Sebastian Hengst
b5294e82d2 Backed out 3 changesets (bug 1710045) for failing GTest TestHttpResponseHead.atoms on Windows. CLOSED TREE
Backed out changeset b4f466ca314e (bug 1710045)
Backed out changeset 66364f605471 (bug 1710045)
Backed out changeset 84c30435445b (bug 1710045)
2021-05-27 14:41:22 +02:00
Valentin Gosu
0e2d78f8d2 Bug 1710045 - Static analysis auto fixes r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D115987
2021-05-27 09:12:36 +00:00
Kershaw Chang
f30711e16b Bug 1682552 - Add a probe to understand the channel successful rate when https rr is used r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D99916
2021-01-12 09:17:21 +00:00
Valentin Gosu
6f6715d91e Bug 1674835 - Hold mutex when accessing mSecurityInfo r=necko-reviewers,kershaw
Also makes mProxyConnectResponseCode atomic to avoid grabbing the mutex twice
in a row in nsHttpChannel.

Differential Revision: https://phabricator.services.mozilla.com/D96432
2020-12-05 23:08:27 +00:00
Hubert Boma Manilla
1fff254efc Bug 1666726 - Set if a transaction uses Http 3 r=dragana,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D97130
2020-11-20 03:36:37 +00:00
Dragana Damjanovic
0801a9ff58 Bug 1675500 - Add telemetry about time needed for an transaction to be dispatch. r=necko-reviewers,valentin
This probe olny collect data for transactions that have used HTTP2, but support HTTP3

Differential Revision: https://phabricator.services.mozilla.com/D96264
2020-11-12 19:07:14 +00:00
Kershaw Chang
97a4cd586e Bug 1675546 - Make sure we use the updated caps and connection info to create a new sticky transaction r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D96070
2020-11-09 10:34:35 +00:00
Kershaw Chang
fc8713f4dc Bug 1668828 - Don't set cos flag if transaction is already closed r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D94081
2020-10-20 12:59:31 +00:00
Kershaw Chang
6a3c8c712d Bug 1652667 - P1: Add telemetry for when an HTTPSSVC record is received r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D87844
2020-08-25 17:29:32 +00:00
Simon Giesecke
39124586b5 Bug 1653335 - Replace MakeSpan uses by constructor calls. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D83817
2020-08-07 07:49:47 +00:00
Honza Bambas
7d7d412478 Bug 1609410 - Clear used proxy identity in nsHttpChannelAuthProvider to prevent authentication prompt pop-up on transaction internal restart, r=kershaw,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D84533
2020-08-03 18:31:36 +00:00
Kershaw Chang
3f9e52045d Bug 1650773 - P4: Small fix for making try green, r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D83341
2020-07-31 18:05:42 +00:00
Kershaw Chang
ece4a3078b Bug 1650773 - P3: Send OnStopRequest from socket process to child process directly, r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D83340
2020-07-31 18:05:22 +00:00
Kershaw Chang
ee6be24a07 Bug 1650773 - P1: Let parent process know that ODA will be sent to child process at OnStartRequest, r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D83338
2020-07-31 18:04:46 +00:00
Dorel Luca
c917154ee0 Backed out 4 changesets (bug 1650773) for build bustage in builds/worker/workspace/obj-build/dist/include/mozilla/Logging.h. CLOSED TREE
Backed out changeset d9b73ed07ef4 (bug 1650773)
Backed out changeset aa96a8af05ae (bug 1650773)
Backed out changeset dac754d24e1f (bug 1650773)
Backed out changeset 896920a3d370 (bug 1650773)
2020-07-31 16:40:43 +03:00
Kershaw Chang
0ce0a0ebad Bug 1650773 - P4: Small fix for making try green, r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D83341
2020-07-31 10:45:50 +00:00
Kershaw Chang
0265d3a464 Bug 1650773 - P3: Send OnStopRequest from socket process to child process directly, r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D83340
2020-07-31 10:45:26 +00:00
Kershaw Chang
8c03239729 Bug 1650773 - P1: Let parent process know that ODA will be sent to child process at OnStartRequest, r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D83338
2020-07-31 10:44:10 +00:00
Kershaw Chang
36e9a7bdeb Bug 1646358 - Only set 'Alt-Used' when the header is not empty r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D82675
2020-07-14 11:38:46 +00:00
Kershaw Chang
aa4a6ffb0f Bug 1646358 - Update transfer size in OnDataAvailable r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D81977
2020-07-14 11:38:49 +00:00
Kershaw Chang
f74a15693b Bug 1646358 - Calculate request size in parent process r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D81976
2020-07-14 11:38:51 +00:00
Kershaw Chang
fba03d9816 Bug 1646358 - Make sure remote address is available at the right time r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D80511
2020-07-14 11:38:53 +00:00
Razvan Maries
59cca30dab Backed out 5 changesets (bug 1646358) for perma failures on nsTSubstring.h. CLOSED TREE
Backed out changeset 432a56d9e68e (bug 1646358)
Backed out changeset f7ebad48e890 (bug 1646358)
Backed out changeset aa32d2fc1762 (bug 1646358)
Backed out changeset 91fce3e27eac (bug 1646358)
Backed out changeset 059a823032d2 (bug 1646358)
2020-07-14 14:32:31 +03:00
Kershaw Chang
4d08e83316 Bug 1646358 - Only set 'Alt-Used' when the header is not empty r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D82675
2020-07-14 10:24:57 +00:00
Kershaw Chang
ce1dfaf5cb Bug 1646358 - Update transfer size in OnDataAvailable r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D81977
2020-07-14 10:24:21 +00:00
Kershaw Chang
385c918479 Bug 1646358 - Calculate request size in parent process r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D81976
2020-07-14 10:24:04 +00:00
Kershaw Chang
53c9974a67 Bug 1646358 - Make sure remote address is available at the right time r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D80511
2020-07-14 10:23:41 +00:00
Michal Novotny
cee65b3911 Bug 1649410 - [socket-process] test_version_fallback() in netwerk/test/unit/test_http3.js fails r=necko-reviewers,kershaw
Propagate Alt-Used request header set in socket process to parent process.

Differential Revision: https://phabricator.services.mozilla.com/D81714
2020-07-02 16:54:34 +00:00
Kershaw Chang
5055abf5ce Bug 1643515 - Implement HttpTransactionParent::ActorDestroy properly, r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D80513
2020-06-23 17:14:55 +00:00
Jean-Yves Avenard
05adafa9ef Bug 1637500 - P2. Rename methods as they are not always dealing with "threads". r=froydnj
Before P1, GetCurrentThreadSerialEventTarget would have always returned the same data as NS_GetCurrentThread, making the comment incorrect Now it will properly return the running TaskQueue if any.

This change of name more clearly exposes what they are doing, as we aren't always dealing with threads directly; but a nsISerialEventTarget

Differential Revision: https://phabricator.services.mozilla.com/D80354
2020-06-23 05:05:36 +00:00
Kershaw Chang
51131f92a7 Bug 1544378 - Implement RetargetDeliveryTo for HttpTransactionParent r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D79429
2020-06-16 14:59:40 +00:00
Kershaw Chang
39bab14560 Bug 1641496 - P4: Send request size in OnStopRequest message r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D77275
2020-06-04 22:56:43 +00:00
Csoregi Natalia
77821df454 Backed out 7 changesets (bug 1641496) for failures on test_trr.js. CLOSED TREE
Backed out changeset 1c927e612dda (bug 1641496)
Backed out changeset 0f1ba77e3942 (bug 1641496)
Backed out changeset a626e86ce5c9 (bug 1641496)
Backed out changeset 196381953eac (bug 1641496)
Backed out changeset 70b0af678bfd (bug 1641496)
Backed out changeset bf41bd8ca89c (bug 1641496)
Backed out changeset 745da0e1cb80 (bug 1641496)
2020-06-05 01:39:19 +03:00
Kershaw Chang
f5111e7508 Bug 1641496 - P4: Send request size in OnStopRequest message r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D77275
2020-06-04 12:23:57 +00:00
Kershaw Chang
6b45454d48 Bug 1623380 - Send ODA directly to content process r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D67609
2020-05-07 14:39:21 +00:00
Dorel Luca
07c453bdb8 Backed out changeset 2b9fc84a789b (bug 1623380) for Mochitest failures in dist/include/mozilla/RefPtr.h. CLOSED TREE 2020-05-07 15:17:30 +03:00
Kershaw Chang
c0ebe10757 Bug 1623380 - Send ODA directly to content process r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D67609
2020-05-07 11:12:46 +00:00
Simon Giesecke
b6d832dc97 Bug 1626570 - Improve handling of copying arrays in netwerk/protocol/. r=valentin,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D73677
2020-05-06 11:50:57 +00:00
Kershaw Chang
40f243a778 Bug 1527384 - Introduce PAltSvcTransaction for carrying the validated result from socket process to parent process r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D65188
2020-03-17 16:32:12 +00:00
anjali1903
0e373a201d Bug 1621251 Replace NS_ADDREF(*var = other) with *var = do_AddRef(other).take() in /netwerk r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D66818
2020-03-17 15:05:26 +00:00