Commit Graph

823 Commits

Author SHA1 Message Date
Andrea Marchesini
beca6e75a9 Bug 1648141 - IPCBlobInputStream to RemoteLazyInputStream - part 7 - RemoteLazyInputStreamUtils, r=smaug,necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D80930
2020-06-29 11:02:59 +00:00
Andrea Marchesini
b1c200777b Bug 1648141 - IPCBlobInputStream to RemoteLazyInputStream - part 4 - IPDL actors, r=smaug,necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D80927
2020-06-29 11:03:02 +00:00
Razvan Maries
6b44dbdf8c Backed out 8 changesets (bug 1648141) for build bustages on RemoteLazyInputStreamThread.cpp. CLOSED TREE
Backed out changeset e9b4ca0ee700 (bug 1648141)
Backed out changeset b9bb847cee47 (bug 1648141)
Backed out changeset 11dfce46ec14 (bug 1648141)
Backed out changeset d824d2f67f27 (bug 1648141)
Backed out changeset e5b8292e7095 (bug 1648141)
Backed out changeset c1a3d5fa0c61 (bug 1648141)
Backed out changeset 24fdb83db3cd (bug 1648141)
Backed out changeset 749d894dde52 (bug 1648141)
2020-06-29 13:59:16 +03:00
Andrea Marchesini
c12b44c63c Bug 1648141 - IPCBlobInputStream to RemoteLazyInputStream - part 8 - mozilla namespace, r=smaug,necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D80931
2020-06-29 10:30:00 +00:00
Andrea Marchesini
907eddc3cc Bug 1648141 - IPCBlobInputStream to RemoteLazyInputStream - part 7 - RemoteLazyInputStreamUtils, r=smaug,necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D80930
2020-06-29 10:29:05 +00:00
Andrea Marchesini
a1197a447e Bug 1648141 - IPCBlobInputStream to RemoteLazyInputStream - part 4 - IPDL actors, r=smaug,necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D80927
2020-06-29 10:27:20 +00:00
Jean-Yves Avenard
05adafa9ef Bug 1637500 - P2. Rename methods as they are not always dealing with "threads". r=froydnj
Before P1, GetCurrentThreadSerialEventTarget would have always returned the same data as NS_GetCurrentThread, making the comment incorrect Now it will properly return the running TaskQueue if any.

This change of name more clearly exposes what they are doing, as we aren't always dealing with threads directly; but a nsISerialEventTarget

Differential Revision: https://phabricator.services.mozilla.com/D80354
2020-06-23 05:05:36 +00:00
Eden Chuang
11c05b5c02 Bug 1642149 - P1 Fix the web-platform-test html/cross-origin-embedder-policy/require-corp.https.html r=necko-reviewers,valentin
Current HttpBaseChannel::ProcessCrossOriginResourcePolicyHeader does not implement the [[ https://wicg.github.io/cross-origin-embedder-policy/#corp-check | corp-check ]] 3.2.1.2.

Differential Revision: https://phabricator.services.mozilla.com/D77594
2020-06-19 13:23:33 +00:00
Coroiu Cristina
c2217fdc9c Backed out 2 changesets (bug 1642149) for perma wpt failures at /fetch/cross-origin-resource-policy/iframe-loads.html
Backed out changeset bc5cfb22c1d7 (bug 1642149)
Backed out changeset c7a1a36d6d91 (bug 1642149)
2020-06-19 07:41:47 +03:00
Eden Chuang
6041989f5d Bug 1642149 - P1 Fix the web-platform-test html/cross-origin-embedder-policy/require-corp.https.html r=necko-reviewers,valentin
Current HttpBaseChannel::ProcessCrossOriginResourcePolicyHeader does not implement the [[ https://wicg.github.io/cross-origin-embedder-policy/#corp-check | corp-check ]] 3.2.1.2.

Differential Revision: https://phabricator.services.mozilla.com/D77594
2020-06-18 10:01:15 +00:00
Valentin Gosu
66116c8e28 Bug 1645715 - Check if uri is null in ComputeCrossOriginOpenerPolicyMismatch r=michal,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D79657
2020-06-17 13:59:53 +00:00
Junior Hsu
54d8e9beb9 Bug 1638513 - P3 strip request body header for preflight, r=valentin,necko-reviewers
(a) Steal nsCORSListenerProxy::UpdateType since the whole usage is removed
    by bug 1312864. Now I'm using it to indicate if the headers should be
	stripped.
(b) Intentionally to let HttpBaseChannel strip the header to save one
    headers copy. It's set via idl, hence I don't think it's moveable.

Differential Revision: https://phabricator.services.mozilla.com/D78831
2020-06-09 18:38:50 +00:00
Junior Hsu
e21a8d455e Bug 1638513 - P2 let nsIHttpChannel implement shouldStripRequestBodyHeader, r=valentin,necko-reviewers
We need to extract the common method into the idl since the connection between necko
and XHR is idl. Need to import the whole necko if we do something like
`#include "HttpBaseChannel.h"

Differential Revision: https://phabricator.services.mozilla.com/D78830
2020-06-09 18:20:15 +00:00
Eden Chuang
d9ba6eef90 Bug 1634419 - Skip CORP checking for TYPE_WEBSOCKET loading r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D74655
2020-05-27 21:29:32 +00:00
Emilio Cobos Álvarez
03cfd95496 Bug 1641245 - Make string comparators not virtual. r=froydnj,necko-reviewers,geckoview-reviewers,jgilbert,agi,valentin
There's no use case for stateful comparators, so they can be just plain
function pointers.

This is used in some hot places like CSS selector matching.

Differential Revision: https://phabricator.services.mozilla.com/D77084
2020-05-27 18:11:12 +00:00
Eden Chuang
8c0436e44c Bug 1575095 - P2 Apply COOP switch with InterceptedHttpChannel in DocumentLoadListener r=necko-reviewers,valentin,mattwoodrow
The response from ServiceWorker might also be COOP mismatched, such that the document/sub-document loading need to be performed on another process.
However, DocumentLoadListener only works with nsHttpChannel.

This patch would like to support InterceptedHttpChannel in DocumentLoadListener.

Differential Revision: https://phabricator.services.mozilla.com/D76841
2020-05-27 15:37:21 +00:00
Eden Chuang
1b1d80ae79 Bug 1575095 - P1 Move CrossOriginXXXHeaders checking into HttpBaseChannel and apply CrossOriginXXXHeaders in InterceptedHttpChannel. r=valentin
Move COOP, COEP, and CORP checking into HttpBaseChannel, and apply these checking on InterceptedHttpChannel.

Differential Revision: https://phabricator.services.mozilla.com/D54224
2020-05-27 15:37:09 +00:00
Christoph Kerschbaumer
21e151a97f Bug 1422284 - Upgrade insecure requests should only apply to top-level same-origin redirects. r=baku,valentin,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D75259
2020-05-25 08:14:10 +00:00
Valentin Gosu
a5d760e844 Bug 1629882 - COEP requires a secure context r=JuniorHsu,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D71617
2020-05-06 11:43:24 +00:00
Simon Giesecke
b6d832dc97 Bug 1626570 - Improve handling of copying arrays in netwerk/protocol/. r=valentin,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D73677
2020-05-06 11:50:57 +00:00
Matt Woodrow
f1e37a8f28 Bug 1624318 - Serialize replacement config input stream as a blob. r=baku,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D71872
2020-04-27 04:49:00 +00:00
Brindusan Cristian
5faeed50a8 Backed out changeset 5465225cb6fc (bug 1629882) for assertion failures at nsContentUtils.cpp. CLOSED TREE 2020-04-21 17:52:52 +03:00
Valentin Gosu
87ce86499b Bug 1629882 - COEP requires a secure context r=JuniorHsu,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D71617
2020-04-20 19:21:45 +00:00
Andrea Marchesini
6fb3ca2e30 Bug 1631523 - Remove unused params in nsICookieService methods - setCookieStringFromHttp without first URI, r=dimi
Depends on D71611

Differential Revision: https://phabricator.services.mozilla.com/D71612
2020-04-20 18:58:28 +00:00
Andrea Marchesini
369c9a7585 Bug 1631523 - Remove unused params in nsICookieService methods - getCookieStringFromHttp without first URI, r=dimi
Depends on D71609

Differential Revision: https://phabricator.services.mozilla.com/D71611
2020-04-20 18:57:04 +00:00
Andrea Marchesini
86975f7406 Bug 1631523 - Remove unused params in nsICookieService methods - setCookieStringFromHttp without serverTime, r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D71609
2020-04-20 18:56:25 +00:00
Eden Chuang
c4652fbd1c Bug 1575090 - add NS_GetCrossOriginEmbedderPolicyFromHeader r=JuniorHsu,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D46178
2020-04-20 17:21:23 +00:00
Eden Chuang
bfdee842ec Bug 1575090 - expose a response's COEP on nsIHttpChannelInternal r=JuniorHsu,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D46176
2020-04-20 17:25:59 +00:00
Shane Caraveo
056b5ff5ce Bug 1530408 add api on channels to prevent using alt-data cache r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D68892
2020-04-11 00:18:39 +00:00
Noemi Erli
c072e3b083 Backed out 3 changesets (bug 1530408) for causing xpcshell failures in test_ext_webRequest_filterResponseData.js
Backed out changeset 365c4d5fe9b0 (bug 1530408)
Backed out changeset 77bb11a76b33 (bug 1530408)
Backed out changeset 3c76ac7b3965 (bug 1530408)
2020-04-08 12:04:10 +03:00
Shane Caraveo
c928b62852 Bug 1530408 add api on channels to prevent using alt-data cache r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D68892
2020-03-31 13:41:00 +00:00
Emilio Cobos Álvarez
46f64ba715 Bug 1627707 - Rename LoadInfo::LoadingPrincipal to GetLoadingPrincipal as it can return null. r=ckerschb
Mostly a matter of:

  rg -l '\->LoadingPrincipal' | xargs sed -i 's/->LoadingPrincipal/->GetLoadingPrincipal/g'

And then clang-format. But I tweaked manually nsHttpChannelAuthProvider (move
the variable where it's used, don't take a useless strong ref),
AddonContentPolicy (move the declaration of the variable to the if condition),
and BackgroundUtils (same).

Differential Revision: https://phabricator.services.mozilla.com/D69828
2020-04-06 18:57:36 +00:00
Cosmin Sabou
8ca4dd2b6f Backed out 3 changesets (bug 1627707) for build bustages @ mozilla::net::LoadInfo.
Backed out changeset 65d6a90651ce (bug 1627707)
Backed out changeset 378ec30d9979 (bug 1627707)
Backed out changeset 058a19e11b06 (bug 1627707)
2020-04-06 20:07:04 +03:00
Emilio Cobos Álvarez
d828790f70 Bug 1627707 - Rename LoadInfo::LoadingPrincipal to GetLoadingPrincipal as it can return null. r=ckerschb
Mostly a matter of:

  rg -l '\->LoadingPrincipal' | xargs sed -i 's/->LoadingPrincipal/->GetLoadingPrincipal/g'

And then clang-format. But I tweaked manually nsHttpChannelAuthProvider (move
the variable where it's used, don't take a useless strong ref),
AddonContentPolicy (move the declaration of the variable to the if condition),
and BackgroundUtils (same).

Differential Revision: https://phabricator.services.mozilla.com/D69828
2020-04-06 16:00:43 +00:00
Honza Bambas
52a8b03f3d Bug 1605895 - Add a diagnostic assertion when an http channel on the child process loading CSS does not notify OnStopRequest before being destroyed, r=michal
Differential Revision: https://phabricator.services.mozilla.com/D68025
2020-04-06 15:12:15 +00:00
Mihai Alexandru Michis
64e7ffad08 Backed out changeset 30fe730b5ab1 (bug 1605895) for causing mochitest failures in HttpChannelChild
CLOSED TREE
2020-04-02 20:37:12 +03:00
Honza Bambas
345cd78c92 Bug 1605895 - Add a diagnostic assertion when an http channel on the child process loading CSS does not notify OnStopRequest before being destroyed, r=michal
Differential Revision: https://phabricator.services.mozilla.com/D68025
2020-04-02 15:53:54 +00:00
Sebastian Streich
0adae91a06 Bug 1622042 - Remove nsContentUtils::GetAsciiOrigin r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D66634
2020-03-26 13:20:35 +00:00
Tim Huang
bed4352713 Bug 1612378 - Part 7: Remove the ContentBlockingAllowListPrincipal from the nsIHttpChannelInternal. r=dimi,baku
We nolonger need to use the ContentBlockingAllowListPrincipal in the
channel because we move to check the IsOnContentBlockingAllowList in the
CookieJarSettings when we do a content blocking allow list check. Also,
we would potentially expose the cross-origin info through the
ContentBlockingAllowListPrincipal in the channel. Hence, we will remove
it from the channel.

Differential Revision: https://phabricator.services.mozilla.com/D66214
2020-03-25 13:51:05 +00:00
Andrea Marchesini
6df5fba02f Bug 1437057 - Expose the origin of a cookie to JS, r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D67589
2020-03-24 16:47:57 +00:00
Andrea Marchesini
a6f6811427 Bug 1585306 - HTTP channels must check if the browsing context is discarded, r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D66760
2020-03-19 16:23:40 +00:00
Andrea Marchesini
a758b7a812 Bug 1585306 - nsILoadGroup observes last-pb-context-exit to monitor the browsing context, r=mayhemer
Differential Revision: https://phabricator.services.mozilla.com/D66745
2020-03-19 16:24:21 +00:00
Stefan Hindli
bb21fc71f7 Backed out 4 changesets (bug 1622042) for causing AddonInstallException: Could not install add-on: c:\users\task_1584560140\appdata\local\temp\tmpbg9_h7.zip: ERROR_FILE_ACCESS: There was an error accessing the filesystem. CLOSED TREE
Backed out changeset 929043330599 (bug 1622042)
Backed out changeset b08cdd075e20 (bug 1622042)
Backed out changeset ca87f1c6b90b (bug 1622042)
Backed out changeset 27dbbb7cd590 (bug 1622042)
2020-03-18 22:49:23 +02:00
Sebastian Streich
2843e0e5b8 Bug 1622042 - Remove nsContentUtils::GetAsciiOrigin r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D66634
2020-03-18 16:00:53 +00:00
Cosmin Sabou
48ff1e921d Backed out 4 changesets (bug 1622042) for causing build bustages on nsContentUtils.cpp. CLOSED TREE
Backed out changeset dc7af5abb8de (bug 1622042)
Backed out changeset 16e3b4a1fefc (bug 1622042)
Backed out changeset f60b16588dad (bug 1622042)
Backed out changeset 4193aea26e28 (bug 1622042)
2020-03-17 20:38:35 +02:00
Sebastian Streich
5dcdec5d06 Bug 1622042 - Remove nsContentUtils::GetAsciiOrigin r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D66634
2020-03-17 17:11:52 +00:00
anjali1903
0e373a201d Bug 1621251 Replace NS_ADDREF(*var = other) with *var = do_AddRef(other).take() in /netwerk r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D66818
2020-03-17 15:05:26 +00:00
Chris Fronk
5f4d7b6abf Bug 1143478 - Rename mozilla::Pair to CompactPair. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D64511
2020-03-17 12:42:12 +00:00
Matt Woodrow
2efb1368a8 Bug 1620875 - Don't duplicate loadFlags in the http specific config as well as the generic config for DocumentChannel replacement. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D65922
2020-03-16 00:56:03 +00:00
shindli
acf53819f5 Backed out changeset a08637fb30c8 (bug 1143478) for causing bustages in /builds/worker/checkouts/gecko/ipc/mscom/Registration.cpp CLOSED TREE 2020-03-11 14:30:54 +02:00