Commit Graph

65 Commits

Author SHA1 Message Date
Kelly Cochrane
c64a9447f3 Bug 1880542 - Refactor fxview-tab-list and fxview-tab-row r=sfoster,fxview-reviewers,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D205499
2024-03-26 18:01:02 +00:00
Dave Townsend
a0c83bc943 Bug 1864896: Autofix unused function arguments (browser). r=webcompat-reviewers,mconley,fxview-reviewers,desktop-theme-reviewers,omc-reviewers,migration-reviewers,twisniewski,aminomancer,dao,sclements,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D203005
2024-03-19 09:36:35 +00:00
Kelly Cochrane
675a186e05 Bug 1884322 - Only toggle mute/unmute tabs in Fx View with Enter/Space keys if using keyboard navigation r=fxview-reviewers,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D204042
2024-03-09 17:14:17 +00:00
Nikki Sharpley
5357a2cc6f Bug 1884170 - Missing options button icon in history fixed r=fxview-reviewers,kcochrane
Added correct secondary class names to show options button icon in history.

Differential Revision: https://phabricator.services.mozilla.com/D203928
2024-03-07 21:39:31 +00:00
Kelly Cochrane
cd1bec4c24 Bug 1883890 - Ensure proper HCM styles are being applied to media button for pinned tabs in Fx View r=fxview-reviewers,ayeddi,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D203827
2024-03-07 18:32:21 +00:00
Kelly Cochrane
bf4070efdc Bug 1883337 - Ensure focus is moved when mute/unmute button is removed in Fx View r=fxview-reviewers,nsharpley,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D203484
2024-03-05 15:49:24 +00:00
Norisz Fay
81c5a0094d Backed out changeset c23d6a5f066e (bug 1883337) for causing bc failures on browser_opentabs_pinned_tabs.js CLOSED TREE 2024-03-05 17:10:15 +02:00
Kelly Cochrane
4a30e42b73 Bug 1883337 - Ensure focus is moved when mute/unmute button is removed in Fx View r=fxview-reviewers,nsharpley,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D203484
2024-03-05 13:49:03 +00:00
Jonathan Sudiaman
a85f5fcf62 Bug 1876165 - Create BookmarkList class that internally stays up-to-date to indicate bookmarked open tabs in Fx View r=mak,fxview-reviewers,places-reviewers,fluent-reviewers,bolsson,sfoster,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201759
2024-03-04 13:02:16 +00:00
Iulian Moraru
26d2d56621 Backed out changeset bfb6942faf35 (bug 1876165) for causing multiple bc failures. CLOSED TREE 2024-03-01 16:20:18 +02:00
Jonathan Sudiaman
f4ce3f9847 Bug 1876165 - Create BookmarkList class that internally stays up-to-date to indicate bookmarked open tabs in Fx View r=mak,fxview-reviewers,places-reviewers,fluent-reviewers,bolsson,sfoster,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201759
2024-03-01 13:34:08 +00:00
Nikki Sharpley
8dceebb0c7 Bug 1879609 - Add pinned indicator for urls pinned in New Tab r=fxview-reviewers,desktop-theme-reviewers,emilio
- added pin icons to the tab row for tabs pinned in New Tab

Differential Revision: https://phabricator.services.mozilla.com/D201770
2024-02-29 02:26:27 +00:00
Nikki Sharpley
487579b587 Bug 1857298 - Add close button to open tabs in view r=fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements
- created tertiary button option for tab rows, styled by a class prop
- added close button to open tabs rows
- removed close tab from open tab context menu
- updated tests to reflect removed panel item in open tab context menu
- added test for the new open tabs close button
- added telemetry for close open tab (requires data review)
- added test suite for keyboard navigation across tab row buttons

Depends on D201652

Differential Revision: https://phabricator.services.mozilla.com/D200689
2024-02-28 19:37:22 +00:00
Stanca Serban
c67b0bdbfc Backed out 2 changesets (bug 1857298) for causing mochitests failures in browser_parsable_css.js. CLOSED TREE
Backed out changeset 32ca524f7abf (bug 1857298)
Backed out changeset c4ed2e3e1ff2 (bug 1857298)
2024-02-28 20:47:18 +02:00
Nikki Sharpley
0fc9567678 Bug 1857298 - Add close button to open tabs in view r=fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements
- created tertiary button option for tab rows, styled by a class prop
- added close button to open tabs rows
- removed close tab from open tab context menu
- updated tests to reflect removed panel item in open tab context menu
- added test for the new open tabs close button
- added telemetry for close open tab (requires data review)
- added test suite for keyboard navigation across tab row buttons

Differential Revision: https://phabricator.services.mozilla.com/D200689
2024-02-28 17:31:17 +00:00
Kelly Cochrane
32b2d59715 Bug 1849175 - Add pinned tabs to Open Tabs in Firefox View r=desktop-theme-reviewers,fxview-reviewers,fluent-reviewers,flod,sclements,nsharpley,dao
Differential Revision: https://phabricator.services.mozilla.com/D201652
2024-02-27 23:33:19 +00:00
Natalia Csoregi
20f1a3f6d6 Backed out 3 changesets (bug 1877678, bug 1849175) for causing failures on browser_opentabs_recency.js CLOSED TREE
Backed out changeset 67fd66802500 (bug 1849175)
Backed out changeset da9aa1960b63 (bug 1877678)
Backed out changeset 8d9e1646bd6e (bug 1877678)
2024-02-28 00:22:14 +02:00
Kelly Cochrane
4cd48be87c Bug 1849175 - Add pinned tabs to Open Tabs in Firefox View r=desktop-theme-reviewers,fxview-reviewers,fluent-reviewers,flod,sclements,nsharpley,dao
Differential Revision: https://phabricator.services.mozilla.com/D201652
2024-02-27 20:30:59 +00:00
Cristian Tuns
26a80e06db Backed out changeset f9c17890d242 (bug 1849175) for causing bc failures in browser_opentabs_firefoxview.js CLOSED TREE 2024-02-27 11:56:55 -05:00
Kelly Cochrane
11fb04203e Bug 1849175 - Add pinned tabs to Open Tabs in Firefox View r=desktop-theme-reviewers,fxview-reviewers,fluent-reviewers,flod,sclements,nsharpley,dao
Differential Revision: https://phabricator.services.mozilla.com/D201652
2024-02-27 16:27:20 +00:00
Iulian Moraru
3725609047 Backed out changeset 37ef0aa2d2b5 (bug 1857298) for causing bc failures on browser_recentlyclosed_firefoxview.js. 2024-02-20 18:06:25 +02:00
Nikki Sharpley
c6710ccaf5 Bug 1857298 - Add close button to open tabs in view r=fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements
- created tertiary button option for tab rows, styled by a class prop
- added close button to open tabs rows
- removed close tab from open tab context menu
- updated tests to reflect removed panel item in open tab context menu
- added test for the new open tabs close button
- added telemetry for close open tab (requires data review)
- added test suite for keyboard navigation across tab row buttons

Differential Revision: https://phabricator.services.mozilla.com/D200689
2024-02-20 14:50:25 +00:00
Kelly Cochrane
b3dfa7a67a Bug 1857005 - Add indicators to open tabs in Fx View r=desktop-theme-reviewers,fxview-reviewers,fluent-reviewers,sfoster,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D199119
2024-01-30 19:52:31 +00:00
Kelly Cochrane
02a25c8f6a Bug 1870141 - Only recalculate maxRenderCountEstimate in virtual-list if itemHeightEstimate is greater than 0 r=sclements,fxview-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D196588
2023-12-18 16:46:55 +00:00
Kelly Cochrane
93848884bc Bug 1857634 - Pause updates and clear interval time in fxview-tab-list when containing cards are collapsed r=sfoster,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D194421
2023-12-12 21:50:56 +00:00
Noemi Erli
3e946ffda9 Backed out changeset c5f52ea7e7d0 (bug 1857634) for causing failures in test_fxview_tab_list.html 2023-12-12 22:39:33 +02:00
Kelly Cochrane
5870650e8d Bug 1857634 - Pause updates and clear interval time in fxview-tab-list when containing cards are collapsed r=sfoster,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D194421
2023-12-12 18:02:04 +00:00
Jonathan Sudiaman
007ee7e78c Bug 1867325 - Small UI updates to Search in Recently closed tabs and History r=fxview-reviewers,desktop-theme-reviewers,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D195893
2023-12-11 15:49:57 +00:00
Kelly Cochrane
187108a7a7 Bug 1868443 - Update calculation for viewport height in Firefox View r=fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D195723
2023-12-07 13:54:25 +00:00
Kelly Cochrane
c3711a4fb7 Bug 1859788 - Implement virtualizer to improve performance of history in Firefox View r=jsudiaman,fxview-reviewers,reusable-components-reviewers,hjones,sfoster,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D184581
2023-12-04 17:50:04 +00:00
Cosmin Sabou
c4e9d6e90f Backed out changeset e1b32d718ed1 (bug 1859788) for high frequency failures on browser_firefoxview_next_general_telemetry.js. 2023-11-30 20:33:51 +02:00
Kelly Cochrane
844d64ea75 Bug 1859788 - Implement virtualizer to improve performance of history in Firefox View r=jsudiaman,fxview-reviewers,reusable-components-reviewers,hjones,sfoster,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D184581
2023-11-30 16:54:08 +00:00
Norisz Fay
d8c0cbb618 Backed out changeset d3d999e4ff71 (bug 1859788) for causing bc failures on browser_firefoxview_next.js 2023-11-28 20:31:50 +02:00
Kelly Cochrane
612c468997 Bug 1859788 - Implement virtualizer to improve performance of history in Firefox View r=jsudiaman,fxview-reviewers,reusable-components-reviewers,hjones,sfoster,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D184581
2023-11-28 16:56:45 +00:00
Jonathan Sudiaman
340defa7ce Bug 1859829 - Add search to recently closed tabs r=fxview-reviewers,fluent-reviewers,bolsson,sclements
Linear search through the list of recently closed tabs, and some light refactoring for the sake of upcoming search enhancements.

Differential Revision: https://phabricator.services.mozilla.com/D193692
2023-11-21 18:01:05 +00:00
Jonathan Sudiaman
a50353e5f0 Bug 1826328 - Add search capability to view in history r=fxview-reviewers,places-reviewers,fluent-reviewers,flod,mak,sclements
Leverages `AUTOCOMPLETE_MATCH` in order to add search functionality to Fx View History.

https://treeherder.mozilla.org/jobs?repo=try&revision=a45a29326ba22252756cd9d142e9199508b6693b

Differential Revision: https://phabricator.services.mozilla.com/D190844
2023-11-08 02:17:13 +00:00
Logan Rosen
294a7f9c79 Bug 1860931 - fix bug in fxview-tab-list.mjs r=fxview-reviewers,sclements
There are two equals signs when there should be just one. This was made more obvious after applying Prettier v3's auto formatting.

Differential Revision: https://phabricator.services.mozilla.com/D190411
2023-10-25 09:41:31 +00:00
Kelly Cochrane
e95bc21d16 Bug 1854603 - Truncate domains to one line for list items in Firefox View r=desktop-theme-reviewers,fxview-reviewers,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D190822
2023-10-16 16:12:26 +00:00
Sam Foster
1982b4ba3b Bug 1857118 - Avoid rendering tab lists and stop the interval timer when not visible. r=jsudiaman,fxview-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D190242
2023-10-11 17:52:03 +00:00
Sandor Molnar
db7c1a262a Backed out 2 changesets (bug 1857118, bug 1841797) for causing bc failures on browser/components/firefoxview/tests/browser/firefoxview-next/browser_opentabs_recency_next.js
Backed out changeset 08d1791bf44b (bug 1857118)
Backed out changeset 444f6de78b7e (bug 1841797)
2023-10-11 09:31:47 +03:00
Sam Foster
2f305008e4 Bug 1857118 - Avoid rendering tab lists and stop the interval timer when not visible. r=jsudiaman,fxview-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D190242
2023-10-10 21:59:46 +00:00
Norisz Fay
ef12528b92 Backed out changeset 9dfc3bfb7943 (bug 1857118) for causing mochitest failures on test_opentabs.html 2023-10-09 20:23:18 +03:00
Sam Foster
b8302958fd Bug 1857118 - Avoid rendering tab lists and stop the interval timer when not visible. r=jsudiaman,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D190242
2023-10-09 13:44:04 +00:00
Kelly Cochrane
8b923cf919 Bug 1852229 - Fix spacing between synced devices on Recent Browsing r=sclements,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D188640
2023-09-20 14:32:56 +00:00
Hanna Jones
6e8a07a1d3 Bug 1810890 - Part 5: remove Storybook CSS path rewrites from fx view elements r=kcochrane,fxview-reviewers
Depends on D185093

Differential Revision: https://phabricator.services.mozilla.com/D185094
2023-09-05 17:48:25 +00:00
Sam Foster
f078d2dc51 Bug 1845836 - Include closed tabs from closed windows in fxview-next's recently closed tabs list. r=kcochrane,dao,fxview-reviewers,sessionstore-reviewers,sclements
* Add a browser.sessionstore.closedTabsFromClosedWindows pref and consult it when building recently-closed tab lists in firefoxview-next
* Add a _resolveClosedDataSource to SessionStore which allows us to find the window state and _closedTabs given a DOMWindow, a window closedId, or a window session store Id.
* Carry window closedId and source window Id into tab items when building recently-closed tab lists in firefoxview-next. This gives us the necessary context when we need to undoClose or forget a tab item in the list.
* Add a getClosed TabCount and TabData for Closed Windows method to SessionStore
* Modify undoCloseTab and forgetClosedTab to accept source params we can resolve to window state data using _resolveClosedDataSource

Differential Revision: https://phabricator.services.mozilla.com/D185108
2023-08-22 20:42:57 +00:00
Mike Kaply
92124f0bcb Bug 1847242 - Show backup icon if we don't have one. r=sclements,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D185447
2023-08-05 12:04:29 +00:00
Sandor Molnar
a02140aac8 Backed out changeset ea1a5147d972 (bug 1847242) for causing failures in skin/extensions/defaultFavicon.svg CLOSED TREE 2023-08-04 21:26:34 +03:00
Mike Kaply
d8fc3aa36b Bug 1847242 - Show backup icon if we don't have one. r=sclements,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D185447
2023-08-04 18:00:47 +00:00
Mike Kaply
cf21f6166f Bug 1828673 - Add support for overview page in synced tabs. r=desktop-theme-reviewers,fxview-reviewers,jsudiaman,dao,sfoster,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D184414
2023-08-03 18:46:32 +00:00