This fixes the cases where we may end urlbar layout extension when the panel is open, causing it to appear as if it has a transparent background.
On dragstart the view is closed, but layout extension is no more ended, because there's no more risk of overlapping toolbar items.
Additionally it stops clearing results when ui.popup.disable_autohide is enabled, so they can be analyzed from the Browser Toolbox.
Differential Revision: https://phabricator.services.mozilla.com/D50077
We add a new connection type 'cert-error-page' and will show a warning
lock icon for it. We add a test for it and update existing tests.
Differential Revision: https://phabricator.services.mozilla.com/D45647
This patch adds a new class 'certError' for the identity icon if it is
in the 'about:certerror' page. The identity icon will show a warning
lock icon if this class is present.
Differential Revision: https://phabricator.services.mozilla.com/D45646
Right now, the gIdentityHandler.refreshIdentityBlock() is gigantic. In
order to not hit the eslint assert 'complexity', we segregate this
function into two functions according to the functionalities. This
slightly improves the readability of this function.
Differential Revision: https://phabricator.services.mozilla.com/D45645
The idea here is that we avoid updating all site data in SiteDataManager.jsm
just for checking a single host/origin and that we optimize performance by prioritizing
the most common data type (cookies) and synchronous lookups (AppCache) and returning
early if any data was found.
We will still refresh the site data list for clearing once the user clicks on "Clear Site Data".
Differential Revision: https://phabricator.services.mozilla.com/D42800
This patch adds the permission granted indicator to the identity panel.
The granted indicator will be shown if there is any granted permission.
And it will got update if permission changes. We also update a test for
this change.
Differential Revision: https://phabricator.services.mozilla.com/D42121
This is probably the simplest way to implementing this. We might also decide to show the normal lock icon, but still
show a bit of a different text in the popup. I think this that might just be confusing though.
Differential Revision: https://phabricator.services.mozilla.com/D41285
The security UI receives an about:blank load when navigating to or from
about: pages, which causes it to try and render security indicators before
showing the "real" security indicators for the next site. It shouldn't do that.
The solution is a bit cheap, we simply ignore all about:blank and other loads
that will receive a pageproxystate="invalid" state in the URL bar and thus
hide the identity block. This takes care of our problem and also avoids
some work when loading the home page.
Differential Revision: https://phabricator.services.mozilla.com/D40515
The security UI receives an about:blank load when navigating to or from
about: pages, which causes it to try and render security indicators before
showing the "real" security indicators for the next site. It shouldn't do that.
The solution is a bit cheap, we simply ignore all about:blank and other loads
that will receive a pageproxystate="invalid" state in the URL bar and thus
hide the identity block. This takes care of our problem and also avoids
some work when loading the home page.
Differential Revision: https://phabricator.services.mozilla.com/D40515
This patch changes the anchor point of the protections popup to the
shield icon container. Also remove the alt key which is needed to
open the protection icon.
In addtion, this also makes these two popups are mutual exclusive.
Differential Revision: https://phabricator.services.mozilla.com/D37791
This patch merges two icons, the connection icon and the extension icon,
into identity icon. And display differently according to the site where
it is. For the site needed to show a lock icon, it will show lock icon.
Otherwise, it will show a proper icon according to the page, such as a
brand icon for chrome page, or a extension icon for a extension page.
Differential Revision: https://phabricator.services.mozilla.com/D37789
This is a pretty big change on paper, but most of the lines are copy-pasted, with some small
adjustments to get the content blocking code comfortable in browser-siteProtections.js.
Differential Revision: https://phabricator.services.mozilla.com/D37556
This lives in the protections popup now and will get a new probe.
Since I'm only removing data collection I don't think a data steward is required to sign off.
I'm removing recordClick calls in identityPanel.inc.xul in a later patch.
Differential Revision: https://phabricator.services.mozilla.com/D37555
This is a pretty big change on paper, but most of the lines are copy-pasted, with some small
adjustments to get the content blocking code comfortable in browser-siteProtections.js.
Differential Revision: https://phabricator.services.mozilla.com/D37556
This lives in the protections popup now and will get a new probe.
Since I'm only removing data collection I don't think a data steward is required to sign off.
I'm removing recordClick calls in identityPanel.inc.xul in a later patch.
Differential Revision: https://phabricator.services.mozilla.com/D37555
