Commit Graph

3428 Commits

Author SHA1 Message Date
Joel Maher
3c323306ab Bug 1917158 - move some skip-if -> run-if for browser/components/**/browser.toml. r=sessionstore-reviewers,tabbrowser-reviewers,urlbar-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D221286
2024-09-06 10:08:18 +00:00
Peter Van der Beken
8d210b04b5 Bug 1916492 - Remove some unused leftover code from GroupedSHistory. r=sessionstore-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D220987
2024-09-05 13:10:18 +00:00
Kelly Cochrane
9600083d6c Bug 1898251 - Add animations for sidebar 'launcher' in 'Always show' mode r=desktop-theme-reviewers,reusable-components-reviewers,sidebar-reviewers,dao,hjones,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D215520
2024-08-26 19:16:07 +00:00
Nikki Sharpley
52f1cd691f Bug 1914455 - Remove "order" from sidebar SessionStore data r=sidebar-reviewers,sessionstore-reviewers,dao,kcochrane
We can rely on the global pref for this. `setPosition` in `browswer-sidebar.js` looks
at the pref `sidebar-position_start` to determine "order" on `init` and on `reversePosition`

Differential Revision: https://phabricator.services.mozilla.com/D219906
2024-08-26 15:05:15 +00:00
Tamas Szentpeteri
db26c1b7f0 Backed out changeset 4270bbbfb92d (bug 1898251) for causing frequent marionette failures on test_restore_sidebar.py. CLOSED TREE 2024-08-24 00:24:39 +03:00
Kelly Cochrane
9c271bfe95 Bug 1898251 - Add animations for sidebar 'launcher' in 'Always show' mode r=desktop-theme-reviewers,reusable-components-reviewers,sidebar-reviewers,dao,hjones,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D215520
2024-08-23 15:56:40 +00:00
Florian Quèze
180dc5f37e Bug 1913624 - Remove expired telemetry histogram FX_SESSION_RESTORE_PRIVACY_LEVEL, r=sessionstore-reviewers,TravisLong,dao.
Depends on D219483

Differential Revision: https://phabricator.services.mozilla.com/D219484
2024-08-21 09:14:32 +00:00
Nikki Sharpley
b8a620c625 Bug 1908908 - Preserve sidebar width on close in session store. r=sidebar-reviewers,sessionstore-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D219238
2024-08-20 15:10:16 +00:00
Norisz Fay
fe5c1d2b6e Backed out changeset 3d3e86a6d3fc (bug 1908908) for causing multiple failures CLOSED TREE 2024-08-20 01:50:37 +03:00
Nikki Sharpley
875fb65856 Bug 1908908 - Preserve sidebar width on close in session store. r=sidebar-reviewers,sessionstore-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D219238
2024-08-19 20:53:47 +00:00
Sam Foster
f64b68c78d Bug 1899580 - Exclude collapsed vertical tabs from indicator-replaces-favicon behavior. r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements
- Ensure everything that sets .expanded on sidebar-main uses the toggleExpanded method

Differential Revision: https://phabricator.services.mozilla.com/D217507
2024-08-07 18:51:26 +00:00
Noemi Erli
add41c1a33 Backed out changeset 81c607ae7fa3 (bug 1906140) for causing mochitest failures CLOSED TREE 2024-08-03 04:30:26 +03:00
Kelly Cochrane
95e61eaaba Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D217504
2024-08-03 00:04:27 +00:00
Noemi Erli
ea6ddac0d7 Backed out changeset f14b6d618dee (bug 1906140) for causing mochitest failures 2024-08-03 00:48:34 +03:00
Kelly Cochrane
0e25ff4d26 Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D217504
2024-08-02 21:07:57 +00:00
Noemi Erli
9526f13a15 Backed out changeset a5aa68704532 (bug 1906140) for causing failures in browser_view_sidebar_menu.js CLOSED TREE 2024-08-03 00:03:13 +03:00
Kelly Cochrane
12ead799a2 Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D217504
2024-08-02 19:27:10 +00:00
Noemi Erli
aa53f7828b Backed out changeset b825b6411765 (bug 1906140) for causing failures in browser_view_sidebar_menu.js CLOSED TREE 2024-08-02 22:17:11 +03:00
Kelly Cochrane
3f0ff02121 Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D217504
2024-08-02 18:32:38 +00:00
Sarah Clements
7ea40f53e4 Bug 1899336 - Position pinned tabs and new tab button for vertical tabs mode r=dao,sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,kcochrane
* Create a new container to house pinned tabs, new tab button and non-pinned tabs
* Create new pinned tabs container to apply grid layout and overflow scrolling
* Update test coverage for pinned tabs for both horizontal and vertical tabs

Differential Revision: https://phabricator.services.mozilla.com/D215482
2024-07-29 11:30:37 +00:00
Joel Maher
d70349f2c5 Bug 1903845 - Add 'os_integration' tags to test manifests for faster image verification. r=aryx,jgilbert,settings-reviewers,media-playback-reviewers,sessionstore-reviewers,places-reviewers,omc-reviewers,migration-reviewers,padenot,dao,aminomancer,Standard8,mconley
Differential Revision: https://phabricator.services.mozilla.com/D214969
2024-07-09 13:01:55 +00:00
Jonathan Sudiaman
fec725412b Bug 1892430 - Add a "Hide" sidebar visibility setting r=sidebar-reviewers,sessionstore-reviewers,sclements
The toggle was there to begin with, but this commit actually gets it working to spec.

Differential Revision: https://phabricator.services.mozilla.com/D214181
2024-06-27 19:34:08 +00:00
Jonathan Sudiaman
52e63f2908 Bug 1892941 - Add a "Always Show" sidebar visibility setting r=sidebar-reviewers,fluent-reviewers,sessionstore-reviewers,bolsson,sclements,reusable-components-reviewers,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D212285
2024-06-27 19:34:08 +00:00
Nikki Sharpley
60f464ed8e Bug 1892957 - Add sidebar position settings to the Customize Sidebar menu r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,sessionstore-reviewers,kcochrane,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D213591
2024-06-21 18:15:25 +00:00
Cristian Tuns
ecab83f214 Backed out changeset bd06757d8344 (bug 1892957) for causing mochitest failures in browser_sidebar_move.js CLOSED TREE 2024-06-21 11:40:07 -04:00
Nikki Sharpley
72b2fd0ee7 Bug 1892957 - Add sidebar position settings to the Customize Sidebar menu r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,sessionstore-reviewers,kcochrane,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D213591
2024-06-21 14:00:00 +00:00
Emilio Cobos Álvarez
f16ff34d47 Bug 1902315 - Remove CHROME_WINDOW_{LOWERED,RAISED}. r=arai,extension-reviewers,sessionstore-reviewers,dao,zombie
These did nothing at the OS level on most OSes (see previous patch), and
were only used on tests, so just remove them.

Note that these were different from the alwaysontop feature, which
remains and is used for stuff like picture-in-picture.

Differential Revision: https://phabricator.services.mozilla.com/D214091
2024-06-19 07:47:37 +00:00
Nikki Sharpley
f60a47f6c5 Bug 1895868 - Sidebar should not be visible in popup windows r=sidebar-reviewers,sessionstore-reviewers,sfoster,kcochrane
- hides sidebar on popup window
- disabled sidebar menu options in View, hence disabling keyboard shortcuts

Differential Revision: https://phabricator.services.mozilla.com/D212597
2024-06-10 22:44:53 +00:00
Tamas Szentpeteri
1b4d233427 Backed out changeset 4ab23ba75a11 (bug 1895868) for causing mochitest failures on browser_history_sidebar.js 2024-06-10 21:55:16 +03:00
Nikki Sharpley
878b2fc533 Bug 1895868 - Sidebar should not be visible in popup windows r=sidebar-reviewers,sessionstore-reviewers,sfoster,kcochrane
- hides sidebar on popup window
- disabled sidebar menu options in View, hence disabling keyboard shortcuts

Differential Revision: https://phabricator.services.mozilla.com/D212597
2024-06-10 17:37:11 +00:00
Dão Gottwald
5d53c6acf7 Bug 1900002 - Move tabbrowser tests into a browser/ folder. r=frontend-codestyle-reviewers,dwalker
See https://phabricator.services.mozilla.com/D211509#inline-1171035

Differential Revision: https://phabricator.services.mozilla.com/D212250
2024-06-04 13:20:52 +00:00
Fatih
aef2965619 Bug 1897590: Check RoundWindowSize RFPTarget before restoring tab sizes. r=tjr,sessionstore-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D211034
2024-05-31 16:03:43 +00:00
Cosmin Sabou
945f1508e6 Bug 1848488 - Disable browser_should_restore_tab.js on linux 18.04 debug for frequent failures. r=intermittent-reviewers,jmaher
Differential Revision: https://phabricator.services.mozilla.com/D211658
2024-05-26 03:13:27 +00:00
Nikki Sharpley
f2f0a26b06 Bug 1892033 - Move sidebar style persistence from XULstore to SessionStore r=sidebar-reviewers,sessionstore-reviewers,backup-reviewers,dao,Gijs,sclements,kpatenio
Move style persistence from XULstore to SessionStore.

Follow up bug to fix persistence of sidebar when only a new tab is open and window is closed, and its
accompanying test `browser_sidebar_persist.js`: Bug 1898613

Depends on D207048

Differential Revision: https://phabricator.services.mozilla.com/D207787
2024-05-24 20:16:31 +00:00
Dão Gottwald
c4167a3cc6 Bug 1898197 - Move tabs tests into browser/components/tabbrowser/. r=tabbrowser-reviewers,frontend-codestyle-reviewers,mak
Differential Revision: https://phabricator.services.mozilla.com/D211190
2024-05-23 12:54:24 +00:00
Sam Foster
3bb578be0b Bug 1896791 - Fix logging typo for the createTabsForSessionRestore return value. r=sessionstore-reviewers,nsharpley,sclements
Differential Revision: https://phabricator.services.mozilla.com/D210391
2024-05-16 17:58:14 +00:00
Sam Foster
6faea180fa Bug 1854373 Use the loggers to capture errors and debug details during session restore.r=sessionstore-reviewers,markh,sclements
* Timestamped log files are written to a `sessionstore-logs` directory in the profile directory
* Errors will always get written to disk, the logOnSuccess pref ensures all logs are saved even if no error has been captured
* The prefs configure how much logging we do. We have more verbose logging by default in  nightly/early-beta, and less (errors, warnings) in release.
* Logging statements have been added to the early phases of session restore. We'll add more I'm sure as we troubleshoot specific bugs.

Differential Revision: https://phabricator.services.mozilla.com/D208816
2024-05-09 20:30:15 +00:00
Peter Van der Beken
811ff6e04e Bug 1865387 - Don't recreate session-store's history listener for browsing-context-did-set-embedder notification if browserId didn't change. r=geckoview-reviewers,nika,sessionstore-reviewers,owlish,kaya,farre
Differential Revision: https://phabricator.services.mozilla.com/D193929
2024-05-07 06:24:13 +00:00
Sam Foster
11a0641a64 Bug 1889941 - Fix the restore all windows command. r=sessionstore-reviewers,farre
Differential Revision: https://phabricator.services.mozilla.com/D209473
2024-05-06 17:56:43 +00:00
Nikki Sharpley
b43107b445 Bug 1885894 - Remove sidebar persistence from XULStore r=sessionstore-reviewers,backup-reviewers,sidebar-reviewers,Gijs,mconley,sfoster,sclements
Since we are moving away from XUL for the revamped sidebar, remove persistence off of XULstore.
For now, this involves moving persistence of "sidebar-command" and "positionend" to SessionStore.

A follow up bug 1892033 for moving the style attribute to SessionStore has been filed. This is slightly more involved,
hence the separate patch.

Differential Revision: https://phabricator.services.mozilla.com/D207048
2024-05-06 15:11:20 +00:00
Sarah Clements
fb5818e268 Bug 1892965 - Rename SidebarUI and SidebarLauncher r=sidebar-reviewers,places-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D208901
2024-05-03 15:20:15 +00:00
kycn
15151ae200 Bug 1677190 - Move buildRestoreData to toolkit to use it on both Android and Desktop. r=geckoview-reviewers,sessionstore-reviewers,owlish,farre
Differential Revision: https://phabricator.services.mozilla.com/D208642
2024-05-02 17:41:06 +00:00
Norisz Fay
a2156ad63a Backed out changeset 75c44ff76360 (bug 1892965) for causing multiple failures 2024-05-01 22:58:27 +03:00
Sarah Clements
5209eded5e Bug 1892965 - Rename SidebarUI and SidebarLauncher r=sidebar-reviewers,places-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D208901
2024-05-01 12:19:41 +00:00
kycn
03568c5097 Bug 1677190 - Introduce SessionStoreFunctions for GeckoView package and move the existing SessionStoreFunctions from toolkit to the browser package. r=geckoview-reviewers,farre,nika,owlish
This change utilizes components.conf to distinguish between the contract implementations of nsISessionStoreFunctions per platform.

Differential Revision: https://phabricator.services.mozilla.com/D206904
2024-04-30 11:17:55 +00:00
Kelly Cochrane
29334c86f7 Bug 1894061 - Resolving 'can_load' extra key error for session restore telemetry causing error console spam r=Gijs,sessionstore-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D208937
2024-04-30 08:59:50 +00:00
endington543
fdf371e937 Bug 1891816 - Refactor gOnceInitializedDeferred to use Promise.withResolvers r=sessionstore-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D208686
2024-04-25 23:37:30 +00:00
Joel Maher
bedfa83025 Bug 1859204 - adjust linux asan browser-chrome tests to be more balanced, skip extremely long tests, run on xlarge instances. r=aryx,sessionstore-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D206822
2024-04-09 19:43:23 +00:00
Yi Xiong Wong
bef11a2dc2 Bug 1880914 - Move browser/tab closing functions. r=Gijs,perftest-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,sfoster,kshampur
Differential Revision: https://phabricator.services.mozilla.com/D206197
2024-04-08 17:21:01 +00:00
Sam Foster
e3765221a6 Bug 1886659 - Remove the FX_SESSION_RESTORE_CLOSED_TABS_NOT_SAVED probe. r=sessionstore-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D206717
2024-04-05 22:13:48 +00:00