Emilio Cobos Álvarez
1456e6c370
Bug 1914223 - Don't manually import eventutils in browser tests. r=Gijs
...
It causes this line not to work:
https://searchfox.org/mozilla-central/rev/cb5faf5dd5176494302068c553da97b4d08aa339/testing/mochitest/tests/SimpleTest/EventUtils.js#3254
And is just not needed. In fact in most of these it was just unused.
Differential Revision: https://phabricator.services.mozilla.com/D220727
2024-09-01 11:51:19 +00:00
Sarah Clements
7ea40f53e4
Bug 1899336 - Position pinned tabs and new tab button for vertical tabs mode r=dao,sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,kcochrane
...
* Create a new container to house pinned tabs, new tab button and non-pinned tabs
* Create new pinned tabs container to apply grid layout and overflow scrolling
* Update test coverage for pinned tabs for both horizontal and vertical tabs
Differential Revision: https://phabricator.services.mozilla.com/D215482
2024-07-29 11:30:37 +00:00
Jonathan Sudiaman
ecde5504b4
Bug 1899582 - Update styling for vertical tabs r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,emilio,dao,sclements
...
The tab container indicators (colored underlines) switch to the left side.
Add a fade effect where the vertical tabs container meets the tools.
Exclude both "allow showing more of the tab title" rules for vertical mode.
Differential Revision: https://phabricator.services.mozilla.com/D215402
2024-07-15 16:04:30 +00:00
Dão Gottwald
5d53c6acf7
Bug 1900002 - Move tabbrowser tests into a browser/ folder. r=frontend-codestyle-reviewers,dwalker
...
See https://phabricator.services.mozilla.com/D211509#inline-1171035
Differential Revision: https://phabricator.services.mozilla.com/D212250
2024-06-04 13:20:52 +00:00
Dão Gottwald
c4167a3cc6
Bug 1898197 - Move tabs tests into browser/components/tabbrowser/. r=tabbrowser-reviewers,frontend-codestyle-reviewers,mak
...
Differential Revision: https://phabricator.services.mozilla.com/D211190
2024-05-23 12:54:24 +00:00
Danny Colin
f6d43c31c6
Bug 1289130 - Limit width of container indicator label in urlbar r=mconley,desktop-theme-reviewers,tabbrowser-reviewers,emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D207352
2024-04-24 17:32:14 +00:00
Dave Townsend
a0c83bc943
Bug 1864896: Autofix unused function arguments (browser). r=webcompat-reviewers,mconley,fxview-reviewers,desktop-theme-reviewers,omc-reviewers,migration-reviewers,twisniewski,aminomancer,dao,sclements,firefox-desktop-core-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D203005
2024-03-19 09:36:35 +00:00
Emilio Cobos Álvarez
1c20c25eda
Bug 232598 - Return null for unset attributes in XUL. r=smaug,devtools-reviewers,omc-reviewers,zombie,nchevobbe,settings-reviewers,application-update-reviewers,credential-management-reviewers,mossop,aminomancer,bytesized,issammani,sessionstore-reviewers,dao
...
I just got bit by this in bug 1873833, let's just fix it. There isn't
all that much stuff depending on it anymore.
Differential Revision: https://phabricator.services.mozilla.com/D204496
2024-03-18 09:15:07 +00:00
Gregory Pappas
9bd4fc9c87
Bug 1878401 - part 7 - Pass BrowsingContext to nsIFilePicker::Init in tests r=extension-reviewers,settings-reviewers,credential-management-reviewers,anti-tracking-reviewers,devtools-reviewers,sgalich,pbz,nchevobbe,zombie,migration-reviewers,mconley
...
Depends on D200551
Differential Revision: https://phabricator.services.mozilla.com/D200552
2024-02-28 21:29:39 +00:00
Sandor Molnar
c853f2f3e9
Backed out 8 changesets (bug 1878401, bug 1879041) for causing build bustages on widget/nsBaseFilePicker.cpp CLOSED TREE
...
Backed out changeset 2e2b8df3bdd6 (bug 1879041)
Backed out changeset 6d6952f9df2c (bug 1878401)
Backed out changeset 30b5bb590d3e (bug 1878401)
Backed out changeset 9a4b830334b9 (bug 1878401)
Backed out changeset 3c3d67f1fcb7 (bug 1878401)
Backed out changeset c83ba4026822 (bug 1878401)
Backed out changeset 6bcb670ce475 (bug 1878401)
Backed out changeset f263b196df96 (bug 1878401)
2024-02-28 17:56:48 +02:00
Gregory Pappas
55e30a8b92
Bug 1878401 - part 7 - Pass BrowsingContext to nsIFilePicker::Init in tests r=extension-reviewers,settings-reviewers,credential-management-reviewers,anti-tracking-reviewers,devtools-reviewers,sgalich,pbz,nchevobbe,zombie,migration-reviewers,mconley
...
Depends on D200551
Differential Revision: https://phabricator.services.mozilla.com/D200552
2024-02-28 15:07:46 +00:00
Tom Marble
a42a175006
Bug 1868866 - adds ManifestParser TOML linter r=jmaher,linter-reviewers,ahal,webdriver-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,cookie-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,translations-reviewers,valentin,whimboo,Standard8,sclements,jesup
...
Differential Revision: https://phabricator.services.mozilla.com/D199054
2024-01-29 17:30:48 +00:00
Sandor Molnar
778333649c
Backed out changeset 2be67d91cf16 (bug 1868866) for causing Mn failures at toolkit/xre/test/marionette/test_exitcode.py CLOSED TREE
2024-01-27 00:15:22 +02:00
Tom Marble
920ed4a927
Bug 1868866 - adds ManifestParser TOML linter r=jmaher,linter-reviewers,ahal,webdriver-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,cookie-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,translations-reviewers,valentin,whimboo,Standard8,sclements,jesup
...
Differential Revision: https://phabricator.services.mozilla.com/D199054
2024-01-26 20:06:56 +00:00
Brian Grinstead
d8faddce1c
Bug 1874599 - Add a pref to disable userContextId guessing for external opens;r=mossop
...
Bug 1692124 improved the behavior for workflows where external opens should move into sessions
inside containers, but it created an issue for those where external opens should move into
the default container and there are also tabs from the same domains inside containers, and
would create extra interstitials with the Multi-Account Containers addon if the predicted
container is different than the "always open" addon setting.
While the heuristic could be improved, it will never be perfect for all workflows,
so this patch introduces a pref to opt out of the behavior (and always open external
links in the default user context ID).
Differential Revision: https://phabricator.services.mozilla.com/D199443
2024-01-25 21:55:59 +00:00
Joel Maher
3662d84cd4
Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D198082
2024-01-25 00:27:05 +00:00
Stanca Serban
71d0d5cf96
Backed out changeset 54462970f797 (bug 1873732) for causing web platform tests failures.
2024-01-24 21:08:19 +02:00
Gijs Kruitbosch
532c3bc439
Bug 1780071 - autofix browser/ violations of no-comparison-or-assignment-inside-ok, r=Standard8,webcompat-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,sessionstore-reviewers,places-reviewers,sgalich,dao,twisniewski,mconley,sclements
...
Differential Revision: https://phabricator.services.mozilla.com/D198974
2024-01-24 17:03:13 +00:00
Joel Maher
04ec786571
Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D198082
2024-01-24 16:35:54 +00:00
Marc Seibert
0d5499987a
Bug 1861530 - Implement the updated UX spec for Switch to tab in containers feature.r=mak,desktop-theme-reviewers,fluent-reviewers,bolsson,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D192026
2024-01-23 08:54:19 +00:00
Stephanie Cunnane
946bb33fb4
Bug 1857264 - Remove unnecessary openTabInUserContext function definitions in tests. r=mseibert
...
Differential Revision: https://phabricator.services.mozilla.com/D197809
2024-01-17 16:09:10 +00:00
Mark Banner
ac8496d866
Bug 1858148 - Remove Cu.importGlobalProperties from sjs files as it is no longer needed. r=mossop,webdriver-reviewers,necko-reviewers,search-reviewers,devtools-reviewers,anti-tracking-reviewers,sessionstore-reviewers,pbz,dao,daleharvey,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D190759
2023-11-04 09:29:27 +00:00
Marc Seibert
c302da11ed
Bug 1859810 - Bookmark suggestion includes container label before URL with browser.urlbar.switchTabs.searchAllContainers = true.r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D191636
2023-11-02 14:50:58 +00:00
Marc Seibert
d102db072b
Bug 1479858 - Added option for UrlBar search open tabs to ignore userContextId.r=mak,dao
...
Oiriginal patch author: Paresh Malalur <atararx@gmail.com >
Differential Revision: https://phabricator.services.mozilla.com/D187465
2023-10-13 08:48:46 +00:00
Brian Grinstead
fef8019dcc
Bug 1858309 - Include tabs without a container set in the heuristic for guessing the container from external opener r=mossop
...
This fixes a bug where we assign a URL into a container when it shouldn't be.
Differential Revision: https://phabricator.services.mozilla.com/D190646
2023-10-11 07:47:48 +00:00
Brian Grinstead
ae5d83d3d1
Bug 1692124 - Guess the userContextId for externally opened URLs;r=mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D154812
2023-10-05 17:44:25 +00:00
Jan Varga
ad471d5a69
Bug 1733107 - Replace some nsIQuotaManagerService::ClearStoragesForPrincipal calls with nsIQuotaManagerService::ClearStoragesForOriginPrefix; r=dom-storage-reviewers,pbz,asuth
...
There's now a dedicated nsIQuotaManagerService::ClearStoragesForOriginPrefix
method for clearing storages for origin prefix. All callers of
nsIQuotaManagerService::ClearStoragesForPrincipal which want to clear all
storages for given origin prefix can be now converted to call the new method.
Changed done in this patch:
- replaced some nsIQuotaManagerService::ClearStoragesForPrincipal calls with
nsIQuotaManagerService::ClearStoragesForOriginPrefix
Differential Revision: https://phabricator.services.mozilla.com/D186778
2023-09-25 16:28:38 +00:00
Tom Marble
ad50861ef9
Bug 1853243 - convert .ini manifests to .toml: batch 5 browser/**/browser.ini r=jmaher,mossop,webcompat-reviewers,twisniewski,search-reviewers,Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D188427
2023-09-21 22:47:07 +00:00
Marco Bonardo
6874dffc71
Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao
...
This should make a bit clearer that it is only starting the load, not waiting
for its completion.
Differential Revision: https://phabricator.services.mozilla.com/D188213
2023-09-15 09:16:34 +00:00
Marco Bonardo
d76762b5ca
Bug 1852963 - Fix tests awaiting on BrowserTestUtils.loadURIString(). r=dao,webdriver-reviewers,devtools-reviewers,whimboo
...
BrowserTestUtils.loadURIString() is not async, nor returning a promise, it's
effectively not awaiting for the page to be loaded.
Differential Revision: https://phabricator.services.mozilla.com/D188211
2023-09-15 09:16:34 +00:00
Sandor Molnar
5d8dd001ad
Backed out 3 changesets (bug 1852963) for causing remote failures on remote/shared/messagehandler/test/browser/browser_session_data.js CLOSED TREE
...
Backed out changeset 98de7bc404c3 (bug 1852963)
Backed out changeset edf1527c9a99 (bug 1852963)
Backed out changeset 34357750f69c (bug 1852963)
2023-09-14 20:29:06 +03:00
Marco Bonardo
c5fb3dbb49
Bug 1852963 - Rename BrowserTestUtils.loadURIString() to .startLoadingURIString(). r=dao
...
This should make a bit clearer that it is only starting the load, not waiting
for its completion.
Differential Revision: https://phabricator.services.mozilla.com/D188213
2023-09-14 16:33:13 +00:00
Marco Bonardo
1bf2559539
Bug 1852963 - Fix tests awaiting on BrowserTestUtils.loadURIString(). r=dao,webdriver-reviewers,devtools-reviewers,whimboo
...
BrowserTestUtils.loadURIString() is not async, nor returning a promise, it's
effectively not awaiting for the page to be loaded.
Differential Revision: https://phabricator.services.mozilla.com/D188211
2023-09-14 16:33:13 +00:00
Mark Banner
544ecba3af
Bug 1837176 - Convert imports of httpd.js to consume the ES module directly. r=necko-reviewers,webcompat-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,robwu,issammani,bytesized,pbz,valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D181159
2023-07-12 13:38:34 +00:00
Mark Banner
0666077666
Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
...
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner
91fde42f7b
Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
...
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Harshit Sohaney
4f1ba4f656
Bug 1712082 - Fixed image partioning error due to invalied ASCII images in tests using atob() to convert into browser readble. r=timhuang,anti-tracking-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D177262
2023-05-08 16:48:19 +00:00
anwar
1d2e079021
Bug 1829673 - Put all mochitest test manifest files under browser/components into alphabetical order. r=mconley,extension-reviewers,credential-management-reviewers,dimi,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D176459
2023-05-02 16:13:24 +00:00
Mark Banner
2a801fd670
Bug 1824173 - Automatically fix some ESLint issues raised by the valid-jsdoc configuration. r=mossop,webcompat-reviewers,denschub
...
Differential Revision: https://phabricator.services.mozilla.com/D173450
2023-03-24 19:35:24 +00:00
Abhishek Tiwari
44d69b39a6
Bug 1821620 - Convert toolkit/components/forgetaboutsite to ES modules r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D172230
2023-03-14 21:36:38 +00:00
Emilio Cobos Álvarez
cdff2ecc8e
Bug 1820534 - Move front-end to modern flexbox. r=Gijs,dao,settings-reviewers,credential-management-reviewers,sgalich,devtools-reviewers,nchevobbe
...
Done mostly automatically via find/replace following the conversions
specified here:
https://groups.google.com/a/mozilla.org/g/firefox-dev/c/9sGpF1TNbLk/m/QpU3oTUuAgAJ
For the most part I think the "flex: N N" usage could be simplified to
just "flex: N", but I wanted to preserve behavior (-moz-box-flex sets
both flex-grow and flex-shrink).
I changed legacy layout to also look at the order property rather than
-moz-box-ordinal-group because it made splitters and treecols easier (we
don't need to deal with both orders).
Differential Revision: https://phabricator.services.mozilla.com/D171715
2023-03-08 16:13:57 +00:00
Stanca Serban
5d57898ee6
Backed out changeset c25af897c9bc (bug 1820534) for causing reftests and mochitests failures.
2023-03-08 17:34:42 +02:00
Emilio Cobos Álvarez
e15feb465b
Bug 1820534 - Move front-end to modern flexbox. r=Gijs,dao,settings-reviewers,credential-management-reviewers,sgalich,devtools-reviewers,nchevobbe
...
Done mostly automatically via find/replace following the conversions
specified here:
https://groups.google.com/a/mozilla.org/g/firefox-dev/c/9sGpF1TNbLk/m/QpU3oTUuAgAJ
For the most part I think the "flex: N N" usage could be simplified to
just "flex: N", but I wanted to preserve behavior (-moz-box-flex sets
both flex-grow and flex-shrink).
I changed legacy layout to also look at the order property rather than
-moz-box-ordinal-group because it made splitters and treecols easier (we
don't need to deal with both orders).
Differential Revision: https://phabricator.services.mozilla.com/D171715
2023-03-08 14:11:35 +00:00
Gijs Kruitbosch
b965c4660a
Bug 1795255 - autofix duplicate imports in tests under browser/, r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D166179
2023-01-31 11:48:41 +00:00
Mark Banner
9f5558b211
Bug 1812977 - Remove now unnecessary import-globals-from statements in browser. r=settings-reviewers,mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D168070
2023-01-30 19:33:37 +00:00
Gijs Kruitbosch
5a903703c5
Bug 1810995 - update BrowserTestUtils.loadURI consumers to use loadURIString (automated) - browser - r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D167153
2023-01-19 20:16:42 +00:00
Danny Colin
2bfbc92b65
Bug 1796797 - Convert toolkit/components/contextualidentity JSM modules to ESMs r=baku,webdriver-reviewers,extension-reviewers,settings-reviewers,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D159945
2022-12-21 08:14:05 +00:00
Emilio Cobos Álvarez
f7d7418f11
Bug 1790902 - Fix userContext icon creation to use css rather than XUL attributes. r=Itiel,preferences-reviewers,desktop-theme-reviewers,Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D157383
2022-09-15 21:56:39 +00:00
Mark Banner
d026f430f6
Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 22:34:21 +00:00
smolnar
ee079d37e2
Backed out 8 changesets (bug 1779982, bug 1780017, bug 1780347) for causing doc generate failures. CLOSED TREE
...
Backed out changeset 3f22c0f99cf1 (bug 1780347)
Backed out changeset 6f20b7e4b21b (bug 1780017)
Backed out changeset ae6062c69aeb (bug 1780017)
Backed out changeset e668d7778d97 (bug 1780017)
Backed out changeset e158fc41594b (bug 1780017)
Backed out changeset d4c69c956271 (bug 1779982)
Backed out changeset 145212fd826d (bug 1779982)
Backed out changeset 54079aaa1857 (bug 1779982)
2022-07-20 22:43:53 +03:00