corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
745,682 Commits 1 Branch 0 Tags
c553be2d4e8f45aca9f3c17f611a4d244276ce5c
Commit Graph

131 Commits

Author SHA1 Message Date
Tooru Fujisawa
cda8cbecfe Bug 1667455 - Part 14: Stop importing Services.jsm in documents. r=kmag,necko-reviewers,dragana 
Differential Revision: https://phabricator.services.mozilla.com/D150903
 2022-07-11 12:41:54 +00:00
Mark Banner
76af8b0f69 Bug 1777451 - Add a rule to prevent/recommend against using globalThis or window in non-system modules for lazy getters. r=arai 
Differential Revision: https://phabricator.services.mozilla.com/D151083
 2022-07-06 08:35:59 +00:00
Mark Banner
f05cb62a29 Bug 1764513 - Update ESLint docs for how to set up test configuration and how to use ES modules. r=arai 
Differential Revision: https://phabricator.services.mozilla.com/D151039
 2022-07-05 17:09:43 +00:00
Tooru Fujisawa
e1538f8276 Bug 1776837 - Part 2: Reject defining lazy getter for module that is already loaded eagerly at top-level. r=mossop 
Depends on D150935

Differential Revision: https://phabricator.services.mozilla.com/D150936
 2022-07-05 01:01:35 +00:00
Mark Banner
f733d566c8 Bug 1646183 - Extend ESLint rule reject-importGlobalProperties to also handle defineLazyGlobalGetters. r=arai,webdriver-reviewers,webcompat-reviewers,extension-reviewers,whimboo,twisniewski,kmag 
Differential Revision: https://phabricator.services.mozilla.com/D150353
 2022-06-29 22:37:57 +00:00
Makoto Kato
37f1452148 Bug 1776804 - Update spotless information in firefox-source-docs. r=geckoview-reviewers,agi 
"Google Java Format plug-in" link is broken now.

Also we should add spotless information to
https://firefox-source-docs.mozilla.org/code-quality/.

Differential Revision: https://phabricator.services.mozilla.com/D150440
 2022-06-28 22:58:11 +00:00
Kagami Sascha Rosylight
e29a0027f8 Bug 1773740 - Part 3: Cover js files including ChromeUtils r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D148938
 2022-06-27 20:31:33 +00:00
Tooru Fujisawa
f141eb6bc3 Bug 1773747 - Part 6: Add ESLint rule to check immediately-used lazy getter. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D149867
 2022-06-24 11:03:53 +00:00
Tooru Fujisawa
d219fa0035 Bug 1772358 - Add ESLint rule to reject defining lazy getters for always available modules. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D149872
 2022-06-24 11:03:50 +00:00
Mark Banner
78cb8fd108 Bug 1771173 - Add ESLint rule to check for correct usages of lazy. r=arai 
Differential Revision: https://phabricator.services.mozilla.com/D149718
 2022-06-21 20:42:16 +00:00
Tooru Fujisawa
14e84976d3 Bug 1771097 - Add ESLint rule for ChromeUtils.defineESModuleGetters lazy object name. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D147400
 2022-06-17 04:59:13 +00:00
criss
20943ab4b3 Backed out 8 changesets (bug 1771092, bug 1768870, bug 1771097, bug 1769002, bug 1768819) for causing mochitest failures on browser_sendQuery.js. CLOSED TREE 
Backed out changeset 8a4d712f819a (bug 1771092)
Backed out changeset f4e27a35c83c (bug 1771092)
Backed out changeset 072323bc72cc (bug 1771092)
Backed out changeset 2ccf2a00fff7 (bug 1769002)
Backed out changeset ba7086fd9b1f (bug 1768819)
Backed out changeset 6205d3e2c666 (bug 1771097)
Backed out changeset 960f0aee97d5 (bug 1768870)
Backed out changeset 5f53760c5637 (bug 1768870)
 2022-06-17 05:44:37 +03:00
Tooru Fujisawa
1b86cf2dbd Bug 1771097 - Add ESLint rule for ChromeUtils.defineESModuleGetters lazy object name. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D147400
 2022-06-17 01:30:23 +00:00
Mark Banner
b0c82d6cae Bug 1766228 - Add an ESLint rule to ensure that member property accesses of Services are valid. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D149393
 2022-06-16 21:11:24 +00:00
Molnar Sandor
ca093dfdcc Backed out 9 changesets (bug 1769002, bug 1768870, bug 1771097, bug 1771092, bug 1768819) for causing lint failures. CLOSED TREE 
Backed out changeset 829df1dfad70 (bug 1769002)
Backed out changeset f0537d333adc (bug 1771092)
Backed out changeset 25b43856bc00 (bug 1771092)
Backed out changeset a49f754ca73f (bug 1771092)
Backed out changeset 164f85686a32 (bug 1769002)
Backed out changeset ef5cf9ceb915 (bug 1768819)
Backed out changeset c64e6c1fbfe7 (bug 1771097)
Backed out changeset f85393f988a8 (bug 1768870)
Backed out changeset fe708d13cc1d (bug 1768870)
 2022-06-16 20:15:14 +03:00
Tooru Fujisawa
2420011dfd Bug 1771097 - Add ESLint rule for ChromeUtils.defineESModuleGetters lazy object name. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D147400
 2022-06-16 16:20:36 +00:00
Norisz Fay
72669e959c Backed out 5 changesets (bug 1766228) for causing lint failures on test_restrequest.js CLOSED TREE 
Backed out changeset 5ff1634cfe18 (bug 1766228)
Backed out changeset 01642c97e7a5 (bug 1766228)
Backed out changeset cbba28151712 (bug 1766228)
Backed out changeset 76a32127865d (bug 1766228)
Backed out changeset 2c7ef1ad380a (bug 1766228)
 2022-06-16 16:36:44 +03:00
Mark Banner
38b7af6a55 Bug 1766228 - Add an ESLint rule to ensure that member property accesses of Services are valid. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D149393
 2022-06-16 12:09:28 +00:00
Tooru Fujisawa
193b54e231 Bug 1772299 - Reject modification to globalThis inside system module. r=Standard8,webdriver-reviewers,jdescottes 
Differential Revision: https://phabricator.services.mozilla.com/D148116
 2022-06-15 22:20:53 +00:00
Ray Kraesig
fcc0aae9a6 Bug 1772856 - Clean up formatting r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D148417
 2022-06-15 07:12:02 +00:00
Ray Kraesig
0cbc21cb91 Bug 1772856 - Add designated initializers to list of acceptable C++ features r=firefox-build-system-reviewers,bholley,glandium DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D148416
 2022-06-15 07:12:02 +00:00
Tooru Fujisawa
a62358a521 Bug 1771751 - Reject static import for system module from non-system module. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D149183
 2022-06-14 21:56:55 +00:00
Tooru Fujisawa
2bef883c3f Bug 1607331 - Part 3: Reject global this usage in JSM. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D148551
 2022-06-14 21:56:55 +00:00
Bobby Holley
98e3028bb3 Bug 1772234 - Update the style guide to deprecate rooting API typedefs. r=tcampbell 
Differential Revision: https://phabricator.services.mozilla.com/D148081
 2022-06-02 21:01:42 +00:00
Mark Banner
a9fecdd342 Bug 1768031 - Reject top-level await in modules via an ESLint rule. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D145892
 2022-05-11 14:08:15 +00:00
Janvi Bajoria
a6d7d18556 Bug 1759754 - fix use the static preference API link in C++ coding style documentation r=KrisWright 
Differential Revision: https://phabricator.services.mozilla.com/D144191
 2022-05-10 17:26:31 +00:00
Tooru Fujisawa
ba3f307e2c Bug 1548308 - Remove modules.json. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D145695
 2022-05-06 12:35:33 +00:00
Mathew Hodson
e39ff60a8e Bug 1630027 - Migrate RTL Guidelines from MDN. r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D142183
 2022-05-06 07:16:58 +00:00
Mathew Hodson
481dd8581a Bug 1630027 - Migrate CSS Guidelines from MDN. r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D142163
 2022-05-06 07:16:48 +00:00
Mathew Hodson
f2b3c1eab6 Bug 1630027 - Migrate SVG Guidelines from MDN. r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D142184
 2022-05-06 07:16:48 +00:00
Mark Banner
02c1e5dc6a Bug 1766238 - Disallow more than one argument to ChromeUtils.import via ESLint. r=mossop 
Depends on D144562

Differential Revision: https://phabricator.services.mozilla.com/D144563
 2022-04-27 08:38:35 +00:00
Barret Rennie
e2069f9e9f Bug 1765675 - Reject OS.Path usage in reject-osfile lint r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D144307
 2022-04-26 17:34:35 +00:00
Kagami Sascha Rosylight
f3f80c30f9 Bug 1703953 - Part 1: Implement mozilla/use-isinstance rule r=Gijs,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D111354
 2022-04-06 11:57:56 +00:00
Mark Banner
6e6f975d7e Bug 1760286 - Add missing docs for rules in eslint-plugin-mozilla. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D142285
 2022-03-30 17:40:15 +00:00
Gijs Kruitbosch
d04ba14faf Bug 1753696 - use an eslint rule to switch to add_setup(), r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D139542
 2022-03-30 16:16:42 +00:00
Norisz Fay
e1d7571cc8 Backed out 2 changesets (bug 1753696) for causing multiple dt and bc failures CLOSED TREE 
Backed out changeset 67fd9edfbcea (bug 1753696)
Backed out changeset a9d957ea887b (bug 1753696)
 2022-03-30 12:17:55 +03:00
Gijs Kruitbosch
43d6391aa2 Bug 1753696 - use an eslint rule to switch to add_setup(), r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D139542
 2022-03-30 08:18:51 +00:00
criss
0038e58f1f Backed out 3 changesets (bug 1703953) for causing multiple failures. CLOSED TREE 
Backed out changeset 871a1fac289e (bug 1703953)
Backed out changeset 8151244bda18 (bug 1703953)
Backed out changeset eaf6d4c353be (bug 1703953)
 2022-03-29 17:01:58 +03:00
Kagami Sascha Rosylight
7e0f00efd6 Bug 1703953 - Part 1: Implement mozilla/use-isinstance rule r=Gijs,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D111354
 2022-03-29 13:10:59 +00:00
Mike Conley
b273648e2f Bug 1758753 - Migrate XPCOM hashtable documentation from MDN to Firefox Source Docs. r=nika 
Differential Revision: https://phabricator.services.mozilla.com/D140671
 2022-03-17 14:23:27 +00:00
Mark Banner
7ea3c792f2 Bug 1758474 - Implement an ESLint rule to disallow passing {} as the target parameter for ChromeUtils.import. r=Gijs,mossop,perftest-reviewers,preferences-reviewers,sparky 
Differential Revision: https://phabricator.services.mozilla.com/D140517
 2022-03-11 16:41:29 +00:00
smolnar
19781d16c7 Backed out changeset 5018856d8fee (bug 1758474) for causing node eslint failure. CLOSED TREE 2022-03-10 11:58:45 +02:00
Mark Banner
de1754318e Bug 1758474 - Implement an ESLint rule to disallow passing {} as the target parameter for ChromeUtils.import. r=Gijs,mossop,perftest-reviewers,preferences-reviewers,sparky 
Differential Revision: https://phabricator.services.mozilla.com/D140517
 2022-03-10 09:25:28 +00:00
Mitchell Hentges
ac893c8e81 Bug 1756224: Update references to perfdocs linter to explicitly set path r=sparky 
Ideally, the `perfdocs` linter suggestion to `--fix` issues would take
into account the `paths` that were provided, rather than printing the
sure-fire "lint and fix all" solution.

Actually, on further consideration, theoretically such a recommendation
should appear at the `./mach lint` level, and not be linter-specific. Oh
well, that's a future improvement :)

-----

This patch updates the `perfdocs` documentation and suggestions to
successfully operate in the same manner that they did before
bug 1753701.

Differential Revision: https://phabricator.services.mozilla.com/D139159
 2022-03-09 15:52:49 +00:00
Chris Peterson
185d44df61 Bug 1756504 - Remove cpp-virtual-final linter, a minor style check that doesn't diagnose real bugs. r=firefox-static-analysis-reviewers,sylvestre 
In bug 1436263, I added a cpp-virtual-final.yml linter to warn about virtual function declarations that included more than one virtual function specifier `virtual`, `final`, or `override`.

I think we should remove this linter now because:

* It's just a style check and doesn't diagnose a real bug. Including more than one virtual function specifier (`virtual`, `final`, or `override`) is harmless and unambiguous, just unnecessary extra code.
* It has caused some engineer frustration because this style check caused their changeset to be backed out of autoland. Backing out and fixing these style issues are not a good use of sheriffs' or engineers' time.
* It doesn't catch all virtual/final/override style issues because:
  * It can't analyze virtual function definitions that span multiple lines.
  * It doesn't check for `virtual void Foo() override` because  there are over 6000 cases already, so our code will never follow this style check consistently.

Differential Revision: https://phabricator.services.mozilla.com/D139454
 2022-02-24 02:14:39 +00:00
Sylvestre Ledru
aa55fd2be8 Bug 1753413 - fx doc: Remove whitespaces, trailing lines & windows CR r=andi,perftest-reviewers,sparky 
Differential Revision: https://phabricator.services.mozilla.com/D137741
 2022-02-03 18:34:58 +00:00
Sylvestre Ledru
d7e02f6d5f Bug 1738988 - Add support for trojan source detection in mozlint r=linter-reviewers,ahal DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D131086
 2021-11-19 08:37:28 +00:00
Bobby Holley
0d8d639e0d Bug 1740616 - Modify the C++ style guide to prefer unsigned types and CheckedInt. r=glandium DONTBUILD 
This commit resolves the question posed in [1], largely on the basis of
the rationale put forth by emilio [2].

The reasons cited for using signed types boil down to (1) taking
advantage of UB optimizations, (2) more tractable dynamic overflow
analysis, and (3) increased chance of the surrounding logic identifying
and rejecting overflowed values.

Emilio points out that (1) is not a durable advantage. I see some value
in (2) and (3), but I see more value in consistency with existing code
and clear communication of semantic intent to the reader.

[1] https://groups.google.com/a/mozilla.org/g/dev-platform/c/-h_2cz5APmY/
[2] https://groups.google.com/a/mozilla.org/g/dev-platform/c/-h_2cz5APmY/m/NPdl2uIhAgAJ

Differential Revision: https://phabricator.services.mozilla.com/D130928
 2021-11-16 19:38:01 +00:00
OnuohaOluebube
a4ad953053 Bug 1460100 - Added ESLint rule to prevent use of nsIScriptableUnicodeConverter r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D129668
 2021-11-01 16:56:25 +00:00
Andi-Bogdan Postelnicu
900f657b62 Bug 1738598 - sunset Coverity in Firefox. 
Differential Revision: https://phabricator.services.mozilla.com/D129779
 2021-10-31 17:18:02 +00:00