corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
906,830 Commits 1 Branch 0 Tags
c4f8ff9d2c26e36216a8aa42c899ee8663efde63
Commit Graph

6154 Commits

Author SHA1 Message Date
Mark Banner
c4f8ff9d2c Bug 1963599 - Remove getLoadContext global from browser.js. r=firefox-desktop-core-reviewers ,dao 
Differential Revision: https://phabricator.services.mozilla.com/D247282
 2025-04-30 16:50:45 +00:00
Niklas Baumgardner
7276800327 Bug 1953884 - Eagerly create the profiles shared database. r=profiles-reviewers,mossop,jhirsch,firefox-desktop-core-reviewers ,omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D244621
 2025-04-23 15:20:14 +00:00
Jeremy Swinarton
4a0e2c38cc Bug 1938405: Tab interaction metrics for tab groups r=dao,sthompson,tabbrowser-reviewers 
This patch adds the most basic tab interaction metrics for tab groups.
As discussed in standup, we agreed to move the `remove_` class of
metrics into its own bug due to extra complexity involved in correctly
capturing these events.

One other thing we discussed was what the scope of events should be for
the `close_` class of events, i.e. should we *only* capture an event
when someone clicks the "X" button or closes from the TOM menu, or
should we also account for things like context menus, keyboard
shortcuts, etc.? Originally we agreed to capture _all_ tab close events
and mark any source that was not one of the above mentioned two as
unknown. However, after thinking about this more, I don't believe this
is the right approach. There are many places in the codebase where a tab
is closed but not because a user deliberately did it (e.g. when moving a
tab to a new window — this is actually done by creating a new tab in a
new window and closing the old). We currently don't distinguish between
user-initiated close actions, so it would take some time to find all
these places and exclude them.

I favour an explicit inclusion approach (which is what we are doing
elsewhere). In this patch I added events for:
  - closing a tab from the "X" close button (`close_tabstrip`)
  - closing a tab from the tab context menu (`close_tabstrip`)
  - closing a tab from the TOM (`close_tabmenu`)

There are other places that could potentially be
addressed, so I suggest moving these to a follow-up bug and addressing
them for 139.

Differential Revision: https://phabricator.services.mozilla.com/D244915
 2025-04-16 15:01:28 +00:00
shaneziegler
9e82afc772 Bug 1957495 - Move ToolbarIconColor helper object from browser.js into its own module browser/themes/ToolbarIconColor.sys.mjs r=Gijs,desktop-theme-reviewers,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D244058
 2025-04-14 16:46:02 +00:00
DJ
91384c4388 Bug 1938425 - add telemetry for reopening saved groups. r=dao,sessionstore-reviewers,tabbrowser-reviewers,urlbar-reviewers,sthompson 
Differential Revision: https://phabricator.services.mozilla.com/D243737
 2025-04-10 17:35:20 +00:00
Butkovits Atila
b9dc6231d7 Backed out changeset 4711e76ce475 (bug 1938425) for causing failures at browser_tab_groups_telemetry.js. CLOSED TREE 2025-04-10 09:35:44 +03:00
DJ
cdc29e0d0d Bug 1938425 - add telemetry for reopening saved groups. r=dao,sessionstore-reviewers,tabbrowser-reviewers,urlbar-reviewers,sthompson 
Differential Revision: https://phabricator.services.mozilla.com/D243737
 2025-04-10 03:02:30 +00:00
Eric Chen
81fd252f84 Bug 1915738 - Part 1: end session when all non-taskbartab Firefox windows are closed and prepare for restore r=sfoster,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D241499
 2025-04-09 18:57:25 +00:00
Cristina Horotan
2d08511dac Backed out changeset 7fed35bbd242 (bug 1938425) for causing bc failures at browser_tab_groups_telemetry.js. CLOSED TREE 2025-04-09 13:06:03 +03:00
DJ
e9f93720b5 Bug 1938425 - add telemetry for reopening saved groups. r=dao,sessionstore-reviewers,tabbrowser-reviewers,urlbar-reviewers,sthompson 
Differential Revision: https://phabricator.services.mozilla.com/D243737
 2025-04-09 03:07:19 +00:00
Dão Gottwald
3d9566e2de Bug 1917069 - Make the tab strip handle live language switching between LTR and RTL. r=Gijs,reusable-components-reviewers,hjones,fxview-reviewers,sidebar-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D244573
 2025-04-08 15:49:13 +00:00
smolnar
8c01d285cf Backed out changeset 1c700c5b8a89 (bug 1938425) for causing bc failures @ browser_tab_groups_telemetry.js CLOSED TREE 2025-04-07 19:45:55 +03:00
DJ
b8f461ce7f Bug 1938425 - add telemetry for reopening saved groups. r=dao,sessionstore-reviewers,tabbrowser-reviewers,urlbar-reviewers,sthompson 
Differential Revision: https://phabricator.services.mozilla.com/D243737
 2025-04-07 14:51:17 +00:00
Gijs Kruitbosch
b9223d261e Bug 1958504 - fix broken network error pages by catching sync-thrown errors from urifixup's checkhost caused by asyncResolve throwing, r=jteow 
asyncResolve can throw e.g. NS_ERROR_UNKNOWN_PROXY_HOST .

Differential Revision: https://phabricator.services.mozilla.com/D244578
 2025-04-07 13:56:34 +00:00
Kelly Cochrane
a75d2e147f Bug 1956624 - Ensure sidebar collapses on mouse out when expand on hover is enabled and the window is inactive (macOS only) r=sidebar-reviewers,mstange,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D243512
 2025-04-02 14:44:08 +00:00
Eric Chen
9ca071f2e5 Bug 1956905 - change EXTRA_JS_MODULES in the taskbartabs directory's moz.build file to EXTRA_JS_MODULES.taskbartabs r=nrishel 
Differential Revision: https://phabricator.services.mozilla.com/D243362
 2025-04-01 17:36:33 +00:00
Cosmin Sabou
34c867c038 Backed out 2 changesets (bug 1956905, bug 1915737) for causing mochitest plain failures on test_no_errors_clean_profile.py. CLOSED TREE 
Backed out changeset 8e96c17b3f8d (bug 1915737)
Backed out changeset 247c8ebd5fd9 (bug 1956905)
 2025-04-01 06:25:11 +03:00
Eric Chen
e999abda53 Bug 1956905 - change EXTRA_JS_MODULES in the taskbartabs directory's moz.build file to EXTRA_JS_MODULES.taskbartabs r=nrishel 
Differential Revision: https://phabricator.services.mozilla.com/D243362
 2025-03-31 23:23:56 +00:00
Thomas Wisniewski
fa66860cf8 Bug 1952334 - Remove the old Report Site Issue fallback and its system addon, and have Report Broken Site perform its function; r=Gijs,mossop,webcompat-reviewers,zeid,frontend-codestyle-reviewers,denschub 
Differential Revision: https://phabricator.services.mozilla.com/D240671
 2025-03-24 11:55:09 +00:00
Sandor Molnar
b9feeb9be6 Backed out changeset 12fe213a5acf (bug 1952334) for causing bc failures @ browser_webcompat.com_fallback.js CLOSED TREE 2025-03-23 11:50:49 +02:00
Thomas Wisniewski
7d89ae3c11 Bug 1952334 - Remove the old Report Site Issue fallback and its system addon, and have Report Broken Site perform its function; r=Gijs,mossop,webcompat-reviewers,zeid,frontend-codestyle-reviewers,denschub 
Differential Revision: https://phabricator.services.mozilla.com/D240671
 2025-03-23 03:38:50 +00:00
Cosmin Sabou
834872dfb3 Backed out changeset 5113567c1ced (bug 1952334) for bc failures on browser_webcompat.com_fallback.js. CLOSED TREE 2025-03-21 22:14:18 +02:00
Florian Quèze
0fd0af1930 Bug 1950710 - Migrate histograms to use Glean APIs in browser/base/content, r=chutten,reusable-components-reviewers,tgiles. 
Differential Revision: https://phabricator.services.mozilla.com/D242369
 2025-03-21 15:46:30 +00:00
shaneziegler
37f81a03af Bug 1954799 - Move new tab, new window, home button drag/drop handlers out of browser.js into ToolbarDropHandler.sys.mjs r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D242203
 2025-03-21 14:37:32 +00:00
Thomas Wisniewski
702cd76018 Bug 1952334 - Remove the old Report Site Issue fallback and its system addon, and have Report Broken Site perform its function; r=Gijs,mossop,webcompat-reviewers,zeid,frontend-codestyle-reviewers,denschub 
Differential Revision: https://phabricator.services.mozilla.com/D240671
 2025-03-21 13:00:34 +00:00
Gijs Kruitbosch
fcab2ecd6a Bug 1953575 - move gShareUtils to its own module, r=firefox-desktop-core-reviewers ,tabbrowser-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D241485
 2025-03-20 15:54:31 +00:00
Sandor Molnar
0fb14f0eb0 Backed out changeset aff0571a4a46 (bug 1952334) for causing build bustages. CLOSED TREE 2025-03-20 03:12:29 +02:00
Thomas Wisniewski
6ac129706e Bug 1952334 - Remove the old Report Site Issue fallback and its system addon, and have Report Broken Site perform its function; r=Gijs,mossop,webcompat-reviewers,zeid,frontend-codestyle-reviewers,denschub 
Differential Revision: https://phabricator.services.mozilla.com/D240671
 2025-03-20 00:14:00 +00:00
Dão Gottwald
3ba48b6655 Bug 1950904 - Use element index instead of tab index for the drop indicator. r=dwalker,jswinarton,tabbrowser-reviewers,perftest-reviewers,fbilt 
Differential Revision: https://phabricator.services.mozilla.com/D239937
 2025-03-19 15:07:53 +00:00
Gijs Kruitbosch
e9de12e4df Bug 1954435 - switch uitour to use moz-src, r=omc-reviewers,firefox-desktop-core-reviewers ,aminomancer,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D241795
 2025-03-17 22:26:21 +00:00
Goloman Adrian
2297602064 Backed out changeset 0f21091f77ec (bug 1952334) for causing bc failures @browser_all_files_referenced.js. CLOSED TREE 2025-03-14 08:05:34 +02:00
Thomas Wisniewski
0c35bb4f68 Bug 1952334 - Remove the old Report Site Issue fallback and its system addon, and have Report Broken Site perform its function; r=Gijs,mossop,webcompat-reviewers,zeid,frontend-codestyle-reviewers,denschub 
Differential Revision: https://phabricator.services.mozilla.com/D240671
 2025-03-13 20:37:14 +00:00
Fatih Kilic
3054a040c5 Bug 1948811: Compare windows instead of tabs to show canvas permission prompt. r=mconley 
Each window gets the observe call once. gBrowser.selectedBrowser refers to the currently selected tab and we check against that to verify if the target browser instance is in the current window.

This patch changes it to comparing windows instead of browser instances.

Differential Revision: https://phabricator.services.mozilla.com/D238974
 2025-03-10 20:04:11 +00:00
Tim Xia
3554189dec Bug 1943391 - Initial entrypoint to detect preview reqeust - r=Mardak,firefox-desktop-core-reviewers ,firefox-ai-ml-reviewers,mossop 
- alt+hover to trigger LinkPreview
- add LinkPreview.sys.mjs modules
- disable browser.ml.linkPreview.enabled by default
- use setOverLink and LinkPreview.sys to handle keyboard shortcut
- dispatch CustomEvent OverLink from browser.js
- add/remove event listeners in sync with state of "browser.ml.linkPreview.enabled"
- update all_files_referenced to handle moz-src

Differential Revision: https://phabricator.services.mozilla.com/D239535
 2025-03-10 17:31:36 +00:00
Cosmin Sabou
8b1371211e Backed out changeset 9d7cf2733400 (bug 1943391) for causing leaks on browser_tab_groups_closed. 
CLOSED TREE
 2025-03-07 06:05:55 +02:00
Tim Xia
f4c4d3cc09 Bug 1943391 - Initial entrypoint to detect preview reqeust - r=Mardak,firefox-desktop-core-reviewers ,firefox-ai-ml-reviewers,mossop 
- alt+hover to trigger LinkPreview
- add LinkPreview.sys.mjs modules
- disable browser.ml.linkPreview.enabled by default
- use setOverLink and LinkPreview.sys to handle keyboard shortcut
- dispatch CustomEvent OverLink from browser.js
- add/remove event listeners in sync with state of "browser.ml.linkPreview.enabled"
- update all_files_referenced to handle moz-src

Differential Revision: https://phabricator.services.mozilla.com/D239535
 2025-03-06 03:03:09 +00:00
Butkovits Atila
625fda149e Backed out changeset 04574e76f8f5 (bug 1943391) for causing high frequency failures at browser_bannerClicking.js. CLOSED TREE 2025-03-06 15:40:06 +02:00
Tim Xia
1d372a23a6 Bug 1943391 - Initial entrypoint to detect preview reqeust - r=Mardak,firefox-desktop-core-reviewers ,firefox-ai-ml-reviewers,mossop 
- alt+hover to trigger LinkPreview
- add LinkPreview.sys.mjs modules
- disable browser.ml.linkPreview.enabled by default
- use setOverLink and LinkPreview.sys to handle keyboard shortcut
- dispatch CustomEvent OverLink from browser.js
- add/remove event listeners in sync with state of "browser.ml.linkPreview.enabled"
- update all_files_referenced to handle moz-src

Differential Revision: https://phabricator.services.mozilla.com/D239535
 2025-03-06 03:03:09 +00:00
Mark Banner
878a5d5415 Bug 1951652 - Convert browser/components/search/ modules to use moz-src uris. r=search-reviewers,scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D240333
 2025-03-05 09:24:37 +00:00
Gijs Kruitbosch
8c703a7db2 Bug 1951072 - switch reader mode modules to use moz-src URLs, r=firefox-desktop-core-reviewers ,sync-reviewers,urlbar-reviewers,mossop,jteow,markh 
Differential Revision: https://phabricator.services.mozilla.com/D240004
 2025-03-04 21:20:35 +00:00
Moritz Beier
34069ddca2 Bug 1948326 - Part 2: Add feature to generate search engine from HTML forms. r=Standard8,fluent-reviewers,bolsson,places-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D238277
 2025-03-04 17:18:21 +00:00
Goloman Adrian
55008ab2ea Backed out 2 changesets (bug 1948326) for causing bc failures @nsContentSecurityUtils.cpp. CLOSED TREE 
Backed out changeset 172464722456 (bug 1948326)
Backed out changeset 855648c27237 (bug 1948326)
 2025-03-04 15:12:56 +02:00
Moritz Beier
4841f6aadb Bug 1948326 - Part 2: Add feature to generate search engine from HTML forms. r=Standard8,fluent-reviewers,bolsson,places-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D238277
 2025-03-04 12:24:49 +00:00
Eric Chen
4b1d13722d Bug 1915739 - Part 3: Remove Fx Account toolbar button taskbar tab windows r=nrishel,desktop-theme-reviewers,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D234538
 2025-03-03 16:40:07 +00:00
Eric Chen
0624fff97b Bug 1915739 - Part 2: Set up TaskbarTab UI module to disable appropiate UI components r=sync-reviewers,firefox-desktop-core-reviewers ,Gijs,markh 
Differential Revision: https://phabricator.services.mozilla.com/D237620
 2025-03-03 16:40:07 +00:00
Gijs Kruitbosch
dcb8be8cff Bug 1950871 - switch browser/components/tabbrowser to use moz-src, r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D239926
 2025-03-03 12:47:49 +00:00
Gijs Kruitbosch
6b3212de9b Bug 1597228 - move 'get me out of here' logic to shared place and make toolkit-safe, r=dimi 
Differential Revision: https://phabricator.services.mozilla.com/D238762
 2025-02-24 15:30:42 +00:00
Gijs Kruitbosch
d7fff069d3 Bug 1597228 - move reportFalseDeceptiveSite to browser-safebrowsing.js, r=firefox-desktop-core-reviewers ,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D238761
 2025-02-24 15:30:41 +00:00
Gijs Kruitbosch
8a155fd76c Bug 1597228 - improve how BlockedSite safebrowsing actor handles page loads, r=firefox-desktop-core-reviewers ,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D238760
 2025-02-24 15:30:41 +00:00
Gijs Kruitbosch
0e31b3087e Bug 1597228 - move BrowserOnClick and other about:blocked safebrowsing helpers out of browser.js, r=firefox-desktop-core-reviewers ,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D238535
 2025-02-24 15:30:40 +00:00