Commit Graph

105 Commits

Author SHA1 Message Date
Mike Kaply
19484d525c Bug 1677524 - Add policies for credit card and address autofill. r=sgalich,fluent-reviewers,bolsson,dimi
Differential Revision: https://phabricator.services.mozilla.com/D202733
2024-03-05 15:25:16 +00:00
Sergey Galich
c923e70636 Bug 1864896: Polishing autofix of unused function arguments (credential management). r=credential-management-reviewers,dimi
Depends on D202958

Differential Revision: https://phabricator.services.mozilla.com/D203314
2024-03-05 00:08:04 +00:00
Dave Townsend
e0861329f5 Bug 1864896: Autofix unused function arguments (credential management). r=credential-management-reviewers,dimi
Differential Revision: https://phabricator.services.mozilla.com/D202957
2024-03-05 00:08:03 +00:00
Issam Mani
34d786dd52 Bug 1881427 - Send address telemetry to iOS. r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D202386
2024-02-23 10:48:21 +00:00
jneuberger
44a0a217d0 Bug 1868967 - Update strings of os prompt dialog before showing payment method r=credential-management-reviewers,fluent-reviewers,bolsson,issammani
Depends on D195659

Differential Revision: https://phabricator.services.mozilla.com/D195857
2023-12-14 08:52:53 +00:00
Butkovits Atila
01ccb94b1f Backed out 2 changesets (bug 1868967, bug 1867022) for causing failures at browser_all_files_referenced.js. CLOSED TREE
Backed out changeset 64afe14f0c7f (bug 1868967)
Backed out changeset 8e47ae54e6cd (bug 1867022)
2023-12-11 17:48:11 +02:00
jneuberger
896e69bcd6 Bug 1868967 - Update strings of os prompt dialog before showing payment method r=credential-management-reviewers,fluent-reviewers,bolsson,issammani
Differential Revision: https://phabricator.services.mozilla.com/D195857
2023-12-11 14:33:54 +00:00
Gregory Pappas
a57c4f9405 Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol
Differential Revision: https://phabricator.services.mozilla.com/D184623
2023-08-01 23:01:02 +00:00
Mark Banner
d3d891e3d7 Bug 1845079 - Update more consumers to import ES modules directly. r=arai,settings-reviewers,credential-management-reviewers,sync-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D184371
2023-07-24 15:32:45 +00:00
Issam Mani
fae895994a Bug 1806951 - P3. Move necessary FormAutofillUtils to shared module. r=sgalich,dimi
Differential Revision: https://phabricator.services.mozilla.com/D174623
2023-05-02 09:42:29 +00:00
Stephanie Cunnane
c1c10d4574 Bug 1824473 - Update consumers of toolkit/components/formautofill to import ES modules directly. r=Standard8,geckoview-reviewers,credential-management-reviewers,sgalich,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D173587
2023-04-12 20:30:43 +00:00
Noemi Erli
4ddb66355f Backed out 2 changesets (bug 1824473) for causing failures in test_clear_form.html CLOSED TREE
Backed out changeset b38aeb74da71 (bug 1824473)
Backed out changeset b73ead08bb19 (bug 1824473)
2023-03-31 21:51:12 +03:00
Stephanie Cunnane
eafb18685c Bug 1824473 - Update consumers of toolkit/components/formautofill to import ES modules directly. r=Standard8,geckoview-reviewers,credential-management-reviewers,sgalich,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D173587
2023-03-31 16:45:03 +00:00
Csoregi Natalia
1229f6bc2e Backed out 2 changesets (bug 1824473) for causing mochitest failures on test_address_level_1_submission.html. CLOSED TREE
Backed out changeset 8dd52b2dae6b (bug 1824473)
Backed out changeset 5fbc5b6422c7 (bug 1824473)
2023-03-30 21:14:51 +03:00
Stephanie Cunnane
e6ed04ef87 Bug 1824473 - Update consumers of toolkit/components/formautofill to import ES modules directly. r=Standard8,geckoview-reviewers,credential-management-reviewers,sgalich,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D173587
2023-03-30 17:29:18 +00:00
Sandor Molnar
2c5379b192 Backed out 2 changesets (bug 1824473) for causing failures in browser/extensions/formautofill/test/<...>.js
Backed out changeset 01046e78078c (bug 1824473)
Backed out changeset 4203fbb8f229 (bug 1824473)
2023-03-27 22:44:33 +03:00
Stephanie Cunnane
f073acc372 Bug 1824473 - Update consumers of toolkit/components/formautofill to import ES modules directly. r=Standard8,geckoview-reviewers,credential-management-reviewers,sgalich,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D173587
2023-03-27 18:12:17 +00:00
Dimi
cdccaa5a19 Bug 1801039 - P1. Share common code for Address and Credit Card r=sgalich
Differential Revision: https://phabricator.services.mozilla.com/D164351
2023-01-03 20:55:56 +00:00
Noemi Erli
899aaa3e75 Backed out 3 changesets (bug 1801039) for causing multiple failures CLOSED TREE
Backed out changeset 0bbe6fbc7658 (bug 1801039)
Backed out changeset 7de8b9fa5c54 (bug 1801039)
Backed out changeset fe8346f26b2d (bug 1801039)
2023-01-03 13:54:03 +02:00
Dimi
1178183a2f Bug 1801039 - P1. Share common code for Address and Credit Card r=sgalich
Differential Revision: https://phabricator.services.mozilla.com/D164351
2023-01-03 10:48:42 +00:00
Mark Banner
ee7470f280 Bug 1803757 - Automatically replace Cu.reportError with console.error (credentials). r=credential-management-reviewers,sgalich
Depends on D163701

Differential Revision: https://phabricator.services.mozilla.com/D163702
2022-12-02 18:44:44 +00:00
trickypr
12495faed2 Bug 1510561 - Part 11: Apply plugin:mozilla/valid-jsdoc to browser/extensions/formautofill. r=sgalich
Differential Revision: https://phabricator.services.mozilla.com/D161386
2022-11-07 12:33:29 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
Mark Banner
a49b8ef78f Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D158094
2022-09-29 06:52:34 +00:00
Eemeli Aro
40341acaff Bug 1446164 - Migrate formautofill edit dialogs to Fluent. r=sgalich,fluent-reviewers,flod
Migrating the strings used by the edit dialogs also allows/requires for their migration elsewhere.

Some streamlining is applied to how autofillEditForms.js gets access to e.g. FormFillUtils methods, so that they are no longer routed via the XHTML files' script tags. The prior independence of this file from internal dependencies appears to have been in place to support its use as a part of the Payments API's UI, but that was dropped in bug 1721229.

The Fluent migration script included in this patch also covers changes from the immediately preceding patch.

The intl documentation change is a typo correction that was noticed while working on this patch.

Differential Revision: https://phabricator.services.mozilla.com/D155705
2022-09-01 20:35:37 +00:00
Eemeli Aro
6186d62a9e Bug 1786708 - Migrate formautofill management dialogs to Fluent. r=sgalich,fluent-reviewers,preferences-reviewers,flod,jaws
A new FTL file for the extension is added under `browser/preferences/` rather than `browser/extensions/formautofill/`, as the former is a more common location for FTL localizations, and the extension already relies on an FTL file hosted outside its own directory, `toolkit/payments/payments.ftl`.

The dialogs are not fully migrated in this patch, as some of the strings are shared with the edit dialogs and are migrated separately.

A Fluent migration for the localization changes applied here is included in the next patch after this one.

Differential Revision: https://phabricator.services.mozilla.com/D155478
2022-09-01 20:35:34 +00:00
Norisz Fay
4961fb7d01 Backed out 2 changesets (bug 1786708, bug 1446164) for causing multiple failures CLOSED TREE
Backed out changeset 469e2500f00e (bug 1446164)
Backed out changeset 0d298c6f7475 (bug 1786708)
2022-09-01 15:34:56 +03:00
Eemeli Aro
27d39b80cc Bug 1446164 - Migrate formautofill edit dialogs to Fluent. r=sgalich,fluent-reviewers,flod
Migrating the strings used by the edit dialogs also allows/requires for their migration elsewhere.

Some streamlining is applied to how autofillEditForms.js gets access to e.g. FormFillUtils methods, so that they are no longer routed via the XHTML files' script tags. The prior independence of this file from internal dependencies appears to have been in place to support its use as a part of the Payments API's UI, but that was dropped in bug 1721229.

The Fluent migration script included in this patch also covers changes from the immediately preceding patch.

The intl documentation change is a typo correction that was noticed while working on this patch.

Depends on D155478

Differential Revision: https://phabricator.services.mozilla.com/D155705
2022-09-01 08:26:47 +00:00
Eemeli Aro
868f4c2248 Bug 1786708 - Migrate formautofill management dialogs to Fluent. r=sgalich,fluent-reviewers,preferences-reviewers,flod,jaws
A new FTL file for the extension is added under `browser/preferences/` rather than `browser/extensions/formautofill/`, as the former is a more common location for FTL localizations, and the extension already relies on an FTL file hosted outside its own directory, `toolkit/payments/payments.ftl`.

The dialogs are not fully migrated in this patch, as some of the strings are shared with the edit dialogs and are migrated separately.

A Fluent migration for the localization changes applied here is included in the next patch after this one.

Differential Revision: https://phabricator.services.mozilla.com/D155478
2022-09-01 08:26:46 +00:00
Tooru Fujisawa
328d63ce7f Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-12 04:21:34 +00:00
Andreea Pavel
f009ba2983 Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
2022-07-11 22:24:40 +03:00
Tooru Fujisawa
bf0a8b781b Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-11 15:09:13 +00:00
Tooru Fujisawa
48c568867c Bug 1667455 - Part 5: Stop importing Services.jsm from chrome-priv JS code, top-level single-line cases. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,pip-reviewers,twisniewski,m_kato,jdescottes,mconley,AlexandruIonescu,mossop
Differential Revision: https://phabricator.services.mozilla.com/D150894
2022-07-11 12:41:50 +00:00
Mark Banner
55a94e6bc8 Bug 1771173 - Rework FormAutoFill's log creation to make it easier for linters to handle. r=sgalich
This rewrites the lazy getters, so that the lazy getter is defined at the call point, which makes it
easier for linters to understand what is being defined.
In some cases, the log is not being used, so the definition code is removed.

Differential Revision: https://phabricator.services.mozilla.com/D149716
2022-06-21 20:42:15 +00:00
Eugen Sawin
0d32a65fd0 Bug 1691821 - [1.c.3] Rename autofill paths to use the new toolkit component. r=zbraniecki,dimi
Differential Revision: https://phabricator.services.mozilla.com/D108058
2021-04-12 17:33:16 +00:00
Dorel Luca
565aa136f7 Backed out 7 changesets (bug 1691821) for Browser-chrome failures in autofill/FormAutofillParent.jsm. CLOSED TREE
Backed out changeset d12aec06eedd (bug 1691821)
Backed out changeset 0affe1783697 (bug 1691821)
Backed out changeset f807e0d0d095 (bug 1691821)
Backed out changeset abdc3fede62b (bug 1691821)
Backed out changeset cea92bd86972 (bug 1691821)
Backed out changeset 1c86de8cd775 (bug 1691821)
Backed out changeset e955f7f5503c (bug 1691821)
2021-04-10 03:05:35 +03:00
Eugen Sawin
5ba5b5c835 Bug 1691821 - [1.c.2] Rename autofill paths to use the new toolkit component. r=zbraniecki,dimi
Differential Revision: https://phabricator.services.mozilla.com/D108058
2021-04-09 22:12:12 +00:00
James Teh
db79981fcc Bug 1664086: Use Fluent to set aria-label for credit card list options in preferences. r=zbraniecki,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D89696
2020-09-11 06:13:36 +00:00
James Teh
34d7542609 Bug 1662879 part 1: Expose the credit card type via aria-label in the credit card list in Preferences. r=zbraniecki
Differential Revision: https://phabricator.services.mozilla.com/D89548
2020-09-11 05:47:27 +00:00
Csoregi Natalia
64073d27da Backed out 2 changesets (bug 1662879) for multiple failures e.g. browser_manageCreditCardsDialog.js. CLOSED TREE
Backed out changeset 3952f1301e38 (bug 1662879)
Backed out changeset 5daec3a7ae6f (bug 1662879)
2020-09-10 10:59:01 +03:00
James Teh
885d3a7228 Bug 1662879 part 1: Expose the credit card type via aria-label in the credit card list in Preferences. r=zbraniecki
Differential Revision: https://phabricator.services.mozilla.com/D89548
2020-09-10 04:47:49 +00:00
pbz
9684cdfd60 Bug 1661030 - Refactor SubDialog and TabDialogBox to support passing multiple window arguments. r=Gijs,preferences-reviewers
This also updates the behavior of the allowDuplicates check:
Instead of only checking if the top dialog is a duplicate, it will now check the whole stack and
skip the dialog open if a duplicate URL is found.
This fixes an issue where callers could alternate between dialogs to bypass the check.

Differential Revision: https://phabricator.services.mozilla.com/D88422
2020-09-02 14:24:47 +00:00
Zibi Braniecki
38d51aecc5 Bug 1654167 - Add preferences telemetry for Credit Card A/B testing. r=abr
Differential Revision: https://phabricator.services.mozilla.com/D84293
2020-07-28 00:29:50 +00:00
Adam Roach [:abr]
4881146452 Bug 1624646: Fix macOS re-auth strings r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D78816
2020-06-08 22:39:54 +00:00
Adam Roach [:abr]
d5f3709c8c Bug 1642058: Add expiration date in card list view under Preferences r=zbraniecki,fluent-reviewers,MattN,flod
***

Differential Revision: https://phabricator.services.mozilla.com/D77953
2020-06-08 15:00:58 +00:00
Butkovits Atila
671cf97b02 Backed out changeset 85183f00ced0 (bug 1642058) for causing failure at browser_manageCreditCardsDialog.js. CLOSED TREE 2020-06-06 00:14:13 +03:00
Adam Roach [:abr]
f5abb1f0eb Bug 1642058: Add expiration date in card list view under Preferences r=zbraniecki,fluent-reviewers,MattN,flod
***

Differential Revision: https://phabricator.services.mozilla.com/D77953
2020-06-05 19:56:59 +00:00
Jared Wein
ef26ce4f53 Bug 1628029 - Add telemetry events for OS authentication. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D70069
2020-04-16 21:23:58 +00:00
Sam Foster
50caf81563 Bug 1622514 - Move OSKeyStore.jsm into toolkit/modules. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D68133
2020-03-25 08:21:24 +00:00
Jared Wein
7cb96865ca Bug 1194529 - Update OSKeyStore pref names now that the module is moved. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D61745
2020-03-12 14:47:28 +00:00